[pypy-commit] pypy default: Disable a half-broken test that fails on Python 2.7 (see comments).
arigo
noreply at buildbot.pypy.org
Mon Nov 21 16:17:20 CET 2011
Author: Armin Rigo <arigo at tunes.org>
Branch:
Changeset: r49622:ab5c477f2f34
Date: 2011-11-21 16:17 +0100
http://bitbucket.org/pypy/pypy/changeset/ab5c477f2f34/
Log: Disable a half-broken test that fails on Python 2.7 (see comments).
diff --git a/pypy/rpython/test/test_rclass.py b/pypy/rpython/test/test_rclass.py
--- a/pypy/rpython/test/test_rclass.py
+++ b/pypy/rpython/test/test_rclass.py
@@ -457,8 +457,12 @@
compute_identity_hash(d))
res = self.interpret(f, [])
- # xxx this is too precise, checking the exact implementation
- assert res.item0 == res.item1
+ # xxx the following test is too precise, checking the exact
+ # implementation. On Python 2.7 it doesn't work anyway, because
+ # object.__hash__(x) is different from id(x). The test is disabled
+ # for now, and nobody should rely on compute_identity_hash() returning
+ # a value that is (or was) the current_object_addr_as_int().
+ # --- disabled: assert res.item0 == res.item1
# the following property is essential on top of the lltypesystem
# otherwise prebuilt dictionaries are broken. It's wrong on
# top of the ootypesystem though.
More information about the pypy-commit
mailing list