[pypy-svn] pypy fold_intadd: Cleaning up a bit.

ademan commits-noreply at bitbucket.org
Wed Mar 16 19:42:02 CET 2011


Author: Daniel Roberts <Ademan555 at gmail.com>
Branch: fold_intadd
Changeset: r42726:bc1f407a6e5f
Date: 2011-03-16 11:41 -0700
http://bitbucket.org/pypy/pypy/changeset/bc1f407a6e5f/

Log:	Cleaning up a bit.

diff --git a/pypy/jit/metainterp/optimizeopt/fold_intadd.py b/pypy/jit/metainterp/optimizeopt/fold_intadd.py
--- a/pypy/jit/metainterp/optimizeopt/fold_intadd.py
+++ b/pypy/jit/metainterp/optimizeopt/fold_intadd.py
@@ -21,7 +21,6 @@
                 func(self, op)
                 break
         else:
-            #self.optimize_default(op)
             self.emit_operation(op)
 
     def _int_operation(self, variable, constant, result):
@@ -66,9 +65,7 @@
         if lv.is_constant() and rv.is_constant():
             self.emit_operation(op) # XXX: there's support for optimizing this elsewhere, right?
         elif lv.is_constant():
-            #constant = lv.box.getint()
-            #self._process_add(op.getarg(1), constant, result)
-            # TODO: implement
+            # TODO: implement?
             self.emit_operation(op)
         elif rv.is_constant():
             constant = rv.box.getint()
@@ -76,21 +73,4 @@
         else:
             self.emit_operation(op)
 
-    def optimize_default(self, op):
-        for i in range(op.numargs()):
-            arg = self.getvalue(op.getarg(i))
-            if arg.is_constant():
-                continue
-
-            try:
-                variable = op.getarg(i)
-                root, constant = self.args[variable]
-
-                new_op = self._int_operation(root, constant, variable)
-                self.emit_operation(new_op)
-            except KeyError:
-                pass
-        self.emit_operation(op)
-
-
 optimize_ops = _findall(OptAddition, 'optimize_')


More information about the Pypy-commit mailing list