[pypy-svn] r76872 - pypy/build/bot2/pypybuildbot
antocuni at codespeak.net
antocuni at codespeak.net
Sun Sep 5 15:31:25 CEST 2010
Author: antocuni
Date: Sun Sep 5 15:31:24 2010
New Revision: 76872
Modified:
pypy/build/bot2/pypybuildbot/builds.py
Log:
try another approach: attaching the test summary to the build is not a good
idea, because then getting the summary given the revision is expensive.
Instead, we build a mapping revision->summary as we go: since the mapping is
attached to the builder_status, it is also serialized and saved on disk, so it
persists across restarts.
Modified: pypy/build/bot2/pypybuildbot/builds.py
==============================================================================
--- pypy/build/bot2/pypybuildbot/builds.py (original)
+++ pypy/build/bot2/pypybuildbot/builds.py Sun Sep 5 15:31:24 2010
@@ -62,10 +62,17 @@
pytestLog = cmd.logs['pytestLog']
outcome = RevisionOutcomeSet(None)
outcome.populate(pytestLog)
- summary = outcome.get_summary()
+ summary = outcome.get_summary()
build_status = self.build.build_status
- build_status.setProperty('test_summary', summary, "TestRunnerCmd")
- build_status.setProperty('test_description', self.description, "TestRunnerCmd")
+ builder = build_status.builder
+ if not hasattr(builder, 'summary_by_revision'):
+ builder.summary_by_revision = {}
+ try:
+ rev = build_status.getProperty('got_revision')
+ except KeyError:
+ return
+ else:
+ builder.summary_by_revision[rev] = summary
# ________________________________________________________________
More information about the Pypy-commit
mailing list