[pypy-svn] r74869 - pypy/trunk/pypy/module/cpyext

afa at codespeak.net afa at codespeak.net
Fri May 28 19:17:33 CEST 2010


Author: afa
Date: Fri May 28 19:17:32 2010
New Revision: 74869

Modified:
   pypy/trunk/pypy/module/cpyext/slotdefs.py
Log:
Add a note to self.
Probably a bug, certainly a test to write.


Modified: pypy/trunk/pypy/module/cpyext/slotdefs.py
==============================================================================
--- pypy/trunk/pypy/module/cpyext/slotdefs.py	(original)
+++ pypy/trunk/pypy/module/cpyext/slotdefs.py	Fri May 28 19:17:32 2010
@@ -150,6 +150,8 @@
 
 @cpython_api([PyObject, PyObject, PyObject], rffi.INT_real, error=-1, external=False)
 def slot_tp_setattro(space, w_self, w_name, w_value):
+    # XXX this is probably wrong when a subtype's tp_setattro
+    # delegates to PyType_Type.tp_setattro!
     if w_value is not None:
         space.setattr(w_self, w_name, w_value)
     else:



More information about the Pypy-commit mailing list