[pypy-svn] r75211 - in pypy/branch/blackhole-improvement-merge/pypy: annotation annotation/test jit/backend jit/backend/llgraph jit/backend/llgraph/test jit/backend/llsupport jit/backend/llsupport/test jit/backend/test jit/backend/x86 jit/backend/x86/test jit/codewriter jit/codewriter/test jit/metainterp jit/metainterp/test jit/tl jit/tl/spli jit/tl/tla jit/tool jit/tool/test module/pypyjit module/pypyjit/test objspace/flow rpython rpython/lltypesystem rpython/lltypesystem/test rpython/memory/gctransform/test rpython/memory/test rpython/test tool/algo tool/algo/test translator/c translator/c/src translator/c/test translator/tool
arigo at codespeak.net
arigo at codespeak.net
Tue Jun 8 19:48:47 CEST 2010
Author: arigo
Date: Tue Jun 8 19:48:40 2010
New Revision: 75211
Added:
pypy/branch/blackhole-improvement-merge/pypy/jit/codewriter/ (props changed)
- copied from r75210, pypy/branch/blackhole-improvement/pypy/jit/codewriter/
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/blackhole.py
- copied unchanged from r75210, pypy/branch/blackhole-improvement/pypy/jit/metainterp/blackhole.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/jitexc.py
- copied unchanged from r75210, pypy/branch/blackhole-improvement/pypy/jit/metainterp/jitexc.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_immutable.py
- copied unchanged from r75210, pypy/branch/blackhole-improvement/pypy/jit/metainterp/test/test_immutable.py
pypy/branch/blackhole-improvement-merge/pypy/tool/algo/color.py
- copied unchanged from r75210, pypy/branch/blackhole-improvement/pypy/tool/algo/color.py
pypy/branch/blackhole-improvement-merge/pypy/tool/algo/test/test_color.py
- copied unchanged from r75210, pypy/branch/blackhole-improvement/pypy/tool/algo/test/test_color.py
Removed:
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/codewriter.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/dump.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/effectinfo.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/heaptracker.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/policy.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/support.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_codewriter.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_effectinfo.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_support.py
Modified:
pypy/branch/blackhole-improvement-merge/pypy/annotation/builtin.py
pypy/branch/blackhole-improvement-merge/pypy/annotation/description.py
pypy/branch/blackhole-improvement-merge/pypy/annotation/test/test_annrpython.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llgraph/llimpl.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llgraph/runner.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llgraph/test/test_llgraph.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/descr.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/gc.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/llmodel.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/test/test_descr.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/test/test_gc.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/model.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/test/runner_test.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/test/test_ll_random.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/test/test_random.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/assembler.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/regalloc.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/ri386.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/runner.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/support.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_assembler.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_basic.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_gc_integration.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_regalloc.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_regalloc2.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_runner.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_send.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_zrpy_gc.py
pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_ztranslation.py
pypy/branch/blackhole-improvement-merge/pypy/jit/codewriter/support.py
pypy/branch/blackhole-improvement-merge/pypy/jit/codewriter/test/ (props changed)
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/compile.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/executor.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/history.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/jitprof.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/logger.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/optimizefindnode.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/optimizeopt.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/optimizeutil.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/pyjitpl.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/resoperation.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/resume.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/simple_optimize.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/specnode.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/oparser.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_basic.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_blackhole.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_compile.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_exception.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_executor.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_history.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_jitprof.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_list.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_loop.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_optimizefindnode.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_optimizeopt.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_pyjitpl.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_recursive.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_resume.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_send.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_slist.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_string.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_tl.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_tlc.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_virtual.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_virtualizable.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_virtualref.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_warmspot.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_warmstate.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_ztranslation.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/typesystem.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/virtualizable.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/virtualref.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/warmspot.py
pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/warmstate.py
pypy/branch/blackhole-improvement-merge/pypy/jit/tl/spli/interpreter.py
pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tl.py
pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tla/tla.py
pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tlc.py
pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tlr.py
pypy/branch/blackhole-improvement-merge/pypy/jit/tool/jitoutput.py
pypy/branch/blackhole-improvement-merge/pypy/jit/tool/test/test_jitoutput.py
pypy/branch/blackhole-improvement-merge/pypy/module/pypyjit/policy.py
pypy/branch/blackhole-improvement-merge/pypy/module/pypyjit/test/test_pypy_c.py
pypy/branch/blackhole-improvement-merge/pypy/objspace/flow/model.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/llinterp.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/ll2ctypes.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/llarena.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/llmemory.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/lloperation.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/lltype.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/rclass.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/test/test_ll2ctypes.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/test/test_llmemory.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/test/test_lltype.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/memory/gctransform/test/test_boehm.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/memory/gctransform/test/test_refcounting.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/memory/test/test_lldict.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/raddress.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/rbuiltin.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_exception.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_llann.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_rdict.py
pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_rptr.py
pypy/branch/blackhole-improvement-merge/pypy/translator/c/primitive.py
pypy/branch/blackhole-improvement-merge/pypy/translator/c/src/address.h
pypy/branch/blackhole-improvement-merge/pypy/translator/c/test/test_genc.py
pypy/branch/blackhole-improvement-merge/pypy/translator/c/test/test_lladdresses.py
pypy/branch/blackhole-improvement-merge/pypy/translator/c/test/test_refcount.py
pypy/branch/blackhole-improvement-merge/pypy/translator/tool/make_dot.py
Log:
Attempt to merge the branch blackhole-improvement into trunk.
Will run all tests...
Modified: pypy/branch/blackhole-improvement-merge/pypy/annotation/builtin.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/annotation/builtin.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/annotation/builtin.py Tue Jun 8 19:48:40 2010
@@ -346,7 +346,7 @@
assert s_type.is_constant()
return SomePtr(s_type.const)
-def llmemory_cast_adr_to_int(s):
+def llmemory_cast_adr_to_int(s, s_mode=None):
return SomeInteger() # xxx
def llmemory_cast_int_to_adr(s):
Modified: pypy/branch/blackhole-improvement-merge/pypy/annotation/description.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/annotation/description.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/annotation/description.py Tue Jun 8 19:48:40 2010
@@ -539,9 +539,18 @@
try:
args.fixedunpack(0)
except ValueError:
-
raise Exception("default __init__ takes no argument"
" (class %s)" % (self.name,))
+ elif self.pyobj is Exception:
+ # check explicitly against "raise Exception, x" where x
+ # is a low-level exception pointer
+ try:
+ [s_arg] = args.fixedunpack(1)
+ except ValueError:
+ pass
+ else:
+ from pypy.annotation.model import SomePtr
+ assert not isinstance(s_arg, SomePtr)
else:
# call the constructor
args = args.prepend(s_instance)
Modified: pypy/branch/blackhole-improvement-merge/pypy/annotation/test/test_annrpython.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/annotation/test/test_annrpython.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/annotation/test/test_annrpython.py Tue Jun 8 19:48:40 2010
@@ -3321,6 +3321,17 @@
s = a.build_types(g, [int])
assert a.bookkeeper.getdesc(f).getuniquegraph()
+ def test_cannot_raise_ll_exception(self):
+ from pypy.rpython.annlowlevel import cast_instance_to_base_ptr
+ #
+ def f():
+ e = OverflowError()
+ lle = cast_instance_to_base_ptr(e)
+ raise Exception, lle
+ # ^^^ instead, must cast back from a base ptr to an instance
+ a = self.RPythonAnnotator()
+ py.test.raises(AssertionError, a.build_types, f, [])
+
def test_unicode_decode_error(self):
def f():
try:
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llgraph/llimpl.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llgraph/llimpl.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llgraph/llimpl.py Tue Jun 8 19:48:40 2010
@@ -7,9 +7,10 @@
import sys
from pypy.objspace.flow.model import Variable, Constant
from pypy.annotation import model as annmodel
-from pypy.jit.metainterp.history import (ConstInt, ConstPtr, ConstAddr,
+from pypy.jit.metainterp.history import (ConstInt, ConstPtr,
BoxInt, BoxPtr, BoxObj, BoxFloat,
REF, INT, FLOAT)
+from pypy.jit.codewriter import heaptracker
from pypy.rpython.lltypesystem import lltype, llmemory, rclass, rstr
from pypy.rpython.ootypesystem import ootype
from pypy.rpython.module.support import LLSupport, OOSupport
@@ -73,12 +74,12 @@
'int_eq' : (('int', 'int'), 'bool'),
'int_ne' : (('int', 'int'), 'bool'),
'int_is_true' : (('int',), 'bool'),
+ 'int_is_zero' : (('int',), 'bool'),
'int_neg' : (('int',), 'int'),
'int_invert' : (('int',), 'int'),
'int_add_ovf' : (('int', 'int'), 'int'),
'int_sub_ovf' : (('int', 'int'), 'int'),
'int_mul_ovf' : (('int', 'int'), 'int'),
- 'bool_not' : (('bool',), 'bool'),
'uint_add' : (('int', 'int'), 'int'),
'uint_sub' : (('int', 'int'), 'int'),
'uint_mul' : (('int', 'int'), 'int'),
@@ -103,7 +104,6 @@
'float_ge' : (('float', 'float'), 'bool'),
'float_neg' : (('float',), 'float'),
'float_abs' : (('float',), 'float'),
- 'float_is_true' : (('float',), 'bool'),
'cast_float_to_int':(('float',), 'int'),
'cast_int_to_float':(('int',), 'float'),
'same_as' : (('int',), 'int'), # could also be ptr=>ptr
@@ -155,16 +155,6 @@
'force_token' : ((), 'int'),
'call_may_force' : (('int', 'varargs'), 'intorptr'),
'guard_not_forced': ((), None),
- 'virtual_ref' : (('ref', 'int'), 'ref'),
- 'virtual_ref_finish': (('ref', 'ref'), None),
- #'getitem' : (('void', 'ref', 'int'), 'int'),
- #'setitem' : (('void', 'ref', 'int', 'int'), None),
- #'newlist' : (('void', 'varargs'), 'ref'),
- #'append' : (('void', 'ref', 'int'), None),
- #'insert' : (('void', 'ref', 'int', 'int'), None),
- #'pop' : (('void', 'ref',), 'int'),
- #'len' : (('void', 'ref',), 'int'),
- #'listnonzero' : (('void', 'ref',), 'int'),
}
# ____________________________________________________________
@@ -231,19 +221,19 @@
else:
return repr(x)
-def repr_list(lst, types, memocast):
+def repr_list(lst, types):
res_l = []
if types and types[-1] == 'varargs':
types = types[:-1] + ('int',) * (len(lst) - len(types) + 1)
assert len(types) == len(lst)
for elem, tp in zip(lst, types):
if isinstance(elem, Constant):
- res_l.append('(%s)' % repr1(elem, tp, memocast))
+ res_l.append('(%s)' % repr1(elem, tp))
else:
- res_l.append(repr1(elem, tp, memocast))
+ res_l.append(repr1(elem, tp))
return '[%s]' % (', '.join(res_l))
-def repr1(x, tp, memocast):
+def repr1(x, tp):
if tp == "intorptr":
TYPE = lltype.typeOf(x)
if isinstance(TYPE, lltype.Ptr) and TYPE.TO._gckind == 'gc':
@@ -259,7 +249,7 @@
return '(* None)'
if isinstance(x, int):
# XXX normalize?
- ptr = str(cast_int_to_adr(memocast, x))
+ ptr = str(llmemory.cast_int_to_adr(x))
elif isinstance(ootype.typeOf(x), ootype.OOType):
return repr(x)
else:
@@ -400,10 +390,9 @@
class Frame(object):
OPHANDLERS = [None] * (rop._LAST+1)
- def __init__(self, memocast, cpu):
+ def __init__(self, cpu):
self.verbose = False
self.cpu = cpu
- self.memocast = memocast
self.opindex = 1
self._forced = False
self._may_force = -1
@@ -522,15 +511,14 @@
elif res is NotImplemented:
resdata = '*fail*'
else:
- resdata = '-> ' + repr1(res, restype, self.memocast)
+ resdata = '-> ' + repr1(res, restype)
# fish the types
- log.cpu('\t%s %s %s' % (opname, repr_list(values, argtypes,
- self.memocast),
+ log.cpu('\t%s %s %s' % (opname, repr_list(values, argtypes),
resdata))
return res
def as_int(self, x):
- return cast_to_int(x, self.memocast)
+ return cast_to_int(x)
def as_ptr(self, x):
return cast_to_ptr(x)
@@ -554,34 +542,36 @@
try:
op = getattr(cls, 'op_' + opname.lower()) # op_guard_true etc.
except AttributeError:
- name = 'do_' + opname.lower()
try:
- impl = globals()[name] # do_arraylen_gc etc.
+ impl = globals()['do_' + opname.lower()] # do_arraylen_gc etc.
def op(self, descr, *args):
- return impl(descr, *args)
- #
+ if descr is None:
+ return impl(*args)
+ else:
+ return impl(descr, *args)
except KeyError:
- from pypy.jit.backend.llgraph import llimpl
- impl = getattr(executor, name) # do_int_add etc.
- def _op_default_implementation(self, descr, *args):
- # for all operations implemented in execute.py
- boxedargs = []
- for x in args:
- if type(x) is int:
- boxedargs.append(BoxInt(x))
- elif type(x) is float:
- boxedargs.append(BoxFloat(x))
- elif isinstance(ootype.typeOf(x), ootype.OOType):
- boxedargs.append(BoxObj(ootype.cast_to_object(x)))
- else:
- boxedargs.append(BoxPtr(x))
- # xxx this passes the 'llimpl' module as the CPU argument
- resbox = impl(llimpl, *boxedargs)
- return getattr(resbox, 'value', None)
- op = _op_default_implementation
- #
+ op = cls._make_impl_from_blackhole_interp(opname)
cls.OPHANDLERS[opnum] = op
+ @classmethod
+ def _make_impl_from_blackhole_interp(cls, opname):
+ from pypy.jit.metainterp.blackhole import BlackholeInterpreter
+ name = 'bhimpl_' + opname.lower()
+ func = BlackholeInterpreter.__dict__[name]
+ for argtype in func.argtypes:
+ assert argtype in ('i', 'r', 'f')
+ #
+ def _op_default_implementation(self, descr, *args):
+ # for all operations implemented in the blackhole interpreter
+ return func(*args)
+ #
+ return _op_default_implementation
+
+ def op_debug_merge_point(self, _, value):
+ from pypy.jit.metainterp.warmspot import get_stats
+ loc = ConstPtr(value)._get_str()
+ get_stats().add_merge_point_location(loc)
+
def op_guard_true(self, _, value):
if not value:
raise GuardFailed
@@ -596,7 +586,7 @@
def op_guard_class(self, _, value, expected_class):
value = lltype.cast_opaque_ptr(rclass.OBJECTPTR, value)
expected_class = llmemory.cast_adr_to_ptr(
- cast_int_to_adr(self.memocast, expected_class),
+ llmemory.cast_int_to_adr(expected_class),
rclass.CLASSTYPE)
if value.typeptr != expected_class:
raise GuardFailed
@@ -630,7 +620,7 @@
def _cast_exception(self, exception):
return llmemory.cast_adr_to_ptr(
- cast_int_to_adr(self.memocast, exception),
+ llmemory.cast_int_to_adr(exception),
rclass.CLASSTYPE)
def _issubclass(self, cls1, cls2):
@@ -696,7 +686,7 @@
if arraydescr.typeinfo == REF:
return do_getarrayitem_gc_ptr(array, index)
elif arraydescr.typeinfo == INT:
- return do_getarrayitem_gc_int(array, index, self.memocast)
+ return do_getarrayitem_gc_int(array, index)
elif arraydescr.typeinfo == FLOAT:
return do_getarrayitem_gc_float(array, index)
else:
@@ -708,7 +698,7 @@
if fielddescr.typeinfo == REF:
return do_getfield_gc_ptr(struct, fielddescr.ofs)
elif fielddescr.typeinfo == INT:
- return do_getfield_gc_int(struct, fielddescr.ofs, self.memocast)
+ return do_getfield_gc_int(struct, fielddescr.ofs)
elif fielddescr.typeinfo == FLOAT:
return do_getfield_gc_float(struct, fielddescr.ofs)
else:
@@ -718,11 +708,11 @@
def op_getfield_raw(self, fielddescr, struct):
if fielddescr.typeinfo == REF:
- return do_getfield_raw_ptr(struct, fielddescr.ofs, self.memocast)
+ return do_getfield_raw_ptr(struct, fielddescr.ofs)
elif fielddescr.typeinfo == INT:
- return do_getfield_raw_int(struct, fielddescr.ofs, self.memocast)
+ return do_getfield_raw_int(struct, fielddescr.ofs)
elif fielddescr.typeinfo == FLOAT:
- return do_getfield_raw_float(struct, fielddescr.ofs, self.memocast)
+ return do_getfield_raw_float(struct, fielddescr.ofs)
else:
raise NotImplementedError
@@ -733,17 +723,17 @@
def op_new_with_vtable(self, descr, vtable):
assert descr is None
- size = get_class_size(self.memocast, vtable)
- result = do_new(size)
+ descr = heaptracker.vtable2descr(self.cpu, vtable)
+ result = do_new(descr.ofs)
value = lltype.cast_opaque_ptr(rclass.OBJECTPTR, result)
- value.typeptr = cast_from_int(rclass.CLASSTYPE, vtable, self.memocast)
+ value.typeptr = cast_from_int(rclass.CLASSTYPE, vtable)
return result
def op_setarrayitem_gc(self, arraydescr, array, index, newvalue):
if arraydescr.typeinfo == REF:
do_setarrayitem_gc_ptr(array, index, newvalue)
elif arraydescr.typeinfo == INT:
- do_setarrayitem_gc_int(array, index, newvalue, self.memocast)
+ do_setarrayitem_gc_int(array, index, newvalue)
elif arraydescr.typeinfo == FLOAT:
do_setarrayitem_gc_float(array, index, newvalue)
else:
@@ -753,8 +743,7 @@
if fielddescr.typeinfo == REF:
do_setfield_gc_ptr(struct, fielddescr.ofs, newvalue)
elif fielddescr.typeinfo == INT:
- do_setfield_gc_int(struct, fielddescr.ofs, newvalue,
- self.memocast)
+ do_setfield_gc_int(struct, fielddescr.ofs, newvalue)
elif fielddescr.typeinfo == FLOAT:
do_setfield_gc_float(struct, fielddescr.ofs, newvalue)
else:
@@ -762,30 +751,41 @@
def op_setfield_raw(self, fielddescr, struct, newvalue):
if fielddescr.typeinfo == REF:
- do_setfield_raw_ptr(struct, fielddescr.ofs, newvalue,
- self.memocast)
+ do_setfield_raw_ptr(struct, fielddescr.ofs, newvalue)
elif fielddescr.typeinfo == INT:
- do_setfield_raw_int(struct, fielddescr.ofs, newvalue,
- self.memocast)
+ do_setfield_raw_int(struct, fielddescr.ofs, newvalue)
elif fielddescr.typeinfo == FLOAT:
- do_setfield_raw_float(struct, fielddescr.ofs, newvalue,
- self.memocast)
+ do_setfield_raw_float(struct, fielddescr.ofs, newvalue)
else:
raise NotImplementedError
def op_call(self, calldescr, func, *args):
- _call_args[:] = args
- if calldescr.typeinfo == 'v':
- err_result = None
- elif calldescr.typeinfo == REF:
- err_result = lltype.nullptr(llmemory.GCREF.TO)
- elif calldescr.typeinfo == INT:
- err_result = 0
- elif calldescr.typeinfo == FLOAT:
- err_result = 0.0
- else:
- raise NotImplementedError
- return _do_call_common(func, self.memocast, err_result)
+ global _last_exception
+ assert _last_exception is None, "exception left behind"
+ assert _call_args_i == _call_args_r == _call_args_f == []
+ args_in_order = []
+ for x in args:
+ T = lltype.typeOf(x)
+ if T is lltype.Signed:
+ args_in_order.append('i')
+ _call_args_i.append(x)
+ elif T == llmemory.GCREF:
+ args_in_order.append('r')
+ _call_args_r.append(x)
+ elif T is lltype.Float:
+ args_in_order.append('f')
+ _call_args_f.append(x)
+ else:
+ raise TypeError(x)
+ try:
+ return _do_call_common(func, args_in_order)
+ except LLException, lle:
+ _last_exception = lle
+ d = {'v': None,
+ REF: lltype.nullptr(llmemory.GCREF.TO),
+ INT: 0,
+ FLOAT: 0.0}
+ return d[calldescr.typeinfo]
op_call_pure = op_call
@@ -801,7 +801,7 @@
return do_new_array(arraydescr.ofs, count)
def op_cast_ptr_to_int(self, descr, ptr):
- return cast_to_int(ptr, self.memocast)
+ return cast_to_int(ptr)
def op_uint_xor(self, descr, arg1, arg2):
return arg1 ^ arg2
@@ -859,12 +859,6 @@
if forced:
raise GuardFailed
- def op_virtual_ref(self, _, virtual, index):
- return virtual
-
- def op_virtual_ref_finish(self, _, vref, virtual):
- pass
-
class OOFrame(Frame):
@@ -925,7 +919,7 @@
def op_call(self, calldescr, func, *args):
sm = ootype.cast_from_object(calldescr.FUNC, func)
- newargs = cast_call_args(calldescr.FUNC.ARGS, args, self.memocast)
+ newargs = cast_call_args(calldescr.FUNC.ARGS, args)
res = call_maybe_on_top_of_llinterp(sm, newargs)
if isinstance(calldescr.FUNC.RESULT, ootype.OOType):
return ootype.cast_to_object(res)
@@ -937,7 +931,7 @@
METH = descr.METH
obj = ootype.cast_from_object(descr.SELFTYPE, obj)
meth = getattr(obj, descr.methname)
- newargs = cast_call_args(METH.ARGS, args, self.memocast)
+ newargs = cast_call_args(METH.ARGS, args)
res = call_maybe_on_top_of_llinterp(meth, newargs)
if isinstance(METH.RESULT, ootype.OOType):
return ootype.cast_to_object(res)
@@ -973,27 +967,27 @@
# ____________________________________________________________
-def cast_to_int(x, memocast):
+def cast_to_int(x):
TP = lltype.typeOf(x)
if isinstance(TP, lltype.Ptr):
- return cast_adr_to_int(memocast, llmemory.cast_ptr_to_adr(x))
+ return heaptracker.adr2int(llmemory.cast_ptr_to_adr(x))
if TP == llmemory.Address:
- return cast_adr_to_int(memocast, x)
+ return heaptracker.adr2int(x)
return lltype.cast_primitive(lltype.Signed, x)
-def cast_from_int(TYPE, x, memocast):
+def cast_from_int(TYPE, x):
if isinstance(TYPE, lltype.Ptr):
- if isinstance(x, (int, long)):
- x = cast_int_to_adr(memocast, x)
+ if isinstance(x, (int, long, llmemory.AddressAsInt)):
+ x = llmemory.cast_int_to_adr(x)
return llmemory.cast_adr_to_ptr(x, TYPE)
elif TYPE == llmemory.Address:
- if isinstance(x, (int, long)):
- x = cast_int_to_adr(memocast, x)
+ if isinstance(x, (int, long, llmemory.AddressAsInt)):
+ x = llmemory.cast_int_to_adr(x)
assert lltype.typeOf(x) == llmemory.Address
return x
else:
if lltype.typeOf(x) == llmemory.Address:
- x = cast_adr_to_int(memocast, x)
+ x = heaptracker.adr2int(x)
return lltype.cast_primitive(TYPE, x)
def cast_to_ptr(x):
@@ -1013,11 +1007,11 @@
return x
-def new_frame(memocast, is_oo, cpu):
+def new_frame(is_oo, cpu):
if is_oo:
- frame = OOFrame(memocast, cpu)
+ frame = OOFrame(cpu)
else:
- frame = Frame(memocast, cpu)
+ frame = Frame(cpu)
return _to_opaque(frame)
_future_values = []
@@ -1067,69 +1061,68 @@
def frame_int_getvalue(frame, num):
frame = _from_opaque(frame)
- return frame.fail_args[num]
+ assert num >= 0
+ x = frame.fail_args[num]
+ assert lltype.typeOf(x) is lltype.Signed
+ return x
def frame_float_getvalue(frame, num):
frame = _from_opaque(frame)
- return frame.fail_args[num]
+ assert num >= 0
+ x = frame.fail_args[num]
+ assert lltype.typeOf(x) is lltype.Float
+ return x
def frame_ptr_getvalue(frame, num):
frame = _from_opaque(frame)
- result = frame.fail_args[num]
- frame.fail_args[num] = None
- return result
+ assert num >= 0
+ x = frame.fail_args[num]
+ assert lltype.typeOf(x) == llmemory.GCREF
+ return x
-_last_exception = None
+def frame_get_value_count(frame):
+ frame = _from_opaque(frame)
+ return len(frame.fail_args)
-def get_exception():
- if _last_exception:
- return llmemory.cast_ptr_to_adr(_last_exception.args[0])
- else:
- return llmemory.NULL
+def frame_clear_latest_values(frame, count):
+ frame = _from_opaque(frame)
+ assert count == len(frame.fail_args)
+ del frame.fail_args
-def get_exc_value():
- if _last_exception:
- return lltype.cast_opaque_ptr(llmemory.GCREF, _last_exception.args[1])
- else:
- return lltype.nullptr(llmemory.GCREF.TO)
+_last_exception = None
-def clear_exception():
+def grab_exc_value():
global _last_exception
- _last_exception = None
+ if _last_exception is not None:
+ result = _last_exception.args[1]
+ _last_exception = None
+ return lltype.cast_opaque_ptr(llmemory.GCREF, result)
+ else:
+ return lltype.nullptr(llmemory.GCREF.TO)
-_pseudo_exceptions = {}
+##_pseudo_exceptions = {}
-def _get_error(Class):
- if _llinterp.typer is not None:
- llframe = _llinterp.frame_class(None, None, _llinterp)
- try:
- llframe.make_llexception(Class())
- except LLException, e:
- return e
- else:
- assert 0, "should have raised"
- else:
- # for tests, a random emulated ll_inst will do
- if Class not in _pseudo_exceptions:
- ll_inst = lltype.malloc(rclass.OBJECT, zero=True)
- ll_inst.typeptr = lltype.malloc(rclass.OBJECT_VTABLE,
- immortal=True)
- _pseudo_exceptions[Class] = LLException(ll_inst.typeptr, ll_inst)
- return _pseudo_exceptions[Class]
-
-def get_overflow_error():
- return llmemory.cast_ptr_to_adr(_get_error(OverflowError).args[0])
-
-def get_overflow_error_value():
- return lltype.cast_opaque_ptr(llmemory.GCREF,
- _get_error(OverflowError).args[1])
-
-def get_zero_division_error():
- return llmemory.cast_ptr_to_adr(_get_error(ZeroDivisionError).args[0])
-
-def get_zero_division_error_value():
- return lltype.cast_opaque_ptr(llmemory.GCREF,
- _get_error(ZeroDivisionError).args[1])
+##def _get_error(Class):
+## if _llinterp.typer is not None:
+## llframe = _llinterp.frame_class(None, None, _llinterp)
+## try:
+## llframe.make_llexception(Class())
+## except LLException, e:
+## return e
+## else:
+## assert 0, "should have raised"
+## else:
+## # for tests, a random emulated ll_inst will do
+## if Class not in _pseudo_exceptions:
+## ll_inst = lltype.malloc(rclass.OBJECT, zero=True)
+## ll_inst.typeptr = lltype.malloc(rclass.OBJECT_VTABLE,
+## immortal=True)
+## _pseudo_exceptions[Class] = LLException(ll_inst.typeptr, ll_inst)
+## return _pseudo_exceptions[Class]
+
+##def get_overflow_error_value():
+## return lltype.cast_opaque_ptr(llmemory.GCREF,
+## _get_error(OverflowError).args[1])
def force(opaque_frame):
frame = _from_opaque(opaque_frame)
@@ -1151,40 +1144,30 @@
def get_frame_forced_token(opaque_frame):
return llmemory.cast_ptr_to_adr(opaque_frame)
-class MemoCast(object):
- def __init__(self):
- self.addresses = [llmemory.NULL]
- self.rev_cache = {}
- self.vtable_to_size = {}
-
-def new_memo_cast():
- memocast = MemoCast()
- return _to_opaque(memocast)
-
-def cast_adr_to_int(memocast, adr):
- # xxx slow
- assert lltype.typeOf(adr) == llmemory.Address
- memocast = _from_opaque(memocast)
- addresses = memocast.addresses
- for i in xrange(len(addresses)-1, -1, -1):
- if addresses[i] == adr:
- return i
- i = len(addresses)
- addresses.append(adr)
- return i
-
-def cast_int_to_adr(memocast, int):
- memocast = _from_opaque(memocast)
- assert 0 <= int < len(memocast.addresses)
- return memocast.addresses[int]
-
-def get_class_size(memocast, vtable):
- memocast = _from_opaque(memocast)
- return memocast.vtable_to_size[vtable]
-
-def set_class_size(memocast, vtable, size):
- memocast = _from_opaque(memocast)
- memocast.vtable_to_size[vtable] = size
+##def cast_adr_to_int(memocast, adr):
+## # xxx slow
+## assert lltype.typeOf(adr) == llmemory.Address
+## memocast = _from_opaque(memocast)
+## addresses = memocast.addresses
+## for i in xrange(len(addresses)-1, -1, -1):
+## if addresses[i] == adr:
+## return i
+## i = len(addresses)
+## addresses.append(adr)
+## return i
+
+##def cast_int_to_adr(memocast, int):
+## memocast = _from_opaque(memocast)
+## assert 0 <= int < len(memocast.addresses)
+## return memocast.addresses[int]
+
+##def get_class_size(memocast, vtable):
+## memocast = _from_opaque(memocast)
+## return memocast.vtable_to_size[vtable]
+
+##def set_class_size(memocast, vtable, size):
+## memocast = _from_opaque(memocast)
+## memocast.vtable_to_size[vtable] = size
class GuardFailed(Exception):
pass
@@ -1192,29 +1175,32 @@
# ____________________________________________________________
+def do_same_as(x):
+ return x
+
def do_arraylen_gc(arraydescr, array):
array = array._obj.container
return array.getlength()
-def do_strlen(_, string):
+def do_strlen(string):
str = lltype.cast_opaque_ptr(lltype.Ptr(rstr.STR), string)
return len(str.chars)
-def do_strgetitem(_, string, index):
+def do_strgetitem(string, index):
str = lltype.cast_opaque_ptr(lltype.Ptr(rstr.STR), string)
return ord(str.chars[index])
-def do_unicodelen(_, string):
+def do_unicodelen(string):
uni = lltype.cast_opaque_ptr(lltype.Ptr(rstr.UNICODE), string)
return len(uni.chars)
-def do_unicodegetitem(_, string, index):
+def do_unicodegetitem(string, index):
uni = lltype.cast_opaque_ptr(lltype.Ptr(rstr.UNICODE), string)
return ord(uni.chars[index])
-def do_getarrayitem_gc_int(array, index, memocast):
+def do_getarrayitem_gc_int(array, index):
array = array._obj.container
- return cast_to_int(array.getitem(index), memocast)
+ return cast_to_int(array.getitem(index))
def do_getarrayitem_gc_float(array, index):
array = array._obj.container
@@ -1229,8 +1215,8 @@
ptr = lltype.cast_opaque_ptr(lltype.Ptr(STRUCT), struct)
return getattr(ptr, fieldname)
-def do_getfield_gc_int(struct, fieldnum, memocast):
- return cast_to_int(_getfield_gc(struct, fieldnum), memocast)
+def do_getfield_gc_int(struct, fieldnum):
+ return cast_to_int(_getfield_gc(struct, fieldnum))
def do_getfield_gc_float(struct, fieldnum):
return cast_to_float(_getfield_gc(struct, fieldnum))
@@ -1238,19 +1224,19 @@
def do_getfield_gc_ptr(struct, fieldnum):
return cast_to_ptr(_getfield_gc(struct, fieldnum))
-def _getfield_raw(struct, fieldnum, memocast):
+def _getfield_raw(struct, fieldnum):
STRUCT, fieldname = symbolic.TokenToField[fieldnum]
- ptr = cast_from_int(lltype.Ptr(STRUCT), struct, memocast)
+ ptr = cast_from_int(lltype.Ptr(STRUCT), struct)
return getattr(ptr, fieldname)
-def do_getfield_raw_int(struct, fieldnum, memocast):
- return cast_to_int(_getfield_raw(struct, fieldnum, memocast), memocast)
+def do_getfield_raw_int(struct, fieldnum):
+ return cast_to_int(_getfield_raw(struct, fieldnum))
-def do_getfield_raw_float(struct, fieldnum, memocast):
- return cast_to_float(_getfield_raw(struct, fieldnum, memocast))
+def do_getfield_raw_float(struct, fieldnum):
+ return cast_to_float(_getfield_raw(struct, fieldnum))
-def do_getfield_raw_ptr(struct, fieldnum, memocast):
- return cast_to_ptr(_getfield_raw(struct, fieldnum, memocast))
+def do_getfield_raw_ptr(struct, fieldnum):
+ return cast_to_ptr(_getfield_raw(struct, fieldnum))
def do_new(size):
TYPE = symbolic.Size2Type[size]
@@ -1262,10 +1248,10 @@
x = lltype.malloc(TYPE, count, zero=True)
return cast_to_ptr(x)
-def do_setarrayitem_gc_int(array, index, newvalue, memocast):
+def do_setarrayitem_gc_int(array, index, newvalue):
array = array._obj.container
ITEMTYPE = lltype.typeOf(array).OF
- newvalue = cast_from_int(ITEMTYPE, newvalue, memocast)
+ newvalue = cast_from_int(ITEMTYPE, newvalue)
array.setitem(index, newvalue)
def do_setarrayitem_gc_float(array, index, newvalue):
@@ -1280,11 +1266,11 @@
newvalue = cast_from_ptr(ITEMTYPE, newvalue)
array.setitem(index, newvalue)
-def do_setfield_gc_int(struct, fieldnum, newvalue, memocast):
+def do_setfield_gc_int(struct, fieldnum, newvalue):
STRUCT, fieldname = symbolic.TokenToField[fieldnum]
ptr = lltype.cast_opaque_ptr(lltype.Ptr(STRUCT), struct)
FIELDTYPE = getattr(STRUCT, fieldname)
- newvalue = cast_from_int(FIELDTYPE, newvalue, memocast)
+ newvalue = cast_from_int(FIELDTYPE, newvalue)
setattr(ptr, fieldname, newvalue)
def do_setfield_gc_float(struct, fieldnum, newvalue):
@@ -1301,108 +1287,129 @@
newvalue = cast_from_ptr(FIELDTYPE, newvalue)
setattr(ptr, fieldname, newvalue)
-def do_setfield_raw_int(struct, fieldnum, newvalue, memocast):
+def do_setfield_raw_int(struct, fieldnum, newvalue):
STRUCT, fieldname = symbolic.TokenToField[fieldnum]
- ptr = cast_from_int(lltype.Ptr(STRUCT), struct, memocast)
+ ptr = cast_from_int(lltype.Ptr(STRUCT), struct)
FIELDTYPE = getattr(STRUCT, fieldname)
- newvalue = cast_from_int(FIELDTYPE, newvalue, memocast)
+ newvalue = cast_from_int(FIELDTYPE, newvalue)
setattr(ptr, fieldname, newvalue)
-def do_setfield_raw_float(struct, fieldnum, newvalue, memocast):
+def do_setfield_raw_float(struct, fieldnum, newvalue):
STRUCT, fieldname = symbolic.TokenToField[fieldnum]
- ptr = cast_from_int(lltype.Ptr(STRUCT), struct, memocast)
+ ptr = cast_from_int(lltype.Ptr(STRUCT), struct)
FIELDTYPE = getattr(STRUCT, fieldname)
newvalue = cast_from_float(FIELDTYPE, newvalue)
setattr(ptr, fieldname, newvalue)
-def do_setfield_raw_ptr(struct, fieldnum, newvalue, memocast):
+def do_setfield_raw_ptr(struct, fieldnum, newvalue):
STRUCT, fieldname = symbolic.TokenToField[fieldnum]
- ptr = cast_from_int(lltype.Ptr(STRUCT), struct, memocast)
+ ptr = cast_from_int(lltype.Ptr(STRUCT), struct)
FIELDTYPE = getattr(STRUCT, fieldname)
newvalue = cast_from_ptr(FIELDTYPE, newvalue)
setattr(ptr, fieldname, newvalue)
-def do_newstr(_, length):
+def do_newstr(length):
x = rstr.mallocstr(length)
return cast_to_ptr(x)
-def do_newunicode(_, length):
+def do_newunicode(length):
return cast_to_ptr(rstr.mallocunicode(length))
-def do_strsetitem(_, string, index, newvalue):
+def do_strsetitem(string, index, newvalue):
str = lltype.cast_opaque_ptr(lltype.Ptr(rstr.STR), string)
str.chars[index] = chr(newvalue)
-def do_unicodesetitem(_, string, index, newvalue):
+def do_unicodesetitem(string, index, newvalue):
uni = lltype.cast_opaque_ptr(lltype.Ptr(rstr.UNICODE), string)
uni.chars[index] = unichr(newvalue)
# ---------- call ----------
-_call_args = []
+_call_args_i = []
+_call_args_r = []
+_call_args_f = []
def do_call_pushint(x):
- _call_args.append(x)
-
-def do_call_pushfloat(x):
- _call_args.append(x)
+ _call_args_i.append(x)
def do_call_pushptr(x):
- _call_args.append(x)
+ _call_args_r.append(x)
-def _do_call_common(f, memocast, err_result=None):
- global _last_exception
- assert _last_exception is None, "exception left behind"
- ptr = cast_int_to_adr(memocast, f).ptr
+def do_call_pushfloat(x):
+ _call_args_f.append(x)
+
+def _do_call_common(f, args_in_order=None):
+ ptr = llmemory.cast_int_to_adr(f).ptr
FUNC = lltype.typeOf(ptr).TO
ARGS = FUNC.ARGS
- args = cast_call_args(ARGS, _call_args, memocast)
- del _call_args[:]
+ args = cast_call_args(ARGS, _call_args_i, _call_args_r, _call_args_f,
+ args_in_order)
+ del _call_args_i[:]
+ del _call_args_r[:]
+ del _call_args_f[:]
assert len(ARGS) == len(args)
- try:
- if hasattr(ptr._obj, 'graph'):
- llinterp = _llinterp # it's a global set here by CPU.__init__()
- result = llinterp.eval_graph(ptr._obj.graph, args)
- else:
- result = ptr._obj._callable(*args)
- except LLException, e:
- _last_exception = e
- result = err_result
+ if hasattr(ptr._obj, 'graph'):
+ llinterp = _llinterp # it's a global set here by CPU.__init__()
+ result = llinterp.eval_graph(ptr._obj.graph, args)
+ # ^^^ may raise, in which case we get an LLException
+ else:
+ result = ptr._obj._callable(*args)
return result
-def do_call_void(f, memocast):
- _do_call_common(f, memocast)
+def do_call_void(f):
+ _do_call_common(f)
-def do_call_int(f, memocast):
- x = _do_call_common(f, memocast, 0)
- return cast_to_int(x, memocast)
+def do_call_int(f):
+ x = _do_call_common(f)
+ return cast_to_int(x)
-def do_call_float(f, memocast):
- x = _do_call_common(f, memocast, 0)
+def do_call_float(f):
+ x = _do_call_common(f)
return cast_to_float(x)
-def do_call_ptr(f, memocast):
- x = _do_call_common(f, memocast, lltype.nullptr(llmemory.GCREF.TO))
+def do_call_ptr(f):
+ x = _do_call_common(f)
return cast_to_ptr(x)
-def cast_call_args(ARGS, args, memocast):
- argsiter = iter(args)
+def cast_call_args(ARGS, args_i, args_r, args_f, args_in_order=None):
+ argsiter_i = iter(args_i)
+ argsiter_r = iter(args_r)
+ argsiter_f = iter(args_f)
+ if args_in_order is not None:
+ orderiter = iter(args_in_order)
args = []
for TYPE in ARGS:
if TYPE is lltype.Void:
x = None
else:
- x = argsiter.next()
if isinstance(TYPE, ootype.OOType):
+ if args_in_order is not None:
+ n = orderiter.next()
+ assert n == 'r'
+ x = argsiter_r.next()
x = ootype.cast_from_object(TYPE, x)
elif isinstance(TYPE, lltype.Ptr) and TYPE.TO._gckind == 'gc':
+ if args_in_order is not None:
+ n = orderiter.next()
+ assert n == 'r'
+ x = argsiter_r.next()
x = cast_from_ptr(TYPE, x)
elif TYPE is lltype.Float:
+ if args_in_order is not None:
+ n = orderiter.next()
+ assert n == 'f'
+ x = argsiter_f.next()
x = cast_from_float(TYPE, x)
else:
- x = cast_from_int(TYPE, x, memocast)
+ if args_in_order is not None:
+ n = orderiter.next()
+ assert n == 'i'
+ x = argsiter_i.next()
+ x = cast_from_int(TYPE, x)
args.append(x)
- assert list(argsiter) == []
+ assert list(argsiter_i) == []
+ assert list(argsiter_r) == []
+ assert list(argsiter_f) == []
return args
@@ -1421,7 +1428,7 @@
result = llinterp.eval_graph(mymethod.graph, myargs)
else:
result = meth(*args)
- except LLException, e:
+ except XXX-LLException, e:
_last_exception = e
result = get_err_result_for_type(mymethod._TYPE.RESULT)
return result
@@ -1474,16 +1481,13 @@
COMPILEDLOOP = lltype.Ptr(lltype.OpaqueType("CompiledLoop"))
FRAME = lltype.Ptr(lltype.OpaqueType("Frame"))
OOFRAME = lltype.Ptr(lltype.OpaqueType("OOFrame"))
-MEMOCAST = lltype.Ptr(lltype.OpaqueType("MemoCast"))
_TO_OPAQUE[CompiledLoop] = COMPILEDLOOP.TO
_TO_OPAQUE[Frame] = FRAME.TO
_TO_OPAQUE[OOFrame] = OOFRAME.TO
-_TO_OPAQUE[MemoCast] = MEMOCAST.TO
s_CompiledLoop = annmodel.SomePtr(COMPILEDLOOP)
s_Frame = annmodel.SomePtr(FRAME)
-s_MemoCast = annmodel.SomePtr(MEMOCAST)
setannotation(compile_start, s_CompiledLoop)
setannotation(compile_start_int_var, annmodel.SomeInteger())
@@ -1512,23 +1516,14 @@
setannotation(frame_int_getvalue, annmodel.SomeInteger())
setannotation(frame_ptr_getvalue, annmodel.SomePtr(llmemory.GCREF))
setannotation(frame_float_getvalue, annmodel.SomeFloat())
+setannotation(frame_get_value_count, annmodel.SomeInteger())
+setannotation(frame_clear_latest_values, annmodel.s_None)
-setannotation(get_exception, annmodel.SomeAddress())
-setannotation(get_exc_value, annmodel.SomePtr(llmemory.GCREF))
-setannotation(clear_exception, annmodel.s_None)
-setannotation(get_overflow_error, annmodel.SomeAddress())
-setannotation(get_overflow_error_value, annmodel.SomePtr(llmemory.GCREF))
-setannotation(get_zero_division_error, annmodel.SomeAddress())
-setannotation(get_zero_division_error_value, annmodel.SomePtr(llmemory.GCREF))
+setannotation(grab_exc_value, annmodel.SomePtr(llmemory.GCREF))
setannotation(force, annmodel.SomeInteger())
setannotation(get_forced_token_frame, s_Frame)
setannotation(get_frame_forced_token, annmodel.SomeAddress())
-setannotation(new_memo_cast, s_MemoCast)
-setannotation(cast_adr_to_int, annmodel.SomeInteger())
-setannotation(cast_int_to_adr, annmodel.SomeAddress())
-setannotation(set_class_size, annmodel.s_None)
-
setannotation(do_arraylen_gc, annmodel.SomeInteger())
setannotation(do_strlen, annmodel.SomeInteger())
setannotation(do_strgetitem, annmodel.SomeInteger())
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llgraph/runner.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llgraph/runner.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llgraph/runner.py Tue Jun 8 19:48:40 2010
@@ -15,6 +15,7 @@
from pypy.jit.backend import model
from pypy.jit.backend.llgraph import llimpl, symbolic
from pypy.jit.metainterp.typesystem import llhelper, oohelper
+from pypy.jit.codewriter import heaptracker
from pypy.rlib import rgc
class MiniStats:
@@ -23,11 +24,19 @@
class Descr(history.AbstractDescr):
- def __init__(self, ofs, typeinfo, extrainfo=None, name=None):
+ def __init__(self, ofs, typeinfo, extrainfo=None, name=None,
+ arg_types=None):
self.ofs = ofs
self.typeinfo = typeinfo
self.extrainfo = extrainfo
self.name = name
+ self.arg_types = arg_types
+
+ def get_arg_types(self):
+ return self.arg_types
+
+ def get_return_type(self):
+ return self.typeinfo
def get_extra_info(self):
return self.extrainfo
@@ -51,6 +60,9 @@
def is_array_of_floats(self):
return self.typeinfo == FLOAT
+ def as_vtable_size_descr(self):
+ return self
+
def __lt__(self, other):
raise TypeError("cannot use comparison on Descrs")
def __le__(self, other):
@@ -86,7 +98,6 @@
self.stats.exec_counters = {}
self.stats.exec_jumps = 0
self.stats.exec_conditional_jumps = 0
- self.memo_cast = llimpl.new_memo_cast()
llimpl._stats = self.stats
llimpl._llinterp = LLInterpreter(self.rtyper)
self._future_values = []
@@ -96,22 +107,16 @@
assert self.translate_support_code
return False
- def getdescr(self, ofs, typeinfo='?', extrainfo=None, name=None):
- key = (ofs, typeinfo, extrainfo, name)
+ def getdescr(self, ofs, typeinfo='?', extrainfo=None, name=None,
+ arg_types=None):
+ key = (ofs, typeinfo, extrainfo, name, arg_types)
try:
return self._descrs[key]
except KeyError:
- descr = Descr(ofs, typeinfo, extrainfo, name)
+ descr = Descr(ofs, typeinfo, extrainfo, name, arg_types)
self._descrs[key] = descr
return descr
- def set_class_sizes(self, class_sizes):
- self.class_sizes = class_sizes
- for vtable, size in class_sizes.items():
- if not self.is_oo:
- size = size.ofs
- llimpl.set_class_size(self.memo_cast, vtable, size)
-
def compile_bridge(self, faildescr, inputargs, operations):
c = llimpl.compile_start()
self._compile_loop_or_bridge(c, inputargs, operations)
@@ -161,8 +166,6 @@
llimpl.compile_add_int_const(c, x.value)
elif isinstance(x, self.ts.ConstRef):
llimpl.compile_add_ref_const(c, x.value, self.ts.BASETYPE)
- elif isinstance(x, history.ConstAddr):
- llimpl.compile_add_int_const(c, x.getint())
elif isinstance(x, history.ConstFloat):
llimpl.compile_add_float_const(c, x.value)
else:
@@ -213,7 +216,7 @@
def _execute_token(self, loop_token):
compiled_version = loop_token._llgraph_compiled_version
- frame = llimpl.new_frame(self.memo_cast, self.is_oo, self)
+ frame = llimpl.new_frame(self.is_oo, self)
# setup the frame
llimpl.frame_clear(frame, compiled_version)
# run the loop
@@ -247,60 +250,22 @@
def get_latest_value_float(self, index):
return llimpl.frame_float_getvalue(self.latest_frame, index)
+ def get_latest_value_count(self):
+ return llimpl.frame_get_value_count(self.latest_frame)
+
def get_latest_force_token(self):
token = llimpl.get_frame_forced_token(self.latest_frame)
- return self.cast_adr_to_int(token)
+ return heaptracker.adr2int(token)
- def make_boxes_from_latest_values(self, faildescr):
- inputargs_and_holes = []
- for i in range(len(faildescr._fail_args_types)):
- boxtype = faildescr._fail_args_types[i]
- if boxtype == history.INT:
- box = history.BoxInt(self.get_latest_value_int(i))
- elif boxtype == history.REF:
- box = self.ts.BoxRef(self.get_latest_value_ref(i))
- elif boxtype == history.FLOAT:
- box = history.BoxFloat(self.get_latest_value_float(i))
- elif boxtype == history.HOLE:
- box = None
- else:
- assert False, "bad box type: num=%d" % ord(boxtype)
- inputargs_and_holes.append(box)
- return inputargs_and_holes
+ def clear_latest_values(self, count):
+ llimpl.frame_clear_latest_values(self.latest_frame, count)
# ----------
- def get_exception(self):
- return self.cast_adr_to_int(llimpl.get_exception())
-
- def get_exc_value(self):
- return llimpl.get_exc_value()
-
- def clear_exception(self):
- llimpl.clear_exception()
-
- def get_overflow_error(self):
- return (self.cast_adr_to_int(llimpl.get_overflow_error()),
- llimpl.get_overflow_error_value())
-
- def get_zero_division_error(self):
- return (self.cast_adr_to_int(llimpl.get_zero_division_error()),
- llimpl.get_zero_division_error_value())
-
def sizeof(self, S):
assert not isinstance(S, lltype.Ptr)
return self.getdescr(symbolic.get_size(S))
- def cast_adr_to_int(self, adr):
- return llimpl.cast_adr_to_int(self.memo_cast, adr)
-
- def cast_int_to_adr(self, int):
- return llimpl.cast_int_to_adr(self.memo_cast, int)
-
- def cast_gcref_to_int(self, gcref):
- return self.cast_adr_to_int(llmemory.cast_ptr_to_adr(gcref))
-
-
class LLtypeCPU(BaseCPU):
is_oo = False
@@ -316,14 +281,17 @@
return self.getdescr(ofs, token[0], name=fieldname)
def calldescrof(self, FUNC, ARGS, RESULT, extrainfo=None):
+ arg_types = []
+ for ARG in ARGS:
+ token = history.getkind(ARG)
+ if token != 'void':
+ arg_types.append(token[0])
token = history.getkind(RESULT)
- return self.getdescr(0, token[0], extrainfo=extrainfo)
-
- def get_exception(self):
- return self.cast_adr_to_int(llimpl.get_exception())
+ return self.getdescr(0, token[0], extrainfo=extrainfo,
+ arg_types=''.join(arg_types))
- def get_exc_value(self):
- return llimpl.get_exc_value()
+ def grab_exc_value(self):
+ return llimpl.grab_exc_value()
def arraydescrof(self, A):
assert isinstance(A, lltype.GcArray)
@@ -334,202 +302,151 @@
# ---------- the backend-dependent operations ----------
- def do_arraylen_gc(self, arraybox, arraydescr):
- array = arraybox.getref_base()
- return history.BoxInt(llimpl.do_arraylen_gc(arraydescr, array))
-
- def do_strlen(self, stringbox):
- string = stringbox.getref_base()
- return history.BoxInt(llimpl.do_strlen(0, string))
-
- def do_strgetitem(self, stringbox, indexbox):
- string = stringbox.getref_base()
- index = indexbox.getint()
- return history.BoxInt(llimpl.do_strgetitem(0, string, index))
-
- def do_unicodelen(self, stringbox):
- string = stringbox.getref_base()
- return history.BoxInt(llimpl.do_unicodelen(0, string))
-
- def do_unicodegetitem(self, stringbox, indexbox):
- string = stringbox.getref_base()
- index = indexbox.getint()
- return history.BoxInt(llimpl.do_unicodegetitem(0, string, index))
+ def bh_strlen(self, string):
+ return llimpl.do_strlen(string)
+
+ def bh_strgetitem(self, string, index):
+ return llimpl.do_strgetitem(string, index)
+
+ def bh_unicodelen(self, string):
+ return llimpl.do_unicodelen(string)
+
+ def bh_unicodegetitem(self, string, index):
+ return llimpl.do_unicodegetitem(string, index)
- def do_getarrayitem_gc(self, arraybox, indexbox, arraydescr):
+ def bh_getarrayitem_gc_i(self, arraydescr, array, index):
assert isinstance(arraydescr, Descr)
- array = arraybox.getref_base()
- index = indexbox.getint()
- if arraydescr.typeinfo == REF:
- return history.BoxPtr(llimpl.do_getarrayitem_gc_ptr(array, index))
- elif arraydescr.typeinfo == INT:
- return history.BoxInt(llimpl.do_getarrayitem_gc_int(array, index,
- self.memo_cast))
- elif arraydescr.typeinfo == FLOAT:
- return history.BoxFloat(llimpl.do_getarrayitem_gc_float(array,
- index))
- else:
- raise NotImplementedError
+ return llimpl.do_getarrayitem_gc_int(array, index)
+ def bh_getarrayitem_gc_r(self, arraydescr, array, index):
+ assert isinstance(arraydescr, Descr)
+ return llimpl.do_getarrayitem_gc_ptr(array, index)
+ def bh_getarrayitem_gc_f(self, arraydescr, array, index):
+ assert isinstance(arraydescr, Descr)
+ return llimpl.do_getarrayitem_gc_float(array, index)
- def do_getfield_gc(self, structbox, fielddescr):
+ def bh_getfield_gc_i(self, struct, fielddescr):
assert isinstance(fielddescr, Descr)
- struct = structbox.getref_base()
- if fielddescr.typeinfo == REF:
- return history.BoxPtr(llimpl.do_getfield_gc_ptr(struct,
- fielddescr.ofs))
- elif fielddescr.typeinfo == INT:
- return history.BoxInt(llimpl.do_getfield_gc_int(struct,
- fielddescr.ofs,
- self.memo_cast))
- elif fielddescr.typeinfo == FLOAT:
- return history.BoxFloat(llimpl.do_getfield_gc_float(struct,
- fielddescr.ofs))
- else:
- raise NotImplementedError
+ return llimpl.do_getfield_gc_int(struct, fielddescr.ofs)
+ def bh_getfield_gc_r(self, struct, fielddescr):
+ assert isinstance(fielddescr, Descr)
+ return llimpl.do_getfield_gc_ptr(struct, fielddescr.ofs)
+ def bh_getfield_gc_f(self, struct, fielddescr):
+ assert isinstance(fielddescr, Descr)
+ return llimpl.do_getfield_gc_float(struct, fielddescr.ofs)
- def do_getfield_raw(self, structbox, fielddescr):
+ def bh_getfield_raw_i(self, struct, fielddescr):
assert isinstance(fielddescr, Descr)
- struct = self.cast_int_to_adr(structbox.getint())
- if fielddescr.typeinfo == REF:
- return history.BoxPtr(llimpl.do_getfield_raw_ptr(struct,
- fielddescr.ofs,
- self.memo_cast))
- elif fielddescr.typeinfo == INT:
- return history.BoxInt(llimpl.do_getfield_raw_int(struct,
- fielddescr.ofs,
- self.memo_cast))
- elif fielddescr.typeinfo == FLOAT:
- return history.BoxFloat(llimpl.do_getfield_raw_float(struct,
- fielddescr.ofs,
- self.memo_cast))
- else:
- raise NotImplementedError
+ return llimpl.do_getfield_raw_int(struct, fielddescr.ofs)
+ def bh_getfield_raw_r(self, struct, fielddescr):
+ assert isinstance(fielddescr, Descr)
+ return llimpl.do_getfield_raw_ptr(struct, fielddescr.ofs)
+ def bh_getfield_raw_f(self, struct, fielddescr):
+ assert isinstance(fielddescr, Descr)
+ return llimpl.do_getfield_raw_float(struct, fielddescr.ofs)
- def do_new(self, size):
- assert isinstance(size, Descr)
- return history.BoxPtr(llimpl.do_new(size.ofs))
-
- def do_new_with_vtable(self, vtablebox):
- vtable = vtablebox.getint()
- size = self.class_sizes[vtable]
- result = llimpl.do_new(size.ofs)
- llimpl.do_setfield_gc_int(result, self.fielddescrof_vtable.ofs,
- vtable, self.memo_cast)
- return history.BoxPtr(result)
-
- def do_new_array(self, countbox, size):
- assert isinstance(size, Descr)
- count = countbox.getint()
- return history.BoxPtr(llimpl.do_new_array(size.ofs, count))
+ def bh_new(self, sizedescr):
+ assert isinstance(sizedescr, Descr)
+ return llimpl.do_new(sizedescr.ofs)
+
+ def bh_new_with_vtable(self, sizedescr, vtable):
+ assert isinstance(sizedescr, Descr)
+ result = llimpl.do_new(sizedescr.ofs)
+ llimpl.do_setfield_gc_int(result, self.fielddescrof_vtable.ofs, vtable)
+ return result
+
+ def bh_classof(self, struct):
+ struct = lltype.cast_opaque_ptr(rclass.OBJECTPTR, struct)
+ result = struct.typeptr
+ result_adr = llmemory.cast_ptr_to_adr(struct.typeptr)
+ return heaptracker.adr2int(result_adr)
- def do_setarrayitem_gc(self, arraybox, indexbox, newvaluebox, arraydescr):
+ def bh_new_array(self, arraydescr, length):
assert isinstance(arraydescr, Descr)
- array = arraybox.getref_base()
- index = indexbox.getint()
- if arraydescr.typeinfo == REF:
- newvalue = newvaluebox.getref_base()
- llimpl.do_setarrayitem_gc_ptr(array, index, newvalue)
- elif arraydescr.typeinfo == INT:
- newvalue = newvaluebox.getint()
- llimpl.do_setarrayitem_gc_int(array, index, newvalue,
- self.memo_cast)
- elif arraydescr.typeinfo == FLOAT:
- newvalue = newvaluebox.getfloat()
- llimpl.do_setarrayitem_gc_float(array, index, newvalue)
- else:
- raise NotImplementedError
+ return llimpl.do_new_array(arraydescr.ofs, length)
+
+ def bh_arraylen_gc(self, arraydescr, array):
+ assert isinstance(arraydescr, Descr)
+ return llimpl.do_arraylen_gc(arraydescr, array)
+
+ def bh_setarrayitem_gc_i(self, arraydescr, array, index, newvalue):
+ assert isinstance(arraydescr, Descr)
+ llimpl.do_setarrayitem_gc_int(array, index, newvalue)
+
+ def bh_setarrayitem_gc_r(self, arraydescr, array, index, newvalue):
+ assert isinstance(arraydescr, Descr)
+ llimpl.do_setarrayitem_gc_ptr(array, index, newvalue)
+
+ def bh_setarrayitem_gc_f(self, arraydescr, array, index, newvalue):
+ assert isinstance(arraydescr, Descr)
+ llimpl.do_setarrayitem_gc_float(array, index, newvalue)
- def do_setfield_gc(self, structbox, newvaluebox, fielddescr):
+ def bh_setfield_gc_i(self, struct, fielddescr, newvalue):
assert isinstance(fielddescr, Descr)
- struct = structbox.getref_base()
- if fielddescr.typeinfo == REF:
- newvalue = newvaluebox.getref_base()
- llimpl.do_setfield_gc_ptr(struct, fielddescr.ofs, newvalue)
- elif fielddescr.typeinfo == INT:
- newvalue = newvaluebox.getint()
- llimpl.do_setfield_gc_int(struct, fielddescr.ofs, newvalue,
- self.memo_cast)
- elif fielddescr.typeinfo == FLOAT:
- newvalue = newvaluebox.getfloat()
- llimpl.do_setfield_gc_float(struct, fielddescr.ofs, newvalue)
- else:
- raise NotImplementedError
+ llimpl.do_setfield_gc_int(struct, fielddescr.ofs, newvalue)
+ def bh_setfield_gc_r(self, struct, fielddescr, newvalue):
+ assert isinstance(fielddescr, Descr)
+ llimpl.do_setfield_gc_ptr(struct, fielddescr.ofs, newvalue)
+ def bh_setfield_gc_f(self, struct, fielddescr, newvalue):
+ assert isinstance(fielddescr, Descr)
+ llimpl.do_setfield_gc_float(struct, fielddescr.ofs, newvalue)
- def do_setfield_raw(self, structbox, newvaluebox, fielddescr):
+ def bh_setfield_raw_i(self, struct, fielddescr, newvalue):
assert isinstance(fielddescr, Descr)
- struct = self.cast_int_to_adr(structbox.getint())
- if fielddescr.typeinfo == REF:
- newvalue = newvaluebox.getref_base()
- llimpl.do_setfield_raw_ptr(struct, fielddescr.ofs, newvalue,
- self.memo_cast)
- elif fielddescr.typeinfo == INT:
- newvalue = newvaluebox.getint()
- llimpl.do_setfield_raw_int(struct, fielddescr.ofs, newvalue,
- self.memo_cast)
- elif fielddescr.typeinfo == FLOAT:
- newvalue = newvaluebox.getfloat()
- llimpl.do_setfield_raw_float(struct, fielddescr.ofs, newvalue,
- self.memo_cast)
- else:
- raise NotImplementedError
+ llimpl.do_setfield_raw_int(struct, fielddescr.ofs, newvalue)
+ def bh_setfield_raw_r(self, struct, fielddescr, newvalue):
+ assert isinstance(fielddescr, Descr)
+ llimpl.do_setfield_raw_ptr(struct, fielddescr.ofs, newvalue)
+ def bh_setfield_raw_f(self, struct, fielddescr, newvalue):
+ assert isinstance(fielddescr, Descr)
+ llimpl.do_setfield_raw_float(struct, fielddescr.ofs, newvalue)
- def do_same_as(self, box1):
- return box1.clonebox()
+ def bh_newstr(self, length):
+ return llimpl.do_newstr(length)
- def do_newstr(self, lengthbox):
- length = lengthbox.getint()
- return history.BoxPtr(llimpl.do_newstr(0, length))
-
- def do_newunicode(self, lengthbox):
- length = lengthbox.getint()
- return history.BoxPtr(llimpl.do_newunicode(0, length))
-
- def do_strsetitem(self, stringbox, indexbox, newvaluebox):
- string = stringbox.getref_base()
- index = indexbox.getint()
- newvalue = newvaluebox.getint()
- llimpl.do_strsetitem(0, string, index, newvalue)
-
- def do_unicodesetitem(self, stringbox, indexbox, newvaluebox):
- string = stringbox.getref_base()
- index = indexbox.getint()
- newvalue = newvaluebox.getint()
- llimpl.do_unicodesetitem(0, string, index, newvalue)
+ def bh_newunicode(self, length):
+ return llimpl.do_newunicode(length)
- def do_call(self, args, calldescr):
- assert isinstance(calldescr, Descr)
- func = args[0].getint()
- for arg in args[1:]:
- if arg.type == REF:
- llimpl.do_call_pushptr(arg.getref_base())
- elif arg.type == FLOAT:
- llimpl.do_call_pushfloat(arg.getfloat())
- else:
- llimpl.do_call_pushint(arg.getint())
- if calldescr.typeinfo == REF:
- return history.BoxPtr(llimpl.do_call_ptr(func, self.memo_cast))
- elif calldescr.typeinfo == INT:
- return history.BoxInt(llimpl.do_call_int(func, self.memo_cast))
- elif calldescr.typeinfo == FLOAT:
- return history.BoxFloat(llimpl.do_call_float(func, self.memo_cast))
- elif calldescr.typeinfo == 'v': # void
- llimpl.do_call_void(func, self.memo_cast)
- else:
- raise NotImplementedError
+ def bh_strsetitem(self, string, index, newvalue):
+ llimpl.do_strsetitem(string, index, newvalue)
+
+ def bh_unicodesetitem(self, string, index, newvalue):
+ llimpl.do_unicodesetitem(string, index, newvalue)
+
+ def bh_call_i(self, func, calldescr, args_i, args_r, args_f):
+ self._prepare_call(INT, calldescr, args_i, args_r, args_f)
+ return llimpl.do_call_int(func)
+ def bh_call_r(self, func, calldescr, args_i, args_r, args_f):
+ self._prepare_call(REF, calldescr, args_i, args_r, args_f)
+ return llimpl.do_call_ptr(func)
+ def bh_call_f(self, func, calldescr, args_i, args_r, args_f):
+ self._prepare_call(FLOAT, calldescr, args_i, args_r, args_f)
+ return llimpl.do_call_float(func)
+ def bh_call_v(self, func, calldescr, args_i, args_r, args_f):
+ self._prepare_call('v', calldescr, args_i, args_r, args_f)
+ llimpl.do_call_void(func)
- def do_cast_ptr_to_int(self, ptrbox):
- return history.BoxInt(llimpl.cast_to_int(ptrbox.getref_base(),
- self.memo_cast))
+ def _prepare_call(self, resulttypeinfo, calldescr, args_i, args_r, args_f):
+ assert isinstance(calldescr, Descr)
+ assert calldescr.typeinfo == resulttypeinfo
+ if args_i is not None:
+ for x in args_i:
+ llimpl.do_call_pushint(x)
+ if args_r is not None:
+ for x in args_r:
+ llimpl.do_call_pushptr(x)
+ if args_f is not None:
+ for x in args_f:
+ llimpl.do_call_pushfloat(x)
def force(self, force_token):
- token = self.cast_int_to_adr(force_token)
+ token = llmemory.cast_int_to_adr(force_token)
frame = llimpl.get_forced_token_frame(token)
fail_index = llimpl.force(frame)
self.latest_frame = frame
return self.get_fail_descr_from_number(fail_index)
-class OOtypeCPU(BaseCPU):
+class OOtypeCPU_xxx_disabled(BaseCPU):
is_oo = True
ts = oohelper
@@ -629,7 +546,7 @@
assert isinstance(typedescr, TypeDescr)
return typedescr.getarraylength(box1)
- def do_call(self, args, descr):
+ def do_call_XXX(self, args, descr):
assert isinstance(descr, StaticMethDescr)
funcbox = args[0]
argboxes = args[1:]
@@ -842,10 +759,3 @@
def __repr__(self):
return '<FieldDescr %r>' % self.fieldname
-
-
-# ____________________________________________________________
-
-import pypy.jit.metainterp.executor
-pypy.jit.metainterp.executor.make_execute_list(LLtypeCPU)
-pypy.jit.metainterp.executor.make_execute_list(OOtypeCPU)
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llgraph/test/test_llgraph.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llgraph/test/test_llgraph.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llgraph/test/test_llgraph.py Tue Jun 8 19:48:40 2010
@@ -7,6 +7,7 @@
TreeLoop
from pypy.jit.metainterp.resoperation import ResOperation, rop
from pypy.jit.metainterp.executor import execute
+from pypy.jit.codewriter import heaptracker
from pypy.jit.backend.test.runner_test import LLtypeBackendTest
class TestLLTypeLLGraph(LLtypeBackendTest):
@@ -18,25 +19,25 @@
def setup_method(self, _):
self.cpu = self.cpu_type(None)
- def test_cast_adr_to_int_and_back(self):
- cpu = self.cpu
- X = lltype.Struct('X', ('foo', lltype.Signed))
- x = lltype.malloc(X, immortal=True)
- x.foo = 42
- a = llmemory.cast_ptr_to_adr(x)
- i = cpu.cast_adr_to_int(a)
- assert isinstance(i, int)
- a2 = cpu.cast_int_to_adr(i)
- assert llmemory.cast_adr_to_ptr(a2, lltype.Ptr(X)) == x
- assert cpu.cast_adr_to_int(llmemory.NULL) == 0
- assert cpu.cast_int_to_adr(0) == llmemory.NULL
+def test_cast_adr_to_int_and_back():
+ X = lltype.Struct('X', ('foo', lltype.Signed))
+ x = lltype.malloc(X, immortal=True)
+ x.foo = 42
+ a = llmemory.cast_ptr_to_adr(x)
+ i = heaptracker.adr2int(a)
+ assert lltype.typeOf(i) is lltype.Signed
+ a2 = heaptracker.int2adr(i)
+ assert llmemory.cast_adr_to_ptr(a2, lltype.Ptr(X)) == x
+ assert heaptracker.adr2int(llmemory.NULL) == 0
+ assert heaptracker.int2adr(0) == llmemory.NULL
## these tests never worked
## class TestOOTypeLLGraph(LLGraphTest):
## from pypy.jit.backend.llgraph.runner import OOtypeCPU as cpu_type
def test_fielddescr_ootype():
+ py.test.skip("ootype tests skipped")
from pypy.rpython.ootypesystem import ootype
from pypy.jit.backend.llgraph.runner import OOtypeCPU
A = ootype.Instance("A", ootype.ROOT, {"foo": ootype.Signed})
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/descr.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/descr.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/descr.py Tue Jun 8 19:48:40 2010
@@ -1,10 +1,11 @@
import py
-from pypy.rpython.lltypesystem import lltype, rffi, llmemory
+from pypy.rpython.lltypesystem import lltype, rffi, llmemory, rclass
from pypy.jit.backend.llsupport import symbolic, support
from pypy.jit.metainterp.history import AbstractDescr, getkind, BoxInt, BoxPtr
from pypy.jit.metainterp.history import BasicFailDescr, LoopToken, BoxFloat
from pypy.jit.metainterp import history
from pypy.jit.metainterp.resoperation import ResOperation, rop
+from pypy.jit.codewriter import heaptracker
# The point of the class organization in this file is to make instances
# as compact as possible. This is done by not storing the field size or
@@ -40,6 +41,10 @@
def repr_of_descr(self):
return '<SizeDescr %s>' % self.size
+class SizeDescrWithVTable(SizeDescr):
+ def as_vtable_size_descr(self):
+ return self
+
BaseSizeDescr = SizeDescr
def get_size_descr(gccache, STRUCT):
@@ -48,7 +53,10 @@
return cache[STRUCT]
except KeyError:
size = symbolic.get_size(STRUCT, gccache.translate_support_code)
- sizedescr = SizeDescr(size)
+ if heaptracker.has_gcstruct_a_vtable(STRUCT):
+ sizedescr = SizeDescrWithVTable(size)
+ else:
+ sizedescr = SizeDescr(size)
gccache.init_size_descr(STRUCT, sizedescr)
cache[STRUCT] = sizedescr
return sizedescr
@@ -179,7 +187,6 @@
# CallDescrs
class BaseCallDescr(AbstractDescr):
- empty_box = BoxInt(0)
_clsname = ''
loop_token = None
arg_classes = '' # <-- annotation hack
@@ -191,35 +198,20 @@
def get_extra_info(self):
return self.extrainfo
- _returns_a_pointer = False # unless overridden by GcPtrCallDescr
- _returns_a_float = False # unless overridden by FloatCallDescr
- _returns_a_void = False # unless overridden by VoidCallDescr
-
- def returns_a_pointer(self):
- return self._returns_a_pointer
-
- def returns_a_float(self):
- return self._returns_a_float
+ def get_arg_types(self):
+ return self.arg_classes
- def returns_a_void(self):
- return self._returns_a_void
+ def get_return_type(self):
+ return self._return_type
def get_result_size(self, translate_support_code):
raise NotImplementedError
- def get_call_stub(self):
- return self.call_stub
-
def create_call_stub(self, rtyper, RESULT):
- def process(no, c):
- if c == 'i':
- return 'args[%d].getint()' % (no,)
- elif c == 'f':
- return 'args[%d].getfloat()' % (no,)
- elif c == 'r':
- return 'args[%d].getref_base()' % (no,)
- else:
- raise Exception("Unknown type %s for type %s" % (c, TP))
+ def process(c):
+ arg = 'args_%s[%d]' % (c, seen[c])
+ seen[c] += 1
+ return arg
def TYPE(arg):
if arg == 'i':
@@ -230,21 +222,23 @@
return llmemory.GCREF
elif arg == 'v':
return lltype.Void
-
- args = ", ".join([process(i + 1, c) for i, c in
- enumerate(self.arg_classes)])
-
- if self.returns_a_pointer():
- result = 'history.BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, res))'
- elif self.returns_a_float():
- result = 'history.BoxFloat(res)'
- elif self.returns_a_void():
+
+ seen = {'i': 0, 'r': 0, 'f': 0}
+ args = ", ".join([process(c) for c in self.arg_classes])
+
+ if self.get_return_type() == history.INT:
+ result = 'rffi.cast(lltype.Signed, res)'
+ elif self.get_return_type() == history.REF:
+ result = 'lltype.cast_opaque_ptr(llmemory.GCREF, res)'
+ elif self.get_return_type() == history.FLOAT:
+ result = 'res'
+ elif self.get_return_type() == history.VOID:
result = 'None'
else:
- result = 'history.BoxInt(rffi.cast(lltype.Signed, res))'
+ assert 0
source = py.code.Source("""
- def call_stub(args):
- fnptr = rffi.cast(lltype.Ptr(FUNC), args[0].getint())
+ def call_stub(func, args_i, args_r, args_f):
+ fnptr = rffi.cast(lltype.Ptr(FUNC), func)
res = support.maybe_on_top_of_llinterp(rtyper, fnptr)(%(args)s)
return %(result)s
""" % locals())
@@ -255,35 +249,64 @@
exec source.compile() in d
self.call_stub = d['call_stub']
+ def verify_types(self, args_i, args_r, args_f, return_type):
+ assert self._return_type == return_type
+ assert self.arg_classes.count('i') == len(args_i or ())
+ assert self.arg_classes.count('r') == len(args_r or ())
+ assert self.arg_classes.count('f') == len(args_f or ())
+
def repr_of_descr(self):
return '<%s>' % self._clsname
-class NonGcPtrCallDescr(BaseCallDescr):
+class BaseIntCallDescr(BaseCallDescr):
+ # Base class of the various subclasses of descrs corresponding to
+ # calls having a return kind of 'int' (including non-gc pointers).
+ # The inheritance hierarchy is a bit different than with other Descr
+ # classes because of the 'call_stub' attribute, which is of type
+ #
+ # lambda func, args_i, args_r, args_f --> int/ref/float/void
+ #
+ # The purpose of BaseIntCallDescr is to be the parent of all classes
+ # in which 'call_stub' has a return kind of 'int'.
+ _return_type = history.INT
+ call_stub = staticmethod(lambda func, args_i, args_r, args_f: 0)
+
+class NonGcPtrCallDescr(BaseIntCallDescr):
_clsname = 'NonGcPtrCallDescr'
-
def get_result_size(self, translate_support_code):
return symbolic.get_size_of_ptr(translate_support_code)
-class GcPtrCallDescr(NonGcPtrCallDescr):
- empty_box = BoxPtr(lltype.nullptr(llmemory.GCREF.TO))
+class GcPtrCallDescr(BaseCallDescr):
_clsname = 'GcPtrCallDescr'
- _returns_a_pointer = True
+ _return_type = history.REF
+ call_stub = staticmethod(lambda func, args_i, args_r, args_f:
+ lltype.nullptr(llmemory.GCREF.TO))
+ def get_result_size(self, translate_support_code):
+ return symbolic.get_size_of_ptr(translate_support_code)
+
+class FloatCallDescr(BaseCallDescr):
+ _clsname = 'FloatCallDescr'
+ _return_type = history.FLOAT
+ call_stub = staticmethod(lambda func, args_i, args_r, args_f: 0.0)
+ def get_result_size(self, translate_support_code):
+ return symbolic.get_size(lltype.Float, translate_support_code)
-class VoidCallDescr(NonGcPtrCallDescr):
- empty_box = None
+class VoidCallDescr(BaseCallDescr):
_clsname = 'VoidCallDescr'
- _returns_a_void = True
-
+ _return_type = history.VOID
+ call_stub = staticmethod(lambda func, args_i, args_r, args_f: None)
def get_result_size(self, translate_support_code):
return 0
def getCallDescrClass(RESULT):
if RESULT is lltype.Void:
return VoidCallDescr
- return getDescrClass(RESULT, BaseCallDescr, GcPtrCallDescr,
+ if RESULT is lltype.Float:
+ return FloatCallDescr
+ return getDescrClass(RESULT, BaseIntCallDescr, GcPtrCallDescr,
NonGcPtrCallDescr, 'Call', 'get_result_size',
- '_returns_a_float')
+ Ellipsis) # <= floatattrname should not be used here
def get_call_descr(gccache, ARGS, RESULT, extrainfo=None):
arg_classes = []
@@ -330,7 +353,6 @@
#
if TYPE is lltype.Float:
setattr(Descr, floatattrname, True)
- Descr.empty_box = BoxFloat(0.0)
#
_cache[nameprefix, TYPE] = Descr
return Descr
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/gc.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/gc.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/gc.py Tue Jun 8 19:48:40 2010
@@ -170,7 +170,7 @@
# first look in the hashtable, using an inexact hash (fails after
# the object moves)
addr = llmemory.cast_ptr_to_adr(gcref)
- hash = llmemory.cast_adr_to_int(addr)
+ hash = llmemory.cast_adr_to_int(addr, "forced")
hash -= hash >> self.HASHTABLE_BITS
hash &= self.HASHTABLE_SIZE - 1
addr_ref = self.hashtable[hash]
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/llmodel.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/llmodel.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/llmodel.py Tue Jun 8 19:48:40 2010
@@ -6,16 +6,19 @@
from pypy.rlib.objectmodel import we_are_translated, specialize
from pypy.jit.metainterp.history import BoxInt, BoxPtr, set_future_values,\
BoxFloat
+from pypy.jit.metainterp import history
+from pypy.jit.codewriter import heaptracker
from pypy.jit.backend.model import AbstractCPU
from pypy.jit.backend.llsupport import symbolic
from pypy.jit.backend.llsupport.symbolic import WORD, unroll_basic_sizes
from pypy.jit.backend.llsupport.descr import get_size_descr, BaseSizeDescr
from pypy.jit.backend.llsupport.descr import get_field_descr, BaseFieldDescr
from pypy.jit.backend.llsupport.descr import get_array_descr, BaseArrayDescr
-from pypy.jit.backend.llsupport.descr import get_call_descr, BaseCallDescr
+from pypy.jit.backend.llsupport.descr import get_call_descr
+from pypy.jit.backend.llsupport.descr import BaseIntCallDescr, GcPtrCallDescr
+from pypy.jit.backend.llsupport.descr import FloatCallDescr, VoidCallDescr
from pypy.rpython.annlowlevel import cast_instance_to_base_ptr
-empty_int_box = BoxInt(0)
class AbstractLLCPU(AbstractCPU):
from pypy.jit.metainterp.typesystem import llhelper as ts
@@ -47,7 +50,7 @@
self._setup_exception_handling_translated()
else:
self._setup_exception_handling_untranslated()
- self.clear_exception()
+ self.saved_exc_value = lltype.nullptr(llmemory.GCREF.TO)
self.setup()
if translate_support_code:
self._setup_on_leave_jitted_translated()
@@ -57,9 +60,6 @@
def setup(self):
pass
- def set_class_sizes(self, class_sizes):
- self.class_sizes = class_sizes
-
def _setup_prebuilt_error(self, prefix, Class):
if self.rtyper is not None: # normal case
bk = self.rtyper.annotator.bookkeeper
@@ -104,12 +104,10 @@
def save_exception():
# copy from _exception_emulator to the real attributes on self
- tp_i = _exception_emulator[0]
- v_i = _exception_emulator[1]
+ v_i = _exception_emulator[1]
_exception_emulator[0] = 0
_exception_emulator[1] = 0
- self.saved_exception = tp_i
- self.saved_exc_value = self._cast_int_to_gcref(v_i)
+ self.saved_exc_value = rffi.cast(llmemory.GCREF, v_i)
self.pos_exception = pos_exception
self.pos_exc_value = pos_exc_value
@@ -120,15 +118,14 @@
def pos_exception():
addr = llop.get_exception_addr(llmemory.Address)
- return llmemory.cast_adr_to_int(addr)
+ return heaptracker.adr2int(addr)
def pos_exc_value():
addr = llop.get_exc_value_addr(llmemory.Address)
- return llmemory.cast_adr_to_int(addr)
+ return heaptracker.adr2int(addr)
def save_exception():
addr = llop.get_exception_addr(llmemory.Address)
- exception = rffi.cast(lltype.Signed, addr.address[0])
addr.address[0] = llmemory.NULL
addr = llop.get_exc_value_addr(llmemory.Address)
exc_value = rffi.cast(llmemory.GCREF, addr.address[0])
@@ -136,7 +133,6 @@
# from now on, the state is again consistent -- no more RPython
# exception is set. The following code produces a write barrier
# in the assignment to self.saved_exc_value, as needed.
- self.saved_exception = exception
self.saved_exc_value = exc_value
self.pos_exception = pos_exception
@@ -174,16 +170,10 @@
f = llhelper(self._ON_JIT_LEAVE_FUNC, self.on_leave_jitted_noexc)
return rffi.cast(lltype.Signed, f)
- def get_exception(self):
- return self.saved_exception
-
- def get_exc_value(self):
- return self.saved_exc_value
-
- def clear_exception(self):
- self.saved_exception = 0
+ def grab_exc_value(self):
+ exc = self.saved_exc_value
self.saved_exc_value = lltype.nullptr(llmemory.GCREF.TO)
-
+ return exc
# ------------------- helpers and descriptions --------------------
@@ -213,24 +203,30 @@
def unpack_fielddescr(self, fielddescr):
assert isinstance(fielddescr, BaseFieldDescr)
+ return fielddescr.offset
+ unpack_fielddescr._always_inline_ = True
+
+ def unpack_fielddescr_size(self, fielddescr):
+ assert isinstance(fielddescr, BaseFieldDescr)
ofs = fielddescr.offset
size = fielddescr.get_field_size(self.translate_support_code)
- ptr = fielddescr.is_pointer_field()
- float = fielddescr.is_float_field()
- return ofs, size, ptr, float
- unpack_fielddescr._always_inline_ = True
+ return ofs, size
+ unpack_fielddescr_size._always_inline_ = True
def arraydescrof(self, A):
return get_array_descr(self.gc_ll_descr, A)
def unpack_arraydescr(self, arraydescr):
assert isinstance(arraydescr, BaseArrayDescr)
+ return arraydescr.get_base_size(self.translate_support_code)
+ unpack_arraydescr._always_inline_ = True
+
+ def unpack_arraydescr_size(self, arraydescr):
+ assert isinstance(arraydescr, BaseArrayDescr)
ofs = arraydescr.get_base_size(self.translate_support_code)
size = arraydescr.get_item_size(self.translate_support_code)
- ptr = arraydescr.is_array_of_pointers()
- float = arraydescr.is_array_of_floats()
- return ofs, size, ptr, float
- unpack_arraydescr._always_inline_ = True
+ return ofs, size
+ unpack_arraydescr_size._always_inline_ = True
def calldescrof(self, FUNC, ARGS, RESULT, extrainfo=None):
return get_call_descr(self.gc_ll_descr, ARGS, RESULT, extrainfo)
@@ -249,254 +245,222 @@
# ____________________________________________________________
- def do_arraylen_gc(self, arraybox, arraydescr):
+ def bh_arraylen_gc(self, arraydescr, array):
assert isinstance(arraydescr, BaseArrayDescr)
ofs = arraydescr.get_ofs_length(self.translate_support_code)
- gcref = arraybox.getref_base()
- length = rffi.cast(rffi.CArrayPtr(lltype.Signed), gcref)[ofs/WORD]
- return BoxInt(length)
-
- def do_getarrayitem_gc(self, arraybox, indexbox, arraydescr):
- itemindex = indexbox.getint()
- gcref = arraybox.getref_base()
- ofs, size, ptr, float = self.unpack_arraydescr(arraydescr)
+ return rffi.cast(rffi.CArrayPtr(lltype.Signed), array)[ofs/WORD]
+
+ def bh_getarrayitem_gc_i(self, arraydescr, gcref, itemindex):
+ ofs, size = self.unpack_arraydescr_size(arraydescr)
# --- start of GC unsafe code (no GC operation!) ---
items = rffi.ptradd(rffi.cast(rffi.CCHARP, gcref), ofs)
- #
- if ptr:
- items = rffi.cast(rffi.CArrayPtr(lltype.Signed), items)
- pval = self._cast_int_to_gcref(items[itemindex])
- # --- end of GC unsafe code ---
- return BoxPtr(pval)
- #
- if float:
- items = rffi.cast(rffi.CArrayPtr(lltype.Float), items)
- fval = items[itemindex]
- # --- end of GC unsafe code ---
- return BoxFloat(fval)
- #
for TYPE, itemsize in unroll_basic_sizes:
if size == itemsize:
items = rffi.cast(rffi.CArrayPtr(TYPE), items)
val = items[itemindex]
# --- end of GC unsafe code ---
- return BoxInt(rffi.cast(lltype.Signed, val))
+ return rffi.cast(lltype.Signed, val)
else:
raise NotImplementedError("size = %d" % size)
- def do_setarrayitem_gc(self, arraybox, indexbox, vbox, arraydescr):
- itemindex = indexbox.getint()
- gcref = arraybox.getref_base()
- ofs, size, ptr, float = self.unpack_arraydescr(arraydescr)
- #
- if ptr:
- vboxptr = vbox.getref_base()
- self.gc_ll_descr.do_write_barrier(gcref, vboxptr)
- # --- start of GC unsafe code (no GC operation!) ---
- items = rffi.ptradd(rffi.cast(rffi.CCHARP, gcref), ofs)
- items = rffi.cast(rffi.CArrayPtr(lltype.Signed), items)
- items[itemindex] = self.cast_gcref_to_int(vboxptr)
- # --- end of GC unsafe code ---
- return
- #
- if float:
- fval = vbox.getfloat()
- # --- start of GC unsafe code (no GC operation!) ---
- items = rffi.ptradd(rffi.cast(rffi.CCHARP, gcref), ofs)
- items = rffi.cast(rffi.CArrayPtr(lltype.Float), items)
- items[itemindex] = fval
- # --- end of GC unsafe code ---
- return
- #
- val = vbox.getint()
+ def bh_getarrayitem_gc_r(self, arraydescr, gcref, itemindex):
+ ofs = self.unpack_arraydescr(arraydescr)
+ # --- start of GC unsafe code (no GC operation!) ---
+ items = rffi.ptradd(rffi.cast(rffi.CCHARP, gcref), ofs)
+ items = rffi.cast(rffi.CArrayPtr(lltype.Signed), items)
+ pval = self._cast_int_to_gcref(items[itemindex])
+ # --- end of GC unsafe code ---
+ return pval
+
+ def bh_getarrayitem_gc_f(self, arraydescr, gcref, itemindex):
+ ofs = self.unpack_arraydescr(arraydescr)
+ # --- start of GC unsafe code (no GC operation!) ---
+ items = rffi.ptradd(rffi.cast(rffi.CCHARP, gcref), ofs)
+ items = rffi.cast(rffi.CArrayPtr(lltype.Float), items)
+ fval = items[itemindex]
+ # --- end of GC unsafe code ---
+ return fval
+
+ def bh_setarrayitem_gc_i(self, arraydescr, gcref, itemindex, newvalue):
+ ofs, size = self.unpack_arraydescr_size(arraydescr)
+ # --- start of GC unsafe code (no GC operation!) ---
+ items = rffi.ptradd(rffi.cast(rffi.CCHARP, gcref), ofs)
for TYPE, itemsize in unroll_basic_sizes:
if size == itemsize:
- # --- start of GC unsafe code (no GC operation!) ---
- items = rffi.ptradd(rffi.cast(rffi.CCHARP, gcref), ofs)
items = rffi.cast(rffi.CArrayPtr(TYPE), items)
- items[itemindex] = rffi.cast(TYPE, val)
+ items[itemindex] = rffi.cast(TYPE, newvalue)
# --- end of GC unsafe code ---
return
else:
raise NotImplementedError("size = %d" % size)
- def _new_do_len(TP):
- def do_strlen(self, stringbox):
- basesize, itemsize, ofs_length = symbolic.get_array_token(TP,
- self.translate_support_code)
- gcref = stringbox.getref_base()
- v = rffi.cast(rffi.CArrayPtr(lltype.Signed), gcref)[ofs_length/WORD]
- return BoxInt(v)
- return do_strlen
-
- do_strlen = _new_do_len(rstr.STR)
- do_unicodelen = _new_do_len(rstr.UNICODE)
-
- def do_strgetitem(self, stringbox, indexbox):
- basesize, itemsize, ofs_length = symbolic.get_array_token(rstr.STR,
- self.translate_support_code)
- gcref = stringbox.getref_base()
- i = indexbox.getint()
- v = rffi.cast(rffi.CArrayPtr(lltype.Char), gcref)[basesize + i]
- return BoxInt(ord(v))
-
- def do_unicodegetitem(self, stringbox, indexbox):
- basesize, itemsize, ofs_length = symbolic.get_array_token(rstr.UNICODE,
- self.translate_support_code)
- gcref = stringbox.getref_base()
- i = indexbox.getint()
- basesize = basesize // itemsize
- v = rffi.cast(rffi.CArrayPtr(lltype.UniChar), gcref)[basesize + i]
- return BoxInt(ord(v))
+ def bh_setarrayitem_gc_r(self, arraydescr, gcref, itemindex, newvalue):
+ ofs = self.unpack_arraydescr(arraydescr)
+ self.gc_ll_descr.do_write_barrier(gcref, newvalue)
+ # --- start of GC unsafe code (no GC operation!) ---
+ items = rffi.ptradd(rffi.cast(rffi.CCHARP, gcref), ofs)
+ items = rffi.cast(rffi.CArrayPtr(lltype.Signed), items)
+ items[itemindex] = self.cast_gcref_to_int(newvalue)
+ # --- end of GC unsafe code ---
+
+ def bh_setarrayitem_gc_f(self, arraydescr, gcref, itemindex, newvalue):
+ ofs = self.unpack_arraydescr(arraydescr)
+ # --- start of GC unsafe code (no GC operation!) ---
+ items = rffi.ptradd(rffi.cast(rffi.CCHARP, gcref), ofs)
+ items = rffi.cast(rffi.CArrayPtr(lltype.Float), items)
+ items[itemindex] = newvalue
+ # --- end of GC unsafe code ---
+
+ def bh_strlen(self, string):
+ s = lltype.cast_opaque_ptr(lltype.Ptr(rstr.STR), string)
+ return len(s.chars)
+
+ def bh_unicodelen(self, string):
+ u = lltype.cast_opaque_ptr(lltype.Ptr(rstr.UNICODE), string)
+ return len(u.chars)
+
+ def bh_strgetitem(self, string, index):
+ s = lltype.cast_opaque_ptr(lltype.Ptr(rstr.STR), string)
+ return ord(s.chars[index])
+
+ def bh_unicodegetitem(self, string, index):
+ u = lltype.cast_opaque_ptr(lltype.Ptr(rstr.UNICODE), string)
+ return ord(u.chars[index])
@specialize.argtype(1)
- def _base_do_getfield(self, gcref, fielddescr):
- ofs, size, ptr, float = self.unpack_fielddescr(fielddescr)
+ def _base_do_getfield_i(self, struct, fielddescr):
+ ofs, size = self.unpack_fielddescr_size(fielddescr)
# --- start of GC unsafe code (no GC operation!) ---
- field = rffi.ptradd(rffi.cast(rffi.CCHARP, gcref), ofs)
- #
- if ptr:
- pval = rffi.cast(rffi.CArrayPtr(lltype.Signed), field)[0]
- pval = self._cast_int_to_gcref(pval)
- # --- end of GC unsafe code ---
- return BoxPtr(pval)
- #
- if float:
- fval = rffi.cast(rffi.CArrayPtr(lltype.Float), field)[0]
- # --- end of GC unsafe code ---
- return BoxFloat(fval)
- #
+ fieldptr = rffi.ptradd(rffi.cast(rffi.CCHARP, struct), ofs)
for TYPE, itemsize in unroll_basic_sizes:
if size == itemsize:
- val = rffi.cast(rffi.CArrayPtr(TYPE), field)[0]
+ val = rffi.cast(rffi.CArrayPtr(TYPE), fieldptr)[0]
# --- end of GC unsafe code ---
- val = rffi.cast(lltype.Signed, val)
- return BoxInt(val)
+ return rffi.cast(lltype.Signed, val)
else:
raise NotImplementedError("size = %d" % size)
- def do_getfield_gc(self, structbox, fielddescr):
- gcref = structbox.getref_base()
- return self._base_do_getfield(gcref, fielddescr)
+ @specialize.argtype(1)
+ def _base_do_getfield_r(self, struct, fielddescr):
+ ofs = self.unpack_fielddescr(fielddescr)
+ # --- start of GC unsafe code (no GC operation!) ---
+ fieldptr = rffi.ptradd(rffi.cast(rffi.CCHARP, struct), ofs)
+ pval = rffi.cast(rffi.CArrayPtr(lltype.Signed), fieldptr)[0]
+ pval = self._cast_int_to_gcref(pval)
+ # --- end of GC unsafe code ---
+ return pval
- def do_getfield_raw(self, structbox, fielddescr):
- return self._base_do_getfield(structbox.getint(), fielddescr)
+ @specialize.argtype(1)
+ def _base_do_getfield_f(self, struct, fielddescr):
+ ofs = self.unpack_fielddescr(fielddescr)
+ # --- start of GC unsafe code (no GC operation!) ---
+ fieldptr = rffi.ptradd(rffi.cast(rffi.CCHARP, struct), ofs)
+ fval = rffi.cast(rffi.CArrayPtr(lltype.Float), fieldptr)[0]
+ # --- end of GC unsafe code ---
+ return fval
+
+ bh_getfield_gc_i = _base_do_getfield_i
+ bh_getfield_gc_r = _base_do_getfield_r
+ bh_getfield_gc_f = _base_do_getfield_f
+ bh_getfield_raw_i = _base_do_getfield_i
+ bh_getfield_raw_r = _base_do_getfield_r
+ bh_getfield_raw_f = _base_do_getfield_f
@specialize.argtype(1)
- def _base_do_setfield(self, gcref, vbox, fielddescr):
- ofs, size, ptr, float = self.unpack_fielddescr(fielddescr)
- #
- if ptr:
- assert lltype.typeOf(gcref) is not lltype.Signed, (
- "can't handle write barriers for setfield_raw")
- ptr = vbox.getref_base()
- self.gc_ll_descr.do_write_barrier(gcref, ptr)
- # --- start of GC unsafe code (no GC operation!) ---
- field = rffi.ptradd(rffi.cast(rffi.CCHARP, gcref), ofs)
- field = rffi.cast(rffi.CArrayPtr(lltype.Signed), field)
- field[0] = self.cast_gcref_to_int(ptr)
- # --- end of GC unsafe code ---
- return
- #
- if float:
- fval = vbox.getfloat()
- # --- start of GC unsafe code (no GC operation!) ---
- field = rffi.ptradd(rffi.cast(rffi.CCHARP, gcref), ofs)
- field = rffi.cast(rffi.CArrayPtr(lltype.Float), field)
- field[0] = fval
- # --- end of GC unsafe code ---
- return
- #
- val = vbox.getint()
+ def _base_do_setfield_i(self, struct, fielddescr, newvalue):
+ ofs, size = self.unpack_fielddescr_size(fielddescr)
+ # --- start of GC unsafe code (no GC operation!) ---
+ fieldptr = rffi.ptradd(rffi.cast(rffi.CCHARP, struct), ofs)
for TYPE, itemsize in unroll_basic_sizes:
if size == itemsize:
- # --- start of GC unsafe code (no GC operation!) ---
- field = rffi.ptradd(rffi.cast(rffi.CCHARP, gcref), ofs)
- field = rffi.cast(rffi.CArrayPtr(TYPE), field)
- field[0] = rffi.cast(TYPE, val)
+ fieldptr = rffi.cast(rffi.CArrayPtr(TYPE), fieldptr)
+ fieldptr[0] = rffi.cast(TYPE, newvalue)
# --- end of GC unsafe code ---
return
else:
raise NotImplementedError("size = %d" % size)
- def do_setfield_gc(self, structbox, vbox, fielddescr):
- gcref = structbox.getref_base()
- self._base_do_setfield(gcref, vbox, fielddescr)
+ @specialize.argtype(1)
+ def _base_do_setfield_r(self, struct, fielddescr, newvalue):
+ ofs = self.unpack_fielddescr(fielddescr)
+ assert lltype.typeOf(struct) is not lltype.Signed, (
+ "can't handle write barriers for setfield_raw")
+ self.gc_ll_descr.do_write_barrier(struct, newvalue)
+ # --- start of GC unsafe code (no GC operation!) ---
+ fieldptr = rffi.ptradd(rffi.cast(rffi.CCHARP, struct), ofs)
+ fieldptr = rffi.cast(rffi.CArrayPtr(lltype.Signed), fieldptr)
+ fieldptr[0] = self.cast_gcref_to_int(newvalue)
+ # --- end of GC unsafe code ---
- def do_setfield_raw(self, structbox, vbox, fielddescr):
- self._base_do_setfield(structbox.getint(), vbox, fielddescr)
+ @specialize.argtype(1)
+ def _base_do_setfield_f(self, struct, fielddescr, newvalue):
+ ofs = self.unpack_fielddescr(fielddescr)
+ # --- start of GC unsafe code (no GC operation!) ---
+ fieldptr = rffi.ptradd(rffi.cast(rffi.CCHARP, struct), ofs)
+ fieldptr = rffi.cast(rffi.CArrayPtr(lltype.Float), fieldptr)
+ fieldptr[0] = newvalue
+ # --- end of GC unsafe code ---
+
+ bh_setfield_gc_i = _base_do_setfield_i
+ bh_setfield_gc_r = _base_do_setfield_r
+ bh_setfield_gc_f = _base_do_setfield_f
+ bh_setfield_raw_i = _base_do_setfield_i
+ bh_setfield_raw_r = _base_do_setfield_r
+ bh_setfield_raw_f = _base_do_setfield_f
- def do_new(self, sizedescr):
- res = self.gc_ll_descr.gc_malloc(sizedescr)
- return BoxPtr(res)
+ def bh_new(self, sizedescr):
+ return self.gc_ll_descr.gc_malloc(sizedescr)
- def do_new_with_vtable(self, classbox):
- classint = classbox.getint()
- descrsize = self.class_sizes[classint]
- res = self.gc_ll_descr.gc_malloc(descrsize)
+ def bh_new_with_vtable(self, sizedescr, vtable):
+ res = self.gc_ll_descr.gc_malloc(sizedescr)
if self.vtable_offset is not None:
as_array = rffi.cast(rffi.CArrayPtr(lltype.Signed), res)
- as_array[self.vtable_offset/WORD] = classint
- return BoxPtr(res)
+ as_array[self.vtable_offset/WORD] = vtable
+ return res
- def do_new_array(self, countbox, arraydescr):
- num_elem = countbox.getint()
- res = self.gc_ll_descr.gc_malloc_array(arraydescr, num_elem)
- return BoxPtr(res)
-
- def do_newstr(self, countbox):
- num_elem = countbox.getint()
- res = self.gc_ll_descr.gc_malloc_str(num_elem)
- return BoxPtr(res)
-
- def do_newunicode(self, countbox):
- num_elem = countbox.getint()
- res = self.gc_ll_descr.gc_malloc_unicode(num_elem)
- return BoxPtr(res)
-
- def do_strsetitem(self, stringbox, indexbox, vbox):
- basesize, itemsize, ofs_length = symbolic.get_array_token(rstr.STR,
- self.translate_support_code)
- index = indexbox.getint()
- v = vbox.getint()
- a = stringbox.getref_base()
- rffi.cast(rffi.CArrayPtr(lltype.Char), a)[index + basesize] = chr(v)
-
- def do_unicodesetitem(self, stringbox, indexbox, vbox):
- basesize, itemsize, ofs_length = symbolic.get_array_token(rstr.UNICODE,
- self.translate_support_code)
- index = indexbox.getint()
- v = vbox.getint()
- a = stringbox.getref_base()
- basesize = basesize // itemsize
- rffi.cast(rffi.CArrayPtr(lltype.UniChar), a)[index + basesize] = unichr(v)
-
- def do_call(self, args, calldescr):
- assert isinstance(calldescr, BaseCallDescr)
- assert len(args) == 1 + len(calldescr.arg_classes)
+ def bh_classof(self, struct):
+ struct = lltype.cast_opaque_ptr(rclass.OBJECTPTR, struct)
+ result = struct.typeptr
+ result_adr = llmemory.cast_ptr_to_adr(struct.typeptr)
+ return heaptracker.adr2int(result_adr)
+
+ def bh_new_array(self, arraydescr, length):
+ return self.gc_ll_descr.gc_malloc_array(arraydescr, length)
+
+ def bh_newstr(self, length):
+ return self.gc_ll_descr.gc_malloc_str(length)
+
+ def bh_newunicode(self, length):
+ return self.gc_ll_descr.gc_malloc_unicode(length)
+
+ def bh_strsetitem(self, string, index, newvalue):
+ s = lltype.cast_opaque_ptr(lltype.Ptr(rstr.STR), string)
+ s.chars[index] = chr(newvalue)
+
+ def bh_unicodesetitem(self, string, index, newvalue):
+ u = lltype.cast_opaque_ptr(lltype.Ptr(rstr.UNICODE), string)
+ u.chars[index] = unichr(newvalue)
+
+ def bh_call_i(self, func, calldescr, args_i, args_r, args_f):
+ assert isinstance(calldescr, BaseIntCallDescr)
if not we_are_translated():
- assert (list(calldescr.arg_classes) ==
- [arg.type for arg in args[1:]])
- callstub = calldescr.get_call_stub()
- try:
- return callstub(args)
- except Exception, e:
- if not we_are_translated():
- if not type(e) is LLException:
- raise
- self.saved_exc_value = lltype.cast_opaque_ptr(llmemory.GCREF,
- e.args[1])
- self.saved_exception = rffi.cast(lltype.Signed, e.args[0])
- else:
- ptr = cast_instance_to_base_ptr(e)
- self.saved_exc_value = lltype.cast_opaque_ptr(llmemory.GCREF,
- ptr)
- self.saved_exception = rffi.cast(lltype.Signed, ptr.typeptr)
- return calldescr.empty_box
-
- def do_cast_ptr_to_int(self, ptrbox):
- return BoxInt(self.cast_gcref_to_int(ptrbox.getref_base()))
+ calldescr.verify_types(args_i, args_r, args_f, history.INT)
+ return calldescr.call_stub(func, args_i, args_r, args_f)
+ def bh_call_r(self, func, calldescr, args_i, args_r, args_f):
+ assert isinstance(calldescr, GcPtrCallDescr)
+ if not we_are_translated():
+ calldescr.verify_types(args_i, args_r, args_f, history.REF)
+ return calldescr.call_stub(func, args_i, args_r, args_f)
-import pypy.jit.metainterp.executor
-pypy.jit.metainterp.executor.make_execute_list(AbstractLLCPU)
+ def bh_call_f(self, func, calldescr, args_i, args_r, args_f):
+ assert isinstance(calldescr, FloatCallDescr)
+ if not we_are_translated():
+ calldescr.verify_types(args_i, args_r, args_f, history.FLOAT)
+ return calldescr.call_stub(func, args_i, args_r, args_f)
+
+ def bh_call_v(self, func, calldescr, args_i, args_r, args_f):
+ assert isinstance(calldescr, VoidCallDescr)
+ if not we_are_translated():
+ calldescr.verify_types(args_i, args_r, args_f, history.VOID)
+ return calldescr.call_stub(func, args_i, args_r, args_f)
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/test/test_descr.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/test/test_descr.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/test/test_descr.py Tue Jun 8 19:48:40 2010
@@ -4,6 +4,7 @@
from pypy.rlib.objectmodel import Symbolic
from pypy.rpython.annlowlevel import llhelper
from pypy.jit.metainterp.history import BoxInt, BoxFloat, BoxPtr
+from pypy.jit.metainterp import history
def test_get_size_descr():
c0 = GcCache(False)
@@ -145,33 +146,29 @@
c0 = GcCache(False)
descr1 = get_call_descr(c0, [lltype.Char, lltype.Signed], lltype.Char)
assert descr1.get_result_size(False) == rffi.sizeof(lltype.Char)
- assert not descr1.returns_a_pointer()
- assert not descr1.returns_a_float()
+ assert descr1.get_return_type() == history.INT
assert descr1.arg_classes == "ii"
- assert isinstance(descr1.empty_box, BoxInt)
#
T = lltype.GcStruct('T')
descr2 = get_call_descr(c0, [lltype.Ptr(T)], lltype.Ptr(T))
assert descr2.get_result_size(False) == rffi.sizeof(lltype.Ptr(T))
- assert descr2.returns_a_pointer()
- assert not descr2.returns_a_float()
+ assert descr2.get_return_type() == history.REF
assert descr2.arg_classes == "r"
- assert isinstance(descr2.empty_box, BoxPtr)
#
U = lltype.GcStruct('U', ('x', lltype.Signed))
assert descr2 == get_call_descr(c0, [lltype.Ptr(U)], lltype.Ptr(U))
#
V = lltype.Struct('V', ('x', lltype.Signed))
- assert isinstance(get_call_descr(c0, [], lltype.Ptr(V)).empty_box, BoxInt)
+ assert (get_call_descr(c0, [], lltype.Ptr(V)).get_return_type() ==
+ history.INT)
#
- assert get_call_descr(c0, [], lltype.Void).empty_box is None
+ assert (get_call_descr(c0, [], lltype.Void).get_return_type() ==
+ history.VOID)
#
descr4 = get_call_descr(c0, [lltype.Float, lltype.Float], lltype.Float)
assert descr4.get_result_size(False) == rffi.sizeof(lltype.Float)
- assert not descr4.returns_a_pointer()
- assert descr4.returns_a_float()
+ assert descr4.get_return_type() == history.FLOAT
assert descr4.arg_classes == "ff"
- assert isinstance(descr4.empty_box, BoxFloat)
def test_get_call_descr_translated():
c1 = GcCache(True)
@@ -179,14 +176,12 @@
U = lltype.GcStruct('U', ('x', lltype.Signed))
descr3 = get_call_descr(c1, [lltype.Ptr(T)], lltype.Ptr(U))
assert isinstance(descr3.get_result_size(True), Symbolic)
- assert descr3.returns_a_pointer()
- assert not descr3.returns_a_float()
+ assert descr3.get_return_type() == history.REF
assert descr3.arg_classes == "r"
#
descr4 = get_call_descr(c1, [lltype.Float, lltype.Float], lltype.Float)
assert isinstance(descr4.get_result_size(True), Symbolic)
- assert not descr4.returns_a_pointer()
- assert descr4.returns_a_float()
+ assert descr4.get_return_type() == history.FLOAT
assert descr4.arg_classes == "ff"
def test_call_descr_extra_info():
@@ -245,12 +240,11 @@
def f(a, b):
return 'c'
- call_stub = descr1.get_call_stub()
+ call_stub = descr1.call_stub
fnptr = llhelper(lltype.Ptr(lltype.FuncType(ARGS, RES)), f)
- res = call_stub([BoxInt(rffi.cast(lltype.Signed, fnptr)),
- BoxInt(1), BoxInt(2)])
- assert res.getint() == ord('c')
+ res = call_stub(rffi.cast(lltype.Signed, fnptr), [1, 2], None, None)
+ assert res == ord('c')
ARRAY = lltype.GcArray(lltype.Signed)
ARGS = [lltype.Float, lltype.Ptr(ARRAY)]
@@ -264,6 +258,6 @@
a = lltype.malloc(ARRAY, 3)
opaquea = lltype.cast_opaque_ptr(llmemory.GCREF, a)
a[0] = 1
- res = descr2.get_call_stub()([BoxInt(rffi.cast(lltype.Signed, fnptr)),
- BoxFloat(3.5), BoxPtr(opaquea)])
- assert res.getfloat() == 4.5
+ res = descr2.call_stub(rffi.cast(lltype.Signed, fnptr),
+ [], [opaquea], [3.5])
+ assert res == 4.5
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/test/test_gc.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/test/test_gc.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/llsupport/test/test_gc.py Tue Jun 8 19:48:40 2010
@@ -291,7 +291,7 @@
v_random_box = BoxPtr()
v_result = BoxInt()
operations = [
- ResOperation(rop.OOIS, [v_random_box, ConstPtr(s_gcref)],
+ ResOperation(rop.PTR_EQ, [v_random_box, ConstPtr(s_gcref)],
v_result),
]
gc_ll_descr = self.gc_ll_descr
@@ -303,7 +303,7 @@
assert operations[0].descr == gc_ll_descr.single_gcref_descr
v_box = operations[0].result
assert isinstance(v_box, BoxPtr)
- assert operations[1].opnum == rop.OOIS
+ assert operations[1].opnum == rop.PTR_EQ
assert operations[1].args == [v_random_box, v_box]
assert operations[1].result == v_result
@@ -324,7 +324,7 @@
v_random_box = BoxPtr()
v_result = BoxInt()
operations = [
- ResOperation(rop.OOIS, [v_random_box, ConstPtr(s_gcref)],
+ ResOperation(rop.PTR_EQ, [v_random_box, ConstPtr(s_gcref)],
v_result),
]
gc_ll_descr = self.gc_ll_descr
@@ -336,7 +336,7 @@
finally:
rgc.can_move = old_can_move
assert len(operations) == 1
- assert operations[0].opnum == rop.OOIS
+ assert operations[0].opnum == rop.PTR_EQ
assert operations[0].args == [v_random_box, ConstPtr(s_gcref)]
assert operations[0].result == v_result
# check that s_gcref gets added to the list anyway, to make sure
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/model.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/model.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/model.py Tue Jun 8 19:48:40 2010
@@ -3,6 +3,7 @@
class AbstractCPU(object):
supports_floats = False
+ _got_exception = None
# assembler_helper_ptr - a pointer to helper to call after a direct
# assembler call
portal_calldescr = None
@@ -24,9 +25,6 @@
def get_fail_descr_from_number(self, n):
return self.fail_descr_list[n]
- def set_class_sizes(self, class_sizes):
- self.class_sizes = class_sizes
-
def setup_once(self):
"""Called once by the front-end when the program starts."""
pass
@@ -87,30 +85,27 @@
or from 'args' if it was a FINISH). Returns a ptr or an obj."""
raise NotImplementedError
+ def get_latest_value_count(self):
+ """Return how many values are ready to be returned by
+ get_latest_value_xxx(). Only after a guard failure; not
+ necessarily correct after a FINISH."""
+ raise NotImplementedError
+
def get_latest_force_token(self):
"""After a GUARD_NOT_FORCED fails, this function returns the
same FORCE_TOKEN result as the one in the just-failed loop."""
raise NotImplementedError
- def make_boxes_from_latest_value(self, faildescr):
- """Build a list of Boxes (and None for holes) that contains
- the current values, as would be returned by calls to
- get_latest_value_xxx()."""
- raise NotImplementedError
-
- def get_exception(self):
- raise NotImplementedError
-
- def get_exc_value(self):
- raise NotImplementedError
-
- def clear_exception(self):
- raise NotImplementedError
-
- def get_overflow_error(self):
+ def clear_latest_values(self, count):
+ """Clear the latest values (at least the ref ones), so that
+ they no longer keep objects alive. 'count' is the number of
+ values -- normally get_latest_value_count()."""
raise NotImplementedError
- def get_zero_division_error(self):
+ def grab_exc_value(self):
+ """Return and clear the exception set by the latest execute_token(),
+ when it exits due to a failure of a GUARD_EXCEPTION or
+ GUARD_NO_EXCEPTION. (Returns a GCREF)""" # XXX remove me
raise NotImplementedError
@staticmethod
@@ -118,10 +113,6 @@
raise NotImplementedError
@staticmethod
- def numof(S):
- raise NotImplementedError
-
- @staticmethod
def fielddescrof(S, fieldname):
"""Return the Descr corresponding to field 'fieldname' on the
structure 'S'. It is important that this function (at least)
@@ -157,101 +148,87 @@
# lltype specific operations
# --------------------------
-
- def do_arraylen_gc(self, arraybox, arraydescr):
- raise NotImplementedError
- def do_strlen(self, stringbox):
+ def bh_getarrayitem_gc_i(self, arraydescr, array, index):
raise NotImplementedError
-
- def do_strgetitem(self, stringbox, indexbox):
+ def bh_getarrayitem_gc_r(self, arraydescr, array, index):
raise NotImplementedError
-
- def do_unicodelen(self, stringbox):
+ def bh_getarrayitem_gc_f(self, arraydescr, array, index):
raise NotImplementedError
- def do_unicodegetitem(self, stringbox, indexbox):
+ def bh_getfield_gc_i(self, struct, fielddescr):
raise NotImplementedError
-
- def do_getarrayitem_gc(self, arraybox, indexbox, arraydescr):
+ def bh_getfield_gc_r(self, struct, fielddescr):
+ raise NotImplementedError
+ def bh_getfield_gc_f(self, struct, fielddescr):
raise NotImplementedError
- def do_arraycopy(self, calldescr, fnptr, sourcebox, destbox,
- source_startbox, dest_startbox, lengthbox, arraydescr):
- return self.do_call([fnptr, sourcebox, destbox, source_startbox,
- dest_startbox, lengthbox], calldescr)
-
- def do_getfield_gc(self, structbox, fielddescr):
+ def bh_getfield_raw_i(self, struct, fielddescr):
raise NotImplementedError
-
- def do_getfield_raw(self, structbox, fielddescr):
+ def bh_getfield_raw_r(self, struct, fielddescr):
raise NotImplementedError
-
- def do_new(self, sizedescr):
+ def bh_getfield_raw_f(self, struct, fielddescr):
raise NotImplementedError
- def do_new_with_vtable(self, classbox):
+ def bh_new(self, sizedescr):
+ raise NotImplementedError
+ def bh_new_with_vtable(self, sizedescr, vtable):
raise NotImplementedError
-
- def do_new_array(self, lengthbox, arraydescr):
+ def bh_new_array(self, arraydescr, length):
raise NotImplementedError
-
- def do_setarrayitem_gc(self, arraybox, indexbox, newvaluebox, arraydescr):
+ def bh_newstr(self, length):
+ raise NotImplementedError
+ def bh_newunicode(self, length):
raise NotImplementedError
- def do_setarrayitem_raw(self, arraybox, indexbox, newvaluebox, arraydescr):
+ def bh_arraylen_gc(self, arraydescr, array):
raise NotImplementedError
- def do_setfield_gc(self, structbox, newvaluebox, fielddescr):
+ def bh_classof(self, struct):
raise NotImplementedError
- def do_setfield_raw(self, structbox, newvaluebox, fielddescr):
+ def bh_setarrayitem_gc_i(self, arraydescr, array, index, newvalue):
raise NotImplementedError
-
- def do_newstr(self, lengthbox):
+ def bh_setarrayitem_gc_r(self, arraydescr, array, index, newvalue):
raise NotImplementedError
-
- def do_newunicode(self, lengthbox):
+ def bh_setarrayitem_gc_f(self, arraydescr, array, index, newvalue):
raise NotImplementedError
- def do_strsetitem(self, stringbox, indexbox, charbox):
+ def bh_setfield_gc_i(self, struct, fielddescr, newvalue):
raise NotImplementedError
-
- def do_unicodesetitem(self, stringbox, indexbox, charbox):
+ def bh_setfield_gc_r(self, struct, fielddescr, newvalue):
raise NotImplementedError
-
- def do_call(self, args, calldescr):
+ def bh_setfield_gc_f(self, struct, fielddescr, newvalue):
raise NotImplementedError
- def do_call_assembler(self, args, token):
+ def bh_setfield_raw_i(self, struct, fielddescr, newvalue):
raise NotImplementedError
-
- def do_call_loopinvariant(self, args, calldescr):
- return self.do_call(args, calldescr)
-
- def do_cond_call_gc_wb(self, args, calldescr):
+ def bh_setfield_raw_r(self, struct, fielddescr, newvalue):
raise NotImplementedError
-
- def do_cast_ptr_to_int(self, ptrbox):
+ def bh_setfield_raw_f(self, struct, fielddescr, newvalue):
raise NotImplementedError
- def do_call_may_force(self, args, calldescr):
- return self.do_call(args, calldescr)
-
- def force(self, force_token):
+ def bh_call_i(self, func, calldescr, args_i, args_r, args_f):
raise NotImplementedError
-
- # ootype specific operations
- # --------------------------
-
- def do_runtimenew(self, classbox):
+ def bh_call_r(self, func, calldescr, args_i, args_r, args_f):
raise NotImplementedError
-
- def do_oosend(self, args, descr):
+ def bh_call_f(self, func, calldescr, args_i, args_r, args_f):
+ raise NotImplementedError
+ def bh_call_v(self, func, calldescr, args_i, args_r, args_f):
raise NotImplementedError
- def do_instanceof(self, instancebox, typedescr):
+ def bh_strlen(self, string):
+ raise NotImplementedError
+ def bh_strgetitem(self, string, index):
+ raise NotImplementedError
+ def bh_unicodelen(self, string):
+ raise NotImplementedError
+ def bh_unicodegetitem(self, string, index):
+ raise NotImplementedError
+ def bh_strsetitem(self, string, index, newvalue):
+ raise NotImplementedError
+ def bh_unicodesetitem(self, string, index, newvalue):
raise NotImplementedError
- def typedescr2classbox(self, descr):
+ def force(self, force_token):
raise NotImplementedError
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/test/runner_test.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/test/runner_test.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/test/runner_test.py Tue Jun 8 19:48:40 2010
@@ -13,6 +13,8 @@
from pypy.rpython.ootypesystem import ootype
from pypy.rpython.annlowlevel import llhelper
from pypy.rpython.llinterp import LLException
+from pypy.jit.codewriter import heaptracker
+
class Runner(object):
@@ -236,7 +238,7 @@
res = self.cpu.get_latest_value_int(0)
assert res == 20
- def test_make_boxes_from_latest_values(self):
+ def test_get_latest_value_count(self):
i0 = BoxInt()
i1 = BoxInt()
i2 = BoxInt()
@@ -255,12 +257,12 @@
self.cpu.set_future_value_int(0, 2)
fail = self.cpu.execute_token(looptoken)
assert fail is faildescr1
- boxes = self.cpu.make_boxes_from_latest_values(faildescr1)
- assert len(boxes) == 3
- assert boxes[0] is None
- assert isinstance(boxes[1], BoxInt)
- assert boxes[1].value == 10
- assert boxes[2] is None
+
+ count = self.cpu.get_latest_value_count()
+ assert count == 3
+ assert self.cpu.get_latest_value_int(1) == 10
+ assert self.cpu.get_latest_value_int(1) == 10 # multiple reads ok
+ self.cpu.clear_latest_values(3)
def test_finish(self):
i0 = BoxInt()
@@ -375,8 +377,8 @@
looptoken = LoopToken()
self.cpu.compile_loop([v1, v2], ops, looptoken)
for x, y, z in testcases:
- assert not self.cpu.get_exception()
- assert not self.cpu.get_exc_value()
+ excvalue = self.cpu.grab_exc_value()
+ assert not excvalue
self.cpu.set_future_value_int(0, x)
self.cpu.set_future_value_int(1, y)
fail = self.cpu.execute_token(looptoken)
@@ -386,13 +388,13 @@
assert fail.identifier == 2
if z != boom:
assert self.cpu.get_latest_value_int(0) == z
- assert not self.cpu.get_exception()
- assert not self.cpu.get_exc_value()
+ excvalue = self.cpu.grab_exc_value()
+ assert not excvalue
def test_ovf_operations_reversed(self):
self.test_ovf_operations(reversed=True)
- def test_do_call(self):
+ def test_bh_call(self):
cpu = self.cpu
#
def func(c):
@@ -400,24 +402,21 @@
FPTR = self.Ptr(self.FuncType([lltype.Char], lltype.Char))
func_ptr = llhelper(FPTR, func)
calldescr = cpu.calldescrof(deref(FPTR), (lltype.Char,), lltype.Char)
- x = cpu.do_call(
- [self.get_funcbox(cpu, func_ptr),
- BoxInt(ord('A'))],
- calldescr)
- assert x.value == ord('B')
+ x = cpu.bh_call_i(self.get_funcbox(cpu, func_ptr).value,
+ calldescr, [ord('A')], None, None)
+ assert x == ord('B')
if cpu.supports_floats:
def func(f, i):
- return float(i) + f
+ return f - float(i)
FPTR = self.Ptr(self.FuncType([lltype.Float, lltype.Signed],
lltype.Float))
func_ptr = llhelper(FPTR, func)
FTP = deref(FPTR)
calldescr = cpu.calldescrof(FTP, FTP.ARGS, FTP.RESULT)
- x = cpu.do_call(
- [self.get_funcbox(cpu, func_ptr),
- BoxFloat(3.5), BoxInt(42)],
- calldescr)
- assert x.value == 42 + 3.5
+ x = cpu.bh_call_f(self.get_funcbox(cpu, func_ptr).value,
+ calldescr,
+ [42], None, [3.5])
+ assert x == 3.5 - 42
def test_call(self):
@@ -611,31 +610,31 @@
def test_ooops(self):
u1_box, U_box = self.alloc_instance(self.U)
u2_box, U_box = self.alloc_instance(self.U)
- r = self.execute_operation(rop.OOIS, [u1_box,
- u1_box.clonebox()], 'int')
+ r = self.execute_operation(rop.PTR_EQ, [u1_box,
+ u1_box.clonebox()], 'int')
assert r.value == 1
- r = self.execute_operation(rop.OOISNOT, [u2_box,
- u2_box.clonebox()], 'int')
+ r = self.execute_operation(rop.PTR_NE, [u2_box,
+ u2_box.clonebox()], 'int')
assert r.value == 0
- r = self.execute_operation(rop.OOIS, [u1_box, u2_box], 'int')
+ r = self.execute_operation(rop.PTR_EQ, [u1_box, u2_box], 'int')
assert r.value == 0
- r = self.execute_operation(rop.OOISNOT, [u2_box, u1_box], 'int')
+ r = self.execute_operation(rop.PTR_NE, [u2_box, u1_box], 'int')
assert r.value == 1
#
null_box = self.null_instance()
- r = self.execute_operation(rop.OOIS, [null_box,
- null_box.clonebox()], 'int')
+ r = self.execute_operation(rop.PTR_EQ, [null_box,
+ null_box.clonebox()], 'int')
assert r.value == 1
- r = self.execute_operation(rop.OOIS, [u1_box, null_box], 'int')
+ r = self.execute_operation(rop.PTR_EQ, [u1_box, null_box], 'int')
assert r.value == 0
- r = self.execute_operation(rop.OOIS, [null_box, u2_box], 'int')
+ r = self.execute_operation(rop.PTR_EQ, [null_box, u2_box], 'int')
assert r.value == 0
- r = self.execute_operation(rop.OOISNOT, [null_box,
- null_box.clonebox()], 'int')
+ r = self.execute_operation(rop.PTR_NE, [null_box,
+ null_box.clonebox()], 'int')
assert r.value == 0
- r = self.execute_operation(rop.OOISNOT, [u2_box, null_box], 'int')
+ r = self.execute_operation(rop.PTR_NE, [u2_box, null_box], 'int')
assert r.value == 1
- r = self.execute_operation(rop.OOISNOT, [null_box, u1_box], 'int')
+ r = self.execute_operation(rop.PTR_NE, [null_box, u1_box], 'int')
assert r.value == 1
def test_array_basic(self):
@@ -768,10 +767,10 @@
assert r.value == 153
def test_do_unicode_basic(self):
- u_box = self.cpu.do_newunicode(ConstInt(5))
- self.cpu.do_unicodesetitem(u_box, BoxInt(4), BoxInt(123))
- r = self.cpu.do_unicodegetitem(u_box, BoxInt(4))
- assert r.value == 123
+ u = self.cpu.bh_newunicode(5)
+ self.cpu.bh_unicodesetitem(u, 4, 123)
+ r = self.cpu.bh_unicodegetitem(u, 4)
+ assert r == 123
def test_unicode_basic(self):
u_box = self.alloc_unicode(u"hello\u1234")
@@ -808,17 +807,10 @@
assert r.value == 5.5
def test_virtual_ref(self):
- # if VIRTUAL_REF reaches the backend, it should just be a SAME_AS
- u_box = self.alloc_unicode(u"hello\u1234")
- r = self.execute_operation(rop.VIRTUAL_REF, [u_box, ConstInt(2)],
- 'ref')
- assert r.value == u_box.value
+ pass # VIRTUAL_REF must not reach the backend nowadays
def test_virtual_ref_finish(self):
- # if VIRTUAL_REF_FINISH reaches the backend, it is a no-op
- self.execute_operation(rop.VIRTUAL_REF_FINISH,
- [BoxInt(123), BoxInt(234)],
- 'void')
+ pass # VIRTUAL_REF_FINISH must not reach the backend nowadays
def test_jump(self):
# this test generates small loops where the JUMP passes many
@@ -1082,7 +1074,6 @@
operator.truediv, no_zero_divison
yield nan_and_infinity, rop.FLOAT_NEG, operator.neg, all_cases_unary
yield nan_and_infinity, rop.FLOAT_ABS, abs, all_cases_unary
- yield nan_and_infinity, rop.FLOAT_IS_TRUE, bool, all_cases_unary
yield nan_and_infinity, rop.FLOAT_LT, operator.lt, all_cases_binary
yield nan_and_infinity, rop.FLOAT_LE, operator.le, all_cases_binary
yield nan_and_infinity, rop.FLOAT_EQ, operator.eq, all_cases_binary
@@ -1102,7 +1093,7 @@
@classmethod
def get_funcbox(cls, cpu, func_ptr):
addr = llmemory.cast_ptr_to_adr(func_ptr)
- return BoxInt(cpu.cast_adr_to_int(addr))
+ return ConstInt(heaptracker.adr2int(addr))
MY_VTABLE = rclass.OBJECT_VTABLE # for tests only
@@ -1134,7 +1125,7 @@
elif T == self.U:
t.parent.parent.parent.typeptr = vtable_for_T
t_box = BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, t))
- T_box = ConstInt(self.cpu.cast_adr_to_int(vtable_for_T_addr))
+ T_box = ConstInt(heaptracker.adr2int(vtable_for_T_addr))
return t_box, T_box
def null_instance(self):
@@ -1163,23 +1154,26 @@
def test_casts(self):
+ py.test.skip("xxx fix or kill")
from pypy.rpython.lltypesystem import lltype, llmemory
TP = lltype.GcStruct('x')
x = lltype.malloc(TP)
x = lltype.cast_opaque_ptr(llmemory.GCREF, x)
res = self.execute_operation(rop.CAST_PTR_TO_INT,
[BoxPtr(x)], 'int').value
- assert res == self.cpu.cast_gcref_to_int(x)
+ expected = self.cpu.cast_adr_to_int(llmemory.cast_ptr_to_adr(x))
+ assert rffi.get_real_int(res) == rffi.get_real_int(expected)
res = self.execute_operation(rop.CAST_PTR_TO_INT,
[ConstPtr(x)], 'int').value
- assert res == self.cpu.cast_gcref_to_int(x)
+ expected = self.cpu.cast_adr_to_int(llmemory.cast_ptr_to_adr(x))
+ assert rffi.get_real_int(res) == rffi.get_real_int(expected)
def test_ooops_non_gc(self):
x = lltype.malloc(lltype.Struct('x'), flavor='raw')
- v = self.cpu.cast_adr_to_int(llmemory.cast_ptr_to_adr(x))
- r = self.execute_operation(rop.OOIS, [BoxInt(v), BoxInt(v)], 'int')
+ v = heaptracker.adr2int(llmemory.cast_ptr_to_adr(x))
+ r = self.execute_operation(rop.PTR_EQ, [BoxInt(v), BoxInt(v)], 'int')
assert r.value == 1
- r = self.execute_operation(rop.OOISNOT, [BoxInt(v), BoxInt(v)], 'int')
+ r = self.execute_operation(rop.PTR_NE, [BoxInt(v), BoxInt(v)], 'int')
assert r.value == 0
lltype.free(x, flavor='raw')
@@ -1206,7 +1200,7 @@
S = lltype.Struct('S', ('x', lltype.Signed))
s = lltype.malloc(S, flavor='raw')
sa = llmemory.cast_ptr_to_adr(s)
- s_box = BoxInt(self.cpu.cast_adr_to_int(sa))
+ s_box = BoxInt(heaptracker.adr2int(sa))
for get_op, set_op in ((rop.GETFIELD_RAW, rop.SETFIELD_RAW),
(rop.GETFIELD_RAW_PURE, rop.SETFIELD_RAW)):
fd = self.cpu.fielddescrof(S, 'x')
@@ -1218,7 +1212,9 @@
def test_new_with_vtable(self):
cpu = self.cpu
t_box, T_box = self.alloc_instance(self.T)
- cpu.set_class_sizes({T_box.value: cpu.sizeof(self.T)})
+ vtable = llmemory.cast_adr_to_ptr(
+ llmemory.cast_int_to_adr(T_box.value), heaptracker.VTABLETYPE)
+ heaptracker.register_known_gctype(cpu, vtable, self.T)
r1 = self.execute_operation(rop.NEW_WITH_VTABLE, [T_box], 'ref')
r2 = self.execute_operation(rop.NEW_WITH_VTABLE, [T_box], 'ref')
assert r1.value != r2.value
@@ -1234,11 +1230,11 @@
s = lltype.cast_opaque_ptr(lltype.Ptr(self.T), r1.value)
assert s.parent.chr1 == chr(190)
assert s.parent.chr2 == chr(150)
- r = self.cpu.do_getfield_gc(r1, descrshort)
- assert r.value == 1313
- self.cpu.do_setfield_gc(r1, BoxInt(1333), descrshort)
- r = self.cpu.do_getfield_gc(r1, descrshort)
- assert r.value == 1333
+ r = self.cpu.bh_getfield_gc_i(r1.value, descrshort)
+ assert r == 1313
+ self.cpu.bh_setfield_gc_i(r1.value, descrshort, 1333)
+ r = self.cpu.bh_getfield_gc_i(r1.value, descrshort)
+ assert r == 1333
r = self.execute_operation(rop.GETFIELD_GC, [r1], 'int',
descr=descrshort)
assert r.value == 1333
@@ -1305,11 +1301,13 @@
self.cpu.execute_token(loop.token)
assert self.cpu.get_latest_value_int(0) == 0
assert self.cpu.get_latest_value_ref(1) == xptr
- self.cpu.clear_exception()
+ excvalue = self.cpu.grab_exc_value()
+ assert not excvalue
self.cpu.set_future_value_int(0, 0)
self.cpu.execute_token(loop.token)
assert self.cpu.get_latest_value_int(0) == 1
- self.cpu.clear_exception()
+ excvalue = self.cpu.grab_exc_value()
+ assert not excvalue
ytp = lltype.malloc(rclass.OBJECT_VTABLE, immortal=True)
ytp.subclassrange_min = 2
@@ -1327,7 +1325,9 @@
self.cpu.set_future_value_int(0, 1)
self.cpu.execute_token(loop.token)
assert self.cpu.get_latest_value_int(0) == 1
- self.cpu.clear_exception()
+ excvalue = self.cpu.grab_exc_value()
+ assert excvalue == yptr
+ assert not self.cpu.grab_exc_value() # cleared
exc_tp = xtp
exc_ptr = xptr
@@ -1343,11 +1343,13 @@
self.cpu.set_future_value_int(0, 1)
self.cpu.execute_token(loop.token)
assert self.cpu.get_latest_value_int(0) == 1
- self.cpu.clear_exception()
+ excvalue = self.cpu.grab_exc_value()
+ assert excvalue == xptr
self.cpu.set_future_value_int(0, 0)
self.cpu.execute_token(loop.token)
assert self.cpu.get_latest_value_int(0) == 0
- self.cpu.clear_exception()
+ excvalue = self.cpu.grab_exc_value()
+ assert not excvalue
def test_cond_call_gc_wb(self):
def func_void(a, b):
@@ -1524,108 +1526,92 @@
A = lltype.GcArray(lltype.Char)
descr_A = cpu.arraydescrof(A)
a = lltype.malloc(A, 5)
- x = cpu.do_arraylen_gc(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, a)),
- descr_A)
- assert x.value == 5
+ x = cpu.bh_arraylen_gc(descr_A,
+ lltype.cast_opaque_ptr(llmemory.GCREF, a))
+ assert x == 5
#
a[2] = 'Y'
- x = cpu.do_getarrayitem_gc(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, a)), BoxInt(2),
- descr_A)
- assert x.value == ord('Y')
+ x = cpu.bh_getarrayitem_gc_i(
+ descr_A, lltype.cast_opaque_ptr(llmemory.GCREF, a), 2)
+ assert x == ord('Y')
#
B = lltype.GcArray(lltype.Ptr(A))
descr_B = cpu.arraydescrof(B)
b = lltype.malloc(B, 4)
b[3] = a
- x = cpu.do_getarrayitem_gc(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, b)), BoxInt(3),
- descr_B)
- assert isinstance(x, BoxPtr)
- assert x.getref(lltype.Ptr(A)) == a
+ x = cpu.bh_getarrayitem_gc_r(
+ descr_B, lltype.cast_opaque_ptr(llmemory.GCREF, b), 3)
+ assert lltype.cast_opaque_ptr(lltype.Ptr(A), x) == a
if self.cpu.supports_floats:
C = lltype.GcArray(lltype.Float)
c = lltype.malloc(C, 6)
c[3] = 3.5
descr_C = cpu.arraydescrof(C)
- x = cpu.do_getarrayitem_gc(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, c)), BoxInt(3),
- descr_C)
- assert isinstance(x, BoxFloat)
- assert x.getfloat() == 3.5
- cpu.do_setarrayitem_gc(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, c)), BoxInt(4),
- BoxFloat(4.5), descr_C)
+ x = cpu.bh_getarrayitem_gc_f(
+ descr_C, lltype.cast_opaque_ptr(llmemory.GCREF, c), 3)
+ assert x == 3.5
+ cpu.bh_setarrayitem_gc_f(
+ descr_C, lltype.cast_opaque_ptr(llmemory.GCREF, c), 4, 4.5)
assert c[4] == 4.5
s = rstr.mallocstr(6)
- x = cpu.do_strlen(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, s)))
- assert x.value == 6
+ x = cpu.bh_strlen(lltype.cast_opaque_ptr(llmemory.GCREF, s))
+ assert x == 6
#
s.chars[3] = 'X'
- x = cpu.do_strgetitem(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, s)), BoxInt(3))
- assert x.value == ord('X')
+ x = cpu.bh_strgetitem(lltype.cast_opaque_ptr(llmemory.GCREF, s), 3)
+ assert x == ord('X')
#
S = lltype.GcStruct('S', ('x', lltype.Char), ('y', lltype.Ptr(A)),
('z', lltype.Float))
descrfld_x = cpu.fielddescrof(S, 'x')
s = lltype.malloc(S)
s.x = 'Z'
- x = cpu.do_getfield_gc(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, s)),
- descrfld_x)
- assert x.value == ord('Z')
- #
- cpu.do_setfield_gc(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, s)),
- BoxInt(ord('4')),
- descrfld_x)
+ x = cpu.bh_getfield_gc_i(lltype.cast_opaque_ptr(llmemory.GCREF, s),
+ descrfld_x)
+ assert x == ord('Z')
+ #
+ cpu.bh_setfield_gc_i(lltype.cast_opaque_ptr(llmemory.GCREF, s),
+ descrfld_x,
+ ord('4'))
assert s.x == '4'
#
descrfld_y = cpu.fielddescrof(S, 'y')
s.y = a
- x = cpu.do_getfield_gc(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, s)),
- descrfld_y)
- assert isinstance(x, BoxPtr)
- assert x.getref(lltype.Ptr(A)) == a
+ x = cpu.bh_getfield_gc_r(lltype.cast_opaque_ptr(llmemory.GCREF, s),
+ descrfld_y)
+ assert lltype.cast_opaque_ptr(lltype.Ptr(A), x) == a
#
s.y = lltype.nullptr(A)
- cpu.do_setfield_gc(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, s)), x,
- descrfld_y)
+ cpu.bh_setfield_gc_r(lltype.cast_opaque_ptr(llmemory.GCREF, s),
+ descrfld_y, x)
assert s.y == a
#
RS = lltype.Struct('S', ('x', lltype.Char)) #, ('y', lltype.Ptr(A)))
descrfld_rx = cpu.fielddescrof(RS, 'x')
rs = lltype.malloc(RS, immortal=True)
rs.x = '?'
- x = cpu.do_getfield_raw(
- BoxInt(cpu.cast_adr_to_int(llmemory.cast_ptr_to_adr(rs))),
+ x = cpu.bh_getfield_raw_i(
+ heaptracker.adr2int(llmemory.cast_ptr_to_adr(rs)),
descrfld_rx)
- assert x.value == ord('?')
+ assert x == ord('?')
#
- cpu.do_setfield_raw(
- BoxInt(cpu.cast_adr_to_int(llmemory.cast_ptr_to_adr(rs))),
- BoxInt(ord('!')),
- descrfld_rx)
+ cpu.bh_setfield_raw_i(
+ heaptracker.adr2int(llmemory.cast_ptr_to_adr(rs)),
+ descrfld_rx, ord('!'))
assert rs.x == '!'
#
if self.cpu.supports_floats:
descrfld_z = cpu.fielddescrof(S, 'z')
- cpu.do_setfield_gc(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, s)),
- BoxFloat(3.5),
- descrfld_z)
+ cpu.bh_setfield_gc_f(
+ lltype.cast_opaque_ptr(llmemory.GCREF, s),
+ descrfld_z, 3.5)
assert s.z == 3.5
s.z = 3.2
- x = cpu.do_getfield_gc(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, s)),
+ x = cpu.bh_getfield_gc_f(
+ lltype.cast_opaque_ptr(llmemory.GCREF, s),
descrfld_z)
- assert x.getfloat() == 3.2
+ assert x == 3.2
### we don't support in the JIT for now GC pointers
### stored inside non-GC structs.
#descrfld_ry = cpu.fielddescrof(RS, 'y')
@@ -1643,45 +1629,43 @@
#assert rs.y == a
#
descrsize = cpu.sizeof(S)
- x = cpu.do_new(descrsize)
- assert isinstance(x, BoxPtr)
- x.getref(lltype.Ptr(S))
+ x = cpu.bh_new(descrsize)
+ lltype.cast_opaque_ptr(lltype.Ptr(S), x) # type check
#
descrsize2 = cpu.sizeof(rclass.OBJECT)
vtable2 = lltype.malloc(rclass.OBJECT_VTABLE, immortal=True)
- vtable2_int = cpu.cast_adr_to_int(llmemory.cast_ptr_to_adr(vtable2))
- cpu.set_class_sizes({vtable2_int: descrsize2})
- x = cpu.do_new_with_vtable(ConstInt(vtable2_int))
- assert isinstance(x, BoxPtr)
+ vtable2_int = heaptracker.adr2int(llmemory.cast_ptr_to_adr(vtable2))
+ heaptracker.register_known_gctype(cpu, vtable2, rclass.OBJECT)
+ x = cpu.bh_new_with_vtable(descrsize2, vtable2_int)
+ lltype.cast_opaque_ptr(lltype.Ptr(rclass.OBJECT), x) # type check
# well...
#assert x.getref(rclass.OBJECTPTR).typeptr == vtable2
#
arraydescr = cpu.arraydescrof(A)
- x = cpu.do_new_array(BoxInt(7), arraydescr)
- assert isinstance(x, BoxPtr)
- assert len(x.getref(lltype.Ptr(A))) == 7
- #
- cpu.do_setarrayitem_gc(
- x, BoxInt(5), BoxInt(ord('*')), descr_A)
- assert x.getref(lltype.Ptr(A))[5] == '*'
- #
- cpu.do_setarrayitem_gc(
- BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, b)),
- BoxInt(1), x,
- descr_B)
- assert b[1] == x.getref(lltype.Ptr(A))
- #
- x = cpu.do_newstr(BoxInt(5))
- assert isinstance(x, BoxPtr)
- assert len(x.getref(lltype.Ptr(rstr.STR)).chars) == 5
- #
- cpu.do_strsetitem(x, BoxInt(4), BoxInt(ord('/')))
- assert x.getref(lltype.Ptr(rstr.STR)).chars[4] == '/'
- #
- x = cpu.do_newstr(BoxInt(5))
- y = cpu.do_cast_ptr_to_int(x)
- assert isinstance(y, BoxInt)
- assert y.value == cpu.cast_gcref_to_int(x.value)
+ x = cpu.bh_new_array(arraydescr, 7)
+ array = lltype.cast_opaque_ptr(lltype.Ptr(A), x)
+ assert len(array) == 7
+ #
+ cpu.bh_setarrayitem_gc_i(descr_A, x, 5, ord('*'))
+ assert array[5] == '*'
+ #
+ cpu.bh_setarrayitem_gc_r(
+ descr_B, lltype.cast_opaque_ptr(llmemory.GCREF, b), 1, x)
+ assert b[1] == array
+ #
+ x = cpu.bh_newstr(5)
+ str = lltype.cast_opaque_ptr(lltype.Ptr(rstr.STR), x)
+ assert len(str.chars) == 5
+ #
+ cpu.bh_strsetitem(x, 4, ord('/'))
+ assert str.chars[4] == '/'
+ #
+## x = cpu.bh_newstr(5)
+## y = cpu.bh_cast_ptr_to_int(x)
+## z = cpu.bh_cast_ptr_to_int(x)
+## y = rffi.get_real_int(y)
+## z = rffi.get_real_int(z)
+## assert type(y) == type(z) == int and y == z
def test_sorting_of_fields(self):
S = self.S
@@ -1694,7 +1678,7 @@
def test_guards_nongc(self):
x = lltype.malloc(lltype.Struct('x'), flavor='raw')
- v = self.cpu.cast_adr_to_int(llmemory.cast_ptr_to_adr(x))
+ v = heaptracker.adr2int(llmemory.cast_ptr_to_adr(x))
vbox = BoxInt(v)
ops = [
(rop.GUARD_NONNULL, vbox, False),
@@ -1797,6 +1781,9 @@
malloc = staticmethod(ootype.new)
nullptr = staticmethod(ootype.null)
+ def setup_class(cls):
+ py.test.skip("ootype tests skipped")
+
@classmethod
def get_funcbox(cls, cpu, func_ptr):
return BoxObj(ootype.cast_to_object(func_ptr))
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/test/test_ll_random.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/test/test_ll_random.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/test/test_ll_random.py Tue Jun 8 19:48:40 2010
@@ -3,8 +3,9 @@
from pypy.jit.backend.test import test_random
from pypy.jit.metainterp.resoperation import ResOperation, rop
from pypy.jit.metainterp.history import ConstInt, ConstPtr
-from pypy.jit.metainterp.history import ConstAddr, BoxPtr, BoxInt
+from pypy.jit.metainterp.history import BoxPtr, BoxInt
from pypy.jit.metainterp.history import BasicFailDescr
+from pypy.jit.codewriter import heaptracker
from pypy.rpython.annlowlevel import llhelper
from pypy.rlib.rarithmetic import intmask
from pypy.rpython.llinterp import LLException
@@ -19,13 +20,11 @@
self.runicodes = []
self.structure_types = []
self.structure_types_and_vtables = []
- self.class_sizes_cache = []
def fork(self, cpu, loop, vars):
fork = test_random.OperationBuilder.fork(self, cpu, loop, vars)
fork.structure_types = self.structure_types
fork.structure_types_and_vtables = self.structure_types_and_vtables
- fork.class_sizes_cache = self.class_sizes_cache
return fork
def get_structptr_var(self, r, must_have_vtable=False, type=lltype.Struct):
@@ -107,11 +106,7 @@
vtable.name[len(name)] = '\x00'
self.structure_types_and_vtables.append((S, vtable))
#
- vtable_adr = llmemory.cast_ptr_to_adr(vtable)
- vtable_int = self.cpu.cast_adr_to_int(vtable_adr)
- descr = self.cpu.sizeof(S)
- self.class_sizes_cache.append((vtable_int, descr))
- self.cpu.set_class_sizes(dict(self.class_sizes_cache))
+ heaptracker.register_known_gctype(self.cpu, vtable, S)
#
return S, vtable
@@ -186,6 +181,9 @@
# ____________________________________________________________
+def ConstAddr(addr, cpu):
+ return ConstInt(heaptracker.adr2int(addr))
+
class GuardClassOperation(test_random.GuardOperation):
def gen_guard(self, builder, r):
ptrvars = [(v, S) for (v, S) in builder.ptrvars
@@ -507,8 +505,6 @@
descr = builder.cpu.calldescrof(TP, TP.ARGS, TP.RESULT)
self.put(builder, args, descr)
exc_box = ConstAddr(llmemory.cast_ptr_to_adr(exc), builder.cpu)
- assert builder.cpu.get_exception()
- builder.cpu.clear_exception()
op = ResOperation(rop.GUARD_EXCEPTION, [exc_box], BoxPtr(),
descr=BasicFailDescr())
op.fail_args = fail_subset
@@ -525,8 +521,6 @@
args = [c_addr] + subset
descr = builder.cpu.calldescrof(TP, TP.ARGS, TP.RESULT)
self.put(builder, args, descr)
- assert builder.cpu.get_exception()
- builder.cpu.clear_exception()
op = ResOperation(rop.GUARD_NO_EXCEPTION, [], BoxPtr(),
descr=BasicFailDescr())
op._exc_box = ConstAddr(llmemory.cast_ptr_to_adr(exc), builder.cpu)
@@ -546,8 +540,6 @@
args = [c_addr] + subset
descr = builder.cpu.calldescrof(TP, TP.ARGS, TP.RESULT)
self.put(builder, args, descr)
- assert builder.cpu.get_exception()
- builder.cpu.clear_exception()
while True:
_, vtableptr = builder.get_random_structure_type_and_vtable(r)
if vtableptr != exc:
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/test/test_random.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/test/test_random.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/test/test_random.py Tue Jun 8 19:48:40 2010
@@ -4,7 +4,7 @@
from pypy.jit.backend.test import conftest as demo_conftest
from pypy.jit.metainterp.history import BasicFailDescr, TreeLoop
from pypy.jit.metainterp.history import BoxInt, ConstInt, LoopToken
-from pypy.jit.metainterp.history import BoxPtr, ConstPtr, ConstAddr
+from pypy.jit.metainterp.history import BoxPtr, ConstPtr
from pypy.jit.metainterp.history import BoxFloat, ConstFloat, Const
from pypy.jit.metainterp.resoperation import ResOperation, rop
from pypy.jit.metainterp.executor import execute_nonspec
@@ -17,9 +17,14 @@
def __init__(self, subops):
self.operations = subops
+class FakeMetaInterp(object):
+ def execute_raised(self, exc, constant=False):
+ self._got_exc = exc
+
class OperationBuilder(object):
def __init__(self, cpu, loop, vars):
self.cpu = cpu
+ self.fakemetainterp = FakeMetaInterp()
self.loop = loop
self.intvars = [box for box in vars if isinstance(box, BoxInt)]
self.boolvars = [] # subset of self.intvars
@@ -40,7 +45,9 @@
return fork
def do(self, opnum, argboxes, descr=None):
- v_result = execute_nonspec(self.cpu, opnum, argboxes, descr)
+ self.fakemetainterp._got_exc = None
+ v_result = execute_nonspec(self.cpu, self.fakemetainterp,
+ opnum, argboxes, descr)
if isinstance(v_result, Const):
v_result = v_result.clonebox()
self.loop.operations.append(ResOperation(opnum, argboxes, v_result,
@@ -56,11 +63,14 @@
if S == S2 and not (isinstance(v, ConstPtr) and
isinstance(v2, ConstPtr)):
if r.random() < 0.5:
- return self.do(rop.OOIS, [v, v2])
+ return self.do(rop.PTR_EQ, [v, v2])
else:
- return self.do(rop.OOISNOT, [v, v2])
+ return self.do(rop.PTR_NE, [v, v2])
v = r.choice(self.intvars)
- return self.do(rop.INT_IS_TRUE, [v])
+ if r.random() < 0.7:
+ return self.do(rop.INT_IS_TRUE, [v])
+ else:
+ return self.do(rop.INT_IS_ZERO, [v])
def subset_of_intvars(self, r):
subset = []
@@ -79,16 +89,16 @@
for v in op.args:
if v in names:
args.append(names[v])
- elif isinstance(v, ConstAddr):
- try:
- name = ''.join([v.value.ptr.name[i]
- for i in range(len(v.value.ptr.name)-1)])
- except AttributeError:
- args.append('ConstAddr(...)')
- else:
- args.append(
- 'ConstAddr(llmemory.cast_ptr_to_adr(%s_vtable), cpu)'
- % name)
+## elif isinstance(v, ConstAddr):
+## try:
+## name = ''.join([v.value.ptr.name[i]
+## for i in range(len(v.value.ptr.name)-1)])
+## except AttributeError:
+## args.append('ConstAddr(...)')
+## else:
+## args.append(
+## 'ConstAddr(llmemory.cast_ptr_to_adr(%s_vtable), cpu)'
+## % name)
elif isinstance(v, ConstFloat):
args.append('ConstFloat(%r)' % v.value)
elif isinstance(v, ConstInt):
@@ -264,8 +274,8 @@
fail_subset = builder.subset_of_intvars(r)
original_intvars = builder.intvars[:]
super(AbstractOvfOperation, self).produce_into(builder, r)
- if builder.cpu._overflow_flag: # overflow detected
- del builder.cpu._overflow_flag
+ if builder.fakemetainterp._got_exc: # overflow detected
+ assert isinstance(builder.fakemetainterp._got_exc, OverflowError)
op = ResOperation(rop.GUARD_OVERFLOW, [], None)
# the overflowed result should not be used any more, but can
# be used on the failure path: recompute fail_subset including
@@ -413,7 +423,7 @@
OPERATIONS.append(UnaryOperation(_op))
OPERATIONS.append(UnaryOperation(rop.INT_IS_TRUE, boolres=True))
-OPERATIONS.append(BooleanUnaryOperation(rop.BOOL_NOT, boolres=True))
+OPERATIONS.append(UnaryOperation(rop.INT_IS_ZERO, boolres=True))
OPERATIONS.append(ConstUnaryOperation(rop.SAME_AS, boolres='sometimes'))
for _op in [rop.INT_ADD_OVF,
@@ -434,8 +444,6 @@
]:
OPERATIONS.append(UnaryFloatOperation(_op))
-OPERATIONS.append(UnaryFloatOperation(rop.FLOAT_IS_TRUE, boolres=True))
-
OPERATIONS.append(CastFloatToIntOperation(rop.CAST_FLOAT_TO_INT))
OPERATIONS.append(CastIntToFloatOperation(rop.CAST_INT_TO_FLOAT))
@@ -587,8 +595,8 @@
def run_loop(self):
cpu = self.builder.cpu
self.clear_state()
- assert not cpu.get_exception()
- assert not cpu.get_exc_value()
+ exc = cpu.grab_exc_value()
+ assert not exc
for i, box in enumerate(self.startvars):
if isinstance(box, BoxInt):
@@ -609,15 +617,13 @@
self.expected[v],
i)
)
+ exc = cpu.grab_exc_value()
if (self.guard_op is not None and
self.guard_op.is_guard_exception()):
if self.guard_op.opnum == rop.GUARD_NO_EXCEPTION:
- assert cpu.get_exception()
- assert cpu.get_exc_value()
- cpu.clear_exception()
+ assert exc
else:
- assert not cpu.get_exception()
- assert not cpu.get_exc_value()
+ assert not exc
def build_bridge(self):
def exc_handling(guard_op):
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/assembler.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/assembler.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/assembler.py Tue Jun 8 19:48:40 2010
@@ -633,8 +633,8 @@
genop_int_ne = _cmpop("NE", "NE")
genop_int_gt = _cmpop("G", "L")
genop_int_ge = _cmpop("GE", "LE")
- genop_oois = genop_int_eq
- genop_ooisnot = genop_int_ne
+ genop_ptr_eq = genop_int_eq
+ genop_ptr_ne = genop_int_ne
genop_float_lt = _cmpop_float('B')
genop_float_le = _cmpop_float('BE')
@@ -654,8 +654,8 @@
genop_guard_int_ne = _cmpop_guard("NE", "NE", "E", "E")
genop_guard_int_gt = _cmpop_guard("G", "L", "LE", "GE")
genop_guard_int_ge = _cmpop_guard("GE", "LE", "L", "G")
- genop_guard_oois = genop_guard_int_eq
- genop_guard_ooisnot = genop_guard_int_ne
+ genop_guard_ptr_eq = genop_guard_int_eq
+ genop_guard_ptr_ne = genop_guard_int_ne
genop_guard_uint_gt = _cmpop_guard("A", "B", "BE", "AE")
genop_guard_uint_lt = _cmpop_guard("B", "A", "AE", "BE")
@@ -689,32 +689,6 @@
# Following what gcc does: res = x & 0x7FFFFFFFFFFFFFFF
self.mc.ANDPD(arglocs[0], self.loc_float_const_abs)
- def genop_guard_float_is_true(self, op, guard_op, addr, arglocs, resloc):
- guard_opnum = guard_op.opnum
- loc0, loc1 = arglocs
- self.mc.XORPD(loc0, loc0)
- self.mc.UCOMISD(loc0, loc1)
- mc = self.mc._mc
- if guard_opnum == rop.GUARD_TRUE:
- mc.JP(rel8(6))
- mc.JZ(rel32(addr))
- return mc.tell() - 4
- else:
- mc.JP(rel8(2))
- mc.JZ(rel8(5))
- return self.implement_guard(addr, mc.JMP)
-
- def genop_float_is_true(self, op, arglocs, resloc):
- loc0, loc1 = arglocs
- self.mc.XORPD(loc0, loc0)
- self.mc.UCOMISD(loc0, loc1)
- rl = resloc.lowest8bits()
- rh = resloc.higher8bits()
- self.mc.SETNE(rl)
- self.mc.SETP(rh)
- self.mc.OR(rl, rh)
- self.mc.MOVZX(resloc, rl)
-
def genop_cast_float_to_int(self, op, arglocs, resloc):
self.mc.CVTTSD2SI(resloc, arglocs[0])
@@ -753,7 +727,7 @@
self.mc.SETNE(rl)
self.mc.MOVZX(resloc, rl)
- def genop_guard_bool_not(self, op, guard_op, addr, arglocs, resloc):
+ def genop_guard_int_is_zero(self, op, guard_op, addr, arglocs, resloc):
guard_opnum = guard_op.opnum
self.mc.CMP(arglocs[0], imm8(0))
if guard_opnum == rop.GUARD_TRUE:
@@ -761,13 +735,15 @@
else:
return self.implement_guard(addr, self.mc.JZ)
- def genop_bool_not(self, op, arglocs, resloc):
- self.mc.XOR(arglocs[0], imm8(1))
+ def genop_int_is_zero(self, op, arglocs, resloc):
+ self.mc.CMP(arglocs[0], imm8(0))
+ rl = resloc.lowest8bits()
+ self.mc.SETE(rl)
+ self.mc.MOVZX(resloc, rl)
def genop_same_as(self, op, arglocs, resloc):
self.mov(arglocs[0], resloc)
- genop_cast_ptr_to_int = genop_same_as
- genop_virtual_ref = genop_same_as
+ #genop_cast_ptr_to_int = genop_same_as
def genop_int_mod(self, op, arglocs, resloc):
self.mc.CDQ()
@@ -1115,13 +1091,8 @@
n = self.CODE_HOLE
mc.writechr(n)
mc.writechr(self.CODE_STOP)
- # preallocate the fail_boxes
- i = len(failargs) - 1
- if i >= 0:
- self.fail_boxes_int.get_addr_for_num(i)
- self.fail_boxes_ptr.get_addr_for_num(i)
- if self.cpu.supports_floats:
- self.fail_boxes_float.get_addr_for_num(i)
+ # assert that the fail_boxes lists are big enough
+ assert len(failargs) <= self.fail_boxes_int.SIZE
def rebuild_faillocs_from_descr(self, bytecode):
from pypy.jit.backend.x86.regalloc import X86FrameManager
@@ -1165,39 +1136,6 @@
arglocs.append(loc)
return arglocs[:]
- def make_boxes_from_latest_values(self, bytecode):
- bytecode = rffi.cast(rffi.UCHARP, bytecode)
- boxes = []
- while 1:
- # decode the next instruction from the bytecode
- code = rffi.cast(lltype.Signed, bytecode[0])
- bytecode = rffi.ptradd(bytecode, 1)
- kind = code & 3
- while code > 0x7F:
- code = rffi.cast(lltype.Signed, bytecode[0])
- bytecode = rffi.ptradd(bytecode, 1)
- index = len(boxes)
- if kind == self.DESCR_INT:
- box = BoxInt(self.fail_boxes_int.getitem(index))
- elif kind == self.DESCR_REF:
- box = BoxPtr(self.fail_boxes_ptr.getitem(index))
- # clear after reading (xxx duplicates
- # get_latest_value_ref())
- self.fail_boxes_ptr.setitem(index, lltype.nullptr(
- llmemory.GCREF.TO))
- elif kind == self.DESCR_FLOAT:
- box = BoxFloat(self.fail_boxes_float.getitem(index))
- else:
- assert kind == self.DESCR_SPECIAL
- if code == self.CODE_STOP:
- break
- elif code == self.CODE_HOLE:
- box = None
- else:
- assert 0, "bad code"
- boxes.append(box)
- return boxes
-
@rgc.no_collect
def grab_frame_values(self, bytecode, frame_addr, allregisters):
# no malloc allowed here!!
@@ -1258,6 +1196,7 @@
#
if not we_are_translated():
assert bytecode[4] == 0xCC
+ self.fail_boxes_count = num
fail_index = rffi.cast(rffi.LONGP, bytecode)[0]
return fail_index
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/regalloc.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/regalloc.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/regalloc.py Tue Jun 8 19:48:40 2010
@@ -3,7 +3,7 @@
"""
from pypy.jit.metainterp.history import (Box, Const, ConstInt, ConstPtr,
- ResOperation, ConstAddr, BoxPtr,
+ ResOperation, BoxPtr,
LoopToken, INT, REF, FLOAT)
from pypy.jit.backend.x86.ri386 import *
from pypy.rpython.lltypesystem import lltype, ll2ctypes, rffi, rstr
@@ -11,6 +11,7 @@
from pypy.rlib import rgc
from pypy.jit.backend.llsupport import symbolic
from pypy.jit.backend.x86.jump import remap_frame_layout
+from pypy.jit.codewriter import heaptracker
from pypy.jit.metainterp.resoperation import rop
from pypy.jit.backend.llsupport.descr import BaseFieldDescr, BaseArrayDescr
from pypy.jit.backend.llsupport.descr import BaseCallDescr, BaseSizeDescr
@@ -45,8 +46,6 @@
print "convert_to_imm: ConstPtr needs special care"
raise AssertionError
return imm(rffi.cast(lltype.Signed, c.value))
- elif isinstance(c, ConstAddr):
- return imm(ll2ctypes.cast_adr_to_int(c.value))
else:
print "convert_to_imm: got a %s" % c
raise AssertionError
@@ -550,8 +549,8 @@
consider_uint_lt = _consider_compop
consider_uint_le = _consider_compop
consider_uint_ge = _consider_compop
- consider_oois = _consider_compop
- consider_ooisnot = _consider_compop
+ consider_ptr_eq = _consider_compop
+ consider_ptr_ne = _consider_compop
def _consider_float_op(self, op):
loc1 = self.xrm.loc(op.args[1])
@@ -593,20 +592,6 @@
self.Perform(op, [loc0], loc0)
self.xrm.possibly_free_var(op.args[0])
- def consider_float_is_true(self, op, guard_op):
- # doesn't need arg to be in a register
- tmpbox0 = TempBox()
- loc0 = self.xrm.force_allocate_reg(tmpbox0)
- loc1 = self.xrm.loc(op.args[0])
- arglocs = [loc0, loc1]
- self.xrm.possibly_free_var(op.args[0])
- self.xrm.possibly_free_var(tmpbox0)
- if guard_op is not None:
- self.perform_with_guard(op, guard_op, arglocs, None)
- else:
- loc2 = self.rm.force_allocate_reg(op.result, need_lower_byte=True)
- self.Perform(op, arglocs, loc2)
-
def consider_cast_float_to_int(self, op):
loc0 = self.xrm.make_sure_var_in_reg(op.args[0], imm_fine=False)
loc1 = self.rm.force_allocate_reg(op.result)
@@ -725,7 +710,7 @@
def consider_new_with_vtable(self, op):
classint = op.args[0].getint()
- descrsize = self.assembler.cpu.class_sizes[classint]
+ descrsize = heaptracker.vtable2descr(self.assembler.cpu, classint)
if self.assembler.cpu.gc_ll_descr.can_inline_malloc(descrsize):
self._fastpath_malloc(op, descrsize)
self.assembler.set_vtable(eax, imm(classint))
@@ -889,22 +874,14 @@
resloc = self.rm.force_allocate_reg(op.result, need_lower_byte=True)
self.Perform(op, [argloc], resloc)
- def consider_bool_not(self, op, guard_op):
- if guard_op is not None:
- # doesn't need arg to be in a register
- argloc = self.loc(op.args[0])
- self.rm.possibly_free_var(op.args[0])
- self.perform_with_guard(op, guard_op, [argloc], None)
- else:
- self.consider_int_neg(op)
+ consider_int_is_zero = consider_int_is_true
def consider_same_as(self, op):
argloc = self.loc(op.args[0])
self.possibly_free_var(op.args[0])
resloc = self.force_allocate_reg(op.result)
self.Perform(op, [argloc], resloc)
- consider_cast_ptr_to_int = consider_same_as
- consider_virtual_ref = consider_same_as
+ #consider_cast_ptr_to_int = consider_same_as
def consider_strlen(self, op):
base_loc = self.rm.make_sure_var_in_reg(op.args[0], op.args)
@@ -963,9 +940,6 @@
def consider_debug_merge_point(self, op):
pass
- def consider_virtual_ref_finish(self, op):
- self.possibly_free_vars(op.args)
-
def get_mark_gc_roots(self, gcrootmap):
shape = gcrootmap.get_basic_shape()
for v, val in self.fm.frame_bindings.items():
@@ -973,6 +947,8 @@
assert isinstance(val, MODRM)
gcrootmap.add_ebp_offset(shape, get_ebp_ofs(val.position))
for v, reg in self.rm.reg_bindings.items():
+ if reg is eax:
+ continue # ok to ignore this one
if (isinstance(v, BoxPtr) and self.rm.stays_alive(v)):
if reg is ebx:
gcrootmap.add_ebx(shape)
@@ -981,7 +957,8 @@
elif reg is edi:
gcrootmap.add_edi(shape)
else:
- assert reg is eax # ok to ignore this one
+ print "[get_mark_gc_roots] bogus register", reg
+ assert False
return gcrootmap.compress_callshape(shape)
def consider_force_token(self, op):
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/ri386.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/ri386.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/ri386.py Tue Jun 8 19:48:40 2010
@@ -210,7 +210,7 @@
class REL32(OPERAND):
width = 4
def __init__(self, absolute_target):
- self.absolute_target = absolute_target
+ self.absolute_target = get_real_int(absolute_target)
def assembler(self):
return '%d' % (self.absolute_target,)
@@ -286,11 +286,14 @@
rel32 = REL32
rel8 = REL8
+def get_real_int(x):
+ from pypy.rpython.lltypesystem import rffi, lltype
+ return rffi.cast(lltype.Signed, x) # force as a real int
+
def imm(value):
if isinstance(value, ComputedIntSymbolic):
value = value.compute_fn()
- if not we_are_translated():
- assert type(value) is int
+ value = get_real_int(value)
if single_byte(value):
return imm8(value)
else:
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/runner.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/runner.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/runner.py Tue Jun 8 19:48:40 2010
@@ -1,4 +1,5 @@
from pypy.rpython.lltypesystem import lltype, llmemory, rffi
+from pypy.rpython.lltypesystem.lloperation import llop
from pypy.rpython.llinterp import LLInterpreter
from pypy.rlib.objectmodel import we_are_translated
from pypy.jit.metainterp import history, compile
@@ -67,19 +68,20 @@
return self.assembler.fail_boxes_float.getitem(index)
def get_latest_value_ref(self, index):
- ptrvalue = self.assembler.fail_boxes_ptr.getitem(index)
- # clear after reading
- self.assembler.fail_boxes_ptr.setitem(index, lltype.nullptr(
- llmemory.GCREF.TO))
- return ptrvalue
+ return self.assembler.fail_boxes_ptr.getitem(index)
+
+ def get_latest_value_count(self):
+ return self.assembler.fail_boxes_count
+
+ def clear_latest_values(self, count):
+ setitem = self.assembler.fail_boxes_ptr.setitem
+ null = lltype.nullptr(llmemory.GCREF.TO)
+ for index in range(count):
+ setitem(index, null)
def get_latest_force_token(self):
return self.assembler.fail_ebp + FORCE_INDEX_OFS
- def make_boxes_from_latest_values(self, faildescr):
- return self.assembler.make_boxes_from_latest_values(
- faildescr._x86_failure_recovery_bytecode)
-
def execute_token(self, executable_token):
addr = executable_token._x86_bootstrap_code
func = rffi.cast(lltype.Ptr(self.BOOTSTRAP_TP), addr)
@@ -136,9 +138,6 @@
CPU = CPU386
-import pypy.jit.metainterp.executor
-pypy.jit.metainterp.executor.make_execute_list(CPU)
-
# silence warnings
history.LoopToken._x86_param_depth = 0
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/support.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/support.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/support.py Tue Jun 8 19:48:40 2010
@@ -4,6 +4,8 @@
ATP = lltype.GcArray(TP)
class ValuesArray(object):
+ SIZE = size
+
def __init__(self):
self.ar = lltype.malloc(ATP, size, zero=True, immortal=True)
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_assembler.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_assembler.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_assembler.py Tue Jun 8 19:48:40 2010
@@ -75,35 +75,6 @@
assert ([loc.assembler() for loc in newlocs] ==
[loc.assembler() for loc in locs if loc is not None])
- # finally, test make_boxes_from_latest_values(), which should
- # reproduce the holes
- expected_classes = [BoxInt, BoxPtr, BoxFloat,
- BoxInt, BoxPtr, BoxFloat,
- type(None), type(None),
- BoxInt, BoxPtr, BoxFloat]
- ptrvalues = {}
- S = lltype.GcStruct('S')
- for i, cls in enumerate(expected_classes):
- if cls == BoxInt:
- assembler.fail_boxes_int.setitem(i, 1000 + i)
- elif cls == BoxPtr:
- s = lltype.malloc(S)
- s_ref = lltype.cast_opaque_ptr(llmemory.GCREF, s)
- ptrvalues[i] = s_ref
- assembler.fail_boxes_ptr.setitem(i, s_ref)
- elif cls == BoxFloat:
- assembler.fail_boxes_float.setitem(i, 42.5 + i)
- boxes = assembler.make_boxes_from_latest_values(bytecode_addr)
- assert len(boxes) == len(locs) == len(expected_classes)
- for i, (box, expected_class) in enumerate(zip(boxes, expected_classes)):
- assert type(box) is expected_class
- if expected_class == BoxInt:
- assert box.value == 1000 + i
- elif expected_class == BoxPtr:
- assert box.value == ptrvalues[i]
- elif expected_class == BoxFloat:
- assert box.value == 42.5 + i
-
# ____________________________________________________________
def test_failure_recovery_func_no_floats():
@@ -244,6 +215,13 @@
# bits of the float were correctly saved and restored.
assert assembler.fail_boxes_float.getitem(i) == expected_floats[i]
+ # verify that until clear_latest_values() is called, reading the
+ # same values multiple times work
+ for i in range(len(content)):
+ assert assembler.fail_boxes_int.getitem(i) == expected_ints[i]
+ assert assembler.fail_boxes_ptr.getitem(i) == expected_ptrs[i]
+ assert assembler.fail_boxes_float.getitem(i) == expected_floats[i]
+
class FakeProfileAgent(object):
def __init__(self):
self.functions = []
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_basic.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_basic.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_basic.py Tue Jun 8 19:48:40 2010
@@ -2,7 +2,7 @@
from pypy.jit.backend.x86.runner import CPU386
from pypy.jit.metainterp.warmspot import ll_meta_interp
from pypy.jit.metainterp.test import test_basic
-from pypy.jit.metainterp.policy import StopAtXPolicy
+from pypy.jit.codewriter.policy import StopAtXPolicy
from pypy.rlib.jit import JitDriver, OPTIMIZER_SIMPLE
class Jit386Mixin(test_basic.LLJitMixin):
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_gc_integration.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_gc_integration.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_gc_integration.py Tue Jun 8 19:48:40 2010
@@ -6,6 +6,7 @@
from pypy.jit.metainterp.history import ResOperation, BoxInt, ConstInt,\
BoxPtr, ConstPtr, TreeLoop
from pypy.jit.metainterp.resoperation import rop, ResOperation
+from pypy.jit.codewriter import heaptracker
from pypy.jit.backend.llsupport.descr import GcCache
from pypy.jit.backend.llsupport.gc import GcLLDescription
from pypy.jit.backend.x86.runner import CPU
@@ -225,10 +226,12 @@
self.nodedescr = nodedescr
vtable = lltype.malloc(rclass.OBJECT_VTABLE, immortal=True)
vtable_int = cpu.cast_adr_to_int(llmemory.cast_ptr_to_adr(vtable))
- NODE2 = lltype.Struct('node2', ('tid', lltype.Signed),
+ NODE2 = lltype.GcStruct('node2',
+ ('parent', rclass.OBJECT),
+ ('tid', lltype.Signed),
('vtable', lltype.Ptr(rclass.OBJECT_VTABLE)))
descrsize = cpu.sizeof(NODE2)
- cpu.set_class_sizes({vtable_int: descrsize})
+ heaptracker.register_known_gctype(cpu, vtable, NODE2)
self.descrsize = descrsize
self.vtable_int = vtable_int
@@ -282,4 +285,4 @@
assert gc_ll_descr.nursery[0] == self.descrsize.tid
assert gc_ll_descr.nursery[1] == self.vtable_int
nurs_adr = rffi.cast(lltype.Signed, gc_ll_descr.nursery)
- assert gc_ll_descr.addrs[0] == nurs_adr + 8
+ assert gc_ll_descr.addrs[0] == nurs_adr + 12
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_regalloc.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_regalloc.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_regalloc.py Tue Jun 8 19:48:40 2010
@@ -211,10 +211,9 @@
'''
S = lltype.GcStruct('S')
ptr = lltype.malloc(S)
+ self.cpu.clear_latest_values(2)
self.interpret(ops, [0, ptr])
assert self.getptr(0, lltype.Ptr(S)) == ptr
- assert not self.cpu.assembler.fail_boxes_ptr.getitem(0)
- assert not self.cpu.assembler.fail_boxes_ptr.getitem(1)
def test_exception_bridge_no_exception(self):
ops = '''
@@ -522,18 +521,20 @@
assert self.getint(0) == 0
def test_bug_float_is_true_stack(self):
+ # NB. float_is_true no longer exists. Unsure if keeping this test
+ # makes sense any more.
ops = '''
[f0, f1, f2, f3, f4, f5, f6, f7, f8, f9]
- i0 = float_is_true(f0)
- i1 = float_is_true(f1)
- i2 = float_is_true(f2)
- i3 = float_is_true(f3)
- i4 = float_is_true(f4)
- i5 = float_is_true(f5)
- i6 = float_is_true(f6)
- i7 = float_is_true(f7)
- i8 = float_is_true(f8)
- i9 = float_is_true(f9)
+ i0 = float_ne(f0, 0.0)
+ i1 = float_ne(f1, 0.0)
+ i2 = float_ne(f2, 0.0)
+ i3 = float_ne(f3, 0.0)
+ i4 = float_ne(f4, 0.0)
+ i5 = float_ne(f5, 0.0)
+ i6 = float_ne(f6, 0.0)
+ i7 = float_ne(f7, 0.0)
+ i8 = float_ne(f8, 0.0)
+ i9 = float_ne(f9, 0.0)
finish(i0, i1, i2, i3, i4, i5, i6, i7, i8, i9)
'''
loop = self.interpret(ops, [0.0, .1, .2, .3, .4, .5, .6, .7, .8, .9])
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_regalloc2.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_regalloc2.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_regalloc2.py Tue Jun 8 19:48:40 2010
@@ -35,7 +35,7 @@
ResOperation(rop.INT_MUL, [v1, v1], v2),
ResOperation(rop.INT_MUL, [v2, v1], v3),
ResOperation(rop.INT_IS_TRUE, [v2], tmp5),
- ResOperation(rop.BOOL_NOT, [tmp5], v4),
+ ResOperation(rop.INT_IS_ZERO, [tmp5], v4),
ResOperation(rop.FINISH, [v4, v3, tmp5], None, descr=BasicFailDescr()),
]
cpu = CPU(None, None)
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_runner.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_runner.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_runner.py Tue Jun 8 19:48:40 2010
@@ -259,9 +259,11 @@
self.cpu.execute_token(looptoken)
result = self.cpu.get_latest_value_int(0)
if guard == rop.GUARD_FALSE:
- assert result == execute(self.cpu, op, None, b).value
+ assert result == execute(self.cpu, None,
+ op, None, b).value
else:
- assert result != execute(self.cpu, op, None, b).value
+ assert result != execute(self.cpu, None,
+ op, None, b).value
def test_stuff_followed_by_guard(self):
@@ -304,7 +306,7 @@
self.cpu.set_future_value_int(i, box.value)
self.cpu.execute_token(looptoken)
result = self.cpu.get_latest_value_int(0)
- expected = execute(self.cpu, op, None, a, b).value
+ expected = execute(self.cpu, None, op, None, a, b).value
if guard == rop.GUARD_FALSE:
assert result == expected
else:
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_send.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_send.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_send.py Tue Jun 8 19:48:40 2010
@@ -2,7 +2,6 @@
import py
from pypy.jit.metainterp.test.test_send import SendTests
from pypy.jit.backend.x86.test.test_basic import Jit386Mixin
-from pypy.jit.metainterp.policy import StopAtXPolicy
from pypy.rlib import jit
class TestSend(Jit386Mixin, SendTests):
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_zrpy_gc.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_zrpy_gc.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_zrpy_gc.py Tue Jun 8 19:48:40 2010
@@ -94,7 +94,7 @@
def run(cbuilder, args=''):
#
pypylog = udir.join('test_zrpy_gc.log')
- data = cbuilder.cmdexec(args, env={'PYPYLOG': str(pypylog)})
+ data = cbuilder.cmdexec(args, env={'PYPYLOG': ':%s' % pypylog})
return data.strip()
def compile_and_run(f, gc, **kwds):
@@ -174,7 +174,7 @@
def run(self, name, n=2000):
pypylog = udir.join('TestCompileHybrid.log')
res = self.cbuilder.cmdexec("%s %d" %(name, n),
- env={'PYPYLOG': str(pypylog)})
+ env={'PYPYLOG': ':%s' % pypylog})
assert int(res) == 20
def run_orig(self, name, n, x):
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_ztranslation.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_ztranslation.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/backend/x86/test/test_ztranslation.py Tue Jun 8 19:48:40 2010
@@ -5,7 +5,7 @@
from pypy.jit.metainterp.jitprof import Profiler
from pypy.jit.backend.x86.runner import CPU386
from pypy.jit.backend.test.support import CCompiledMixin
-from pypy.jit.metainterp.policy import StopAtXPolicy
+from pypy.jit.codewriter.policy import StopAtXPolicy
from pypy.translator.translator import TranslationContext
class TestTranslationX86(CCompiledMixin):
@@ -38,7 +38,7 @@
return abs(x)
jitdriver = JitDriver(greens = [],
- reds = ['frame', 'total', 'j'],
+ reds = ['total', 'frame', 'j'],
virtualizables = ['frame'])
def f(i, j):
for param in unroll_parameters:
@@ -72,7 +72,7 @@
class Frame(object):
_virtualizable2_ = ['thing']
- driver = JitDriver(greens = ['codeno'], reds = ['frame', 'i'],
+ driver = JitDriver(greens = ['codeno'], reds = ['i', 'frame'],
virtualizables = ['frame'],
get_printable_location = lambda codeno : str(codeno),
can_inline = lambda codeno : False)
@@ -127,8 +127,14 @@
def test_external_exception_handling_translates(self):
jitdriver = JitDriver(greens = [], reds = ['n', 'total'])
+ class ImDone(Exception):
+ def __init__(self, resvalue):
+ self.resvalue = resvalue
+
@dont_look_inside
- def f(x):
+ def f(x, total):
+ if x <= 3:
+ raise ImDone(total * 10)
if x > 20:
return 2
raise ValueError
@@ -149,16 +155,16 @@
return Sub()
else:
return Base()
- def main(i):
+ def myportal(i):
jitdriver.set_param("threshold", 3)
jitdriver.set_param("trace_eagerness", 2)
total = 0
n = i
- while n > 3:
+ while True:
jitdriver.can_enter_jit(n=n, total=total)
jitdriver.jit_merge_point(n=n, total=total)
try:
- total += f(n)
+ total += f(n, total)
except ValueError:
total += 1
try:
@@ -166,7 +172,11 @@
except ValueError:
total -= 1
n -= h(n).meth() # this is to force a GUARD_CLASS
- return total * 10
+ def main(i):
+ try:
+ myportal(i)
+ except ImDone, e:
+ return e.resvalue
# XXX custom fishing, depends on the exact env var and format
logfile = udir.join('test_ztranslation.log')
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/codewriter/support.py
==============================================================================
--- pypy/branch/blackhole-improvement/pypy/jit/codewriter/support.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/codewriter/support.py Tue Jun 8 19:48:40 2010
@@ -42,7 +42,7 @@
annpolicy.allow_someobjects = False
a = t.buildannotator(policy=annpolicy)
argtypes = getargtypes(a, values)
- a.build_types(func, argtypes)
+ a.build_types(func, argtypes, main_entry_point=True)
rtyper = t.buildrtyper(type_system = type_system)
rtyper.specialize()
if inline:
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/compile.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/compile.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/compile.py Tue Jun 8 19:48:40 2010
@@ -4,6 +4,7 @@
from pypy.rlib.objectmodel import we_are_translated
from pypy.rlib.debug import debug_start, debug_stop
from pypy.conftest import option
+from pypy.tool.sourcetools import func_with_new_name
from pypy.jit.metainterp.resoperation import ResOperation, rop
from pypy.jit.metainterp.history import TreeLoop, Box, History, LoopToken
@@ -14,8 +15,10 @@
from pypy.jit.metainterp.typesystem import llhelper, oohelper
from pypy.jit.metainterp.optimizeutil import InvalidLoop
-class GiveUp(Exception):
- pass
+def giveup():
+ from pypy.jit.metainterp.pyjitpl import SwitchToBlackhole
+ from pypy.jit.metainterp.jitprof import ABORT_BRIDGE
+ raise SwitchToBlackhole(ABORT_BRIDGE)
def show_loop(metainterp_sd, loop=None, error=None):
# debugging
@@ -153,6 +156,7 @@
assert metainterp_sd.result_type == 'ref'
cpu = metainterp_sd.cpu
result = cpu.get_latest_value_ref(0)
+ cpu.clear_latest_values(1)
raise metainterp_sd.DoneWithThisFrameRef(cpu, result)
class DoneWithThisFrameDescrFloat(_DoneWithThisFrameDescr):
@@ -165,6 +169,7 @@
def handle_fail(self, metainterp_sd):
cpu = metainterp_sd.cpu
value = cpu.get_latest_value_ref(0)
+ cpu.clear_latest_values(1)
raise metainterp_sd.ExitFrameWithExceptionRef(cpu, value)
@@ -220,6 +225,11 @@
rd_virtuals = None
rd_pendingfields = None
+ CNT_INT = -0x20000000
+ CNT_REF = -0x40000000
+ CNT_FLOAT = -0x60000000
+ CNT_MASK = 0x1FFFFFFF
+
def __init__(self, metainterp_sd, original_greenkey):
ResumeDescr.__init__(self, original_greenkey)
self.metainterp_sd = metainterp_sd
@@ -236,23 +246,64 @@
except ValueError:
return # xxx probably very rare
else:
- self._counter = ~i # use ~(index_of_guarded_box_in_fail_args)
+ if box.type == history.INT:
+ cnt = self.CNT_INT
+ elif box.type == history.REF:
+ cnt = self.CNT_REF
+ elif box.type == history.FLOAT:
+ cnt = self.CNT_FLOAT
+ else:
+ assert 0, box.type
+ # we build the following value for _counter, which is always
+ # a negative value
+ self._counter = cnt | i
def handle_fail(self, metainterp_sd):
+ if self.must_compile(metainterp_sd):
+ return self._trace_and_compile_from_bridge(metainterp_sd)
+ else:
+ from pypy.jit.metainterp.blackhole import resume_in_blackhole
+ resume_in_blackhole(metainterp_sd, self)
+ assert 0, "unreachable"
+
+ def _trace_and_compile_from_bridge(self, metainterp_sd):
from pypy.jit.metainterp.pyjitpl import MetaInterp
metainterp = MetaInterp(metainterp_sd)
return metainterp.handle_guard_failure(self)
+ _trace_and_compile_from_bridge._dont_inline_ = True
- def must_compile(self, metainterp_sd, inputargs_and_holes):
+ def must_compile(self, metainterp_sd):
trace_eagerness = metainterp_sd.state.trace_eagerness
if self._counter >= 0:
self._counter += 1
return self._counter >= trace_eagerness
else:
- box = inputargs_and_holes[~self._counter]
- if self._counters is None:
- self._counters = ResumeGuardCounters()
- counter = self._counters.see(box)
+ index = self._counter & self.CNT_MASK
+ typetag = self._counter & ~ self.CNT_MASK
+ counters = self._counters
+ if typetag == self.CNT_INT:
+ intvalue = metainterp_sd.cpu.get_latest_value_int(index)
+ if counters is None:
+ self._counters = counters = ResumeGuardCountersInt()
+ else:
+ assert isinstance(counters, ResumeGuardCountersInt)
+ counter = counters.see_int(intvalue)
+ elif typetag == self.CNT_REF:
+ refvalue = metainterp_sd.cpu.get_latest_value_ref(index)
+ if counters is None:
+ self._counters = counters = ResumeGuardCountersRef()
+ else:
+ assert isinstance(counters, ResumeGuardCountersRef)
+ counter = counters.see_ref(refvalue)
+ elif typetag == self.CNT_FLOAT:
+ floatvalue = metainterp_sd.cpu.get_latest_value_float(index)
+ if counters is None:
+ self._counters = counters = ResumeGuardCountersFloat()
+ else:
+ assert isinstance(counters, ResumeGuardCountersFloat)
+ counter = counters.see_float(floatvalue)
+ else:
+ assert 0, typetag
return counter >= trace_eagerness
def reset_counter_from_failure(self):
@@ -283,17 +334,17 @@
class ResumeGuardForcedDescr(ResumeGuardDescr):
def handle_fail(self, metainterp_sd):
- from pypy.jit.metainterp.pyjitpl import MetaInterp
- metainterp = MetaInterp(metainterp_sd)
+ # Failures of a GUARD_NOT_FORCED are never compiled, but
+ # always just blackholed. First fish for the data saved when
+ # the virtualrefs and virtualizable have been forced by
+ # handle_async_forcing() just a moment ago.
+ from pypy.jit.metainterp.blackhole import resume_in_blackhole
token = metainterp_sd.cpu.get_latest_force_token()
all_virtuals = self.fetch_data(token)
if all_virtuals is None:
all_virtuals = []
- metainterp._already_allocated_resume_virtuals = all_virtuals
- return metainterp.handle_guard_failure(self)
-
- def must_compile(self, metainterp_sd, inputargs_and_holes):
- return False # never compile GUARD_NOT_FORCED failures
+ resume_in_blackhole(metainterp_sd, self, all_virtuals)
+ assert 0, "unreachable"
@staticmethod
def force_now(cpu, token):
@@ -305,91 +356,101 @@
faildescr.handle_async_forcing(token)
def handle_async_forcing(self, force_token):
- from pypy.jit.metainterp.pyjitpl import MetaInterp
from pypy.jit.metainterp.resume import force_from_resumedata
- # To handle the forcing itself, we create a temporary MetaInterp
- # as a convenience to move the various data to its proper place.
metainterp_sd = self.metainterp_sd
- metainterp = MetaInterp(metainterp_sd)
- metainterp.history = None # blackholing
- liveboxes = metainterp_sd.cpu.make_boxes_from_latest_values(self)
- #
- expect_virtualizable = metainterp_sd.virtualizable_info is not None
- forced_data = force_from_resumedata(metainterp, liveboxes, self,
- expect_virtualizable)
- virtualizable_boxes, virtualref_boxes, all_virtuals = forced_data
- #
- # Handle virtualref_boxes: mark each JIT_VIRTUAL_REF as forced
- vrefinfo = metainterp_sd.virtualref_info
- for i in range(0, len(virtualref_boxes), 2):
- virtualbox = virtualref_boxes[i]
- vrefbox = virtualref_boxes[i+1]
- vrefinfo.forced_single_vref(vrefbox.getref_base(),
- virtualbox.getref_base())
- # Handle virtualizable_boxes: store them on the real virtualizable now
- if expect_virtualizable:
- metainterp_sd.virtualizable_info.forced_vable(virtualizable_boxes)
+ all_virtuals = force_from_resumedata(metainterp_sd, self)
+ # The virtualizable data was stored on the real virtualizable above.
# Handle all_virtuals: keep them for later blackholing from the
# future failure of the GUARD_NOT_FORCED
self.save_data(force_token, all_virtuals)
def save_data(self, key, value):
globaldata = self.metainterp_sd.globaldata
- assert key not in globaldata.resume_virtuals
- globaldata.resume_virtuals[key] = value
+ if we_are_translated():
+ assert key not in globaldata.resume_virtuals
+ globaldata.resume_virtuals[key] = value
+ else:
+ rv = globaldata.resume_virtuals_not_translated
+ for key1, value1 in rv:
+ assert key1 != key
+ rv.append((key, value))
def fetch_data(self, key):
globaldata = self.metainterp_sd.globaldata
- assert key in globaldata.resume_virtuals
- data = globaldata.resume_virtuals[key]
- del globaldata.resume_virtuals[key]
+ if we_are_translated():
+ assert key in globaldata.resume_virtuals
+ data = globaldata.resume_virtuals[key]
+ del globaldata.resume_virtuals[key]
+ else:
+ rv = globaldata.resume_virtuals_not_translated
+ for i in range(len(rv)):
+ if rv[i][0] == key:
+ data = rv[i][1]
+ del rv[i]
+ break
+ else:
+ assert 0, "not found: %r" % (key,)
return data
-class ResumeGuardCounters(object):
- # Completely custom algorithm for now: keep 5 pairs (box, counter),
+class AbstractResumeGuardCounters(object):
+ # Completely custom algorithm for now: keep 5 pairs (value, counter),
# and when we need more, we discard the middle pair (middle in the
# current value of the counter). That way, we tend to keep the
- # boxes with a high counter, but also we avoid always throwing away
- # the most recently added box. **THIS ALGO MUST GO AWAY AT SOME POINT**
+ # values with a high counter, but also we avoid always throwing away
+ # the most recently added value. **THIS ALGO MUST GO AWAY AT SOME POINT**
+ pass
+def _see(self, newvalue):
+ # find and update an existing counter
+ unused = -1
+ for i in range(5):
+ cnt = self.counters[i]
+ if cnt:
+ if self.values[i] == newvalue:
+ cnt += 1
+ self.counters[i] = cnt
+ return cnt
+ else:
+ unused = i
+ # not found. Use a previously unused entry, if there is one
+ if unused >= 0:
+ self.counters[unused] = 1
+ self.values[unused] = newvalue
+ return 1
+ # no unused entry. Overwrite the middle one. Computed with indices
+ # a, b, c meaning the highest, second highest, and third highest
+ # entries.
+ a = 0
+ b = c = -1
+ for i in range(1, 5):
+ if self.counters[i] > self.counters[a]:
+ c = b; b = a; a = i
+ elif b < 0 or self.counters[i] > self.counters[b]:
+ c = b; b = i
+ elif c < 0 or self.counters[i] > self.counters[c]:
+ c = i
+ self.counters[c] = 1
+ self.values[c] = newvalue
+ return 1
+
+class ResumeGuardCountersInt(AbstractResumeGuardCounters):
def __init__(self):
self.counters = [0] * 5
- self.boxes = [None] * 5
+ self.values = [0] * 5
+ see_int = func_with_new_name(_see, 'see_int')
- def see(self, newbox):
- newbox = newbox.constbox()
- # find and update an existing counter
- unused = -1
- for i in range(5):
- cnt = self.counters[i]
- if cnt:
- if newbox.same_constant(self.boxes[i]):
- cnt += 1
- self.counters[i] = cnt
- return cnt
- else:
- unused = i
- # not found. Use a previously unused entry, if there is one
- if unused >= 0:
- self.counters[unused] = 1
- self.boxes[unused] = newbox
- return 1
- # no unused entry. Overwrite the middle one. Computed with indices
- # a, b, c meaning the highest, second highest, and third highest
- # entries.
- a = 0
- b = c = -1
- for i in range(1, 5):
- if self.counters[i] > self.counters[a]:
- c = b; b = a; a = i
- elif b < 0 or self.counters[i] > self.counters[b]:
- c = b; b = i
- elif c < 0 or self.counters[i] > self.counters[c]:
- c = i
- self.counters[c] = 1
- self.boxes[c] = newbox
- return 1
+class ResumeGuardCountersRef(AbstractResumeGuardCounters):
+ def __init__(self):
+ self.counters = [0] * 5
+ self.values = [history.ConstPtr.value] * 5
+ see_ref = func_with_new_name(_see, 'see_ref')
+
+class ResumeGuardCountersFloat(AbstractResumeGuardCounters):
+ def __init__(self):
+ self.counters = [0] * 5
+ self.values = [0.0] * 5
+ see_float = func_with_new_name(_see, 'see_float')
class ResumeFromInterpDescr(ResumeDescr):
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/executor.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/executor.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/executor.py Tue Jun 8 19:48:40 2010
@@ -2,248 +2,232 @@
"""
import py
-from pypy.rpython.lltypesystem import lltype
+from pypy.rpython.lltypesystem import lltype, llmemory
from pypy.rpython.ootypesystem import ootype
from pypy.rpython.lltypesystem.lloperation import llop
from pypy.rlib.rarithmetic import ovfcheck, r_uint, intmask
-from pypy.jit.metainterp.history import BoxInt, BoxPtr, ConstInt, check_descr
-from pypy.jit.metainterp.history import INT, REF, ConstFloat
+from pypy.rlib.unroll import unrolling_iterable
+from pypy.jit.metainterp.history import BoxInt, BoxPtr, BoxFloat, check_descr
+from pypy.jit.metainterp.history import INT, REF, FLOAT, VOID, AbstractDescr
from pypy.jit.metainterp import resoperation
from pypy.jit.metainterp.resoperation import rop
-
-
-# Operations in the _ALWAYS_PURE part of the table of resoperation.py
-# must return a ConstInt or ConstPtr. Other operations must return
-# a BoxInt or BoxPtr or None.
+from pypy.jit.metainterp.blackhole import BlackholeInterpreter, NULL
# ____________________________________________________________
-def do_int_add(cpu, box1, box2):
- return ConstInt(intmask(box1.getint() + box2.getint()))
-
-def do_int_sub(cpu, box1, box2):
- return ConstInt(intmask(box1.getint() - box2.getint()))
-
-def do_int_mul(cpu, box1, box2):
- return ConstInt(intmask(box1.getint() * box2.getint()))
-
-def do_int_floordiv(cpu, box1, box2):
- z = llop.int_floordiv(lltype.Signed, box1.getint(), box2.getint())
- return ConstInt(z)
-
-def do_uint_floordiv(cpu, box1, box2):
- z = llop.uint_floordiv(lltype.Unsigned, r_uint(box1.getint()),
- r_uint(box2.getint()))
- return ConstInt(intmask(z))
-
-def do_int_mod(cpu, box1, box2):
- z = llop.int_mod(lltype.Signed, box1.getint(), box2.getint())
- return ConstInt(z)
-
-def do_int_and(cpu, box1, box2):
- return ConstInt(box1.getint() & box2.getint())
-
-def do_int_or(cpu, box1, box2):
- return ConstInt(box1.getint() | box2.getint())
-
-def do_int_xor(cpu, box1, box2):
- return ConstInt(box1.getint() ^ box2.getint())
-
-def do_int_rshift(cpu, box1, box2):
- return ConstInt(box1.getint() >> box2.getint())
-
-def do_int_lshift(cpu, box1, box2):
- return ConstInt(intmask(box1.getint() << box2.getint()))
-
-def do_uint_rshift(cpu, box1, box2):
- v = r_uint(box1.getint()) >> r_uint(box2.getint())
- return ConstInt(intmask(v))
-
-# ----------
-
-def do_int_lt(cpu, box1, box2):
- return ConstInt(box1.getint() < box2.getint())
-
-def do_int_le(cpu, box1, box2):
- return ConstInt(box1.getint() <= box2.getint())
-
-def do_int_eq(cpu, box1, box2):
- return ConstInt(box1.getint() == box2.getint())
-
-def do_int_ne(cpu, box1, box2):
- return ConstInt(box1.getint() != box2.getint())
-
-def do_int_gt(cpu, box1, box2):
- return ConstInt(box1.getint() > box2.getint())
-
-def do_int_ge(cpu, box1, box2):
- return ConstInt(box1.getint() >= box2.getint())
-
-def do_uint_lt(cpu, box1, box2):
- return ConstInt(r_uint(box1.getint()) < r_uint(box2.getint()))
-
-def do_uint_le(cpu, box1, box2):
- return ConstInt(r_uint(box1.getint()) <= r_uint(box2.getint()))
-
-def do_uint_gt(cpu, box1, box2):
- return ConstInt(r_uint(box1.getint()) > r_uint(box2.getint()))
-
-def do_uint_ge(cpu, box1, box2):
- return ConstInt(r_uint(box1.getint()) >= r_uint(box2.getint()))
-
-# ----------
-
-def do_int_is_true(cpu, box1):
- return ConstInt(bool(box1.getint()))
-
-def do_int_neg(cpu, box1):
- return ConstInt(intmask(-box1.getint()))
-
-def do_int_invert(cpu, box1):
- return ConstInt(~box1.getint())
-
-def do_bool_not(cpu, box1):
- return ConstInt(not box1.getint())
+def _prepare_call(argboxes, descr):
+ # count the number of arguments of the different types
+ count_i = count_r = count_f = 0
+ for i in range(1, len(argboxes)):
+ type = argboxes[i].type
+ if type == INT: count_i += 1
+ elif type == REF: count_r += 1
+ elif type == FLOAT: count_f += 1
+ # allocate lists for each type that has at least one argument
+ if count_i: args_i = [0] * count_i
+ else: args_i = None
+ if count_r: args_r = [NULL] * count_r
+ else: args_r = None
+ if count_f: args_f = [0.0] * count_f
+ else: args_f = None
+ # fill in the lists
+ count_i = count_r = count_f = 0
+ for i in range(1, len(argboxes)):
+ box = argboxes[i]
+ if box.type == INT:
+ args_i[count_i] = box.getint()
+ count_i += 1
+ elif box.type == REF:
+ args_r[count_r] = box.getref_base()
+ count_r += 1
+ elif box.type == FLOAT:
+ args_f[count_f] = box.getfloat()
+ count_f += 1
+ # get the function address as an integer
+ func = argboxes[0].getint()
+ # do the call using the correct function from the cpu
+ rettype = descr.get_return_type()
+ return func, args_i, args_r, args_f, rettype
+
+def do_call(cpu, metainterp, argboxes, descr):
+ assert metainterp is not None
+ func, args_i, args_r, args_f, rettype = _prepare_call(argboxes, descr)
+ if rettype == INT:
+ try:
+ result = cpu.bh_call_i(func, descr, args_i, args_r, args_f)
+ except Exception, e:
+ metainterp.execute_raised(e)
+ result = 0
+ return BoxInt(result)
+ if rettype == REF:
+ try:
+ result = cpu.bh_call_r(func, descr, args_i, args_r, args_f)
+ except Exception, e:
+ metainterp.execute_raised(e)
+ result = NULL
+ return BoxPtr(result)
+ if rettype == FLOAT:
+ try:
+ result = cpu.bh_call_f(func, descr, args_i, args_r, args_f)
+ except Exception, e:
+ metainterp.execute_raised(e)
+ result = 0.0
+ return BoxFloat(result)
+ if rettype == VOID:
+ try:
+ cpu.bh_call_v(func, descr, args_i, args_r, args_f)
+ except Exception, e:
+ metainterp.execute_raised(e)
+ return None
+ raise AssertionError("bad rettype")
+
+do_call_loopinvariant = do_call
+do_call_may_force = do_call
+
+def do_call_pure(cpu, _, argboxes, descr):
+ # this version does not deal with exceptions at all
+ # xxx in case of MemoryError, it crashes the JIT
+ func, args_i, args_r, args_f, rettype = _prepare_call(argboxes, descr)
+ if rettype == INT:
+ return BoxInt(cpu.bh_call_i(func, descr, args_i, args_r, args_f))
+ if rettype == REF:
+ return BoxPtr(cpu.bh_call_r(func, descr, args_i, args_r, args_f))
+ if rettype == FLOAT:
+ return BoxFloat(cpu.bh_call_f(func, descr, args_i, args_r, args_f))
+ if rettype == VOID:
+ cpu.bh_call_v(func, descr, args_i, args_r, args_f)
+ return None
+ raise AssertionError("bad rettype")
+
+def do_getarrayitem_gc(cpu, _, arraybox, indexbox, arraydescr):
+ array = arraybox.getref_base()
+ index = indexbox.getint()
+ if arraydescr.is_array_of_pointers():
+ return BoxPtr(cpu.bh_getarrayitem_gc_r(arraydescr, array, index))
+ elif arraydescr.is_array_of_floats():
+ return BoxFloat(cpu.bh_getarrayitem_gc_f(arraydescr, array, index))
+ else:
+ return BoxInt(cpu.bh_getarrayitem_gc_i(arraydescr, array, index))
-def do_same_as(cpu, box1):
- return box1
+def do_setarrayitem_gc(cpu, _, arraybox, indexbox, itembox, arraydescr):
+ array = arraybox.getref_base()
+ index = indexbox.getint()
+ if arraydescr.is_array_of_pointers():
+ cpu.bh_setarrayitem_gc_r(arraydescr, array, index,
+ itembox.getref_base())
+ elif arraydescr.is_array_of_floats():
+ cpu.bh_setarrayitem_gc_f(arraydescr, array, index, itembox.getfloat())
+ else:
+ cpu.bh_setarrayitem_gc_i(arraydescr, array, index, itembox.getint())
-def do_oois(cpu, box1, box2):
- tp = box1.type
- assert tp == box2.type
- if tp == INT:
- x = box1.getint() == box2.getint()
- elif tp == REF:
- x = box1.getref_base() == box2.getref_base()
+def do_getfield_gc(cpu, _, structbox, fielddescr):
+ struct = structbox.getref_base()
+ if fielddescr.is_pointer_field():
+ return BoxPtr(cpu.bh_getfield_gc_r(struct, fielddescr))
+ elif fielddescr.is_float_field():
+ return BoxFloat(cpu.bh_getfield_gc_f(struct, fielddescr))
else:
- assert False
- return ConstInt(x)
+ return BoxInt(cpu.bh_getfield_gc_i(struct, fielddescr))
-def do_ooisnot(cpu, box1, box2):
- tp = box1.type
- assert tp == box2.type
- if tp == INT:
- x = box1.getint() != box2.getint()
- elif tp == REF:
- x = box1.getref_base() != box2.getref_base()
+def do_getfield_raw(cpu, _, structbox, fielddescr):
+ check_descr(fielddescr)
+ struct = structbox.getint()
+ if fielddescr.is_pointer_field():
+ return BoxPtr(cpu.bh_getfield_raw_r(struct, fielddescr))
+ elif fielddescr.is_float_field():
+ return BoxFloat(cpu.bh_getfield_raw_f(struct, fielddescr))
else:
- assert False
- return ConstInt(x)
+ return BoxInt(cpu.bh_getfield_raw_i(struct, fielddescr))
-def do_subclassof(cpu, box1, box2):
- return ConstInt(cpu.ts.subclassOf(cpu, box1, box2))
+def do_setfield_gc(cpu, _, structbox, itembox, fielddescr):
+ struct = structbox.getref_base()
+ if fielddescr.is_pointer_field():
+ cpu.bh_setfield_gc_r(struct, fielddescr, itembox.getref_base())
+ elif fielddescr.is_float_field():
+ cpu.bh_setfield_gc_f(struct, fielddescr, itembox.getfloat())
+ else:
+ cpu.bh_setfield_gc_i(struct, fielddescr, itembox.getint())
-# ----------
+def do_setfield_raw(cpu, _, structbox, itembox, fielddescr):
+ struct = structbox.getint()
+ if fielddescr.is_pointer_field():
+ cpu.bh_setfield_raw_r(struct, fielddescr, itembox.getref_base())
+ elif fielddescr.is_float_field():
+ cpu.bh_setfield_raw_f(struct, fielddescr, itembox.getfloat())
+ else:
+ cpu.bh_setfield_raw_i(struct, fielddescr, itembox.getint())
-def do_int_add_ovf(cpu, box1, box2):
- x = box1.getint()
- y = box2.getint()
+def exec_new_with_vtable(cpu, clsbox):
+ from pypy.jit.codewriter import heaptracker
+ vtable = clsbox.getint()
+ descr = heaptracker.vtable2descr(cpu, vtable)
+ return cpu.bh_new_with_vtable(descr, vtable)
+
+def do_new_with_vtable(cpu, _, clsbox):
+ return BoxPtr(exec_new_with_vtable(cpu, clsbox))
+
+def do_arraycopy(cpu, _, calldescr, funcbox, x1box, x2box,
+ x3box, x4box, x5box, arraydescr):
+ cpu.bh_call_v(funcbox.getint(), calldescr,
+ [x3box.getint(), x4box.getint(), x5box.getint()],
+ [x1box.getref_base(), x2box.getref_base()], None)
+
+def do_int_add_ovf(cpu, metainterp, box1, box2):
+ assert metainterp is not None
+ a = box1.getint()
+ b = box2.getint()
try:
- z = ovfcheck(x + y)
+ z = ovfcheck(a + b)
except OverflowError:
- ovf = True
+ metainterp.execute_raised(OverflowError(), constant=True)
z = 0
- else:
- ovf = False
- cpu._overflow_flag = ovf
return BoxInt(z)
-def do_int_sub_ovf(cpu, box1, box2):
- x = box1.getint()
- y = box2.getint()
+def do_int_sub_ovf(cpu, metainterp, box1, box2):
+ assert metainterp is not None
+ a = box1.getint()
+ b = box2.getint()
try:
- z = ovfcheck(x - y)
+ z = ovfcheck(a - b)
except OverflowError:
- ovf = True
+ metainterp.execute_raised(OverflowError(), constant=True)
z = 0
- else:
- ovf = False
- cpu._overflow_flag = ovf
return BoxInt(z)
-def do_int_mul_ovf(cpu, box1, box2):
- x = box1.getint()
- y = box2.getint()
+def do_int_mul_ovf(cpu, metainterp, box1, box2):
+ assert metainterp is not None
+ a = box1.getint()
+ b = box2.getint()
try:
- z = ovfcheck(x * y)
+ z = ovfcheck(a * b)
except OverflowError:
- ovf = True
+ metainterp.execute_raised(OverflowError(), constant=True)
z = 0
- else:
- ovf = False
- cpu._overflow_flag = ovf
return BoxInt(z)
-# ----------
-
-def do_float_neg(cpu, box1):
- return ConstFloat(-box1.getfloat())
-
-def do_float_abs(cpu, box1):
- return ConstFloat(abs(box1.getfloat()))
-
-def do_float_is_true(cpu, box1):
- return ConstInt(bool(box1.getfloat()))
-
-def do_float_add(cpu, box1, box2):
- return ConstFloat(box1.getfloat() + box2.getfloat())
-
-def do_float_sub(cpu, box1, box2):
- return ConstFloat(box1.getfloat() - box2.getfloat())
-
-def do_float_mul(cpu, box1, box2):
- return ConstFloat(box1.getfloat() * box2.getfloat())
-
-def do_float_truediv(cpu, box1, box2):
- return ConstFloat(box1.getfloat() / box2.getfloat())
-
-def do_float_lt(cpu, box1, box2):
- return ConstInt(box1.getfloat() < box2.getfloat())
-
-def do_float_le(cpu, box1, box2):
- return ConstInt(box1.getfloat() <= box2.getfloat())
-
-def do_float_eq(cpu, box1, box2):
- return ConstInt(box1.getfloat() == box2.getfloat())
-
-def do_float_ne(cpu, box1, box2):
- return ConstInt(box1.getfloat() != box2.getfloat())
-
-def do_float_gt(cpu, box1, box2):
- return ConstInt(box1.getfloat() > box2.getfloat())
-
-def do_float_ge(cpu, box1, box2):
- return ConstInt(box1.getfloat() >= box2.getfloat())
-
-def do_cast_float_to_int(cpu, box1):
- # note: we need to call int() twice to care for the fact that
- # int(-2147483648.0) returns a long :-(
- return ConstInt(int(int(box1.getfloat())))
-
-def do_cast_int_to_float(cpu, box1):
- return ConstFloat(float(box1.getint()))
+def do_same_as(cpu, _, box):
+ return box.clonebox()
# ____________________________________________________________
-def do_force_token(cpu):
- raise NotImplementedError
+##def do_force_token(cpu):
+## raise NotImplementedError
-def do_virtual_ref(cpu, box1, box2):
- raise NotImplementedError
+##def do_virtual_ref(cpu, box1, box2):
+## raise NotImplementedError
-def do_virtual_ref_finish(cpu, box1, box2):
- raise NotImplementedError
+##def do_virtual_ref_finish(cpu, box1, box2):
+## raise NotImplementedError
-def do_debug_merge_point(cpu, box1):
- from pypy.jit.metainterp.warmspot import get_stats
- loc = box1._get_str()
- get_stats().add_merge_point_location(loc)
+##def do_debug_merge_point(cpu, box1):
+## from pypy.jit.metainterp.warmspot import get_stats
+## loc = box1._get_str()
+## get_stats().add_merge_point_location(loc)
# ____________________________________________________________
-def make_execute_list(cpuclass):
- from pypy.jit.backend.model import AbstractCPU
+def _make_execute_list():
if 0: # enable this to trace calls to do_xxx
def wrap(fn):
def myfn(*args):
@@ -266,37 +250,109 @@
# find which list to store the operation in, based on num_args
num_args = resoperation.oparity[value]
withdescr = resoperation.opwithdescr[value]
- if withdescr and num_args >= 0:
- num_args += 1
- if num_args not in execute_by_num_args:
- execute_by_num_args[num_args] = [None] * (rop._LAST+1)
- execute = execute_by_num_args[num_args]
+ dictkey = num_args, withdescr
+ if dictkey not in execute_by_num_args:
+ execute_by_num_args[dictkey] = [None] * (rop._LAST+1)
+ execute = execute_by_num_args[dictkey]
#
if execute[value] is not None:
- raise Exception("duplicate entry for op number %d" % value)
+ raise AssertionError("duplicate entry for op number %d"% value)
+ #
+ # Fish for a way for the pyjitpl interpreter to delegate
+ # really running the operation to the blackhole interpreter
+ # or directly to the cpu. First try the do_xxx() functions
+ # explicitly encoded above:
+ name = 'do_' + key.lower()
+ if name in globals():
+ execute[value] = globals()[name]
+ continue
+ #
+ # Maybe the same without the _PURE suffix?
if key.endswith('_PURE'):
key = key[:-5]
- name = 'do_' + key.lower()
- if hasattr(cpuclass, name):
- execute[value] = wrap(getattr(cpuclass, name))
- elif name in globals():
- execute[value] = wrap(globals()[name])
- else:
- assert hasattr(AbstractCPU, name), name
- cpuclass._execute_by_num_args = execute_by_num_args
+ name = 'do_' + key.lower()
+ if name in globals():
+ execute[value] = globals()[name]
+ continue
+ #
+ # If missing, fallback to the bhimpl_xxx() method of the
+ # blackhole interpreter. This only works if there is a
+ # method of the exact same name and it accepts simple
+ # parameters.
+ name = 'bhimpl_' + key.lower()
+ if hasattr(BlackholeInterpreter, name):
+ func = make_execute_function_with_boxes(
+ key.lower(),
+ getattr(BlackholeInterpreter, name).im_func)
+ if func is not None:
+ execute[value] = func
+ continue
+ if value in (rop.FORCE_TOKEN,
+ rop.CALL_ASSEMBLER,
+ rop.COND_CALL_GC_WB,
+ rop.DEBUG_MERGE_POINT,
+ rop.SETARRAYITEM_RAW,
+ ): # list of opcodes never executed by pyjitpl
+ continue
+ raise AssertionError("missing %r" % (key,))
+ return execute_by_num_args
+def make_execute_function_with_boxes(name, func):
+ # Make a wrapper for 'func'. The func is a simple bhimpl_xxx function
+ # from the BlackholeInterpreter class. The wrapper is a new function
+ # that receives and returns boxed values.
+ for argtype in func.argtypes:
+ if argtype not in ('i', 'r', 'f', 'd', 'cpu'):
+ return None
+ if list(func.argtypes).count('d') > 1:
+ return None
+ if func.resulttype not in ('i', 'r', 'f', None):
+ return None
+ argtypes = unrolling_iterable(func.argtypes)
+ resulttype = func.resulttype
+ #
+ def do(cpu, _, *argboxes):
+ newargs = ()
+ for argtype in argtypes:
+ if argtype == 'cpu':
+ value = cpu
+ elif argtype == 'd':
+ value = argboxes[-1]
+ assert isinstance(value, AbstractDescr)
+ argboxes = argboxes[:-1]
+ else:
+ argbox = argboxes[0]
+ argboxes = argboxes[1:]
+ if argtype == 'i': value = argbox.getint()
+ elif argtype == 'r': value = argbox.getref_base()
+ elif argtype == 'f': value = argbox.getfloat()
+ newargs = newargs + (value,)
+ assert not argboxes
+ #
+ result = func(*newargs)
+ #
+ if resulttype == 'i': return BoxInt(result)
+ if resulttype == 'r': return BoxPtr(result)
+ if resulttype == 'f': return BoxFloat(result)
+ return None
+ #
+ do.func_name = 'do_' + name
+ return do
-def get_execute_funclist(cpu, num_args):
+def get_execute_funclist(num_args, withdescr):
# workaround, similar to the next one
- return cpu._execute_by_num_args[num_args]
+ return EXECUTE_BY_NUM_ARGS[num_args, withdescr]
get_execute_funclist._annspecialcase_ = 'specialize:memo'
-def get_execute_function(cpu, opnum, num_args):
+def get_execute_function(opnum, num_args, withdescr):
# workaround for an annotation limitation: putting this code in
# a specialize:memo function makes sure the following line is
# constant-folded away. Only works if opnum and num_args are
# constants, of course.
- return cpu._execute_by_num_args[num_args][opnum]
+ func = EXECUTE_BY_NUM_ARGS[num_args, withdescr][opnum]
+ assert func is not None, "EXECUTE_BY_NUM_ARGS[%s, %s][%s]" % (
+ num_args, withdescr, resoperation.opname[opnum])
+ return func
get_execute_function._annspecialcase_ = 'specialize:memo'
def has_descr(opnum):
@@ -305,56 +361,61 @@
has_descr._annspecialcase_ = 'specialize:memo'
-def execute(cpu, opnum, descr, *argboxes):
+def execute(cpu, metainterp, opnum, descr, *argboxes):
# only for opnums with a fixed arity
- if has_descr(opnum):
+ num_args = len(argboxes)
+ withdescr = has_descr(opnum)
+ if withdescr:
check_descr(descr)
argboxes = argboxes + (descr,)
else:
assert descr is None
- func = get_execute_function(cpu, opnum, len(argboxes))
- assert func is not None
- return func(cpu, *argboxes)
-execute._annspecialcase_ = 'specialize:arg(1)'
+ func = get_execute_function(opnum, num_args, withdescr)
+ return func(cpu, metainterp, *argboxes) # note that the 'argboxes' tuple
+ # optionally ends with the descr
+execute._annspecialcase_ = 'specialize:arg(2)'
-def execute_varargs(cpu, opnum, argboxes, descr):
+def execute_varargs(cpu, metainterp, opnum, argboxes, descr):
# only for opnums with a variable arity (calls, typically)
check_descr(descr)
- func = get_execute_function(cpu, opnum, -1)
- assert func is not None
- return func(cpu, argboxes, descr)
-execute_varargs._annspecialcase_ = 'specialize:arg(1)'
+ func = get_execute_function(opnum, -1, True)
+ return func(cpu, metainterp, argboxes, descr)
+execute_varargs._annspecialcase_ = 'specialize:arg(2)'
-def execute_nonspec(cpu, opnum, argboxes, descr=None):
+def execute_nonspec(cpu, metainterp, opnum, argboxes, descr=None):
arity = resoperation.oparity[opnum]
assert arity == -1 or len(argboxes) == arity
if resoperation.opwithdescr[opnum]:
check_descr(descr)
if arity == -1:
- func = get_execute_funclist(cpu, -1)[opnum]
- return func(cpu, argboxes, descr)
+ func = get_execute_funclist(-1, True)[opnum]
+ return func(cpu, metainterp, argboxes, descr)
if arity == 0:
- func = get_execute_funclist(cpu, 1)[opnum]
- return func(cpu, descr)
+ func = get_execute_funclist(0, True)[opnum]
+ return func(cpu, metainterp, descr)
if arity == 1:
- func = get_execute_funclist(cpu, 2)[opnum]
- return func(cpu, argboxes[0], descr)
+ func = get_execute_funclist(1, True)[opnum]
+ return func(cpu, metainterp, argboxes[0], descr)
if arity == 2:
- func = get_execute_funclist(cpu, 3)[opnum]
- return func(cpu, argboxes[0], argboxes[1], descr)
+ func = get_execute_funclist(2, True)[opnum]
+ return func(cpu, metainterp, argboxes[0], argboxes[1], descr)
if arity == 3:
- func = get_execute_funclist(cpu, 4)[opnum]
- return func(cpu, argboxes[0], argboxes[1], argboxes[2], descr)
+ func = get_execute_funclist(3, True)[opnum]
+ return func(cpu, metainterp, argboxes[0], argboxes[1], argboxes[2],
+ descr)
else:
assert descr is None
if arity == 1:
- func = get_execute_funclist(cpu, 1)[opnum]
- return func(cpu, argboxes[0])
+ func = get_execute_funclist(1, False)[opnum]
+ return func(cpu, metainterp, argboxes[0])
if arity == 2:
- func = get_execute_funclist(cpu, 2)[opnum]
- return func(cpu, argboxes[0], argboxes[1])
+ func = get_execute_funclist(2, False)[opnum]
+ return func(cpu, metainterp, argboxes[0], argboxes[1])
if arity == 3:
- func = get_execute_funclist(cpu, 3)[opnum]
- return func(cpu, argboxes[0], argboxes[1], argboxes[2])
+ func = get_execute_funclist(3, False)[opnum]
+ return func(cpu, metainterp, argboxes[0], argboxes[1], argboxes[2])
raise NotImplementedError
+
+
+EXECUTE_BY_NUM_ARGS = _make_execute_list()
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/history.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/history.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/history.py Tue Jun 8 19:48:40 2010
@@ -9,6 +9,7 @@
from pypy.conftest import option
from pypy.jit.metainterp.resoperation import ResOperation, rop
+from pypy.jit.codewriter import heaptracker
# ____________________________________________________________
@@ -16,6 +17,7 @@
REF = 'r'
FLOAT = 'f'
HOLE = '_'
+VOID = 'v'
FAILARGS_LIMIT = 1000
@@ -40,6 +42,7 @@
return "ref"
else:
raise NotImplementedError("type %s not supported" % TYPE)
+getkind._annspecialcase_ = 'specialize:memo'
def repr_pointer(box):
from pypy.rpython.lltypesystem import rstr
@@ -98,7 +101,7 @@
def nonconstbox(self):
raise NotImplementedError
- def getaddr(self, cpu):
+ def getaddr(self):
raise NotImplementedError
def sort_key(self):
@@ -125,6 +128,18 @@
def _clone_if_mutable(self):
return self
+ def get_arg_types(self):
+ """ Implement in call descr.
+ Must return a string of INT, REF and FLOAT ('i', 'r', 'f').
+ """
+ raise NotImplementedError
+
+ def get_return_type(self):
+ """ Implement in call descr.
+ Must return INT, REF, FLOAT, or 'v' for void.
+ """
+ raise NotImplementedError
+
def get_extra_info(self):
""" Implement in call descr
"""
@@ -150,6 +165,12 @@
"""
raise NotImplementedError
+ def as_vtable_size_descr(self):
+ """ Implement for size descr representing objects with vtables.
+ Returns self. (it's an annotation hack)
+ """
+ raise NotImplementedError
+
class AbstractFailDescr(AbstractDescr):
index = -1
@@ -176,18 +197,13 @@
__slots__ = ()
@staticmethod
- def _new(x, cpu):
+ def _new(x):
"NOT_RPYTHON"
T = lltype.typeOf(x)
kind = getkind(T)
if kind == "int":
if isinstance(T, lltype.Ptr):
- if not we_are_translated():
- # cannot store integers representing casted addresses
- # inside ConstInt() instances that are going through
- # translation; must use the special ConstAddr instead.
- return ConstAddr(x, cpu)
- intval = cpu.cast_adr_to_int(llmemory.cast_ptr_to_adr(x))
+ intval = heaptracker.adr2int(llmemory.cast_ptr_to_adr(x))
else:
intval = lltype.cast_primitive(lltype.Signed, x)
return ConstInt(intval)
@@ -216,15 +232,13 @@
# to get the other behavior (i.e. using this __eq__).
if self.__class__ is not other.__class__:
return False
- if isinstance(self.value, Symbolic):
- v1 = "symbolic", id(self.value)
- else:
- v1 = self.value
- if isinstance(other.value, Symbolic):
- v2 = "symbolic", id(other.value)
- else:
- v2 = other.value
- return v1 == v2
+ try:
+ return self.value == other.value
+ except TypeError:
+ if (isinstance(self.value, Symbolic) and
+ isinstance(other.value, Symbolic)):
+ return self.value is other.value
+ raise
def __ne__(self, other):
return not (self == other)
@@ -232,6 +246,7 @@
class ConstInt(Const):
type = INT
+ value = 0
_attrs_ = ('value',)
def __init__(self, value):
@@ -250,11 +265,11 @@
def getint(self):
return self.value
- def getaddr(self, cpu):
- return cpu.cast_int_to_adr(self.value)
+ def getaddr(self):
+ return heaptracker.int2adr(self.value)
def _get_hash_(self):
- return self.value
+ return make_hashable_int(self.value)
def set_future_value(self, cpu, j):
cpu.set_future_value_int(j, self.value)
@@ -275,50 +290,6 @@
CONST_FALSE = ConstInt(0)
CONST_TRUE = ConstInt(1)
-class ConstAddr(Const): # only for constants built before translation
- type = INT
- _attrs_ = ('value', 'cpu')
-
- def __init__(self, adrvalue, cpu):
- "NOT_RPYTHON"
- assert not we_are_translated()
- if isinstance(lltype.typeOf(adrvalue), lltype.Ptr):
- adrvalue = llmemory.cast_ptr_to_adr(adrvalue) # convenience
- else:
- assert lltype.typeOf(adrvalue) == llmemory.Address
- self.value = adrvalue
- self.cpu = cpu
-
- def clonebox(self):
- return BoxInt(self.cpu.cast_adr_to_int(self.value))
-
- nonconstbox = clonebox
-
- def getint(self):
- return self.cpu.cast_adr_to_int(self.value)
-
- def getaddr(self, cpu):
- return self.value
-
- def _get_hash_(self):
- return llmemory.cast_adr_to_int(self.value)
-
- def set_future_value(self, cpu, j):
- cpu.set_future_value_int(j, self.getint())
-
- def same_constant(self, other):
- assert isinstance(other, Const)
- return self.value == other.getaddr(self.cpu)
-
- def nonnull(self):
- return bool(self.value)
-
- def _getrepr_(self):
- return self.value
-
- def repr_rpython(self):
- return repr_rpython(self, 'ca')
-
class ConstFloat(Const):
type = FLOAT
value = 0.0
@@ -355,6 +326,8 @@
def repr_rpython(self):
return repr_rpython(self, 'cf')
+CONST_FZERO = ConstFloat(0.0)
+
class ConstPtr(Const):
type = REF
value = lltype.nullptr(llmemory.GCREF.TO)
@@ -382,7 +355,7 @@
else:
return 0
- def getaddr(self, cpu):
+ def getaddr(self):
return llmemory.cast_ptr_to_adr(self.value)
def set_future_value(self, cpu, j):
@@ -403,7 +376,13 @@
def _get_str(self): # for debugging only
from pypy.rpython.annlowlevel import hlstr
from pypy.rpython.lltypesystem import rstr
- return hlstr(lltype.cast_opaque_ptr(lltype.Ptr(rstr.STR), self.value))
+ try:
+ return hlstr(lltype.cast_opaque_ptr(lltype.Ptr(rstr.STR),
+ self.value))
+ except lltype.UninitializedMemoryAccess:
+ return '<uninitialized string>'
+
+CONST_NULL = ConstPtr(ConstPtr.value)
class ConstObj(Const):
type = REF
@@ -435,7 +414,7 @@
def set_future_value(self, cpu, j):
cpu.set_future_value_ref(j, self.value)
-## def getaddr(self, cpu):
+## def getaddr(self):
## # so far this is used only when calling
## # CodeWriter.IndirectCallset.bytecode_for_address. We don't need a
## # real addr, but just a key for the dictionary
@@ -464,7 +443,7 @@
is_box = True # hint that we want to make links in graphviz from this
@staticmethod
- def _new(x, cpu):
+ def _new(x):
"NOT_RPYTHON"
kind = getkind(lltype.typeOf(x))
if kind == "int":
@@ -527,11 +506,11 @@
def getint(self):
return self.value
- def getaddr(self, cpu):
- return cpu.cast_int_to_adr(self.value)
+ def getaddr(self):
+ return heaptracker.int2adr(self.value)
def _get_hash_(self):
- return self.value
+ return make_hashable_int(self.value)
def set_future_value(self, cpu, j):
cpu.set_future_value_int(j, self.value)
@@ -598,7 +577,7 @@
return lltype.cast_opaque_ptr(PTR, self.getref_base())
getref._annspecialcase_ = 'specialize:arg(1)'
- def getaddr(self, cpu):
+ def getaddr(self):
return llmemory.cast_ptr_to_adr(self.value)
def _get_hash_(self):
@@ -694,6 +673,13 @@
except lltype.DelayedPointer:
return -2 # xxx risk of changing hash...
+def make_hashable_int(i):
+ if not we_are_translated() and isinstance(i, llmemory.AddressAsInt):
+ # Warning: such a hash changes at the time of translation
+ adr = heaptracker.int2adr(i)
+ return llmemory.cast_adr_to_int(adr, "emulated")
+ return i
+
# ____________________________________________________________
# The TreeLoop class contains a loop or a generalized loop, i.e. a tree
@@ -845,16 +831,6 @@
op = ResOperation(opnum, argboxes, resbox, descr)
self.operations[position] = op
- def slice_history_at(self, position):
- """ a strange function that does this:
- history : operation_at_position : rest
- it'll kill operation_at_position, store everything before that
- in history.operations and return rest
- """
- rest = self.operations[position + 1:]
- del self.operations[position:]
- return rest
-
# ____________________________________________________________
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/jitprof.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/jitprof.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/jitprof.py Tue Jun 8 19:48:40 2010
@@ -5,6 +5,7 @@
import os
import time
from pypy.rlib.debug import debug_print
+from pypy.jit.metainterp.jitexc import JitException
counters="""
TRACING
@@ -13,7 +14,6 @@
BLACKHOLE
OPS
RECORDED_OPS
-BLACKHOLED_OPS
GUARDS
OPT_OPS
OPT_GUARDS
@@ -34,7 +34,7 @@
ncounters = len(names)
_setup()
-JITPROF_LINES = ncounters + 1 + 5 # one for TOTAL, 5 for calls, update if needed
+JITPROF_LINES = ncounters + 1 + 4 # one for TOTAL, 4 for calls, update if needed
class BaseProfiler(object):
pass
@@ -97,7 +97,7 @@
self.t1 = self.starttime
self.times = [0, 0]
self.counters = [0] * ncounters
- self.calls = [[0, 0], [0, 0], [0, 0]]
+ self.calls = [[0, 0], [0, 0]]
self.current = []
def finish(self):
@@ -150,10 +150,10 @@
def count_ops(self, opnum, kind=OPS):
from pypy.jit.metainterp.resoperation import rop
self.counters[kind] += 1
- if opnum == rop.CALL or opnum == rop.OOSEND:
+ if opnum == rop.CALL: # or opnum == rop.OOSEND:
self.calls[kind-OPS][0] += 1
- elif opnum == rop.CALL_PURE or opnum == rop.OOSEND_PURE:
- self.calls[kind-OPS][1] += 1
+ elif opnum == rop.CALL_PURE: # or opnum == rop.OOSEND_PURE:
+ self.calls[kind-OPS][1] += 1
def print_stats(self):
cnt = self.counters
@@ -172,8 +172,6 @@
self._print_intline(" calls", calls[1][0])
self._print_intline(" pure calls", calls[1][1])
self._print_intline("guards", cnt[GUARDS])
- self._print_intline("blackholed ops", calls[2][0])
- self._print_intline(" pure calls", calls[2][1])
self._print_intline("opt ops", cnt[OPT_OPS])
self._print_intline("opt guards", cnt[OPT_GUARDS])
self._print_intline("forcings", cnt[OPT_FORCINGS])
@@ -195,5 +193,5 @@
-class BrokenProfilerData(Exception):
+class BrokenProfilerData(JitException):
pass
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/logger.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/logger.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/logger.py Tue Jun 8 19:48:40 2010
@@ -1,9 +1,11 @@
import os
from pypy.rlib.debug import have_debug_prints
from pypy.rlib.debug import debug_start, debug_stop, debug_print
+from pypy.rlib.objectmodel import we_are_translated
+from pypy.rpython.lltypesystem import lltype, llmemory, rffi
from pypy.jit.metainterp.resoperation import rop
from pypy.jit.metainterp.history import Const, ConstInt, Box, \
- BoxInt, ConstAddr, ConstFloat, BoxFloat, AbstractFailDescr
+ BoxInt, ConstFloat, BoxFloat, AbstractFailDescr
class Logger(object):
@@ -46,10 +48,16 @@
mv = len(memo)
memo[arg] = mv
if isinstance(arg, ConstInt):
+ if int_could_be_an_address(arg.value):
+ addr = arg.getaddr()
+ name = self.metainterp_sd.get_name_from_address(addr)
+ if name:
+ return 'ConstClass(' + name + ')'
return str(arg.value)
elif isinstance(arg, BoxInt):
return 'i' + str(mv)
elif isinstance(arg, self.ts.ConstRef):
+ # XXX for ootype, this should also go through get_name_from_address
return 'ConstPtr(ptr' + str(mv) + ')'
elif isinstance(arg, self.ts.BoxRef):
return 'p' + str(mv)
@@ -57,12 +65,6 @@
return str(arg.value)
elif isinstance(arg, BoxFloat):
return 'f' + str(mv)
- elif isinstance(arg, self.ts.ConstAddr):
- addr = arg.getaddr(self.metainterp_sd.cpu)
- name = self.metainterp_sd.get_name_from_address(addr)
- if not name:
- name = 'cls' + str(mv)
- return 'ConstClass(' + name + ')'
elif arg is None:
return 'None'
else:
@@ -102,3 +104,11 @@
fail_args = ''
debug_print(res + op.getopname() +
'(' + args + ')' + fail_args)
+
+
+def int_could_be_an_address(x):
+ if we_are_translated():
+ x = rffi.cast(lltype.Signed, x) # force it
+ return not (-32768 <= x <= 32767)
+ else:
+ return isinstance(x, llmemory.AddressAsInt)
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/optimizefindnode.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/optimizefindnode.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/optimizefindnode.py Tue Jun 8 19:48:40 2010
@@ -160,7 +160,8 @@
else:
# all constant arguments: we can constant-fold
argboxes = [self.get_constant_box(arg) for arg in op.args]
- resbox = execute_nonspec(self.cpu, op.opnum, argboxes, op.descr)
+ resbox = execute_nonspec(self.cpu, None,
+ op.opnum, argboxes, op.descr)
self.set_constant_node(op.result, resbox.constbox())
# default case: mark the arguments as escaping
for box in op.args:
@@ -169,8 +170,8 @@
def find_nodes_no_escape(self, op):
pass # for operations that don't escape their arguments
- find_nodes_OOIS = find_nodes_no_escape
- find_nodes_OOISNOT = find_nodes_no_escape
+ find_nodes_PTR_EQ = find_nodes_no_escape
+ find_nodes_PTR_NE = find_nodes_no_escape
find_nodes_INSTANCEOF = find_nodes_no_escape
find_nodes_GUARD_NONNULL = find_nodes_no_escape
find_nodes_GUARD_ISNULL = find_nodes_no_escape
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/optimizeopt.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/optimizeopt.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/optimizeopt.py Tue Jun 8 19:48:40 2010
@@ -16,7 +16,7 @@
from pypy.jit.metainterp.typesystem import llhelper, oohelper
from pypy.rlib.objectmodel import we_are_translated
from pypy.rpython.lltypesystem import lltype
-from pypy.jit.metainterp.history import AbstractDescr
+from pypy.jit.metainterp.history import AbstractDescr, make_hashable_int
def optimize_loop_1(metainterp_sd, loop):
"""Optimize loop.operations to make it match the input of loop.specnodes
@@ -89,7 +89,7 @@
if level == LEVEL_KNOWNCLASS:
return self.known_class
elif level == LEVEL_CONSTANT:
- return cpu.ts.cls_of_box(cpu, self.box)
+ return cpu.ts.cls_of_box(self.box)
else:
return None
@@ -564,7 +564,7 @@
modifier = resume.ResumeDataVirtualAdder(descr, self.resumedata_memo)
newboxes = modifier.finish(self.values, pendingfields)
if len(newboxes) > self.metainterp_sd.options.failargs_limit: # XXX be careful here
- raise compile.GiveUp
+ compile.giveup()
descr.store_final_boxes(op, newboxes)
#
if op.opnum == rop.GUARD_VALUE:
@@ -594,7 +594,8 @@
else:
# all constant arguments: constant-fold away
argboxes = [self.get_constant_box(arg) for arg in op.args]
- resbox = execute_nonspec(self.cpu, op.opnum, argboxes, op.descr)
+ resbox = execute_nonspec(self.cpu, None,
+ op.opnum, argboxes, op.descr)
self.make_constant(op.result, resbox.constbox())
return
@@ -747,6 +748,9 @@
def optimize_INT_IS_TRUE(self, op):
self._optimize_nullness(op, op.args[0], True)
+ def optimize_INT_IS_ZERO(self, op):
+ self._optimize_nullness(op, op.args[0], False)
+
def _optimize_oois_ooisnot(self, op, expect_isnot):
value0 = self.getvalue(op.args[0])
value1 = self.getvalue(op.args[1])
@@ -775,10 +779,10 @@
return
self.optimize_default(op)
- def optimize_OOISNOT(self, op):
+ def optimize_PTR_NE(self, op):
self._optimize_oois_ooisnot(op, True)
- def optimize_OOIS(self, op):
+ def optimize_PTR_EQ(self, op):
self._optimize_oois_ooisnot(op, False)
def optimize_VIRTUAL_REF(self, op):
@@ -944,7 +948,8 @@
if not funcvalue.is_constant():
self.optimize_default(op)
return
- resvalue = self.loop_invariant_results.get(op.args[0].getint(), None)
+ key = make_hashable_int(op.args[0].getint())
+ resvalue = self.loop_invariant_results.get(key, None)
if resvalue is not None:
self.make_equal_to(op.result, resvalue)
return
@@ -953,7 +958,7 @@
op.opnum = rop.CALL
self.optimize_default(op)
resvalue = self.getvalue(op.result)
- self.loop_invariant_results[op.args[0].getint()] = resvalue
+ self.loop_invariant_results[key] = resvalue
def optimize_INT_AND(self, op):
v1 = self.getvalue(op.args[0])
@@ -1101,7 +1106,7 @@
del self.cached_arrayitems[arraydescr]
except KeyError:
pass
- if effectinfo.forces_virtual_or_virtualizable:
+ if effectinfo.check_forces_virtual_or_virtualizable():
vrefinfo = self.optimizer.metainterp_sd.virtualref_info
self.force_lazy_setfield(vrefinfo.descr_forced)
# ^^^ we only need to force this field; the other fields
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/optimizeutil.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/optimizeutil.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/optimizeutil.py Tue Jun 8 19:48:40 2010
@@ -2,8 +2,9 @@
from pypy.rlib.rarithmetic import intmask
from pypy.rlib.unroll import unrolling_iterable
from pypy.jit.metainterp import resoperation, history
+from pypy.jit.metainterp.jitexc import JitException
-class InvalidLoop(Exception):
+class InvalidLoop(JitException):
"""Raised when the optimize*.py detect that the loop that
we are trying to build cannot possibly make sense as a
long-running loop (e.g. it cannot run 2 complete iterations)."""
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/pyjitpl.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/pyjitpl.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/pyjitpl.py Tue Jun 8 19:48:40 2010
@@ -1,205 +1,170 @@
import py, os
-from pypy.rpython.lltypesystem import llmemory
-from pypy.rpython.ootypesystem import ootype
+from pypy.rpython.lltypesystem import lltype, llmemory, rclass
from pypy.rlib.objectmodel import we_are_translated
from pypy.rlib.unroll import unrolling_iterable
from pypy.rlib.debug import debug_start, debug_stop, debug_print
+from pypy.rlib.debug import make_sure_not_resized
+from pypy.rlib import nonconst
from pypy.jit.metainterp import history, compile, resume
-from pypy.jit.metainterp.history import Const, ConstInt, Box
+from pypy.jit.metainterp.history import Const, ConstInt, ConstPtr, ConstFloat
+from pypy.jit.metainterp.history import Box
from pypy.jit.metainterp.resoperation import rop
-from pypy.jit.metainterp import codewriter, executor
+from pypy.jit.metainterp import executor
from pypy.jit.metainterp.logger import Logger
-from pypy.jit.metainterp.jitprof import BLACKHOLED_OPS, EmptyProfiler
+from pypy.jit.metainterp.jitprof import EmptyProfiler
from pypy.jit.metainterp.jitprof import GUARDS, RECORDED_OPS, ABORT_ESCAPE
from pypy.jit.metainterp.jitprof import ABORT_TOO_LONG, ABORT_BRIDGE
+from pypy.jit.metainterp.jitexc import JitException, get_llexception
from pypy.rlib.rarithmetic import intmask
from pypy.rlib.objectmodel import specialize
from pypy.rlib.jit import DEBUG_OFF, DEBUG_PROFILE, DEBUG_STEPS, DEBUG_DETAILED
-from pypy.jit.metainterp.compile import GiveUp
+from pypy.jit.codewriter.jitcode import JitCode, SwitchDictDescr
+from pypy.jit.codewriter import heaptracker
# ____________________________________________________________
-def check_args(*args):
- for arg in args:
- assert isinstance(arg, (Box, Const))
-
-class arguments(object):
- def __init__(self, *argtypes):
- self.argtypes = argtypes
-
- def __eq__(self, other):
- if not isinstance(other, arguments):
- return NotImplemented
- return self.argtypes == other.argtypes
-
- def __ne__(self, other):
- if not isinstance(other, arguments):
- return NotImplemented
- return self.argtypes != other.argtypes
-
- def __call__(self, func):
- argtypes = unrolling_iterable(self.argtypes)
- def wrapped(self, orgpc):
- args = (self, )
- for argspec in argtypes:
- if argspec == "box":
- box = self.load_arg()
- args += (box, )
- elif argspec == "constbox":
- args += (self.load_const_arg(), )
- elif argspec == "int":
- args += (self.load_int(), )
- elif argspec == "jumptarget":
- args += (self.load_3byte(), )
- elif argspec == "jumptargets":
- num = self.load_int()
- args += ([self.load_3byte() for i in range(num)], )
- elif argspec == "varargs":
- args += (self.load_varargs(), )
- elif argspec == "constargs":
- args += (self.load_constargs(), )
- elif argspec == "descr":
- descr = self.load_const_arg()
- assert isinstance(descr, history.AbstractDescr)
- args += (descr, )
- elif argspec == "bytecode":
- bytecode = self.load_const_arg()
- assert isinstance(bytecode, codewriter.JitCode)
- args += (bytecode, )
- elif argspec == "orgpc":
- args += (orgpc, )
- elif argspec == "methdescr":
- methdescr = self.load_const_arg()
- assert isinstance(methdescr,
- history.AbstractMethDescr)
- args += (methdescr, )
- else:
- assert 0, "unknown argtype declaration: %r" % (argspec,)
- val = func(*args)
- if val is None:
- val = False
- return val
- name = func.func_name
- wrapped.func_name = "wrap_" + name
- wrapped.argspec = self
- return wrapped
+def arguments(*args):
+ def decorate(func):
+ func.argtypes = args
+ return func
+ return decorate
# ____________________________________________________________
class MIFrame(object):
- exception_box = None
- exc_value_box = None
- # for resume.py operation
- parent_resumedata_snapshot = None
- parent_resumedata_frame_info_list = None
- def __init__(self, metainterp, jitcode, greenkey=None):
- assert isinstance(jitcode, codewriter.JitCode)
+ def __init__(self, metainterp):
self.metainterp = metainterp
+ self.registers_i = [None] * 256
+ self.registers_r = [None] * 256
+ self.registers_f = [None] * 256
+
+ def setup(self, jitcode, greenkey=None):
+ assert isinstance(jitcode, JitCode)
self.jitcode = jitcode
self.bytecode = jitcode.code
- self.constants = jitcode.constants
- self.exception_target = -1
- self.name = jitcode.name # purely for having name attribute
# this is not None for frames that are recursive portal calls
self.greenkey = greenkey
+ # copy the constants in place
+ self.copy_constants(self.registers_i, jitcode.constants_i, ConstInt)
+ self.copy_constants(self.registers_r, jitcode.constants_r, ConstPtr)
+ self.copy_constants(self.registers_f, jitcode.constants_f, ConstFloat)
+ self._result_argcode = 'v'
+ # for resume.py operation
+ self.parent_resumedata_snapshot = None
+ self.parent_resumedata_frame_info_list = None
+
+ def copy_constants(self, registers, constants, ConstClass):
+ """Copy jitcode.constants[0] to registers[255],
+ jitcode.constants[1] to registers[254],
+ jitcode.constants[2] to registers[253], etc."""
+ if nonconst.NonConstant(0): # force the right type
+ constants[0] = ConstClass.value # (useful for small tests)
+ i = len(constants) - 1
+ while i >= 0:
+ j = 255 - i
+ assert j >= 0
+ registers[j] = ConstClass(constants[i])
+ i -= 1
+ copy_constants._annspecialcase_ = 'specialize:arg(3)'
+
+ def cleanup_registers(self):
+ # To avoid keeping references alive, this cleans up the registers_r.
+ # It does not clear the references set by copy_constants(), but
+ # these are all prebuilt constants anyway.
+ for i in range(self.jitcode.num_regs_r()):
+ self.registers_r[i] = None
# ------------------------------
# Decoding of the JitCode
- def load_int(self):
- pc = self.pc
- result = ord(self.bytecode[pc])
- self.pc = pc + 1
- if result > 0x7F:
- result = self._load_larger_int(result)
- return result
-
- def _load_larger_int(self, result): # slow path
- result = result & 0x7F
- shift = 7
- pc = self.pc
- while 1:
- byte = ord(self.bytecode[pc])
- pc += 1
- result += (byte & 0x7F) << shift
- shift += 7
- if not byte & 0x80:
- break
- self.pc = pc
- return intmask(result)
- _load_larger_int._dont_inline_ = True
-
- def load_3byte(self):
- pc = self.pc
- result = (((ord(self.bytecode[pc + 0])) << 16) |
- ((ord(self.bytecode[pc + 1])) << 8) |
- ((ord(self.bytecode[pc + 2])) << 0))
- self.pc = pc + 3
- return result
-
- def load_bool(self):
- pc = self.pc
- result = ord(self.bytecode[pc])
- self.pc = pc + 1
- return bool(result)
-
- def getenv(self, i):
- assert i >= 0
- j = i >> 1
- if i & 1:
- return self.constants[j]
- else:
- assert j < len(self.env)
- return self.env[j]
-
- def load_arg(self):
- return self.getenv(self.load_int())
-
- def load_const_arg(self):
- return self.constants[self.load_int()]
-
- def load_varargs(self):
- count = self.load_int()
- return [self.load_arg() for i in range(count)]
-
- def load_constargs(self):
- count = self.load_int()
- return [self.load_const_arg() for i in range(count)]
-
- def ignore_varargs(self):
- count = self.load_int()
+ def prepare_list_of_boxes(self, outvalue, startindex, position, argcode):
+ assert argcode in 'IRF'
+ code = self.bytecode
+ length = ord(code[position])
+ position += 1
+ for i in range(length):
+ index = ord(code[position+i])
+ if argcode == 'I': reg = self.registers_i[index]
+ elif argcode == 'R': reg = self.registers_r[index]
+ elif argcode == 'F': reg = self.registers_f[index]
+ else: raise AssertionError(argcode)
+ outvalue[startindex+i] = reg
+ prepare_list_of_boxes._annspecialcase_ = 'specialize:arg(4)'
+
+ def get_current_position_info(self):
+ return self.jitcode.get_live_vars_info(self.pc)
+
+ def get_list_of_active_boxes(self, in_a_call):
+ if in_a_call:
+ # If we are not the topmost frame, self._result_argcode contains
+ # the type of the result of the call instruction in the bytecode.
+ # We use it to clear the box that will hold the result: this box
+ # is not defined yet.
+ argcode = self._result_argcode
+ index = ord(self.bytecode[self.pc - 1])
+ if argcode == 'i': self.registers_i[index] = history.CONST_FALSE
+ elif argcode == 'r': self.registers_r[index] = history.CONST_NULL
+ elif argcode == 'f': self.registers_f[index] = history.CONST_FZERO
+ self._result_argcode = '?' # done
+ #
+ info = self.get_current_position_info()
+ start_i = 0
+ start_r = start_i + info.get_register_count_i()
+ start_f = start_r + info.get_register_count_r()
+ total = start_f + info.get_register_count_f()
+ # allocate a list of the correct size
+ env = [None] * total
+ make_sure_not_resized(env)
+ # fill it now
+ for i in range(info.get_register_count_i()):
+ index = info.get_register_index_i(i)
+ env[start_i + i] = self.registers_i[index]
+ for i in range(info.get_register_count_r()):
+ index = info.get_register_index_r(i)
+ env[start_r + i] = self.registers_r[index]
+ for i in range(info.get_register_count_f()):
+ index = info.get_register_index_f(i)
+ env[start_f + i] = self.registers_f[index]
+ return env
+
+ def replace_active_box_in_frame(self, oldbox, newbox):
+ if isinstance(oldbox, history.BoxInt):
+ count = self.jitcode.num_regs_i()
+ registers = self.registers_i
+ elif isinstance(oldbox, history.BoxPtr):
+ count = self.jitcode.num_regs_r()
+ registers = self.registers_r
+ elif isinstance(oldbox, history.BoxFloat):
+ count = self.jitcode.num_regs_f()
+ registers = self.registers_f
+ else:
+ assert 0, oldbox
for i in range(count):
- self.load_int()
-
- def getvarenv(self, i):
- return self.env[i]
+ if registers[i] is oldbox:
+ registers[i] = newbox
+ if not we_are_translated():
+ assert oldbox not in registers[count:]
- def make_result_box(self, box):
- assert isinstance(box, Box) or isinstance(box, Const)
- self.env.append(box)
+ def make_result_of_lastop(self, resultbox):
+ if resultbox is None:
+ return
+ target_index = ord(self.bytecode[self.pc-1])
+ if resultbox.type == history.INT:
+ self.registers_i[target_index] = resultbox
+ elif resultbox.type == history.REF:
+ #debug_print(' ->',
+ # llmemory.cast_ptr_to_adr(resultbox.getref_base()))
+ self.registers_r[target_index] = resultbox
+ elif resultbox.type == history.FLOAT:
+ self.registers_f[target_index] = resultbox
+ else:
+ raise AssertionError("bad result box type")
# ------------------------------
- for _n in range(codewriter.MAX_MAKE_NEW_VARS):
- _decl = ', '.join(["'box'" for _i in range(_n)])
- _allargs = ', '.join(["box%d" % _i for _i in range(_n)])
- exec py.code.Source("""
- @arguments(%s)
- def opimpl_make_new_vars_%d(self, %s):
- if not we_are_translated():
- check_args(%s)
- self.env = [%s]
- """ % (_decl, _n, _allargs, _allargs, _allargs)).compile()
-
- @arguments("varargs")
- def opimpl_make_new_vars(self, newenv):
- if not we_are_translated():
- check_args(*newenv)
- self.env = newenv
-
for _opimpl in ['int_add', 'int_sub', 'int_mul', 'int_floordiv', 'int_mod',
'int_lt', 'int_le', 'int_eq',
'int_ne', 'int_gt', 'int_ge',
@@ -210,175 +175,241 @@
'float_add', 'float_sub', 'float_mul', 'float_truediv',
'float_lt', 'float_le', 'float_eq',
'float_ne', 'float_gt', 'float_ge',
+ 'ptr_eq', 'ptr_ne',
]:
exec py.code.Source('''
@arguments("box", "box")
def opimpl_%s(self, b1, b2):
- self.execute(rop.%s, b1, b2)
+ return self.execute(rop.%s, b1, b2)
''' % (_opimpl, _opimpl.upper())).compile()
for _opimpl in ['int_add_ovf', 'int_sub_ovf', 'int_mul_ovf']:
exec py.code.Source('''
@arguments("box", "box")
def opimpl_%s(self, b1, b2):
- self.execute(rop.%s, b1, b2)
- return self.metainterp.handle_overflow_error()
+ self.metainterp.clear_exception()
+ resbox = self.execute(rop.%s, b1, b2)
+ self.make_result_of_lastop(resbox) # same as execute_varargs()
+ self.metainterp.handle_possible_overflow_error()
+ return resbox
''' % (_opimpl, _opimpl.upper())).compile()
- for _opimpl in ['int_is_true', 'int_neg', 'int_invert', 'bool_not',
- 'cast_ptr_to_int', 'cast_float_to_int',
- 'cast_int_to_float', 'float_neg', 'float_abs',
- 'float_is_true',
+ for _opimpl in ['int_is_true', 'int_is_zero', 'int_neg', 'int_invert',
+ 'cast_float_to_int', 'cast_int_to_float',
+ 'float_neg', 'float_abs',
]:
exec py.code.Source('''
@arguments("box")
def opimpl_%s(self, b):
- self.execute(rop.%s, b)
+ return self.execute(rop.%s, b)
''' % (_opimpl, _opimpl.upper())).compile()
- @arguments()
- def opimpl_return(self):
- assert len(self.env) == 1
- return self.metainterp.finishframe(self.env[0])
+ @arguments("box")
+ def opimpl_ptr_nonzero(self, box):
+ return self.execute(rop.PTR_NE, box, history.CONST_NULL)
+
+ @arguments("box")
+ def opimpl_ptr_iszero(self, box):
+ return self.execute(rop.PTR_EQ, box, history.CONST_NULL)
+
+ @arguments("box")
+ def _opimpl_any_return(self, box):
+ self.metainterp.finishframe(box)
+
+ opimpl_int_return = _opimpl_any_return
+ opimpl_ref_return = _opimpl_any_return
+ opimpl_float_return = _opimpl_any_return
@arguments()
def opimpl_void_return(self):
- assert len(self.env) == 0
- return self.metainterp.finishframe(None)
+ self.metainterp.finishframe(None)
+
+ @arguments("box")
+ def _opimpl_any_copy(self, box):
+ return box
+
+ opimpl_int_copy = _opimpl_any_copy
+ opimpl_ref_copy = _opimpl_any_copy
+ opimpl_float_copy = _opimpl_any_copy
+
+ @arguments("box")
+ def _opimpl_any_push(self, box):
+ self.pushed_box = box
+
+ opimpl_int_push = _opimpl_any_push
+ opimpl_ref_push = _opimpl_any_push
+ opimpl_float_push = _opimpl_any_push
- @arguments("jumptarget")
+ @arguments()
+ def _opimpl_any_pop(self):
+ box = self.pushed_box
+ self.pushed_box = None
+ return box
+
+ opimpl_int_pop = _opimpl_any_pop
+ opimpl_ref_pop = _opimpl_any_pop
+ opimpl_float_pop = _opimpl_any_pop
+
+ @arguments("label")
+ def opimpl_catch_exception(self, target):
+ """This is a no-op when run normally. We can check that
+ last_exc_value_box is None; it should have been set to None
+ by the previous instruction. If the previous instruction
+ raised instead, finishframe_exception() should have been
+ called and we would not be there."""
+ assert self.metainterp.last_exc_value_box is None
+
+ @arguments("label")
def opimpl_goto(self, target):
self.pc = target
- @arguments("orgpc", "jumptarget", "box", "varargs")
- def opimpl_goto_if_not(self, pc, target, box, livelist):
+ @arguments("box", "label")
+ def opimpl_goto_if_not(self, box, target):
switchcase = box.getint()
if switchcase:
opnum = rop.GUARD_TRUE
else:
- self.pc = target
opnum = rop.GUARD_FALSE
- self.env = livelist
- self.generate_guard(pc, opnum, box)
- # note about handling self.env explicitly here: it is done in
- # such a way that the 'box' on which we generate the guard is
- # typically not included in the livelist.
-
- def follow_jump(self):
- _op_goto_if_not = self.metainterp.staticdata._op_goto_if_not
- assert ord(self.bytecode[self.pc]) == _op_goto_if_not
- self.pc += 1 # past the bytecode for 'goto_if_not'
- target = self.load_3byte() # load the 'target' argument
- self.pc = target # jump
-
- def ignore_next_guard_nullness(self, opnum):
- _op_ooisnull = self.metainterp.staticdata._op_ooisnull
- _op_oononnull = self.metainterp.staticdata._op_oononnull
- bc = ord(self.bytecode[self.pc])
- if bc == _op_ooisnull:
- if opnum == rop.GUARD_ISNULL:
- res = ConstInt(0)
- else:
- res = ConstInt(1)
+ self.generate_guard(opnum, box)
+ if not switchcase:
+ self.pc = target
+
+ @arguments("box", "label")
+ def opimpl_goto_if_not_int_is_true(self, box, target):
+ condbox = self.execute(rop.INT_IS_TRUE, box)
+ self.opimpl_goto_if_not(condbox, target)
+
+ @arguments("box", "label")
+ def opimpl_goto_if_not_int_is_zero(self, box, target):
+ condbox = self.execute(rop.INT_IS_ZERO, box)
+ self.opimpl_goto_if_not(condbox, target)
+
+ for _opimpl in ['int_lt', 'int_le', 'int_eq', 'int_ne', 'int_gt', 'int_ge',
+ 'ptr_eq', 'ptr_ne']:
+ exec py.code.Source('''
+ @arguments("box", "box", "label")
+ def opimpl_goto_if_not_%s(self, b1, b2, target):
+ condbox = self.execute(rop.%s, b1, b2)
+ self.opimpl_goto_if_not(condbox, target)
+ ''' % (_opimpl, _opimpl.upper())).compile()
+
+ @arguments("orgpc", "box", "label")
+ def opimpl_goto_if_not_ptr_nonzero(self, orgpc, box, target):
+ value = box.nonnull()
+ if value:
+ opnum = rop.GUARD_NONNULL
else:
- assert bc == _op_oononnull
- if opnum == rop.GUARD_ISNULL:
- res = ConstInt(1)
- else:
- res = ConstInt(0)
- self.pc += 1 # past the bytecode for ptr_iszero/ptr_nonzero
- self.load_int() # past the 'box' argument
- self.make_result_box(res)
-
- def dont_follow_jump(self):
- _op_goto_if_not = self.metainterp.staticdata._op_goto_if_not
- assert ord(self.bytecode[self.pc]) == _op_goto_if_not
- self.pc += 1 # past the bytecode for 'goto_if_not'
- self.load_3byte() # past the 'target' argument
- self.load_int() # past the 'box' argument
- self.ignore_varargs() # past the 'livelist' argument
-
- @arguments("orgpc", "box", "constargs", "jumptargets")
- def opimpl_switch(self, pc, valuebox, constargs, jumptargets):
- box = self.implement_guard_value(pc, valuebox)
- for i in range(len(constargs)):
- casebox = constargs[i]
- if box.same_constant(casebox):
- self.pc = jumptargets[i]
- break
-
- @arguments("orgpc", "box", "constbox")
- def opimpl_switch_dict(self, pc, valuebox, switchdict):
- box = self.implement_guard_value(pc, valuebox)
+ opnum = rop.GUARD_ISNULL
+ self.generate_guard(opnum, box, resumepc=orgpc)
+ if not value:
+ self.pc = target
+
+ @arguments("orgpc", "box", "label")
+ def opimpl_goto_if_not_ptr_iszero(self, orgpc, box, target):
+ value = box.nonnull()
+ if value:
+ opnum = rop.GUARD_NONNULL
+ else:
+ opnum = rop.GUARD_ISNULL
+ self.generate_guard(opnum, box, resumepc=orgpc)
+ if value:
+ self.pc = target
+
+ @arguments("box", "descr", "orgpc")
+ def opimpl_switch(self, valuebox, switchdict, orgpc):
+ box = self.implement_guard_value(orgpc, valuebox)
search_value = box.getint()
- assert isinstance(switchdict, codewriter.SwitchDict)
+ assert isinstance(switchdict, SwitchDictDescr)
try:
self.pc = switchdict.dict[search_value]
except KeyError:
pass
- @arguments("descr")
- def opimpl_new(self, size):
- self.execute_with_descr(rop.NEW, descr=size)
-
- @arguments("constbox")
- def opimpl_new_with_vtable(self, vtablebox):
- self.execute(rop.NEW_WITH_VTABLE, vtablebox)
+ @arguments()
+ def opimpl_unreachable(self):
+ raise AssertionError("unreachable")
- @arguments("box")
- def opimpl_runtimenew(self, classbox):
- self.execute(rop.RUNTIMENEW, classbox)
+ @arguments("descr")
+ def opimpl_new(self, sizedescr):
+ return self.execute_with_descr(rop.NEW, sizedescr)
- @arguments("orgpc", "box", "descr")
- def opimpl_instanceof(self, pc, objbox, typedescr):
- clsbox = self.cls_of_box(objbox)
- if isinstance(objbox, Box):
- self.generate_guard(pc, rop.GUARD_CLASS, objbox, [clsbox])
- self.execute_with_descr(rop.INSTANCEOF, typedescr, objbox)
+ @arguments("descr")
+ def opimpl_new_with_vtable(self, sizedescr):
+ cpu = self.metainterp.cpu
+ cls = heaptracker.descr2vtable(cpu, sizedescr)
+ return self.execute(rop.NEW_WITH_VTABLE, ConstInt(cls))
- @arguments("box", "box")
- def opimpl_subclassof(self, box1, box2):
- self.execute(rop.SUBCLASSOF, box1, box2)
+## @FixME #arguments("box")
+## def opimpl_runtimenew(self, classbox):
+## self.execute(rop.RUNTIMENEW, classbox)
+
+## @FixME #arguments("orgpc", "box", "descr")
+## def opimpl_instanceof(self, pc, objbox, typedescr):
+## clsbox = self.cls_of_box(objbox)
+## if isinstance(objbox, Box):
+## self.generate_guard(pc, rop.GUARD_CLASS, objbox, [clsbox])
+## self.execute_with_descr(rop.INSTANCEOF, typedescr, objbox)
+
+## @FixME #arguments("box", "box")
+## def opimpl_subclassof(self, box1, box2):
+## self.execute(rop.SUBCLASSOF, box1, box2)
@arguments("descr", "box")
- def opimpl_new_array(self, itemsize, countbox):
- self.execute_with_descr(rop.NEW_ARRAY, itemsize, countbox)
+ def opimpl_new_array(self, itemsizedescr, countbox):
+ return self.execute_with_descr(rop.NEW_ARRAY, itemsizedescr, countbox)
@arguments("box", "descr", "box")
- def opimpl_getarrayitem_gc(self, arraybox, arraydesc, indexbox):
- self.execute_with_descr(rop.GETARRAYITEM_GC, arraydesc, arraybox, indexbox)
+ def _opimpl_getarrayitem_gc_any(self, arraybox, arraydescr, indexbox):
+ return self.execute_with_descr(rop.GETARRAYITEM_GC,
+ arraydescr, arraybox, indexbox)
+
+ opimpl_getarrayitem_gc_i = _opimpl_getarrayitem_gc_any
+ opimpl_getarrayitem_gc_r = _opimpl_getarrayitem_gc_any
+ opimpl_getarrayitem_gc_f = _opimpl_getarrayitem_gc_any
@arguments("box", "descr", "box")
- def opimpl_getarrayitem_gc_pure(self, arraybox, arraydesc, indexbox):
- self.execute_with_descr(rop.GETARRAYITEM_GC_PURE, arraydesc, arraybox, indexbox)
+ def _opimpl_getarrayitem_gc_pure_any(self, arraybox, arraydescr, indexbox):
+ return self.execute_with_descr(rop.GETARRAYITEM_GC_PURE,
+ arraydescr, arraybox, indexbox)
+
+ opimpl_getarrayitem_gc_pure_i = _opimpl_getarrayitem_gc_pure_any
+ opimpl_getarrayitem_gc_pure_r = _opimpl_getarrayitem_gc_pure_any
+ opimpl_getarrayitem_gc_pure_f = _opimpl_getarrayitem_gc_pure_any
@arguments("box", "descr", "box", "box")
- def opimpl_setarrayitem_gc(self, arraybox, arraydesc, indexbox, itembox):
- self.execute_with_descr(rop.SETARRAYITEM_GC, arraydesc, arraybox, indexbox, itembox)
+ def _opimpl_setarrayitem_gc_any(self, arraybox, arraydescr,
+ indexbox, itembox):
+ self.execute_with_descr(rop.SETARRAYITEM_GC, arraydescr, arraybox,
+ indexbox, itembox)
+
+ opimpl_setarrayitem_gc_i = _opimpl_setarrayitem_gc_any
+ opimpl_setarrayitem_gc_r = _opimpl_setarrayitem_gc_any
+ opimpl_setarrayitem_gc_f = _opimpl_setarrayitem_gc_any
@arguments("box", "descr")
- def opimpl_arraylen_gc(self, arraybox, arraydesc):
- self.execute_with_descr(rop.ARRAYLEN_GC, arraydesc, arraybox)
+ def opimpl_arraylen_gc(self, arraybox, arraydescr):
+ return self.execute_with_descr(rop.ARRAYLEN_GC, arraydescr, arraybox)
@arguments("descr", "box", "box", "box", "box", "box", "box", "descr")
def opimpl_arraycopy(self, calldescr, fnptr, sourcebox, destbox,
- source_startbox, dest_startbox, lengthbox, arraydescr):
+ source_startbox, dest_startbox, lengthbox,
+ arraydescr):
self.execute_with_descr(rop.ARRAYCOPY, arraydescr, calldescr, fnptr,
sourcebox, destbox, source_startbox,
dest_startbox, lengthbox)
@arguments("orgpc", "box", "descr", "box")
- def opimpl_check_neg_index(self, pc, arraybox, arraydesc, indexbox):
+ def opimpl_check_neg_index(self, orgpc, arraybox, arraydescr, indexbox):
negbox = self.metainterp.execute_and_record(
- rop.INT_LT, None, indexbox, ConstInt(0))
- negbox = self.implement_guard_value(pc, negbox)
+ rop.INT_LT, None, indexbox, history.CONST_FALSE)
+ negbox = self.implement_guard_value(orgpc, negbox)
if negbox.getint():
# the index is < 0; add the array length to it
lenbox = self.metainterp.execute_and_record(
- rop.ARRAYLEN_GC, arraydesc, arraybox)
+ rop.ARRAYLEN_GC, arraydescr, arraybox)
indexbox = self.metainterp.execute_and_record(
rop.INT_ADD, None, indexbox, lenbox)
- self.make_result_box(indexbox)
+ return indexbox
@arguments("descr", "descr", "descr", "descr", "box")
def opimpl_newlist(self, structdescr, lengthdescr, itemsdescr, arraydescr,
@@ -390,131 +421,87 @@
sizebox)
self.metainterp.execute_and_record(rop.SETFIELD_GC, itemsdescr,
sbox, abox)
- self.make_result_box(sbox)
+ return sbox
@arguments("box", "descr", "descr", "box")
- def opimpl_getlistitem_gc(self, listbox, itemsdescr, arraydescr, indexbox):
+ def _opimpl_getlistitem_gc_any(self, listbox, itemsdescr, arraydescr,
+ indexbox):
arraybox = self.metainterp.execute_and_record(rop.GETFIELD_GC,
itemsdescr, listbox)
- self.execute_with_descr(rop.GETARRAYITEM_GC, arraydescr, arraybox, indexbox)
+ return self.execute_with_descr(rop.GETARRAYITEM_GC,
+ arraydescr, arraybox, indexbox)
+
+ opimpl_getlistitem_gc_i = _opimpl_getlistitem_gc_any
+ opimpl_getlistitem_gc_r = _opimpl_getlistitem_gc_any
+ opimpl_getlistitem_gc_f = _opimpl_getlistitem_gc_any
@arguments("box", "descr", "descr", "box", "box")
- def opimpl_setlistitem_gc(self, listbox, itemsdescr, arraydescr, indexbox,
- valuebox):
+ def _opimpl_setlistitem_gc_any(self, listbox, itemsdescr, arraydescr,
+ indexbox, valuebox):
arraybox = self.metainterp.execute_and_record(rop.GETFIELD_GC,
itemsdescr, listbox)
- self.execute_with_descr(rop.SETARRAYITEM_GC, arraydescr, arraybox, indexbox, valuebox)
+ self.execute_with_descr(rop.SETARRAYITEM_GC, arraydescr, arraybox,
+ indexbox, valuebox)
+
+ opimpl_setlistitem_gc_i = _opimpl_setlistitem_gc_any
+ opimpl_setlistitem_gc_r = _opimpl_setlistitem_gc_any
+ opimpl_setlistitem_gc_f = _opimpl_setlistitem_gc_any
@arguments("orgpc", "box", "descr", "box")
- def opimpl_check_resizable_neg_index(self, pc, listbox, lengthdesc,
+ def opimpl_check_resizable_neg_index(self, orgpc, listbox, lengthdescr,
indexbox):
negbox = self.metainterp.execute_and_record(
- rop.INT_LT, None, indexbox, ConstInt(0))
- negbox = self.implement_guard_value(pc, negbox)
+ rop.INT_LT, None, indexbox, history.CONST_FALSE)
+ negbox = self.implement_guard_value(orgpc, negbox)
if negbox.getint():
# the index is < 0; add the array length to it
lenbox = self.metainterp.execute_and_record(
- rop.GETFIELD_GC, lengthdesc, listbox)
+ rop.GETFIELD_GC, lengthdescr, listbox)
indexbox = self.metainterp.execute_and_record(
rop.INT_ADD, None, indexbox, lenbox)
- self.make_result_box(indexbox)
-
- @arguments("orgpc", "box")
- def opimpl_check_zerodivisionerror(self, pc, box):
- nonzerobox = self.metainterp.execute_and_record(
- rop.INT_NE, None, box, ConstInt(0))
- nonzerobox = self.implement_guard_value(pc, nonzerobox)
- if nonzerobox.getint():
- return False
- else:
- # division by zero!
- return self.metainterp.raise_zero_division_error()
-
- @arguments("orgpc", "box", "box")
- def opimpl_check_div_overflow(self, pc, box1, box2):
- # detect the combination "box1 = -sys.maxint-1, box2 = -1".
- import sys
- tmp1 = self.metainterp.execute_and_record( # combination to detect:
- rop.INT_ADD, None, box1, ConstInt(sys.maxint)) # tmp1=-1, box2=-1
- tmp2 = self.metainterp.execute_and_record(
- rop.INT_AND, None, tmp1, box2) # tmp2=-1
- tmp3 = self.metainterp.execute_and_record(
- rop.INT_EQ, None, tmp2, ConstInt(-1)) # tmp3?
- tmp4 = self.implement_guard_value(pc, tmp3) # tmp4?
- if not tmp4.getint():
- return False
- else:
- # division overflow!
- return self.metainterp.raise_overflow_error()
-
- @arguments()
- def opimpl_overflow_error(self):
- return self.metainterp.raise_overflow_error()
-
- @arguments("orgpc", "box")
- def opimpl_int_abs(self, pc, box):
- nonneg = self.metainterp.execute_and_record(
- rop.INT_GE, None, box, ConstInt(0))
- nonneg = self.implement_guard_value(pc, nonneg)
- if nonneg.getint():
- self.make_result_box(box)
- else:
- self.execute(rop.INT_NEG, box)
-
- @arguments("orgpc", "box")
- def opimpl_oononnull(self, pc, box):
- value = box.nonnull()
- if value:
- opnum = rop.GUARD_NONNULL
- res = ConstInt(1)
- else:
- opnum = rop.GUARD_ISNULL
- res = ConstInt(0)
- self.generate_guard(pc, opnum, box, [])
- self.make_result_box(res)
-
- @arguments("orgpc", "box")
- def opimpl_ooisnull(self, pc, box):
- value = box.nonnull()
- if value:
- opnum = rop.GUARD_NONNULL
- res = ConstInt(0)
- else:
- opnum = rop.GUARD_ISNULL
- res = ConstInt(1)
- self.generate_guard(pc, opnum, box, [])
- self.make_result_box(res)
-
- @arguments("box", "box")
- def opimpl_ptr_eq(self, box1, box2):
- self.execute(rop.OOIS, box1, box2)
-
- @arguments("box", "box")
- def opimpl_ptr_ne(self, box1, box2):
- self.execute(rop.OOISNOT, box1, box2)
-
- opimpl_oois = opimpl_ptr_eq
- opimpl_ooisnot = opimpl_ptr_ne
+ return indexbox
@arguments("box", "descr")
- def opimpl_getfield_gc(self, box, fielddesc):
- self.execute_with_descr(rop.GETFIELD_GC, fielddesc, box)
+ def _opimpl_getfield_gc_any(self, box, fielddescr):
+ return self.execute_with_descr(rop.GETFIELD_GC, fielddescr, box)
+ opimpl_getfield_gc_i = _opimpl_getfield_gc_any
+ opimpl_getfield_gc_r = _opimpl_getfield_gc_any
+ opimpl_getfield_gc_f = _opimpl_getfield_gc_any
+
@arguments("box", "descr")
- def opimpl_getfield_gc_pure(self, box, fielddesc):
- self.execute_with_descr(rop.GETFIELD_GC_PURE, fielddesc, box)
+ def _opimpl_getfield_gc_pure_any(self, box, fielddescr):
+ return self.execute_with_descr(rop.GETFIELD_GC_PURE, fielddescr, box)
+ opimpl_getfield_gc_i_pure = _opimpl_getfield_gc_pure_any
+ opimpl_getfield_gc_r_pure = _opimpl_getfield_gc_pure_any
+ opimpl_getfield_gc_f_pure = _opimpl_getfield_gc_pure_any
+
@arguments("box", "descr", "box")
- def opimpl_setfield_gc(self, box, fielddesc, valuebox):
- self.execute_with_descr(rop.SETFIELD_GC, fielddesc, box, valuebox)
+ def _opimpl_setfield_gc_any(self, box, fielddescr, valuebox):
+ self.execute_with_descr(rop.SETFIELD_GC, fielddescr, box, valuebox)
+ opimpl_setfield_gc_i = _opimpl_setfield_gc_any
+ opimpl_setfield_gc_r = _opimpl_setfield_gc_any
+ opimpl_setfield_gc_f = _opimpl_setfield_gc_any
@arguments("box", "descr")
- def opimpl_getfield_raw(self, box, fielddesc):
- self.execute_with_descr(rop.GETFIELD_RAW, fielddesc, box)
+ def _opimpl_getfield_raw_any(self, box, fielddescr):
+ return self.execute_with_descr(rop.GETFIELD_RAW, fielddescr, box)
+ opimpl_getfield_raw_i = _opimpl_getfield_raw_any
+ opimpl_getfield_raw_r = _opimpl_getfield_raw_any
+ opimpl_getfield_raw_f = _opimpl_getfield_raw_any
+
@arguments("box", "descr")
- def opimpl_getfield_raw_pure(self, box, fielddesc):
- self.execute_with_descr(rop.GETFIELD_RAW_PURE, fielddesc, box)
+ def _opimpl_getfield_raw_pure_any(self, box, fielddescr):
+ return self.execute_with_descr(rop.GETFIELD_RAW_PURE, fielddescr, box)
+ opimpl_getfield_raw_i_pure = _opimpl_getfield_raw_pure_any
+ opimpl_getfield_raw_r_pure = _opimpl_getfield_raw_pure_any
+ opimpl_getfield_raw_f_pure = _opimpl_getfield_raw_pure_any
+
@arguments("box", "descr", "box")
- def opimpl_setfield_raw(self, box, fielddesc, valuebox):
- self.execute_with_descr(rop.SETFIELD_RAW, fielddesc, box, valuebox)
+ def _opimpl_setfield_raw_any(self, box, fielddescr, valuebox):
+ self.execute_with_descr(rop.SETFIELD_RAW, fielddescr, box, valuebox)
+ opimpl_setfield_raw_i = _opimpl_setfield_raw_any
+ opimpl_setfield_raw_r = _opimpl_setfield_raw_any
+ opimpl_setfield_raw_f = _opimpl_setfield_raw_any
def _nonstandard_virtualizable(self, pc, box):
# returns True if 'box' is actually not the "standard" virtualizable
@@ -522,7 +509,7 @@
standard_box = self.metainterp.virtualizable_boxes[-1]
if standard_box is box:
return False
- eqbox = self.metainterp.execute_and_record(rop.OOIS, None,
+ eqbox = self.metainterp.execute_and_record(rop.PTR_EQ, None,
box, standard_box)
eqbox = self.implement_guard_value(pc, eqbox)
isstandard = eqbox.getint()
@@ -530,9 +517,9 @@
self.metainterp.replace_box(box, standard_box)
return not isstandard
- def _get_virtualizable_field_descr(self, index):
+ def _get_virtualizable_field_index(self, fielddescr):
vinfo = self.metainterp.staticdata.virtualizable_info
- return vinfo.static_field_descrs[index]
+ return vinfo.static_field_by_descrs[fielddescr]
def _get_virtualizable_array_field_descr(self, index):
vinfo = self.metainterp.staticdata.virtualizable_info
@@ -542,328 +529,271 @@
vinfo = self.metainterp.staticdata.virtualizable_info
return vinfo.array_descrs[index]
- @arguments("orgpc", "box", "int")
- def opimpl_getfield_vable(self, pc, basebox, index):
- if self._nonstandard_virtualizable(pc, basebox):
- self.execute_with_descr(rop.GETFIELD_GC, self._get_virtualizable_field_descr(index), basebox)
- return
+ @arguments("orgpc", "box", "descr")
+ def _opimpl_getfield_vable(self, pc, box, fielddescr):
+ if self._nonstandard_virtualizable(pc, box):
+ return self.execute_with_descr(rop.GETFIELD_GC, fielddescr, box)
self.metainterp.check_synchronized_virtualizable()
- resbox = self.metainterp.virtualizable_boxes[index]
- self.make_result_box(resbox)
- @arguments("orgpc", "box", "int", "box")
- def opimpl_setfield_vable(self, pc, basebox, index, valuebox):
- if self._nonstandard_virtualizable(pc, basebox):
- self.execute_with_descr(rop.SETFIELD_GC, self._get_virtualizable_field_descr(index), basebox, valuebox)
+ index = self._get_virtualizable_field_index(fielddescr)
+ return self.metainterp.virtualizable_boxes[index]
+
+ opimpl_getfield_vable_i = _opimpl_getfield_vable
+ opimpl_getfield_vable_r = _opimpl_getfield_vable
+ opimpl_getfield_vable_f = _opimpl_getfield_vable
+
+ @arguments("orgpc", "box", "descr", "box")
+ def _opimpl_setfield_vable(self, pc, box, fielddescr, valuebox):
+ if self._nonstandard_virtualizable(pc, box):
+ self.execute_with_descr(rop.SETFIELD_GC, fielddescr, box, valuebox)
return
+ index = self._get_virtualizable_field_index(fielddescr)
self.metainterp.virtualizable_boxes[index] = valuebox
self.metainterp.synchronize_virtualizable()
# XXX only the index'th field needs to be synchronized, really
- def _get_arrayitem_vable_index(self, pc, arrayindex, indexbox):
+ opimpl_setfield_vable_i = _opimpl_setfield_vable
+ opimpl_setfield_vable_r = _opimpl_setfield_vable
+ opimpl_setfield_vable_f = _opimpl_setfield_vable
+
+ def _get_arrayitem_vable_index(self, pc, arrayfielddescr, indexbox):
indexbox = self.implement_guard_value(pc, indexbox)
vinfo = self.metainterp.staticdata.virtualizable_info
virtualizable_box = self.metainterp.virtualizable_boxes[-1]
virtualizable = vinfo.unwrap_virtualizable_box(virtualizable_box)
+ arrayindex = vinfo.array_field_by_descrs[arrayfielddescr]
index = indexbox.getint()
if index < 0:
index += vinfo.get_array_length(virtualizable, arrayindex)
assert 0 <= index < vinfo.get_array_length(virtualizable, arrayindex)
return vinfo.get_index_in_array(virtualizable, arrayindex, index)
- @arguments("orgpc", "box", "int", "box")
- def opimpl_getarrayitem_vable(self, pc, basebox, arrayindex, indexbox):
- if self._nonstandard_virtualizable(pc, basebox):
- descr = self._get_virtualizable_array_field_descr(arrayindex)
+ @arguments("orgpc", "box", "descr", "descr", "box")
+ def _opimpl_getarrayitem_vable(self, pc, box, fdescr, adescr, indexbox):
+ if self._nonstandard_virtualizable(pc, box):
arraybox = self.metainterp.execute_and_record(rop.GETFIELD_GC,
- descr, basebox)
- descr = self._get_virtualizable_array_descr(arrayindex)
- self.execute_with_descr(rop.GETARRAYITEM_GC, descr,
- arraybox, indexbox)
- return
+ fdescr, box)
+ return self.execute_with_descr(rop.GETARRAYITEM_GC, adescr,
+ arraybox, indexbox)
self.metainterp.check_synchronized_virtualizable()
- index = self._get_arrayitem_vable_index(pc, arrayindex, indexbox)
- resbox = self.metainterp.virtualizable_boxes[index]
- self.make_result_box(resbox)
- @arguments("orgpc", "box", "int", "box", "box")
- def opimpl_setarrayitem_vable(self, pc, basebox, arrayindex, indexbox,
+ index = self._get_arrayitem_vable_index(pc, fdescr, indexbox)
+ return self.metainterp.virtualizable_boxes[index]
+
+ opimpl_getarrayitem_vable_i = _opimpl_getarrayitem_vable
+ opimpl_getarrayitem_vable_r = _opimpl_getarrayitem_vable
+ opimpl_getarrayitem_vable_f = _opimpl_getarrayitem_vable
+
+ @arguments("orgpc", "box", "descr", "descr", "box", "box")
+ def _opimpl_setarrayitem_vable(self, pc, box, fdescr, adescr, indexbox,
valuebox):
- if self._nonstandard_virtualizable(pc, basebox):
- descr = self._get_virtualizable_array_field_descr(arrayindex)
+ if self._nonstandard_virtualizable(pc, box):
arraybox = self.metainterp.execute_and_record(rop.GETFIELD_GC,
- descr, basebox)
- descr = self._get_virtualizable_array_descr(arrayindex)
- self.execute_with_descr(rop.SETARRAYITEM_GC, descr,
+ fdescr, box)
+ self.execute_with_descr(rop.SETARRAYITEM_GC, adescr,
arraybox, indexbox, valuebox)
return
- index = self._get_arrayitem_vable_index(pc, arrayindex, indexbox)
+ index = self._get_arrayitem_vable_index(pc, fdescr, indexbox)
self.metainterp.virtualizable_boxes[index] = valuebox
self.metainterp.synchronize_virtualizable()
# XXX only the index'th field needs to be synchronized, really
- @arguments("orgpc", "box", "int")
- def opimpl_arraylen_vable(self, pc, basebox, arrayindex):
- if self._nonstandard_virtualizable(pc, basebox):
- descr = self._get_virtualizable_array_field_descr(arrayindex)
+
+ opimpl_setarrayitem_vable_i = _opimpl_setarrayitem_vable
+ opimpl_setarrayitem_vable_r = _opimpl_setarrayitem_vable
+ opimpl_setarrayitem_vable_f = _opimpl_setarrayitem_vable
+
+ @arguments("orgpc", "box", "descr", "descr")
+ def opimpl_arraylen_vable(self, pc, box, fdescr, adescr):
+ if self._nonstandard_virtualizable(pc, box):
arraybox = self.metainterp.execute_and_record(rop.GETFIELD_GC,
- descr, basebox)
- descr = self._get_virtualizable_array_descr(arrayindex)
- self.execute_with_descr(rop.ARRAYLEN_GC, descr, arraybox)
- return
+ fdescr, box)
+ return self.execute_with_descr(rop.ARRAYLEN_GC, adescr, arraybox)
vinfo = self.metainterp.staticdata.virtualizable_info
virtualizable_box = self.metainterp.virtualizable_boxes[-1]
virtualizable = vinfo.unwrap_virtualizable_box(virtualizable_box)
+ arrayindex = vinfo.array_field_by_descrs[fdescr]
result = vinfo.get_array_length(virtualizable, arrayindex)
- self.make_result_box(ConstInt(result))
+ return ConstInt(result)
- def perform_call(self, jitcode, varargs, greenkey=None):
- if (self.metainterp.is_blackholing() and
- jitcode.calldescr is not None):
- # when producing only a BlackHole, we can implement this by
- # calling the subfunction directly instead of interpreting it
- if jitcode.cfnptr is not None:
- # for non-oosends
- varargs = [jitcode.cfnptr] + varargs
- res = self.execute_varargs(rop.CALL, varargs,
- descr=jitcode.calldescr, exc=True)
- else:
- # for oosends (ootype only): calldescr is a MethDescr
- res = self.execute_varargs(rop.OOSEND, varargs,
- descr=jitcode.calldescr, exc=True)
- self.metainterp.load_fields_from_virtualizable()
- return res
- else:
- # when tracing, this bytecode causes the subfunction to be entered
- f = self.metainterp.newframe(jitcode, greenkey)
- f.setup_call(varargs)
- return True
-
- @arguments("bytecode", "varargs")
- def opimpl_call(self, callee, varargs):
- return self.perform_call(callee, varargs)
-
- @arguments("descr", "varargs")
- def opimpl_residual_call(self, calldescr, varargs):
- return self.do_residual_call(varargs, descr=calldescr, exc=True)
-
- @arguments("descr", "varargs")
- def opimpl_residual_call_loopinvariant(self, calldescr, varargs):
- return self.execute_varargs(rop.CALL_LOOPINVARIANT, varargs, calldescr, exc=True)
-
- @arguments("orgpc", "descr", "varargs")
- def opimpl_recursive_call(self, pc, calldescr, varargs):
- warmrunnerstate = self.metainterp.staticdata.state
+ @arguments("jitcode", "boxes")
+ def _opimpl_inline_call1(self, jitcode, argboxes):
+ return self.metainterp.perform_call(jitcode, argboxes)
+ @arguments("jitcode", "boxes2")
+ def _opimpl_inline_call2(self, jitcode, argboxes):
+ return self.metainterp.perform_call(jitcode, argboxes)
+ @arguments("jitcode", "boxes3")
+ def _opimpl_inline_call3(self, jitcode, argboxes):
+ return self.metainterp.perform_call(jitcode, argboxes)
+
+ opimpl_inline_call_r_i = _opimpl_inline_call1
+ opimpl_inline_call_r_r = _opimpl_inline_call1
+ opimpl_inline_call_r_v = _opimpl_inline_call1
+ opimpl_inline_call_ir_i = _opimpl_inline_call2
+ opimpl_inline_call_ir_r = _opimpl_inline_call2
+ opimpl_inline_call_ir_v = _opimpl_inline_call2
+ opimpl_inline_call_irf_i = _opimpl_inline_call3
+ opimpl_inline_call_irf_r = _opimpl_inline_call3
+ opimpl_inline_call_irf_f = _opimpl_inline_call3
+ opimpl_inline_call_irf_v = _opimpl_inline_call3
+
+ @arguments("box", "descr", "boxes")
+ def _opimpl_residual_call1(self, funcbox, calldescr, argboxes):
+ return self.do_residual_or_indirect_call(funcbox, calldescr, argboxes)
+ @arguments("box", "descr", "boxes2")
+ def _opimpl_residual_call2(self, funcbox, calldescr, argboxes):
+ return self.do_residual_or_indirect_call(funcbox, calldescr, argboxes)
+ @arguments("box", "descr", "boxes3")
+ def _opimpl_residual_call3(self, funcbox, calldescr, argboxes):
+ return self.do_residual_or_indirect_call(funcbox, calldescr, argboxes)
+
+ opimpl_residual_call_r_i = _opimpl_residual_call1
+ opimpl_residual_call_r_r = _opimpl_residual_call1
+ opimpl_residual_call_r_v = _opimpl_residual_call1
+ opimpl_residual_call_ir_i = _opimpl_residual_call2
+ opimpl_residual_call_ir_r = _opimpl_residual_call2
+ opimpl_residual_call_ir_v = _opimpl_residual_call2
+ opimpl_residual_call_irf_i = _opimpl_residual_call3
+ opimpl_residual_call_irf_r = _opimpl_residual_call3
+ opimpl_residual_call_irf_f = _opimpl_residual_call3
+ opimpl_residual_call_irf_v = _opimpl_residual_call3
+
+ @arguments("boxes3", "boxes3")
+ def _opimpl_recursive_call(self, greenboxes, redboxes):
+ allboxes = greenboxes + redboxes
+ metainterp_sd = self.metainterp.staticdata
+ portal_code = metainterp_sd.portal_code
+ warmrunnerstate = metainterp_sd.state
token = None
- if not self.metainterp.is_blackholing() and warmrunnerstate.inlining:
- num_green_args = self.metainterp.staticdata.num_green_args
- portal_code = self.metainterp.staticdata.portal_code
- greenkey = varargs[1:num_green_args + 1]
- if warmrunnerstate.can_inline_callable(greenkey):
- return self.perform_call(portal_code, varargs[1:], greenkey)
- token = warmrunnerstate.get_assembler_token(greenkey)
- call_position = 0
- if token is not None:
- call_position = len(self.metainterp.history.operations)
+ if warmrunnerstate.inlining:
+ if warmrunnerstate.can_inline_callable(greenboxes):
+ return self.metainterp.perform_call(portal_code, allboxes,
+ greenkey=greenboxes)
+ token = warmrunnerstate.get_assembler_token(greenboxes)
# verify that we have all green args, needed to make sure
# that assembler that we call is still correct
- greenargs = varargs[1:num_green_args + 1]
- self.verify_green_args(greenargs)
- res = self.do_residual_call(varargs, descr=calldescr, exc=True)
- if not self.metainterp.is_blackholing() and token is not None:
- # XXX fix the call position, <UGLY!>
- found = False
- while True:
- op = self.metainterp.history.operations[call_position]
- if op.opnum == rop.CALL or op.opnum == rop.CALL_MAY_FORCE:
- found = True
- break
- call_position += 1
- assert found
- # </UGLY!>
- # this will substitute the residual call with assembler call
- self.metainterp.direct_assembler_call(pc, varargs, token,
- call_position)
- return res
-
- @arguments("descr", "varargs")
- def opimpl_residual_call_noexception(self, calldescr, varargs):
- self.do_residual_call(varargs, descr=calldescr, exc=False)
-
- @arguments("descr", "varargs")
- def opimpl_residual_call_pure(self, calldescr, varargs):
- self.execute_varargs(rop.CALL_PURE, varargs, descr=calldescr, exc=False)
-
- @arguments("orgpc", "descr", "box", "varargs")
- def opimpl_indirect_call(self, pc, calldescr, box, varargs):
- box = self.implement_guard_value(pc, box)
- cpu = self.metainterp.cpu
- key = cpu.ts.getaddr_for_box(cpu, box)
- jitcode = self.metainterp.staticdata.bytecode_for_address(key)
- if jitcode is not None:
- # we should follow calls to this graph
- return self.perform_call(jitcode, varargs)
- else:
- # but we should not follow calls to that graph
- return self.do_residual_call([box] + varargs,
- descr=calldescr, exc=True)
-
- @arguments("orgpc", "methdescr", "varargs")
- def opimpl_oosend(self, pc, methdescr, varargs):
- objbox = varargs[0]
- clsbox = self.cls_of_box(objbox)
- if isinstance(objbox, Box):
- self.generate_guard(pc, rop.GUARD_CLASS, objbox, [clsbox])
- oocls = clsbox.getref(ootype.Class)
- jitcode = methdescr.get_jitcode_for_class(oocls)
- if jitcode is not None:
- # we should follow calls to this graph
- return self.perform_call(jitcode, varargs)
- else:
- # but we should not follow calls to that graph
- return self.execute_varargs(rop.OOSEND, varargs,
- descr=methdescr, exc=True)
+ self.verify_green_args(greenboxes)
+ #
+ k = llmemory.cast_ptr_to_adr(metainterp_sd._portal_runner_ptr)
+ funcbox = ConstInt(heaptracker.adr2int(k))
+ return self.do_residual_call(funcbox, portal_code.calldescr,
+ allboxes, assembler_call_token=token)
+
+ opimpl_recursive_call_i = _opimpl_recursive_call
+ opimpl_recursive_call_r = _opimpl_recursive_call
+ opimpl_recursive_call_f = _opimpl_recursive_call
+ opimpl_recursive_call_v = _opimpl_recursive_call
+
+## @FixME #arguments("orgpc", "methdescr", "varargs")
+## def opimpl_oosend(self, pc, methdescr, varargs):
+## objbox = varargs[0]
+## clsbox = self.cls_of_box(objbox)
+## if isinstance(objbox, Box):
+## self.generate_guard(pc, rop.GUARD_CLASS, objbox, [clsbox])
+## oocls = clsbox.getref(ootype.Class)
+## jitcode = methdescr.get_jitcode_for_class(oocls)
+## if jitcode is not None:
+## # we should follow calls to this graph
+## return self.perform_call(jitcode, varargs)
+## else:
+## # but we should not follow calls to that graph
+## return self.execute_varargs(rop.OOSEND, varargs,
+## descr=methdescr, exc=True)
@arguments("box")
- def opimpl_strlen(self, str):
- self.execute(rop.STRLEN, str)
+ def opimpl_strlen(self, strbox):
+ return self.execute(rop.STRLEN, strbox)
@arguments("box")
- def opimpl_unicodelen(self, str):
- self.execute(rop.UNICODELEN, str)
+ def opimpl_unicodelen(self, unicodebox):
+ return self.execute(rop.UNICODELEN, unicodebox)
@arguments("box", "box")
- def opimpl_strgetitem(self, str, index):
- self.execute(rop.STRGETITEM, str, index)
+ def opimpl_strgetitem(self, strbox, indexbox):
+ return self.execute(rop.STRGETITEM, strbox, indexbox)
@arguments("box", "box")
- def opimpl_unicodegetitem(self, str, index):
- self.execute(rop.UNICODEGETITEM, str, index)
+ def opimpl_unicodegetitem(self, unicodebox, indexbox):
+ return self.execute(rop.UNICODEGETITEM, unicodebox, indexbox)
@arguments("box", "box", "box")
- def opimpl_strsetitem(self, str, index, newchar):
- self.execute(rop.STRSETITEM, str, index, newchar)
+ def opimpl_strsetitem(self, strbox, indexbox, newcharbox):
+ return self.execute(rop.STRSETITEM, strbox, indexbox, newcharbox)
@arguments("box", "box", "box")
- def opimpl_unicodesetitem(self, str, index, newchar):
- self.execute(rop.UNICODESETITEM, str, index, newchar)
+ def opimpl_unicodesetitem(self, unicodebox, indexbox, newcharbox):
+ self.execute(rop.UNICODESETITEM, unicodebox, indexbox, newcharbox)
@arguments("box")
- def opimpl_newstr(self, length):
- self.execute(rop.NEWSTR, length)
+ def opimpl_newstr(self, lengthbox):
+ return self.execute(rop.NEWSTR, lengthbox)
@arguments("box")
- def opimpl_newunicode(self, length):
- self.execute(rop.NEWUNICODE, length)
-
- @arguments("descr", "varargs")
- def opimpl_residual_oosend_canraise(self, methdescr, varargs):
- return self.execute_varargs(rop.OOSEND, varargs, descr=methdescr, exc=True)
-
- @arguments("descr", "varargs")
- def opimpl_residual_oosend_noraise(self, methdescr, varargs):
- self.execute_varargs(rop.OOSEND, varargs, descr=methdescr, exc=False)
-
- @arguments("descr", "varargs")
- def opimpl_residual_oosend_pure(self, methdescr, boxes):
- self.execute_varargs(rop.OOSEND_PURE, boxes, descr=methdescr, exc=False)
+ def opimpl_newunicode(self, lengthbox):
+ return self.execute(rop.NEWUNICODE, lengthbox)
- @arguments("orgpc", "box")
- def opimpl_guard_value(self, pc, box):
- constbox = self.implement_guard_value(pc, box)
- self.make_result_box(constbox)
-
- @arguments("orgpc", "int")
- def opimpl_guard_green(self, pc, boxindex):
- """Like guard_value, but overwrites the original box with the const.
- Used to prevent Boxes from showing up in the greenkey of some
- operations, like jit_merge_point. The in-place overwriting is
- convenient for jit_merge_point, which expects self.env to contain
- not more than the greens+reds described in the jitdriver."""
- box = self.env[boxindex]
- constbox = self.implement_guard_value(pc, box)
- self.env[boxindex] = constbox
+## @FixME #arguments("descr", "varargs")
+## def opimpl_residual_oosend_canraise(self, methdescr, varargs):
+## return self.execute_varargs(rop.OOSEND, varargs, descr=methdescr,
+## exc=True)
+
+## @FixME #arguments("descr", "varargs")
+## def opimpl_residual_oosend_noraise(self, methdescr, varargs):
+## return self.execute_varargs(rop.OOSEND, varargs, descr=methdescr,
+## exc=False)
+
+## @FixME #arguments("descr", "varargs")
+## def opimpl_residual_oosend_pure(self, methdescr, boxes):
+## return self.execute_varargs(rop.OOSEND_PURE, boxes, descr=methdescr,
+## exc=False)
+
+ @arguments("orgpc", "box",)
+ def _opimpl_guard_value(self, orgpc, box):
+ self.implement_guard_value(orgpc, box)
+
+ opimpl_int_guard_value = _opimpl_guard_value
+ opimpl_ref_guard_value = _opimpl_guard_value
+ opimpl_float_guard_value = _opimpl_guard_value
@arguments("orgpc", "box")
- def opimpl_guard_class(self, pc, box):
+ def opimpl_guard_class(self, orgpc, box):
clsbox = self.cls_of_box(box)
- if isinstance(box, Box):
- self.generate_guard(pc, rop.GUARD_CLASS, box, [clsbox])
- self.make_result_box(clsbox)
-
-## @arguments("orgpc", "box", "builtin")
-## def opimpl_guard_builtin(self, pc, box, builtin):
-## self.generate_guard(pc, "guard_builtin", box, [builtin])
-
-## @arguments("orgpc", "box", "builtin")
-## def opimpl_guard_len(self, pc, box, builtin):
-## intbox = self.metainterp.cpu.execute_operation(
-## 'len', [builtin.len_func, box], 'int')
-## self.generate_guard(pc, "guard_len", box, [intbox])
-
- @arguments("box")
- def opimpl_keepalive(self, box):
- pass # xxx?
-
- def verify_green_args(self, varargs):
- num_green_args = self.metainterp.staticdata.num_green_args
- for i in range(num_green_args):
- assert isinstance(varargs[i], Const)
-
- def blackhole_reached_merge_point(self, varargs):
- if self.metainterp.in_recursion:
- portal_code = self.metainterp.staticdata.portal_code
- # small hack: fish for the result box
- lenenv = len(self.env)
- raised = self.perform_call(portal_code, varargs)
- # in general this cannot be assumed, but when blackholing,
- # perform_call returns True only if an exception is called. In
- # this case perform_call has called finishframe_exception
- # already, so we need to return.
- if raised:
- return
- if lenenv == len(self.env):
- res = None
- else:
- assert lenenv == len(self.env) - 1
- res = self.env.pop()
- self.metainterp.finishframe(res)
- else:
- raise self.metainterp.staticdata.ContinueRunningNormally(varargs)
+ self.generate_guard(rop.GUARD_CLASS, box, [clsbox], resumepc=orgpc)
+ return clsbox
@arguments()
def opimpl_can_enter_jit(self):
- # Note: when running with a BlackHole history, this 'can_enter_jit'
- # may be completely skipped by the logic that replaces perform_call
- # with rop.CALL. But in that case, no-one will check the flag anyway,
- # so it's fine.
if self.metainterp.in_recursion:
from pypy.jit.metainterp.warmspot import CannotInlineCanEnterJit
raise CannotInlineCanEnterJit()
self.metainterp.seen_can_enter_jit = True
- @arguments()
- def opimpl_jit_merge_point(self):
- if not self.metainterp.is_blackholing():
- self.verify_green_args(self.env)
- # xxx we may disable the following line in some context later
- self.debug_merge_point()
- if self.metainterp.seen_can_enter_jit:
- self.metainterp.seen_can_enter_jit = False
- assert not self.metainterp.in_recursion
- # ^^^ it's impossible to arrive here with in_recursion set
- # to a non-zero value: seen_can_enter_jit can only be set
- # to True by opimpl_can_enter_jit, which should be executed
- # just before opimpl_jit_merge_point (no recursion inbetween).
- try:
- self.metainterp.reached_can_enter_jit(self.env)
- except GiveUp:
- self.metainterp.switch_to_blackhole(ABORT_BRIDGE)
- if self.metainterp.is_blackholing():
- self.blackhole_reached_merge_point(self.env)
- return True
+ def verify_green_args(self, varargs):
+ num_green_args = self.metainterp.staticdata.num_green_args
+ assert len(varargs) == num_green_args
+ for i in range(num_green_args):
+ assert isinstance(varargs[i], Const)
- def debug_merge_point(self):
+ @arguments("orgpc", "boxes3", "boxes3")
+ def opimpl_jit_merge_point(self, orgpc, greenboxes, redboxes):
+ self.verify_green_args(greenboxes)
+ # xxx we may disable the following line in some context later
+ self.debug_merge_point(greenboxes)
+ if self.metainterp.seen_can_enter_jit:
+ self.metainterp.seen_can_enter_jit = False
+ # Assert that it's impossible to arrive here with in_recursion
+ # set to a non-zero value: seen_can_enter_jit can only be set
+ # to True by opimpl_can_enter_jit, which should be executed
+ # just before opimpl_jit_merge_point (no recursion inbetween).
+ assert not self.metainterp.in_recursion
+ # Set self.pc to point to jit_merge_point instead of just after:
+ # if reached_can_enter_jit() raises SwitchToBlackhole, then the
+ # pc is still at the jit_merge_point, which is a point that is
+ # much less expensive to blackhole out of.
+ saved_pc = self.pc
+ self.pc = orgpc
+ self.metainterp.reached_can_enter_jit(greenboxes, redboxes)
+ self.pc = saved_pc
+
+ def debug_merge_point(self, greenkey):
# debugging: produce a DEBUG_MERGE_POINT operation
- num_green_args = self.metainterp.staticdata.num_green_args
- greenkey = self.env[:num_green_args]
sd = self.metainterp.staticdata
loc = sd.state.get_location_str(greenkey)
debug_print(loc)
@@ -871,45 +801,45 @@
self.metainterp.history.record(rop.DEBUG_MERGE_POINT,
[constloc], None)
- @arguments("jumptarget")
- def opimpl_setup_exception_block(self, exception_target):
- self.exception_target = exception_target
-
- @arguments()
- def opimpl_teardown_exception_block(self):
- self.exception_target = -1
-
- @arguments("constbox", "jumptarget", "orgpc")
- def opimpl_goto_if_exception_mismatch(self, vtableref, next_exc_target, pc):
- # XXX used to be:
- # assert isinstance(self.exception_box, Const) # XXX
- # seems this can happen that self.exception_box is not a Const,
- # but I failed to write a test so far :-(
- self.exception_box = self.implement_guard_value(pc, self.exception_box)
- cpu = self.metainterp.cpu
- ts = self.metainterp.cpu.ts
- if not ts.subclassOf(cpu, self.exception_box, vtableref):
+ @arguments("box", "label")
+ def opimpl_goto_if_exception_mismatch(self, vtablebox, next_exc_target):
+ metainterp = self.metainterp
+ last_exc_value_box = metainterp.last_exc_value_box
+ assert last_exc_value_box is not None
+ assert metainterp.class_of_last_exc_is_const
+ if not metainterp.cpu.ts.instanceOf(last_exc_value_box, vtablebox):
self.pc = next_exc_target
- @arguments("int")
- def opimpl_put_last_exception(self, index):
- assert index >= 0
- self.env.insert(index, self.exception_box)
-
- @arguments("int")
- def opimpl_put_last_exc_value(self, index):
- assert index >= 0
- self.env.insert(index, self.exc_value_box)
+ @arguments("orgpc", "box")
+ def opimpl_raise(self, orgpc, exc_value_box):
+ # xxx hack
+ clsbox = self.cls_of_box(exc_value_box)
+ self.generate_guard(rop.GUARD_CLASS, exc_value_box, [clsbox],
+ resumepc=orgpc)
+ self.metainterp.class_of_last_exc_is_const = True
+ self.metainterp.last_exc_value_box = exc_value_box
+ self.metainterp.popframe()
+ self.metainterp.finishframe_exception()
@arguments()
- def opimpl_raise(self):
- assert len(self.env) == 2
- return self.metainterp.finishframe_exception(self.env[0], self.env[1])
+ def opimpl_reraise(self):
+ assert self.metainterp.last_exc_value_box is not None
+ self.metainterp.popframe()
+ self.metainterp.finishframe_exception()
@arguments()
- def opimpl_reraise(self):
- return self.metainterp.finishframe_exception(self.exception_box,
- self.exc_value_box)
+ def opimpl_last_exception(self):
+ # Same comment as in opimpl_goto_if_exception_mismatch().
+ exc_value_box = self.metainterp.last_exc_value_box
+ assert exc_value_box is not None
+ assert self.metainterp.class_of_last_exc_is_const
+ return self.metainterp.cpu.ts.cls_of_box(exc_value_box)
+
+ @arguments()
+ def opimpl_last_exc_value(self):
+ exc_value_box = self.metainterp.last_exc_value_box
+ assert exc_value_box is not None
+ return exc_value_box
@arguments("box")
def opimpl_virtual_ref(self, box):
@@ -920,30 +850,26 @@
# the 'virtual_ref(frame)').
#
# * if we detect that the virtual box escapes during tracing
- # already (by generating a CALl_MAY_FORCE that marks the flags
+ # already (by generating a CALL_MAY_FORCE that marks the flags
# in the vref), then we replace the vref in the list with
# ConstPtr(NULL).
#
metainterp = self.metainterp
- if metainterp.is_blackholing():
- resbox = box # good enough when blackholing
- else:
- vrefinfo = metainterp.staticdata.virtualref_info
- obj = box.getref_base()
- vref = vrefinfo.virtual_ref_during_tracing(obj)
- resbox = history.BoxPtr(vref)
- cindex = history.ConstInt(len(metainterp.virtualref_boxes) // 2)
- metainterp.history.record(rop.VIRTUAL_REF, [box, cindex], resbox)
- # Note: we allocate a JIT_VIRTUAL_REF here
- # (in virtual_ref_during_tracing()), in order to detect when
- # the virtual escapes during tracing already. We record it as a
- # VIRTUAL_REF operation, although the backend sees this operation
- # as a no-op. The point is that the backend should not really see
- # it in practice, as optimizeopt.py should either kill it or
- # replace it with a NEW_WITH_VTABLE followed by SETFIELD_GCs.
+ vrefinfo = metainterp.staticdata.virtualref_info
+ obj = box.getref_base()
+ vref = vrefinfo.virtual_ref_during_tracing(obj)
+ resbox = history.BoxPtr(vref)
+ cindex = history.ConstInt(len(metainterp.virtualref_boxes) // 2)
+ metainterp.history.record(rop.VIRTUAL_REF, [box, cindex], resbox)
+ # Note: we allocate a JIT_VIRTUAL_REF here
+ # (in virtual_ref_during_tracing()), in order to detect when
+ # the virtual escapes during tracing already. We record it as a
+ # VIRTUAL_REF operation. Later, optimizeopt.py should either kill
+ # that operation or replace it with a NEW_WITH_VTABLE followed by
+ # SETFIELD_GCs.
metainterp.virtualref_boxes.append(box)
metainterp.virtualref_boxes.append(resbox)
- self.make_result_box(resbox)
+ return resbox
@arguments("box")
def opimpl_virtual_ref_finish(self, box):
@@ -953,27 +879,32 @@
vrefbox = metainterp.virtualref_boxes.pop()
lastbox = metainterp.virtualref_boxes.pop()
assert box.getref_base() == lastbox.getref_base()
- if not metainterp.is_blackholing():
- vrefinfo = metainterp.staticdata.virtualref_info
- vref = vrefbox.getref_base()
- if vrefinfo.is_virtual_ref(vref):
- metainterp.history.record(rop.VIRTUAL_REF_FINISH,
- [vrefbox, lastbox], None)
+ vrefinfo = metainterp.staticdata.virtualref_info
+ vref = vrefbox.getref_base()
+ if vrefinfo.is_virtual_ref(vref):
+ metainterp.history.record(rop.VIRTUAL_REF_FINISH,
+ [vrefbox, lastbox], None)
# ------------------------------
def setup_call(self, argboxes):
- if not we_are_translated():
- check_args(*argboxes)
self.pc = 0
- self.env = argboxes
+ count_i = count_r = count_f = 0
+ for box in argboxes:
+ if box.type == history.INT:
+ self.registers_i[count_i] = box
+ count_i += 1
+ elif box.type == history.REF:
+ self.registers_r[count_r] = box
+ count_r += 1
+ elif box.type == history.FLOAT:
+ self.registers_f[count_f] = box
+ count_f += 1
+ else:
+ raise AssertionError(box.type)
- def setup_resume_at_op(self, pc, exception_target, env):
- if not we_are_translated():
- check_args(*env)
+ def setup_resume_at_op(self, pc):
self.pc = pc
- self.exception_target = exception_target
- self.env = env
## values = ' '.join([box.repr_rpython() for box in self.env])
## log('setup_resume_at_op %s:%d [%s] %d' % (self.jitcode.name,
## self.pc, values,
@@ -984,25 +915,21 @@
# whenever the 'opcode_implementations' (which is one of the 'opimpl_'
# methods) returns True. This is the case when the current frame
# changes, due to a call or a return.
- while True:
- pc = self.pc
- op = ord(self.bytecode[pc])
- #print self.metainterp.opcode_names[op]
- self.pc = pc + 1
+ try:
staticdata = self.metainterp.staticdata
- stop = staticdata.opcode_implementations[op](self, pc)
- #self.metainterp.most_recent_mp = None
- if stop:
- break
+ while True:
+ pc = self.pc
+ op = ord(self.bytecode[pc])
+ #debug_print(self.jitcode.name, pc)
+ #print staticdata.opcode_names[op]
+ staticdata.opcode_implementations[op](self, pc)
+ except ChangeFrame:
+ pass
- def generate_guard(self, pc, opnum, box, extraargs=[]):
+ def generate_guard(self, opnum, box=None, extraargs=[], resumepc=-1):
if isinstance(box, Const): # no need for a guard
return
metainterp = self.metainterp
- if metainterp.is_blackholing():
- return
- saved_pc = self.pc
- self.pc = pc
if box is not None:
moreargs = [box] + extraargs
else:
@@ -1020,15 +947,18 @@
virtualizable_boxes = None
if metainterp.staticdata.virtualizable_info is not None:
virtualizable_boxes = metainterp.virtualizable_boxes
+ saved_pc = self.pc
+ if resumepc >= 0:
+ self.pc = resumepc
resume.capture_resumedata(metainterp.framestack, virtualizable_boxes,
metainterp.virtualref_boxes, resumedescr)
+ self.pc = saved_pc
self.metainterp.staticdata.profiler.count_ops(opnum, GUARDS)
# count
metainterp.attach_debug_info(guard_op)
- self.pc = saved_pc
return guard_op
- def implement_guard_value(self, pc, box):
+ def implement_guard_value(self, orgpc, box):
"""Promote the given Box into a Const. Note: be careful, it's a
bit unclear what occurs if a single opcode needs to generate
several ones and/or ones not near the beginning."""
@@ -1036,91 +966,138 @@
return box # no promotion needed, already a Const
else:
promoted_box = box.constbox()
- self.generate_guard(pc, rop.GUARD_VALUE, box, [promoted_box])
+ self.generate_guard(rop.GUARD_VALUE, box, [promoted_box],
+ resumepc=orgpc)
self.metainterp.replace_box(box, promoted_box)
return promoted_box
def cls_of_box(self, box):
- return self.metainterp.cpu.ts.cls_of_box(self.metainterp.cpu, box)
+ return self.metainterp.cpu.ts.cls_of_box(box)
@specialize.arg(1)
def execute(self, opnum, *argboxes):
- self.execute_with_descr(opnum, None, *argboxes)
+ return self.metainterp.execute_and_record(opnum, None, *argboxes)
@specialize.arg(1)
def execute_with_descr(self, opnum, descr, *argboxes):
- resbox = self.metainterp.execute_and_record(opnum, descr, *argboxes)
- if resbox is not None:
- self.make_result_box(resbox)
+ return self.metainterp.execute_and_record(opnum, descr, *argboxes)
@specialize.arg(1)
def execute_varargs(self, opnum, argboxes, descr, exc):
+ self.metainterp.clear_exception()
resbox = self.metainterp.execute_and_record_varargs(opnum, argboxes,
descr=descr)
- if resbox is not None:
- self.make_result_box(resbox)
+ self.make_result_of_lastop(resbox)
+ # ^^^ this is done before handle_possible_exception() because we need
+ # the box to show up in get_list_of_active_boxes()
if exc:
- return self.metainterp.handle_exception()
+ self.metainterp.handle_possible_exception()
else:
- return self.metainterp.assert_no_exception()
+ self.metainterp.assert_no_exception()
+ return resbox
- def do_residual_call(self, argboxes, descr, exc):
+ def do_residual_call(self, funcbox, descr, argboxes,
+ assembler_call_token=None):
+ # First build allboxes: it may need some reordering from the
+ # list provided in argboxes, depending on the order in which
+ # the arguments are expected by the function
+ allboxes = [None] * (len(argboxes)+1)
+ allboxes[0] = funcbox
+ src_i = src_r = src_f = 0
+ i = 1
+ for kind in descr.get_arg_types():
+ if kind == history.INT:
+ while True:
+ box = argboxes[src_i]
+ src_i += 1
+ if box.type == history.INT:
+ break
+ elif kind == history.REF:
+ while True:
+ box = argboxes[src_r]
+ src_r += 1
+ if box.type == history.REF:
+ break
+ elif kind == history.FLOAT:
+ while True:
+ box = argboxes[src_f]
+ src_f += 1
+ if box.type == history.FLOAT:
+ break
+ else:
+ raise AssertionError
+ allboxes[i] = box
+ i += 1
+ assert i == len(allboxes)
+ #
effectinfo = descr.get_extra_info()
- if effectinfo is None or effectinfo.forces_virtual_or_virtualizable:
+ if (effectinfo is None or
+ effectinfo.extraeffect ==
+ effectinfo.EF_FORCES_VIRTUAL_OR_VIRTUALIZABLE or
+ assembler_call_token is not None):
# residual calls require attention to keep virtualizables in-sync
+ self.metainterp.clear_exception()
self.metainterp.vable_and_vrefs_before_residual_call()
- # xxx do something about code duplication
resbox = self.metainterp.execute_and_record_varargs(
- rop.CALL_MAY_FORCE, argboxes, descr=descr)
- self.metainterp.vable_and_vrefs_after_residual_call()
+ rop.CALL_MAY_FORCE, allboxes, descr=descr)
+ self.metainterp.vrefs_after_residual_call()
+ if assembler_call_token is not None:
+ self.metainterp.direct_assembler_call(assembler_call_token)
if resbox is not None:
- self.make_result_box(resbox)
- self.generate_guard(self.pc, rop.GUARD_NOT_FORCED, None, [])
- if exc:
- return self.metainterp.handle_exception()
+ self.make_result_of_lastop(resbox)
+ self.metainterp.vable_after_residual_call()
+ self.generate_guard(rop.GUARD_NOT_FORCED, None)
+ self.metainterp.handle_possible_exception()
+ return resbox
+ else:
+ effect = effectinfo.extraeffect
+ if effect == effectinfo.EF_CANNOT_RAISE:
+ return self.execute_varargs(rop.CALL, allboxes, descr, False)
+ elif effect == effectinfo.EF_PURE:
+ return self.execute_varargs(rop.CALL_PURE, allboxes,
+ descr, False)
+ elif effect == effectinfo.EF_LOOPINVARIANT:
+ return self.execute_varargs(rop.CALL_LOOPINVARIANT, allboxes,
+ descr, True)
else:
- return self.metainterp.assert_no_exception()
+ return self.execute_varargs(rop.CALL, allboxes, descr, True)
+
+ def do_residual_or_indirect_call(self, funcbox, calldescr, argboxes):
+ """The 'residual_call' operation is emitted in two cases:
+ when we have to generate a residual CALL operation, but also
+ to handle an indirect_call that may need to be inlined."""
+ assert isinstance(funcbox, Const)
+ sd = self.metainterp.staticdata
+ key = sd.cpu.ts.getaddr_for_box(funcbox)
+ jitcode = sd.bytecode_for_address(key)
+ if jitcode is not None:
+ # we should follow calls to this graph
+ return self.metainterp.perform_call(jitcode, argboxes)
else:
- return self.execute_varargs(rop.CALL, argboxes, descr, exc)
+ # but we should not follow calls to that graph
+ return self.do_residual_call(funcbox, calldescr, argboxes)
# ____________________________________________________________
class MetaInterpStaticData(object):
- virtualizable_info = None
logger_noopt = None
logger_ops = None
- def __init__(self, portal_graph, cpu, stats, options,
+ def __init__(self, cpu, options,
ProfilerClass=EmptyProfiler, warmrunnerdesc=None):
self.cpu = cpu
- self.stats = stats
+ self.stats = self.cpu.stats
self.options = options
self.logger_noopt = Logger(self)
self.logger_ops = Logger(self, guard_number=True)
- RESULT = portal_graph.getreturnvar().concretetype
- self.result_type = history.getkind(RESULT)
-
- self.opcode_implementations = []
- self.opcode_names = []
- self.opname_to_index = {}
-
self.profiler = ProfilerClass()
-
- self.indirectcall_keys = []
- self.indirectcall_values = []
-
self.warmrunnerdesc = warmrunnerdesc
- self._op_goto_if_not = self.find_opcode('goto_if_not')
- self._op_ooisnull = self.find_opcode('ooisnull')
- self._op_oononnull = self.find_opcode('oononnull')
backendmodule = self.cpu.__module__
backendmodule = backendmodule.split('.')[-2]
self.jit_starting_line = 'JIT starting (%s)' % backendmodule
- self.portal_code = None
- self._class_sizes = None
self._addr2name_keys = []
self._addr2name_values = []
@@ -1132,15 +1109,44 @@
def _freeze_(self):
return True
- def info_from_codewriter(self, portal_code, class_sizes,
- list_of_addr2name, portal_runner_ptr):
- self.portal_code = portal_code
- self._class_sizes = class_sizes
- self._addr2name_keys = [key for key, value in list_of_addr2name]
+ def setup_insns(self, insns):
+ self.opcode_names = ['?'] * len(insns)
+ self.opcode_implementations = [None] * len(insns)
+ for key, value in insns.items():
+ assert self.opcode_implementations[value] is None
+ self.opcode_names[value] = key
+ name, argcodes = key.split('/')
+ opimpl = _get_opimpl_method(name, argcodes)
+ self.opcode_implementations[value] = opimpl
+ self.op_catch_exception = insns.get('catch_exception/L', -1)
+
+ def setup_descrs(self, descrs):
+ self.opcode_descrs = descrs
+
+ def setup_indirectcalltargets(self, indirectcalltargets):
+ self.indirectcalltargets = list(indirectcalltargets)
+
+ def setup_list_of_addr2name(self, list_of_addr2name):
+ self._addr2name_keys = [key for key, value in list_of_addr2name]
self._addr2name_values = [value for key, value in list_of_addr2name]
- self._portal_runner_ptr = portal_runner_ptr
- def finish_setup(self, optimizer=None):
+ def finish_setup(self, codewriter, optimizer=None):
+ from pypy.jit.metainterp.blackhole import BlackholeInterpBuilder
+ self.blackholeinterpbuilder = BlackholeInterpBuilder(codewriter, self)
+ #
+ asm = codewriter.assembler
+ self.setup_insns(asm.insns)
+ self.setup_descrs(asm.descrs)
+ self.setup_indirectcalltargets(asm.indirectcalltargets)
+ self.setup_list_of_addr2name(asm.list_of_addr2name)
+ #
+ self.portal_code = codewriter.mainjitcode
+ self._portal_runner_ptr = codewriter.callcontrol.portal_runner_ptr
+ self.virtualref_info = codewriter.callcontrol.virtualref_info
+ self.virtualizable_info = codewriter.callcontrol.virtualizable_info
+ RESULT = codewriter.portal_graph.getreturnvar().concretetype
+ self.result_type = history.getkind(RESULT)
+ #
warmrunnerdesc = self.warmrunnerdesc
if warmrunnerdesc is not None:
self.num_green_args = warmrunnerdesc.num_green_args
@@ -1156,20 +1162,12 @@
"""Runtime setup needed by the various components of the JIT."""
if not self.globaldata.initialized:
debug_print(self.jit_starting_line)
- self._setup_class_sizes()
self.cpu.setup_once()
if not self.profiler.initialized:
self.profiler.start()
self.profiler.initialized = True
self.globaldata.initialized = True
- def _setup_class_sizes(self):
- class_sizes = {}
- for vtable, sizedescr in self._class_sizes:
- vtable = self.cpu.ts.cast_vtable_to_hashable(self.cpu, vtable)
- class_sizes[vtable] = sizedescr
- self.cpu.set_class_sizes(class_sizes)
-
def get_name_from_address(self, addr):
# for debugging only
if we_are_translated():
@@ -1200,39 +1198,16 @@
# because the keys are function addresses, so they
# can change from run to run.
d = {}
- keys = self.indirectcall_keys
- values = self.indirectcall_values
- for i in range(len(keys)):
- d[keys[i]] = values[i]
+ for jitcode in self.indirectcalltargets:
+ d[jitcode.fnaddr] = jitcode
self.globaldata.indirectcall_dict = d
return d.get(fnaddress, None)
else:
- for i in range(len(self.indirectcall_keys)):
- if fnaddress == self.indirectcall_keys[i]:
- return self.indirectcall_values[i]
+ for jitcode in self.indirectcalltargets:
+ if jitcode.fnaddr == fnaddress:
+ return jitcode
return None
- # ---------- construction-time interface ----------
-
- def _register_indirect_call_target(self, fnaddress, jitcode):
- self.indirectcall_keys.append(fnaddress)
- self.indirectcall_values.append(jitcode)
-
- def find_opcode(self, name):
- try:
- return self.opname_to_index[name]
- except KeyError:
- self._register_opcode(name)
- return self.opname_to_index[name]
-
- def _register_opcode(self, opname):
- assert len(self.opcode_implementations) < 256, \
- "too many implementations of opcodes!"
- name = "opimpl_" + opname
- self.opname_to_index[opname] = len(self.opcode_implementations)
- self.opcode_names.append(opname)
- self.opcode_implementations.append(getattr(MIFrame, name).im_func)
-
# ---------------- logging ------------------------
def log(self, msg):
@@ -1259,6 +1234,7 @@
self.addr2name = None
self.loopnumbering = 0
self.resume_virtuals = {}
+ self.resume_virtuals_not_translated = []
#
state = staticdata.state
if state is not None:
@@ -1283,23 +1259,32 @@
class MetaInterp(object):
in_recursion = 0
- _already_allocated_resume_virtuals = None
def __init__(self, staticdata):
self.staticdata = staticdata
self.cpu = staticdata.cpu
self.portal_trace_positions = []
+ self.free_frames_list = []
+ self.last_exc_value_box = None
- def is_blackholing(self):
- return self.history is None
+ def perform_call(self, jitcode, boxes, greenkey=None):
+ # causes the metainterp to enter the given subfunction
+ # with a special case for recursive portal calls
+ f = self.newframe(jitcode, greenkey)
+ f.setup_call(boxes)
+ raise ChangeFrame
def newframe(self, jitcode, greenkey=None):
if jitcode is self.staticdata.portal_code:
self.in_recursion += 1
- if greenkey is not None and not self.is_blackholing():
+ if greenkey is not None:
self.portal_trace_positions.append(
(greenkey, len(self.history.operations)))
- f = MIFrame(self, jitcode, greenkey)
+ if len(self.free_frames_list) > 0:
+ f = self.free_frames_list.pop()
+ else:
+ f = MIFrame(self)
+ f.setup(jitcode, greenkey)
self.framestack.append(f)
return f
@@ -1307,23 +1292,27 @@
frame = self.framestack.pop()
if frame.jitcode is self.staticdata.portal_code:
self.in_recursion -= 1
- if frame.greenkey is not None and not self.is_blackholing():
+ if frame.greenkey is not None:
self.portal_trace_positions.append(
(None, len(self.history.operations)))
- return frame
+ # we save the freed MIFrames to avoid needing to re-create new
+ # MIFrame objects all the time; they are a bit big, with their
+ # 3*256 register entries.
+ frame.cleanup_registers()
+ self.free_frames_list.append(frame)
def finishframe(self, resultbox):
- frame = self.popframe()
+ # handle a non-exceptional return from the current frame
+ self.last_exc_value_box = None
+ self.popframe()
if self.framestack:
- if resultbox is not None:
- self.framestack[-1].make_result_box(resultbox)
- return True
+ self.framestack[-1].make_result_of_lastop(resultbox)
+ raise ChangeFrame
else:
- if not self.is_blackholing():
- try:
- self.compile_done_with_this_frame(resultbox)
- except GiveUp:
- self.switch_to_blackhole(ABORT_BRIDGE)
+ try:
+ self.compile_done_with_this_frame(resultbox)
+ except SwitchToBlackhole, stb:
+ self.aborted_tracing(stb.reason)
sd = self.staticdata
if sd.result_type == 'void':
assert resultbox is None
@@ -1337,30 +1326,25 @@
else:
assert False
- def finishframe_exception(self, exceptionbox, excvaluebox):
- # detect and propagate some exceptions early:
- # - AssertionError
- # - all subclasses of JitException
- if we_are_translated():
- from pypy.jit.metainterp.warmspot import JitException
- e = self.cpu.ts.get_exception_obj(excvaluebox)
- if isinstance(e, JitException) or isinstance(e, AssertionError):
- raise Exception, e
- #
+ def finishframe_exception(self):
+ excvaluebox = self.last_exc_value_box
while self.framestack:
frame = self.framestack[-1]
- if frame.exception_target >= 0:
- frame.pc = frame.exception_target
- frame.exception_target = -1
- frame.exception_box = exceptionbox
- frame.exc_value_box = excvaluebox
- return True
+ code = frame.bytecode
+ position = frame.pc # <-- just after the insn that raised
+ if position < len(code):
+ opcode = ord(code[position])
+ if opcode == self.staticdata.op_catch_exception:
+ # found a 'catch_exception' instruction;
+ # jump to the handler
+ target = ord(code[position+1]) | (ord(code[position+2])<<8)
+ frame.pc = target
+ raise ChangeFrame
self.popframe()
- if not self.is_blackholing():
- try:
- self.compile_exit_frame_with_exception(excvaluebox)
- except GiveUp:
- self.switch_to_blackhole(ABORT_BRIDGE)
+ try:
+ self.compile_exit_frame_with_exception(excvaluebox)
+ except SwitchToBlackhole, stb:
+ self.aborted_tracing(stb.reason)
raise self.staticdata.ExitFrameWithExceptionRef(self.cpu, excvaluebox.getref_base())
def check_recursion_invariant(self):
@@ -1379,19 +1363,7 @@
else:
print " ",
print jitcode.name
- raise Exception
-
- def raise_overflow_error(self):
- etype, evalue = self.cpu.get_overflow_error()
- return self.finishframe_exception(
- self.cpu.ts.get_exception_box(etype),
- self.cpu.ts.get_exc_value_box(evalue).constbox())
-
- def raise_zero_division_error(self):
- etype, evalue = self.cpu.get_zero_division_error()
- return self.finishframe_exception(
- self.cpu.ts.get_exception_box(etype),
- self.cpu.ts.get_exc_value_box(evalue).constbox())
+ raise AssertionError
def create_empty_history(self):
warmrunnerstate = self.staticdata.state
@@ -1412,15 +1384,11 @@
@specialize.arg(1)
def execute_and_record(self, opnum, descr, *argboxes):
history.check_descr(descr)
- assert (opnum != rop.CALL and opnum != rop.CALL_MAY_FORCE
- and opnum != rop.OOSEND)
+ assert not (rop._CANRAISE_FIRST <= opnum <= rop._CANRAISE_LAST)
# execute the operation
profiler = self.staticdata.profiler
profiler.count_ops(opnum)
- resbox = executor.execute(self.cpu, opnum, descr, *argboxes)
- if self.is_blackholing():
- profiler.count_ops(opnum, BLACKHOLED_OPS)
- return resbox
+ resbox = executor.execute(self.cpu, self, opnum, descr, *argboxes)
if rop._ALWAYS_PURE_FIRST <= opnum <= rop._ALWAYS_PURE_LAST:
return self._record_helper_pure(opnum, resbox, descr, *argboxes)
else:
@@ -1433,16 +1401,14 @@
# execute the operation
profiler = self.staticdata.profiler
profiler.count_ops(opnum)
- resbox = executor.execute_varargs(self.cpu, opnum, argboxes, descr)
- if self.is_blackholing():
- profiler.count_ops(opnum, BLACKHOLED_OPS)
- else:
- # check if the operation can be constant-folded away
- argboxes = list(argboxes)
- if rop._ALWAYS_PURE_FIRST <= opnum <= rop._ALWAYS_PURE_LAST:
- resbox = self._record_helper_pure_varargs(opnum, resbox, descr, argboxes)
- else:
- resbox = self._record_helper_nonpure_varargs(opnum, resbox, descr, argboxes)
+ resbox = executor.execute_varargs(self.cpu, self,
+ opnum, argboxes, descr)
+ # check if the operation can be constant-folded away
+ argboxes = list(argboxes)
+ if rop._ALWAYS_PURE_FIRST <= opnum <= rop._ALWAYS_PURE_LAST:
+ resbox = self._record_helper_pure_varargs(opnum, resbox, descr, argboxes)
+ else:
+ resbox = self._record_helper_nonpure_varargs(opnum, resbox, descr, argboxes)
return resbox
def _record_helper_pure(self, opnum, resbox, descr, *argboxes):
@@ -1478,45 +1444,57 @@
op.pc = self.framestack[-1].pc
op.name = self.framestack[-1].jitcode.name
- def switch_to_blackhole(self, reason):
+ def execute_raised(self, exception, constant=False):
+ if isinstance(exception, JitException):
+ raise JitException, exception # go through
+ llexception = get_llexception(self.cpu, exception)
+ self.execute_ll_raised(llexception, constant)
+
+ def execute_ll_raised(self, llexception, constant=False):
+ # Exception handling: when execute.do_call() gets an exception it
+ # calls metainterp.execute_raised(), which puts it into
+ # 'self.last_exc_value_box'. This is used shortly afterwards
+ # to generate either GUARD_EXCEPTION or GUARD_NO_EXCEPTION, and also
+ # to handle the following opcodes 'goto_if_exception_mismatch'.
+ llexception = self.cpu.ts.cast_to_ref(llexception)
+ exc_value_box = self.cpu.ts.get_exc_value_box(llexception)
+ if constant:
+ exc_value_box = exc_value_box.constbox()
+ self.last_exc_value_box = exc_value_box
+ self.class_of_last_exc_is_const = constant
+ # 'class_of_last_exc_is_const' means that the class of the value
+ # stored in the exc_value Box can be assumed to be a Const. This
+ # is only True after a GUARD_EXCEPTION or GUARD_CLASS.
+
+ def clear_exception(self):
+ self.last_exc_value_box = None
+
+ def aborted_tracing(self, reason):
self.staticdata.profiler.count(reason)
debug_print('~~~ ABORTING TRACING')
- debug_stop('jit-tracing')
- debug_start('jit-blackhole')
- self.history = None # start blackholing
self.staticdata.stats.aborted()
- self.staticdata.profiler.end_tracing()
- self.staticdata.profiler.start_blackhole()
self.resumekey.reset_counter_from_failure()
- switch_to_blackhole._dont_inline_ = True
- def switch_to_blackhole_if_trace_too_long(self):
- if not self.is_blackholing():
- warmrunnerstate = self.staticdata.state
- if len(self.history.operations) > warmrunnerstate.trace_limit:
- greenkey_of_huge_function = self.find_biggest_function()
- self.portal_trace_positions = None
- self.switch_to_blackhole(ABORT_TOO_LONG)
- if greenkey_of_huge_function is not None:
- warmrunnerstate = self.staticdata.state
- warmrunnerstate.disable_noninlinable_function(
- greenkey_of_huge_function)
+ def blackhole_if_trace_too_long(self):
+ warmrunnerstate = self.staticdata.state
+ if len(self.history.operations) > warmrunnerstate.trace_limit:
+ greenkey_of_huge_function = self.find_biggest_function()
+ self.portal_trace_positions = None
+ if greenkey_of_huge_function is not None:
+ warmrunnerstate = self.staticdata.state
+ warmrunnerstate.disable_noninlinable_function(
+ greenkey_of_huge_function)
+ raise SwitchToBlackhole(ABORT_TOO_LONG)
def _interpret(self):
# Execute the frames forward until we raise a DoneWithThisFrame,
- # a ContinueRunningNormally, or a GenerateMergePoint exception.
+ # a ExitFrameWithException, or a GenerateMergePoint exception.
self.staticdata.stats.entered()
- try:
- while True:
- self.framestack[-1].run_one_step()
- self.switch_to_blackhole_if_trace_too_long()
- if not we_are_translated():
- self.check_recursion_invariant()
- finally:
- if self.is_blackholing():
- self.staticdata.profiler.end_blackhole()
- else:
- self.staticdata.profiler.end_tracing()
+ while True:
+ self.framestack[-1].run_one_step()
+ self.blackhole_if_trace_too_long()
+ if not we_are_translated():
+ self.check_recursion_invariant()
def interpret(self):
if we_are_translated():
@@ -1527,20 +1505,19 @@
except:
import sys
if sys.exc_info()[0] is not None:
- codewriter.log.info(sys.exc_info()[0].__name__)
+ self.staticdata.log(sys.exc_info()[0].__name__)
raise
def compile_and_run_once(self, *args):
debug_start('jit-tracing')
self.staticdata._setup_once()
+ self.staticdata.profiler.start_tracing()
self.create_empty_history()
try:
return self._compile_and_run_once(*args)
finally:
- if self.history is None:
- debug_stop('jit-blackhole')
- else:
- debug_stop('jit-tracing')
+ self.staticdata.profiler.end_tracing()
+ debug_stop('jit-tracing')
def _compile_and_run_once(self, *args):
original_boxes = self.initialize_state_from_start(*args)
@@ -1553,20 +1530,22 @@
self.seen_can_enter_jit = False
try:
self.interpret()
- assert False, "should always raise"
except GenerateMergePoint, gmp:
return self.designate_target_loop(gmp)
+ except SwitchToBlackhole, stb:
+ self.run_blackhole_interp_to_cancel_tracing(stb)
+ assert False, "should always raise"
def handle_guard_failure(self, key):
+ debug_start('jit-tracing')
+ self.staticdata.profiler.start_tracing()
assert isinstance(key, compile.ResumeGuardDescr)
self.initialize_state_from_guard_failure(key)
try:
return self._handle_guard_failure(key)
finally:
- if self.history is None:
- debug_stop('jit-blackhole')
- else:
- debug_stop('jit-tracing')
+ self.staticdata.profiler.end_tracing()
+ debug_stop('jit-tracing')
def _handle_guard_failure(self, key):
original_greenkey = key.original_greenkey
@@ -1579,13 +1558,23 @@
try:
self.prepare_resume_from_failure(key.guard_opnum)
self.interpret()
- assert False, "should always raise"
except GenerateMergePoint, gmp:
return self.designate_target_loop(gmp)
+ except SwitchToBlackhole, stb:
+ self.run_blackhole_interp_to_cancel_tracing(stb)
+ assert False, "should always raise"
+
+ def run_blackhole_interp_to_cancel_tracing(self, stb):
+ # We got a SwitchToBlackhole exception. Convert the framestack into
+ # a stack of blackhole interpreters filled with the same values, and
+ # run it.
+ from pypy.jit.metainterp.blackhole import convert_and_run_from_pyjitpl
+ self.aborted_tracing(stb.reason)
+ convert_and_run_from_pyjitpl(self, stb.raising_exception)
+ assert False # ^^^ must raise
- def remove_consts_and_duplicates(self, boxes, startindex, endindex,
- duplicates):
- for i in range(startindex, endindex):
+ def remove_consts_and_duplicates(self, boxes, endindex, duplicates):
+ for i in range(endindex):
box = boxes[i]
if isinstance(box, Const) or box in duplicates:
oldbox = box
@@ -1595,22 +1584,19 @@
else:
duplicates[box] = None
- def reached_can_enter_jit(self, live_arg_boxes):
- num_green_args = self.staticdata.num_green_args
+ def reached_can_enter_jit(self, greenboxes, redboxes):
duplicates = {}
- self.remove_consts_and_duplicates(live_arg_boxes,
- num_green_args,
- len(live_arg_boxes),
+ self.remove_consts_and_duplicates(redboxes, len(redboxes),
duplicates)
- live_arg_boxes = live_arg_boxes[:]
+ live_arg_boxes = greenboxes + redboxes
if self.staticdata.virtualizable_info is not None:
- # we use ':-1' to remove the last item, which is the virtualizable
+ # we use pop() to remove the last item, which is the virtualizable
# itself
self.remove_consts_and_duplicates(self.virtualizable_boxes,
- 0,
len(self.virtualizable_boxes)-1,
duplicates)
- live_arg_boxes += self.virtualizable_boxes[:-1]
+ live_arg_boxes += self.virtualizable_boxes
+ live_arg_boxes.pop()
assert len(self.virtualref_boxes) == 0, "missing virtual_ref_finish()?"
# Called whenever we reach the 'can_enter_jit' hint.
# First, attempt to make a bridge:
@@ -1639,11 +1625,12 @@
# Found! Compile it as a loop.
if start < 0:
# we cannot reconstruct the beginning of the proper loop
- raise GiveUp
+ raise SwitchToBlackhole(ABORT_BRIDGE)
# raises in case it works -- which is the common case
self.compile(original_boxes, live_arg_boxes, start)
# creation of the loop was cancelled!
+ self.staticdata.log('cancelled, going on...')
# Otherwise, no loop found so far, so continue tracing.
start = len(self.history.operations)
@@ -1658,17 +1645,39 @@
return loop_token
def prepare_resume_from_failure(self, opnum):
+ frame = self.framestack[-1]
if opnum == rop.GUARD_TRUE: # a goto_if_not that jumps only now
- self.framestack[-1].follow_jump()
+ frame.pc = frame.jitcode.follow_jump(frame.pc)
elif opnum == rop.GUARD_FALSE: # a goto_if_not that stops jumping
- self.framestack[-1].dont_follow_jump()
- elif (opnum == rop.GUARD_NO_EXCEPTION or opnum == rop.GUARD_EXCEPTION
- or opnum == rop.GUARD_NOT_FORCED):
- self.handle_exception()
+ pass
+ elif opnum == rop.GUARD_VALUE or opnum == rop.GUARD_CLASS:
+ pass # the pc is already set to the *start* of the opcode
+ elif (opnum == rop.GUARD_NONNULL or
+ opnum == rop.GUARD_ISNULL or
+ opnum == rop.GUARD_NONNULL_CLASS):
+ pass # the pc is already set to the *start* of the opcode
+ elif opnum == rop.GUARD_NO_EXCEPTION or opnum == rop.GUARD_EXCEPTION:
+ exception = self.cpu.grab_exc_value()
+ if exception:
+ self.execute_ll_raised(lltype.cast_opaque_ptr(rclass.OBJECTPTR,
+ exception))
+ else:
+ self.clear_exception()
+ try:
+ self.handle_possible_exception()
+ except ChangeFrame:
+ pass
elif opnum == rop.GUARD_NO_OVERFLOW: # an overflow now detected
- self.raise_overflow_error()
- elif opnum == rop.GUARD_NONNULL or opnum == rop.GUARD_ISNULL:
- self.framestack[-1].ignore_next_guard_nullness(opnum)
+ self.execute_raised(OverflowError(), constant=True)
+ try:
+ self.finishframe_exception()
+ except ChangeFrame:
+ pass
+ elif opnum == rop.GUARD_OVERFLOW: # no longer overflowing
+ self.clear_exception()
+ else:
+ from pypy.jit.metainterp.resoperation import opname
+ raise NotImplementedError(opname[opnum])
def compile(self, original_boxes, live_arg_boxes, start):
num_green_args = self.staticdata.num_green_args
@@ -1753,15 +1762,13 @@
def initialize_state_from_start(self, *args):
self.in_recursion = -1 # always one portal around
- self.staticdata.profiler.start_tracing()
num_green_args = self.staticdata.num_green_args
original_boxes = []
self._initialize_from_start(original_boxes, num_green_args, *args)
# ----- make a new frame -----
self.framestack = []
f = self.newframe(self.staticdata.portal_code)
- f.pc = 0
- f.env = original_boxes[:]
+ f.setup_call(original_boxes)
self.virtualref_boxes = []
self.initialize_virtualizable(original_boxes)
return original_boxes
@@ -1769,20 +1776,9 @@
def initialize_state_from_guard_failure(self, resumedescr):
# guard failure: rebuild a complete MIFrame stack
self.in_recursion = -1 # always one portal around
- inputargs_and_holes = self.cpu.make_boxes_from_latest_values(
- resumedescr)
- must_compile = resumedescr.must_compile(self.staticdata,
- inputargs_and_holes)
- if must_compile:
- debug_start('jit-tracing')
- self.history = history.History()
- self.history.inputargs = [box for box in inputargs_and_holes if box]
- self.staticdata.profiler.start_tracing()
- else:
- debug_start('jit-blackhole')
- self.staticdata.profiler.start_blackhole()
- self.history = None # this means that is_blackholing() is true
- self.rebuild_state_after_failure(resumedescr, inputargs_and_holes)
+ self.history = history.History()
+ inputargs_and_holes = self.rebuild_state_after_failure(resumedescr)
+ self.history.inputargs = [box for box in inputargs_and_holes if box]
def initialize_virtualizable(self, original_boxes):
vinfo = self.staticdata.virtualizable_info
@@ -1804,9 +1800,6 @@
vinfo.clear_vable_token(virtualizable)
def vable_and_vrefs_before_residual_call(self):
- if self.is_blackholing():
- return
- #
vrefinfo = self.staticdata.virtualref_info
for i in range(1, len(self.virtualref_boxes), 2):
vrefbox = self.virtualref_boxes[i]
@@ -1827,37 +1820,31 @@
force_token_box],
None, descr=vinfo.vable_token_descr)
- def vable_and_vrefs_after_residual_call(self):
- if self.is_blackholing():
- escapes = True
- else:
- escapes = False
- #
- vrefinfo = self.staticdata.virtualref_info
- for i in range(0, len(self.virtualref_boxes), 2):
- virtualbox = self.virtualref_boxes[i]
- vrefbox = self.virtualref_boxes[i+1]
- vref = vrefbox.getref_base()
- if vrefinfo.tracing_after_residual_call(vref):
- # this vref was really a virtual_ref, but it escaped
- # during this CALL_MAY_FORCE. Mark this fact by
- # generating a VIRTUAL_REF_FINISH on it and replacing
- # it by ConstPtr(NULL).
- self.stop_tracking_virtualref(i)
- #
- vinfo = self.staticdata.virtualizable_info
- if vinfo is not None:
- virtualizable_box = self.virtualizable_boxes[-1]
- virtualizable = vinfo.unwrap_virtualizable_box(virtualizable_box)
- if vinfo.tracing_after_residual_call(virtualizable):
- # the virtualizable escaped during CALL_MAY_FORCE.
- escapes = True
- #
- if escapes:
- self.switch_to_blackhole(ABORT_ESCAPE)
- #
- if escapes:
- self.load_fields_from_virtualizable()
+ def vrefs_after_residual_call(self):
+ vrefinfo = self.staticdata.virtualref_info
+ for i in range(0, len(self.virtualref_boxes), 2):
+ virtualbox = self.virtualref_boxes[i]
+ vrefbox = self.virtualref_boxes[i+1]
+ vref = vrefbox.getref_base()
+ if vrefinfo.tracing_after_residual_call(vref):
+ # this vref was really a virtual_ref, but it escaped
+ # during this CALL_MAY_FORCE. Mark this fact by
+ # generating a VIRTUAL_REF_FINISH on it and replacing
+ # it by ConstPtr(NULL).
+ self.stop_tracking_virtualref(i)
+
+ def vable_after_residual_call(self):
+ vinfo = self.staticdata.virtualizable_info
+ if vinfo is not None:
+ virtualizable_box = self.virtualizable_boxes[-1]
+ virtualizable = vinfo.unwrap_virtualizable_box(virtualizable_box)
+ if vinfo.tracing_after_residual_call(virtualizable):
+ # the virtualizable escaped during CALL_MAY_FORCE.
+ self.load_fields_from_virtualizable()
+ raise SwitchToBlackhole(ABORT_ESCAPE, raising_exception=True)
+ # ^^^ we set 'raising_exception' to True because we must still
+ # have the eventual exception raised (this is normally done
+ # after the call to vable_after_residual_call()).
def stop_tracking_virtualref(self, i):
virtualbox = self.virtualref_boxes[i]
@@ -1871,44 +1858,37 @@
# mark by replacing it with ConstPtr(NULL)
self.virtualref_boxes[i+1] = self.cpu.ts.CONST_NULL
- def handle_exception(self):
- etype = self.cpu.get_exception()
- evalue = self.cpu.get_exc_value()
- assert bool(etype) == bool(evalue)
- self.cpu.clear_exception()
+ def handle_possible_exception(self):
frame = self.framestack[-1]
- if etype:
- exception_box = self.cpu.ts.get_exception_box(etype)
- exc_value_box = self.cpu.ts.get_exc_value_box(evalue)
- op = frame.generate_guard(frame.pc, rop.GUARD_EXCEPTION,
+ if self.last_exc_value_box is not None:
+ exception_box = self.cpu.ts.cls_of_box(self.last_exc_value_box)
+ op = frame.generate_guard(rop.GUARD_EXCEPTION,
None, [exception_box])
- if op:
- op.result = exc_value_box
- return self.finishframe_exception(exception_box, exc_value_box)
+ assert op is not None
+ op.result = self.last_exc_value_box
+ self.class_of_last_exc_is_const = True
+ self.finishframe_exception()
else:
- frame.generate_guard(frame.pc, rop.GUARD_NO_EXCEPTION, None, [])
- return False
-
- def assert_no_exception(self):
- assert not self.cpu.get_exception()
- return False
+ frame.generate_guard(rop.GUARD_NO_EXCEPTION, None, [])
- def handle_overflow_error(self):
+ def handle_possible_overflow_error(self):
frame = self.framestack[-1]
- if self.cpu._overflow_flag:
- self.cpu._overflow_flag = False
- frame.generate_guard(frame.pc, rop.GUARD_OVERFLOW, None, [])
- return self.raise_overflow_error()
+ if self.last_exc_value_box is not None:
+ frame.generate_guard(rop.GUARD_OVERFLOW, None)
+ assert isinstance(self.last_exc_value_box, Const)
+ assert self.class_of_last_exc_is_const
+ self.finishframe_exception()
else:
- frame.generate_guard(frame.pc, rop.GUARD_NO_OVERFLOW, None, [])
- return False
+ frame.generate_guard(rop.GUARD_NO_OVERFLOW, None)
+
+ def assert_no_exception(self):
+ assert self.last_exc_value_box is None
- def rebuild_state_after_failure(self, resumedescr, newboxes):
+ def rebuild_state_after_failure(self, resumedescr):
vinfo = self.staticdata.virtualizable_info
self.framestack = []
- expect_virtualizable = vinfo is not None
- virtualizable_boxes, virtualref_boxes = resume.rebuild_from_resumedata(
- self, newboxes, resumedescr, expect_virtualizable)
+ boxlists = resume.rebuild_from_resumedata(self, resumedescr, vinfo)
+ inputargs_and_holes, virtualizable_boxes, virtualref_boxes = boxlists
#
# virtual refs: make the vrefs point to the freshly allocated virtuals
self.virtualref_boxes = virtualref_boxes
@@ -1921,7 +1901,7 @@
#
# virtualizable: synchronize the real virtualizable and the local
# boxes, in whichever direction is appropriate
- if expect_virtualizable:
+ if vinfo is not None:
self.virtualizable_boxes = virtualizable_boxes
# just jumped away from assembler (case 4 in the comment in
# virtualizable.py) into tracing (case 2); check that vable_token
@@ -1930,13 +1910,14 @@
virtualizable_box = self.virtualizable_boxes[-1]
virtualizable = vinfo.unwrap_virtualizable_box(virtualizable_box)
assert not virtualizable.vable_token
- if self._already_allocated_resume_virtuals is not None:
+ if 0: ## self._already_allocated_resume_virtuals is not None:
# resuming from a ResumeGuardForcedDescr: load the new values
# currently stored on the virtualizable fields
self.load_fields_from_virtualizable()
else:
# normal case: fill the virtualizable with the local boxes
self.synchronize_virtualizable()
+ return inputargs_and_holes
def check_synchronized_virtualizable(self):
if not we_are_translated():
@@ -1953,8 +1934,8 @@
def load_fields_from_virtualizable(self):
# Force a reload of the virtualizable fields into the local
- # boxes (called only in escaping cases)
- assert self.is_blackholing()
+ # boxes (called only in escaping cases). Only call this function
+ # just before SwitchToBlackhole.
vinfo = self.staticdata.virtualizable_info
if vinfo is not None:
virtualizable_box = self.virtualizable_boxes[-1]
@@ -2003,11 +1984,9 @@
return boxes
def replace_box(self, oldbox, newbox):
+ assert isinstance(oldbox, Box)
for frame in self.framestack:
- boxes = frame.env
- for i in range(len(boxes)):
- if boxes[i] is oldbox:
- boxes[i] = newbox
+ frame.replace_active_box_in_frame(oldbox, newbox)
boxes = self.virtualref_boxes
for i in range(len(boxes)):
if boxes[i] is oldbox:
@@ -2019,8 +1998,6 @@
boxes[i] = newbox
def find_biggest_function(self):
- assert not self.is_blackholing()
-
start_stack = []
max_size = 0
max_key = None
@@ -2042,23 +2019,158 @@
max_key = key
return max_key
- def direct_assembler_call(self, pc, varargs, token, call_position):
- """ Generate a direct call to assembler for portal entry point.
+ def direct_assembler_call(self, token):
+ """ Generate a direct call to assembler for portal entry point,
+ patching the CALL_MAY_FORCE that occurred just now.
"""
- assert not self.is_blackholing() # XXX
+ op = self.history.operations.pop()
+ assert op.opnum == rop.CALL_MAY_FORCE
num_green_args = self.staticdata.num_green_args
- args = varargs[num_green_args + 1:]
- resbox = self.history.operations[call_position].result
- rest = self.history.slice_history_at(call_position)
+ args = op.args[num_green_args + 1:]
if self.staticdata.virtualizable_info is not None:
vindex = self.staticdata.virtualizable_info.index_of_virtualizable
vbox = args[vindex - num_green_args]
- args += self.gen_load_from_other_virtualizable(vbox)
- self.history.record(rop.CALL_ASSEMBLER, args[:], resbox, descr=token)
- self.history.operations += rest
+ args = args + self.gen_load_from_other_virtualizable(vbox)
+ # ^^^ and not "+=", which makes 'args' a resizable list
+ op.opnum = rop.CALL_ASSEMBLER
+ op.args = args
+ op.descr = token
+ self.history.operations.append(op)
-class GenerateMergePoint(Exception):
+# ____________________________________________________________
+
+class GenerateMergePoint(JitException):
def __init__(self, args, target_loop_token):
assert target_loop_token is not None
self.argboxes = args
self.target_loop_token = target_loop_token
+
+class ChangeFrame(JitException):
+ """Raised after we mutated metainterp.framestack, in order to force
+ it to reload the current top-of-stack frame that gets interpreted."""
+
+class SwitchToBlackhole(JitException):
+ def __init__(self, reason, raising_exception=False):
+ self.reason = reason
+ self.raising_exception = raising_exception
+ # ^^^ must be set to True if the SwitchToBlackhole is raised at a
+ # point where the exception on metainterp.last_exc_value_box
+ # is supposed to be raised. The default False means that it
+ # should just be copied into the blackhole interp, but not raised.
+
+# ____________________________________________________________
+
+def _get_opimpl_method(name, argcodes):
+ from pypy.jit.metainterp.blackhole import signedord
+ #
+ def handler(self, position):
+ assert position >= 0
+ args = ()
+ next_argcode = 0
+ code = self.bytecode
+ orgpc = position
+ position += 1
+ for argtype in argtypes:
+ if argtype == "box": # a box, of whatever type
+ argcode = argcodes[next_argcode]
+ next_argcode = next_argcode + 1
+ if argcode == 'i':
+ value = self.registers_i[ord(code[position])]
+ elif argcode == 'c':
+ value = ConstInt(signedord(code[position]))
+ elif argcode == 'r':
+ value = self.registers_r[ord(code[position])]
+ elif argcode == 'f':
+ value = self.registers_f[ord(code[position])]
+ else:
+ raise AssertionError("bad argcode")
+ position += 1
+ elif argtype == "descr" or argtype == "jitcode":
+ assert argcodes[next_argcode] == 'd'
+ next_argcode = next_argcode + 1
+ index = ord(code[position]) | (ord(code[position+1])<<8)
+ value = self.metainterp.staticdata.opcode_descrs[index]
+ if argtype == "jitcode":
+ assert isinstance(value, JitCode)
+ position += 2
+ elif argtype == "label":
+ assert argcodes[next_argcode] == 'L'
+ next_argcode = next_argcode + 1
+ value = ord(code[position]) | (ord(code[position+1])<<8)
+ position += 2
+ elif argtype == "boxes": # a list of boxes of some type
+ length = ord(code[position])
+ value = [None] * length
+ self.prepare_list_of_boxes(value, 0, position,
+ argcodes[next_argcode])
+ next_argcode = next_argcode + 1
+ position += 1 + length
+ elif argtype == "boxes2": # two lists of boxes merged into one
+ length1 = ord(code[position])
+ position2 = position + 1 + length1
+ length2 = ord(code[position2])
+ value = [None] * (length1 + length2)
+ self.prepare_list_of_boxes(value, 0, position,
+ argcodes[next_argcode])
+ self.prepare_list_of_boxes(value, length1, position2,
+ argcodes[next_argcode + 1])
+ next_argcode = next_argcode + 2
+ position = position2 + 1 + length2
+ elif argtype == "boxes3": # three lists of boxes merged into one
+ length1 = ord(code[position])
+ position2 = position + 1 + length1
+ length2 = ord(code[position2])
+ position3 = position2 + 1 + length2
+ length3 = ord(code[position3])
+ value = [None] * (length1 + length2 + length3)
+ self.prepare_list_of_boxes(value, 0, position,
+ argcodes[next_argcode])
+ self.prepare_list_of_boxes(value, length1, position2,
+ argcodes[next_argcode + 1])
+ self.prepare_list_of_boxes(value, length1 + length2, position3,
+ argcodes[next_argcode + 2])
+ next_argcode = next_argcode + 3
+ position = position3 + 1 + length3
+ elif argtype == "orgpc":
+ value = orgpc
+ else:
+ raise AssertionError("bad argtype: %r" % (argtype,))
+ args += (value,)
+ #
+ num_return_args = len(argcodes) - next_argcode
+ assert num_return_args == 0 or num_return_args == 2
+ if num_return_args:
+ # Save the type of the resulting box. This is needed if there is
+ # a get_list_of_active_boxes(). See comments there.
+ self._result_argcode = argcodes[next_argcode + 1]
+ position += 1
+ else:
+ self._result_argcode = 'v'
+ self.pc = position
+ #
+ if not we_are_translated():
+ print '\tpyjitpl: %s(%s)' % (name, ', '.join(map(repr, args))),
+ try:
+ resultbox = unboundmethod(self, *args)
+ except Exception, e:
+ print '-> %s!' % e.__class__.__name__
+ raise
+ if num_return_args == 0:
+ print
+ assert resultbox is None
+ else:
+ print '-> %r' % (resultbox,)
+ assert argcodes[next_argcode] == '>'
+ result_argcode = argcodes[next_argcode + 1]
+ assert resultbox.type == {'i': history.INT,
+ 'r': history.REF,
+ 'f': history.FLOAT}[result_argcode]
+ else:
+ resultbox = unboundmethod(self, *args)
+ #
+ self.make_result_of_lastop(resultbox)
+ #
+ unboundmethod = getattr(MIFrame, 'opimpl_' + name).im_func
+ argtypes = unrolling_iterable(unboundmethod.argtypes)
+ handler.func_name = 'handler_' + name
+ return handler
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/resoperation.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/resoperation.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/resoperation.py Tue Jun 8 19:48:40 2010
@@ -22,10 +22,11 @@
self.setdescr(descr)
def setdescr(self, descr):
- # for 'call', 'new', 'getfield_gc'...: the descr is a number provided
- # by the backend holding details about the type of the operation --
- # actually an instance of a class, typically Descr, that inherits
- # from AbstractDescr
+ # for 'call', 'new', 'getfield_gc'...: the descr is a prebuilt
+ # instance provided by the backend holding details about the type
+ # of the operation. It must inherit from AbstractDescr. The
+ # backend provides it with cpu.fielddescrof(), cpu.arraydescrof(),
+ # cpu.calldescrof(), and cpu.typedescrof().
from pypy.jit.metainterp.history import check_descr
check_descr(descr)
self.descr = descr
@@ -134,10 +135,9 @@
'_NOSIDEEFFECT_FIRST', # ----- start of no_side_effect operations -----
'_ALWAYS_PURE_FIRST', # ----- start of always_pure operations -----
- 'OOSEND_PURE', # ootype operation
+ #'OOSEND_PURE', # ootype operation
'CALL_PURE',
#
- 'CAST_PTR_TO_INT/1',
'INT_ADD/2',
'INT_SUB/2',
'INT_MUL/2',
@@ -156,7 +156,6 @@
'FLOAT_TRUEDIV/2',
'FLOAT_NEG/1',
'FLOAT_ABS/1',
- 'FLOAT_IS_TRUE/1b',
'CAST_FLOAT_TO_INT/1',
'CAST_INT_TO_FLOAT/1',
#
@@ -177,15 +176,15 @@
'FLOAT_GT/2b',
'FLOAT_GE/2b',
#
+ 'INT_IS_ZERO/1b',
'INT_IS_TRUE/1b',
'INT_NEG/1',
'INT_INVERT/1',
- 'BOOL_NOT/1b',
#
'SAME_AS/1', # gets a Const or a Box, turns it into another Box
#
- 'OOIS/2b',
- 'OOISNOT/2b',
+ 'PTR_EQ/2b',
+ 'PTR_NE/2b',
#
'ARRAYLEN_GC/1d',
'STRLEN/1',
@@ -197,8 +196,8 @@
'UNICODEGETITEM/2',
#
# ootype operations
- 'INSTANCEOF/1db',
- 'SUBCLASSOF/2b',
+ #'INSTANCEOF/1db',
+ #'SUBCLASSOF/2b',
#
'_ALWAYS_PURE_LAST', # ----- end of always_pure operations -----
@@ -209,29 +208,29 @@
'NEW_WITH_VTABLE/1',
'NEW_ARRAY/1d',
'FORCE_TOKEN/0',
- 'VIRTUAL_REF/2',
+ 'VIRTUAL_REF/2', # removed before it's passed to the backend
'_NOSIDEEFFECT_LAST', # ----- end of no_side_effect operations -----
'SETARRAYITEM_GC/3d',
'SETARRAYITEM_RAW/3d',#only added by backend.llsupport.gc.rewrite_assembler
'SETFIELD_GC/2d',
'SETFIELD_RAW/2d',
- 'ARRAYCOPY/7d',
+ 'ARRAYCOPY/7d', # removed before it's passed to the backend
'NEWSTR/1',
'STRSETITEM/3',
'UNICODESETITEM/3',
'NEWUNICODE/1',
- 'RUNTIMENEW/1', # ootype operation
+ #'RUNTIMENEW/1', # ootype operation
'COND_CALL_GC_WB', # [objptr, newvalue] (for the write barrier)
'DEBUG_MERGE_POINT/1', # debugging only
- 'VIRTUAL_REF_FINISH/2',
+ 'VIRTUAL_REF_FINISH/2', # removed before it's passed to the backend
'_CANRAISE_FIRST', # ----- start of can_raise operations -----
'CALL',
'CALL_ASSEMBLER',
'CALL_MAY_FORCE',
'CALL_LOOPINVARIANT',
- 'OOSEND', # ootype operation
+ #'OOSEND', # ootype operation
'_CANRAISE_LAST', # ----- end of can_raise operations -----
'_OVF_FIRST', # ----- start of is_ovf operations -----
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/resume.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/resume.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/resume.py Tue Jun 8 19:48:40 2010
@@ -1,10 +1,12 @@
import sys, os
-from pypy.jit.metainterp.history import Box, Const, ConstInt, INT, REF
+from pypy.jit.metainterp.history import Box, Const, ConstInt, getkind
+from pypy.jit.metainterp.history import BoxInt, BoxPtr, BoxFloat
+from pypy.jit.metainterp.history import INT, REF, FLOAT, HOLE
from pypy.jit.metainterp.resoperation import rop
from pypy.jit.metainterp import jitprof
-from pypy.rpython.lltypesystem import rffi
+from pypy.rpython.lltypesystem import lltype, llmemory, rffi
from pypy.rlib import rarithmetic
-from pypy.rlib.objectmodel import we_are_translated
+from pypy.rlib.objectmodel import we_are_translated, specialize
from pypy.rlib.debug import have_debug_prints
from pypy.rlib.debug import debug_start, debug_stop, debug_print
@@ -21,26 +23,29 @@
self.boxes = boxes
class FrameInfo(object):
- __slots__ = ('prev', 'jitcode', 'pc', 'exception_target')
+ __slots__ = ('prev', 'jitcode', 'pc')
- def __init__(self, prev, frame):
+ def __init__(self, prev, jitcode, pc):
self.prev = prev
- self.jitcode = frame.jitcode
- self.pc = frame.pc
- self.exception_target = frame.exception_target
+ self.jitcode = jitcode
+ self.pc = pc
def _ensure_parent_resumedata(framestack, n):
target = framestack[n]
- if n == 0 or target.parent_resumedata_frame_info_list is not None:
+ if n == 0:
return
- _ensure_parent_resumedata(framestack, n-1)
back = framestack[n-1]
+ if target.parent_resumedata_frame_info_list is not None:
+ assert target.parent_resumedata_frame_info_list.pc == back.pc
+ return
+ _ensure_parent_resumedata(framestack, n-1)
target.parent_resumedata_frame_info_list = FrameInfo(
back.parent_resumedata_frame_info_list,
- back)
+ back.jitcode,
+ back.pc)
target.parent_resumedata_snapshot = Snapshot(
back.parent_resumedata_snapshot,
- back.env[:])
+ back.get_list_of_active_boxes(True))
def capture_resumedata(framestack, virtualizable_boxes, virtualref_boxes,
storage):
@@ -48,12 +53,15 @@
top = framestack[n]
_ensure_parent_resumedata(framestack, n)
frame_info_list = FrameInfo(top.parent_resumedata_frame_info_list,
- top)
+ top.jitcode, top.pc)
storage.rd_frame_info_list = frame_info_list
- snapshot = Snapshot(top.parent_resumedata_snapshot, top.env[:])
- snapshot = Snapshot(snapshot, virtualref_boxes[:]) # xxx for now
+ snapshot = Snapshot(top.parent_resumedata_snapshot,
+ top.get_list_of_active_boxes(False))
if virtualizable_boxes is not None:
- snapshot = Snapshot(snapshot, virtualizable_boxes[:]) # xxx for now
+ boxes = virtualref_boxes + virtualizable_boxes
+ else:
+ boxes = virtualref_boxes[:]
+ snapshot = Snapshot(snapshot, boxes)
storage.rd_snapshot = snapshot
class Numbering(object):
@@ -182,6 +190,7 @@
n += 1
liveboxes[box] = tagged
nums[i] = tagged
+ #
numb = Numbering(numb1, nums)
self.numberings[snapshot] = numb, liveboxes, v
return numb, liveboxes.copy(), v
@@ -388,10 +397,10 @@
class AbstractVirtualInfo(object):
- def allocate(self, metainterp):
- raise NotImplementedError
- def setfields(self, metainterp, box, fn_decode_box):
- raise NotImplementedError
+ #def allocate(self, metainterp):
+ # raise NotImplementedError
+ #def setfields(self, decoder, struct):
+ # raise NotImplementedError
def equals(self, fieldnums):
return tagged_list_eq(self.fieldnums, fieldnums)
def set_content(self, fieldnums):
@@ -405,12 +414,11 @@
self.fielddescrs = fielddescrs
#self.fieldnums = ...
- def setfields(self, metainterp, box, fn_decode_box):
+ @specialize.argtype(1)
+ def setfields(self, decoder, struct):
for i in range(len(self.fielddescrs)):
- fieldbox = fn_decode_box(self.fieldnums[i])
- metainterp.execute_and_record(rop.SETFIELD_GC,
- self.fielddescrs[i],
- box, fieldbox)
+ descr = self.fielddescrs[i]
+ decoder.setfield(descr, struct, self.fieldnums[i])
def debug_prints(self):
assert len(self.fielddescrs) == len(self.fieldnums)
@@ -424,9 +432,9 @@
AbstractVirtualStructInfo.__init__(self, fielddescrs)
self.known_class = known_class
- def allocate(self, metainterp):
- return metainterp.execute_and_record(rop.NEW_WITH_VTABLE,
- None, self.known_class)
+ @specialize.argtype(1)
+ def allocate(self, decoder):
+ return decoder.allocate_with_vtable(self.known_class)
def debug_prints(self):
debug_print("\tvirtualinfo", self.known_class.repr_rpython())
@@ -437,8 +445,9 @@
AbstractVirtualStructInfo.__init__(self, fielddescrs)
self.typedescr = typedescr
- def allocate(self, metainterp):
- return metainterp.execute_and_record(rop.NEW, self.typedescr)
+ @specialize.argtype(1)
+ def allocate(self, decoder):
+ return decoder.allocate_struct(self.typedescr)
def debug_prints(self):
debug_print("\tvstructinfo", self.typedescr.repr_rpython())
@@ -449,117 +458,457 @@
self.arraydescr = arraydescr
#self.fieldnums = ...
- def allocate(self, metainterp):
+ @specialize.argtype(1)
+ def allocate(self, decoder):
length = len(self.fieldnums)
- return metainterp.execute_and_record(rop.NEW_ARRAY,
- self.arraydescr,
- ConstInt(length))
-
- def setfields(self, metainterp, box, fn_decode_box):
- for i in range(len(self.fieldnums)):
- itembox = fn_decode_box(self.fieldnums[i])
- metainterp.execute_and_record(rop.SETARRAYITEM_GC,
- self.arraydescr,
- box, ConstInt(i), itembox)
+ return decoder.allocate_array(self.arraydescr, length)
+
+ @specialize.argtype(1)
+ def setfields(self, decoder, array):
+ arraydescr = self.arraydescr
+ length = len(self.fieldnums)
+ # NB. the check for the kind of array elements is moved out of the loop
+ if arraydescr.is_array_of_pointers():
+ for i in range(length):
+ decoder.setarrayitem_ref(arraydescr, array, i,
+ self.fieldnums[i])
+ elif arraydescr.is_array_of_floats():
+ for i in range(length):
+ decoder.setarrayitem_float(arraydescr, array, i,
+ self.fieldnums[i])
+ else:
+ for i in range(length):
+ decoder.setarrayitem_int(arraydescr, array, i,
+ self.fieldnums[i])
def debug_prints(self):
debug_print("\tvarrayinfo", self.arraydescr)
for i in self.fieldnums:
debug_print("\t\t", str(untag(i)))
+# ____________________________________________________________
-def rebuild_from_resumedata(metainterp, newboxes, storage,
- expects_virtualizables):
- resumereader = ResumeDataReader(storage, newboxes, metainterp)
- virtualizable_boxes = None
- if expects_virtualizables:
- virtualizable_boxes = resumereader.consume_boxes()
- virtualref_boxes = resumereader.consume_boxes()
- frameinfo = storage.rd_frame_info_list
- while True:
- env = resumereader.consume_boxes()
- f = metainterp.newframe(frameinfo.jitcode)
- f.setup_resume_at_op(frameinfo.pc, frameinfo.exception_target, env)
- frameinfo = frameinfo.prev
- if frameinfo is None:
- break
- metainterp.framestack.reverse()
- return virtualizable_boxes, virtualref_boxes
-
-def force_from_resumedata(metainterp, newboxes, storage,
- expects_virtualizables):
- resumereader = ResumeDataReader(storage, newboxes, metainterp)
- virtualizable_boxes = None
- if expects_virtualizables:
- virtualizable_boxes = resumereader.consume_boxes()
- virtualref_boxes = resumereader.consume_boxes()
- return virtualizable_boxes, virtualref_boxes, resumereader.virtuals
-
-
-class ResumeDataReader(object):
+class AbstractResumeDataReader(object):
+ """A base mixin containing the logic to reconstruct virtuals out of
+ guard failure. There are two implementations of this mixin:
+ ResumeDataBoxReader for when we are compiling (i.e. when we have a
+ metainterp), and ResumeDataDirectReader for when we are merely
+ blackholing and want the best performance.
+ """
+ _mixin_ = True
virtuals = None
+ virtual_default = None
- def __init__(self, storage, liveboxes, metainterp=None):
+ def _init(self, cpu, storage):
+ self.cpu = cpu
self.cur_numb = storage.rd_numb
self.consts = storage.rd_consts
- self.liveboxes = liveboxes
- self.cpu = metainterp.cpu
- self._prepare_virtuals(metainterp, storage.rd_virtuals)
- self._prepare_pendingfields(metainterp, storage.rd_pendingfields)
- def _prepare_virtuals(self, metainterp, virtuals):
+ def _prepare(self, storage):
+ self._prepare_virtuals(storage.rd_virtuals)
+ self._prepare_pendingfields(storage.rd_pendingfields)
+
+ def _prepare_virtuals(self, virtuals):
if virtuals:
- v = metainterp._already_allocated_resume_virtuals
- if v is not None:
- self.virtuals = v
- return
- self.virtuals = [None] * len(virtuals)
+ self.virtuals = [self.virtual_default] * len(virtuals)
for i in range(len(virtuals)):
vinfo = virtuals[i]
if vinfo is not None:
- self.virtuals[i] = vinfo.allocate(metainterp)
+ self.virtuals[i] = vinfo.allocate(self)
for i in range(len(virtuals)):
vinfo = virtuals[i]
if vinfo is not None:
- vinfo.setfields(metainterp, self.virtuals[i],
- self._decode_box)
+ vinfo.setfields(self, self.virtuals[i])
- def _prepare_pendingfields(self, metainterp, pendingfields):
- if pendingfields:
- if metainterp._already_allocated_resume_virtuals is not None:
- return
+ def _prepare_pendingfields(self, pendingfields):
+ if pendingfields is not None:
for descr, num, fieldnum in pendingfields:
- box = self._decode_box(num)
- fieldbox = self._decode_box(fieldnum)
- metainterp.execute_and_record(rop.SETFIELD_GC,
- descr, box, fieldbox)
-
- def consume_boxes(self):
- numb = self.cur_numb
- assert numb is not None
- nums = numb.nums
- n = len(nums)
- boxes = [None] * n
- for i in range(n):
- boxes[i] = self._decode_box(nums[i])
- self.cur_numb = numb.prev
- return boxes
+ struct = self.decode_ref(num)
+ self.setfield(descr, struct, fieldnum)
+
+ def _prepare_next_section(self, info):
+ # Use info.enumerate_vars(), normally dispatching to
+ # pypy.jit.codewriter.jitcode. Some tests give a different 'info'.
+ info.enumerate_vars(self._callback_i,
+ self._callback_r,
+ self._callback_f,
+ self.unique_id) # <-- annotation hack
+ self.cur_numb = self.cur_numb.prev
+
+ def _callback_i(self, index, register_index):
+ value = self.decode_int(self.cur_numb.nums[index])
+ self.write_an_int(register_index, value)
+
+ def _callback_r(self, index, register_index):
+ value = self.decode_ref(self.cur_numb.nums[index])
+ self.write_a_ref(register_index, value)
+
+ def _callback_f(self, index, register_index):
+ value = self.decode_float(self.cur_numb.nums[index])
+ self.write_a_float(register_index, value)
+
+ def done(self):
+ self.cpu.clear_latest_values(self.cpu.get_latest_value_count())
+
+# ---------- when resuming for pyjitpl.py, make boxes ----------
+
+def rebuild_from_resumedata(metainterp, storage, virtualizable_info):
+ resumereader = ResumeDataBoxReader(storage, metainterp)
+ boxes = resumereader.consume_vref_and_vable_boxes(virtualizable_info)
+ virtualizable_boxes, virtualref_boxes = boxes
+ frameinfo = storage.rd_frame_info_list
+ while True:
+ f = metainterp.newframe(frameinfo.jitcode)
+ f.setup_resume_at_op(frameinfo.pc)
+ resumereader.consume_boxes(f.get_current_position_info(),
+ f.registers_i, f.registers_r, f.registers_f)
+ frameinfo = frameinfo.prev
+ if frameinfo is None:
+ break
+ metainterp.framestack.reverse()
+ resumereader.done()
+ return resumereader.liveboxes, virtualizable_boxes, virtualref_boxes
+
+class ResumeDataBoxReader(AbstractResumeDataReader):
+ unique_id = lambda: None
- def _decode_box(self, tagged):
+ def __init__(self, storage, metainterp):
+ self._init(metainterp.cpu, storage)
+ self.metainterp = metainterp
+ self.liveboxes = [None] * metainterp.cpu.get_latest_value_count()
+ self._prepare(storage)
+
+ def consume_boxes(self, info, boxes_i, boxes_r, boxes_f):
+ self.boxes_i = boxes_i
+ self.boxes_r = boxes_r
+ self.boxes_f = boxes_f
+ self._prepare_next_section(info)
+
+ def consume_virtualizable_boxes(self, vinfo, nums):
+ # we have to ignore the initial part of 'nums' (containing vrefs),
+ # find the virtualizable from nums[-1], and use it to know how many
+ # boxes of which type we have to return. This does not write
+ # anything into the virtualizable.
+ virtualizablebox = self.decode_ref(nums[-1])
+ virtualizable = vinfo.unwrap_virtualizable_box(virtualizablebox)
+ return vinfo.load_list_of_boxes(virtualizable, self, nums)
+
+ def consume_virtualref_boxes(self, nums, end):
+ # Returns a list of boxes, assumed to be all BoxPtrs.
+ # We leave up to the caller to call vrefinfo.continue_tracing().
+ assert (end & 1) == 0
+ return [self.decode_ref(nums[i]) for i in range(end)]
+
+ def consume_vref_and_vable_boxes(self, vinfo):
+ nums = self.cur_numb.nums
+ self.cur_numb = self.cur_numb.prev
+ if vinfo is None:
+ virtualizable_boxes = None
+ end = len(nums)
+ else:
+ virtualizable_boxes = self.consume_virtualizable_boxes(vinfo, nums)
+ end = len(nums) - len(virtualizable_boxes)
+ virtualref_boxes = self.consume_virtualref_boxes(nums, end)
+ return virtualizable_boxes, virtualref_boxes
+
+ def allocate_with_vtable(self, known_class):
+ return self.metainterp.execute_and_record(rop.NEW_WITH_VTABLE,
+ None, known_class)
+
+ def allocate_struct(self, typedescr):
+ return self.metainterp.execute_and_record(rop.NEW, typedescr)
+
+ def allocate_array(self, arraydescr, length):
+ return self.metainterp.execute_and_record(rop.NEW_ARRAY,
+ arraydescr, ConstInt(length))
+
+ def setfield(self, descr, structbox, fieldnum):
+ if descr.is_pointer_field():
+ kind = REF
+ elif descr.is_float_field():
+ kind = FLOAT
+ else:
+ kind = INT
+ fieldbox = self.decode_box(fieldnum, kind)
+ self.metainterp.execute_and_record(rop.SETFIELD_GC, descr,
+ structbox, fieldbox)
+
+ def setarrayitem_int(self, arraydescr, arraybox, index, fieldnum):
+ self.setarrayitem(arraydescr, arraybox, index, fieldnum, INT)
+
+ def setarrayitem_ref(self, arraydescr, arraybox, index, fieldnum):
+ self.setarrayitem(arraydescr, arraybox, index, fieldnum, REF)
+
+ def setarrayitem_float(self, arraydescr, arraybox, index, fieldnum):
+ self.setarrayitem(arraydescr, arraybox, index, fieldnum, FLOAT)
+
+ def setarrayitem(self, arraydescr, arraybox, index, fieldnum, kind):
+ itembox = self.decode_box(fieldnum, kind)
+ self.metainterp.execute_and_record(rop.SETARRAYITEM_GC,
+ arraydescr, arraybox,
+ ConstInt(index), itembox)
+
+ def decode_int(self, tagged):
+ return self.decode_box(tagged, INT)
+ def decode_ref(self, tagged):
+ return self.decode_box(tagged, REF)
+ def decode_float(self, tagged):
+ return self.decode_box(tagged, FLOAT)
+
+ def decode_box(self, tagged, kind):
num, tag = untag(tagged)
if tag == TAGCONST:
if tagged_eq(tagged, NULLREF):
- return self.cpu.ts.CONST_NULL
- return self.consts[num]
+ box = self.cpu.ts.CONST_NULL
+ else:
+ box = self.consts[num]
elif tag == TAGVIRTUAL:
virtuals = self.virtuals
assert virtuals is not None
- return virtuals[num]
+ box = virtuals[num]
+ elif tag == TAGINT:
+ box = ConstInt(num)
+ else:
+ assert tag == TAGBOX
+ box = self.liveboxes[num]
+ if box is None:
+ box = self.load_box_from_cpu(num, kind)
+ assert box.type == kind
+ return box
+
+ def load_box_from_cpu(self, num, kind):
+ if num < 0:
+ num += len(self.liveboxes)
+ assert num >= 0
+ if kind == INT:
+ box = BoxInt(self.cpu.get_latest_value_int(num))
+ elif kind == REF:
+ box = BoxPtr(self.cpu.get_latest_value_ref(num))
+ elif kind == FLOAT:
+ box = BoxFloat(self.cpu.get_latest_value_float(num))
+ else:
+ assert 0, "bad kind: %d" % ord(kind)
+ self.liveboxes[num] = box
+ return box
+
+ def decode_box_of_type(self, TYPE, tagged):
+ kind = getkind(TYPE)
+ if kind == 'int': kind = INT
+ elif kind == 'ref': kind = REF
+ elif kind == 'float': kind = FLOAT
+ else: raise AssertionError(kind)
+ return self.decode_box(tagged, kind)
+ decode_box_of_type._annspecialcase_ = 'specialize:arg(1)'
+
+ def write_an_int(self, index, box):
+ self.boxes_i[index] = box
+ def write_a_ref(self, index, box):
+ self.boxes_r[index] = box
+ def write_a_float(self, index, box):
+ self.boxes_f[index] = box
+
+# ---------- when resuming for blackholing, get direct values ----------
+
+def blackhole_from_resumedata(blackholeinterpbuilder, storage,
+ all_virtuals=None):
+ resumereader = ResumeDataDirectReader(blackholeinterpbuilder.cpu, storage,
+ all_virtuals)
+ vinfo = blackholeinterpbuilder.metainterp_sd.virtualizable_info
+ vrefinfo = blackholeinterpbuilder.metainterp_sd.virtualref_info
+ resumereader.consume_vref_and_vable(vrefinfo, vinfo)
+ #
+ # First get a chain of blackhole interpreters whose length is given
+ # by the depth of rd_frame_info_list. The first one we get must be
+ # the bottom one, i.e. the last one in the chain, in order to make
+ # the comment in BlackholeInterpreter.setposition() valid.
+ nextbh = None
+ frameinfo = storage.rd_frame_info_list
+ while True:
+ curbh = blackholeinterpbuilder.acquire_interp()
+ curbh.nextblackholeinterp = nextbh
+ nextbh = curbh
+ frameinfo = frameinfo.prev
+ if frameinfo is None:
+ break
+ firstbh = nextbh
+ #
+ # Now fill the blackhole interpreters with resume data.
+ curbh = firstbh
+ frameinfo = storage.rd_frame_info_list
+ while True:
+ curbh.setposition(frameinfo.jitcode, frameinfo.pc)
+ resumereader.consume_one_section(curbh)
+ curbh = curbh.nextblackholeinterp
+ frameinfo = frameinfo.prev
+ if frameinfo is None:
+ break
+ resumereader.done()
+ return firstbh
+
+def force_from_resumedata(metainterp_sd, storage):
+ resumereader = ResumeDataDirectReader(metainterp_sd.cpu, storage)
+ resumereader.handling_async_forcing()
+ vinfo = metainterp_sd.virtualizable_info
+ vrefinfo = metainterp_sd.virtualref_info
+ resumereader.consume_vref_and_vable(vrefinfo, vinfo)
+ return resumereader.virtuals
+
+class ResumeDataDirectReader(AbstractResumeDataReader):
+ unique_id = lambda: None
+ virtual_default = lltype.nullptr(llmemory.GCREF.TO)
+ resume_after_guard_not_forced = 0
+ # 0: not a GUARD_NOT_FORCED
+ # 1: in handle_async_forcing
+ # 2: resuming from the GUARD_NOT_FORCED
+
+ def __init__(self, cpu, storage, all_virtuals=None):
+ self._init(cpu, storage)
+ if all_virtuals is None: # common case
+ self._prepare(storage)
+ else:
+ # special case for resuming after a GUARD_NOT_FORCED: we already
+ # have the virtuals
+ self.resume_after_guard_not_forced = 2
+ self.virtuals = all_virtuals
+
+ def handling_async_forcing(self):
+ self.resume_after_guard_not_forced = 1
+
+ def consume_one_section(self, blackholeinterp):
+ self.blackholeinterp = blackholeinterp
+ info = blackholeinterp.get_current_position_info()
+ self._prepare_next_section(info)
+
+ def consume_virtualref_info(self, vrefinfo, nums, end):
+ # we have to decode a list of references containing pairs
+ # [..., virtual, vref, ...] stopping at 'end'
+ assert (end & 1) == 0
+ for i in range(0, end, 2):
+ virtual = self.decode_ref(nums[i])
+ vref = self.decode_ref(nums[i+1])
+ # For each pair, we store the virtual inside the vref.
+ vrefinfo.continue_tracing(vref, virtual)
+
+ def consume_vable_info(self, vinfo, nums):
+ # we have to ignore the initial part of 'nums' (containing vrefs),
+ # find the virtualizable from nums[-1], load all other values
+ # from the CPU stack, and copy them into the virtualizable
+ if vinfo is None:
+ return len(nums)
+ virtualizable = self.decode_ref(nums[-1])
+ virtualizable = vinfo.cast_gcref_to_vtype(virtualizable)
+ if self.resume_after_guard_not_forced == 1:
+ # in the middle of handle_async_forcing()
+ assert virtualizable.vable_token
+ virtualizable.vable_token = vinfo.TOKEN_NONE
+ else:
+ # just jumped away from assembler (case 4 in the comment in
+ # virtualizable.py) into tracing (case 2); check that vable_token
+ # is and stays 0. Note the call to reset_vable_token() in
+ # warmstate.py.
+ assert not virtualizable.vable_token
+ return vinfo.write_from_resume_data_partial(virtualizable, self, nums)
+
+ def load_value_of_type(self, TYPE, tagged):
+ from pypy.jit.metainterp.warmstate import specialize_value
+ kind = getkind(TYPE)
+ if kind == 'int':
+ x = self.decode_int(tagged)
+ elif kind == 'ref':
+ x = self.decode_ref(tagged)
+ elif kind == 'float':
+ x = self.decode_float(tagged)
+ else:
+ raise AssertionError(kind)
+ return specialize_value(TYPE, x)
+ load_value_of_type._annspecialcase_ = 'specialize:arg(1)'
+
+ def consume_vref_and_vable(self, vrefinfo, vinfo):
+ nums = self.cur_numb.nums
+ self.cur_numb = self.cur_numb.prev
+ if self.resume_after_guard_not_forced != 2:
+ end_vref = self.consume_vable_info(vinfo, nums)
+ self.consume_virtualref_info(vrefinfo, nums, end_vref)
+
+ def allocate_with_vtable(self, known_class):
+ from pypy.jit.metainterp.executor import exec_new_with_vtable
+ return exec_new_with_vtable(self.cpu, known_class)
+
+ def allocate_struct(self, typedescr):
+ return self.cpu.bh_new(typedescr)
+
+ def allocate_array(self, arraydescr, length):
+ return self.cpu.bh_new_array(arraydescr, length)
+
+ def setfield(self, descr, struct, fieldnum):
+ if descr.is_pointer_field():
+ newvalue = self.decode_ref(fieldnum)
+ self.cpu.bh_setfield_gc_r(struct, descr, newvalue)
+ elif descr.is_float_field():
+ newvalue = self.decode_float(fieldnum)
+ self.cpu.bh_setfield_gc_f(struct, descr, newvalue)
+ else:
+ newvalue = self.decode_int(fieldnum)
+ self.cpu.bh_setfield_gc_i(struct, descr, newvalue)
+
+ def setarrayitem_int(self, arraydescr, array, index, fieldnum):
+ newvalue = self.decode_int(fieldnum)
+ self.cpu.bh_setarrayitem_gc_i(arraydescr, array, index, newvalue)
+
+ def setarrayitem_ref(self, arraydescr, array, index, fieldnum):
+ newvalue = self.decode_ref(fieldnum)
+ self.cpu.bh_setarrayitem_gc_r(arraydescr, array, index, newvalue)
+
+ def setarrayitem_float(self, arraydescr, array, index, fieldnum):
+ newvalue = self.decode_float(fieldnum)
+ self.cpu.bh_setarrayitem_gc_f(arraydescr, array, index, newvalue)
+
+ def decode_int(self, tagged):
+ num, tag = untag(tagged)
+ if tag == TAGCONST:
+ return self.consts[num].getint()
elif tag == TAGINT:
- return ConstInt(num)
+ return num
else:
assert tag == TAGBOX
- return self.liveboxes[num]
+ if num < 0:
+ num += self.cpu.get_latest_value_count()
+ return self.cpu.get_latest_value_int(num)
+
+ def decode_ref(self, tagged):
+ num, tag = untag(tagged)
+ if tag == TAGCONST:
+ if tagged_eq(tagged, NULLREF):
+ return self.cpu.ts.NULLREF
+ return self.consts[num].getref_base()
+ elif tag == TAGVIRTUAL:
+ virtuals = self.virtuals
+ assert virtuals is not None
+ return virtuals[num]
+ else:
+ assert tag == TAGBOX
+ if num < 0:
+ num += self.cpu.get_latest_value_count()
+ return self.cpu.get_latest_value_ref(num)
+
+ def decode_float(self, tagged):
+ num, tag = untag(tagged)
+ if tag == TAGCONST:
+ return self.consts[num].getfloat()
+ else:
+ assert tag == TAGBOX
+ if num < 0:
+ num += self.cpu.get_latest_value_count()
+ return self.cpu.get_latest_value_float(num)
+
+ def write_an_int(self, index, int):
+ self.blackholeinterp.setarg_i(index, int)
+
+ def write_a_ref(self, index, ref):
+ self.blackholeinterp.setarg_r(index, ref)
+
+ def write_a_float(self, index, float):
+ self.blackholeinterp.setarg_f(index, float)
# ____________________________________________________________
@@ -576,7 +925,7 @@
except AttributeError:
jitcodename = str(compute_unique_id(frameinfo.jitcode))
debug_print('\tjitcode/pc', jitcodename,
- frameinfo.pc, frameinfo.exception_target,
+ frameinfo.pc,
'at', compute_unique_id(frameinfo))
frameinfo = frameinfo.prev
numb = storage.rd_numb
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/simple_optimize.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/simple_optimize.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/simple_optimize.py Tue Jun 8 19:48:40 2010
@@ -10,12 +10,16 @@
def transform(op):
from pypy.jit.metainterp.history import AbstractDescr
# change ARRAYCOPY to call, so we don't have to pass around
- # unnecessary information to the backend
+ # unnecessary information to the backend. Do the same with VIRTUAL_REF_*.
if op.opnum == rop.ARRAYCOPY:
descr = op.args[0]
assert isinstance(descr, AbstractDescr)
- return ResOperation(rop.CALL, op.args[1:], op.result, descr=descr)
- return op
+ op = ResOperation(rop.CALL, op.args[1:], op.result, descr=descr)
+ elif op.opnum == rop.VIRTUAL_REF:
+ op = ResOperation(rop.SAME_AS, [op.args[0]], op.result)
+ elif op.opnum == rop.VIRTUAL_REF_FINISH:
+ return []
+ return [op]
def optimize_loop(metainterp_sd, old_loops, loop):
if old_loops:
@@ -35,7 +39,7 @@
modifier = resume.ResumeDataVirtualAdder(descr, memo)
newboxes = modifier.finish(EMPTY_VALUES)
descr.store_final_boxes(op, newboxes)
- newoperations.append(transform(op))
+ newoperations.extend(transform(op))
loop.operations = newoperations
return None
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/specnode.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/specnode.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/specnode.py Tue Jun 8 19:48:40 2010
@@ -57,7 +57,8 @@
from pypy.jit.metainterp import executor, history, resoperation
for ofs, subspecnode in self.fields:
assert isinstance(ofs, history.AbstractDescr)
- fieldbox = executor.execute(cpu, resoperation.rop.GETFIELD_GC,
+ fieldbox = executor.execute(cpu, None,
+ resoperation.rop.GETFIELD_GC,
ofs, valuebox)
subspecnode.extract_runtime_data(cpu, fieldbox, resultlist)
@@ -95,7 +96,8 @@
def extract_runtime_data(self, cpu, valuebox, resultlist):
from pypy.jit.metainterp import executor, history, resoperation
for i in range(len(self.items)):
- itembox = executor.execute(cpu, resoperation.rop.GETARRAYITEM_GC,
+ itembox = executor.execute(cpu, None,
+ resoperation.rop.GETARRAYITEM_GC,
self.arraydescr,
valuebox, history.ConstInt(i))
subspecnode = self.items[i]
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/oparser.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/oparser.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/oparser.py Tue Jun 8 19:48:40 2010
@@ -4,10 +4,11 @@
"""
from pypy.jit.metainterp.history import TreeLoop, BoxInt, ConstInt,\
- ConstAddr, ConstObj, ConstPtr, Box, BasicFailDescr, BoxFloat, ConstFloat,\
+ ConstObj, ConstPtr, Box, BasicFailDescr, BoxFloat, ConstFloat,\
LoopToken
from pypy.jit.metainterp.resoperation import rop, ResOperation
from pypy.jit.metainterp.typesystem import llhelper
+from pypy.jit.codewriter.heaptracker import adr2int
from pypy.rpython.lltypesystem import lltype, llmemory
from pypy.rpython.ootypesystem import ootype
from pypy.rpython.annlowlevel import llstr
@@ -74,8 +75,7 @@
return ConstPtr(obj)
else:
assert typ == 'class'
- return ConstAddr(llmemory.cast_ptr_to_adr(obj),
- self.cpu)
+ return ConstInt(adr2int(llmemory.cast_ptr_to_adr(obj)))
else:
if typ == 'ptr':
return ConstObj(obj)
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_basic.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_basic.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_basic.py Tue Jun 8 19:48:40 2010
@@ -4,30 +4,97 @@
from pypy.rlib.jit import OPTIMIZER_FULL, OPTIMIZER_SIMPLE, loop_invariant
from pypy.jit.metainterp.warmspot import ll_meta_interp, get_stats
from pypy.jit.backend.llgraph import runner
-from pypy.jit.metainterp import support, codewriter, pyjitpl, history
-from pypy.jit.metainterp.policy import JitPolicy, StopAtXPolicy
+from pypy.jit.metainterp import pyjitpl, history
+from pypy.jit.codewriter.policy import JitPolicy, StopAtXPolicy
from pypy import conftest
from pypy.rlib.rarithmetic import ovfcheck
from pypy.jit.metainterp.typesystem import LLTypeHelper, OOTypeHelper
-from pypy.rpython.lltypesystem import lltype
+from pypy.rpython.lltypesystem import lltype, llmemory
from pypy.rpython.ootypesystem import ootype
-def _get_bare_metainterp(func, values, CPUClass, type_system,
- listops=False):
- from pypy.annotation.policy import AnnotatorPolicy
- from pypy.annotation.model import lltype_to_annotation
- from pypy.rpython.test.test_llinterp import gengraph
+def _get_jitcodes(testself, CPUClass, func, values, type_system):
+ from pypy.jit.codewriter import support, codewriter
+ from pypy.jit.metainterp import simple_optimize
- rtyper = support.annotate(func, values, type_system=type_system)
+ class FakeWarmRunnerState:
+ def attach_unoptimized_bridge_from_interp(self, greenkey, newloop):
+ pass
+
+ # pick the optimizer this way
+ optimize_loop = staticmethod(simple_optimize.optimize_loop)
+ optimize_bridge = staticmethod(simple_optimize.optimize_bridge)
+
+ trace_limit = sys.maxint
+ debug_level = 2
+ func._jit_unroll_safe_ = True
+ rtyper = support.annotate(func, values, type_system=type_system)
+ graphs = rtyper.annotator.translator.graphs
stats = history.Stats()
cpu = CPUClass(rtyper, stats, None, False)
- graphs = rtyper.annotator.translator.graphs
- opt = history.Options(listops=listops)
- metainterp_sd = pyjitpl.MetaInterpStaticData(graphs[0], cpu, stats, opt)
- metainterp_sd.finish_setup(optimizer="bogus")
+ cw = codewriter.CodeWriter(cpu, graphs[0])
+ testself.cw = cw
+ cw.find_all_graphs(JitPolicy())
+ #
+ testself.warmrunnerstate = FakeWarmRunnerState()
+ testself.warmrunnerstate.cpu = cpu
+ if hasattr(testself, 'finish_setup_for_interp_operations'):
+ testself.finish_setup_for_interp_operations()
+ #
+ cw.make_jitcodes(verbose=True)
+
+def _run_with_blackhole(testself, args):
+ from pypy.jit.metainterp.blackhole import BlackholeInterpBuilder
+ cw = testself.cw
+ blackholeinterpbuilder = BlackholeInterpBuilder(cw)
+ blackholeinterp = blackholeinterpbuilder.acquire_interp()
+ count_i = count_r = count_f = 0
+ for value in args:
+ T = lltype.typeOf(value)
+ if T == lltype.Signed:
+ blackholeinterp.setarg_i(count_i, value)
+ count_i += 1
+ elif T == llmemory.GCREF:
+ blackholeinterp.setarg_r(count_r, value)
+ count_r += 1
+ elif T == lltype.Float:
+ blackholeinterp.setarg_f(count_f, value)
+ count_f += 1
+ else:
+ raise TypeError(T)
+ blackholeinterp.setposition(cw.mainjitcode, 0)
+ blackholeinterp.run()
+ return blackholeinterp._final_result_anytype()
+
+def _run_with_pyjitpl(testself, args):
+
+ class DoneWithThisFrame(Exception):
+ pass
+
+ class DoneWithThisFrameRef(DoneWithThisFrame):
+ def __init__(self, cpu, *args):
+ DoneWithThisFrame.__init__(self, *args)
+
+ cw = testself.cw
+ opt = history.Options(listops=True)
+ metainterp_sd = pyjitpl.MetaInterpStaticData(cw.cpu, opt)
+ metainterp_sd.finish_setup(cw, optimizer="bogus")
+ metainterp_sd.state = testself.warmrunnerstate
+ metainterp_sd.state.cpu = metainterp_sd.cpu
metainterp = pyjitpl.MetaInterp(metainterp_sd)
- return metainterp, rtyper
+ metainterp_sd.DoneWithThisFrameInt = DoneWithThisFrame
+ metainterp_sd.DoneWithThisFrameRef = DoneWithThisFrameRef
+ metainterp_sd.DoneWithThisFrameFloat = DoneWithThisFrame
+ testself.metainterp = metainterp
+ try:
+ metainterp.compile_and_run_once(*args)
+ except DoneWithThisFrame, e:
+ #if conftest.option.view:
+ # metainterp.stats.view()
+ return e.args[0]
+ else:
+ raise Exception("FAILED")
+
class JitMixin:
basic = True
@@ -63,56 +130,14 @@
return ll_meta_interp(*args, **kwds)
def interp_operations(self, f, args, **kwds):
- from pypy.jit.metainterp import simple_optimize
-
- class DoneWithThisFrame(Exception):
- pass
-
- class DoneWithThisFrameRef(DoneWithThisFrame):
- def __init__(self, cpu, *args):
- DoneWithThisFrame.__init__(self, *args)
-
- class FakeWarmRunnerState:
- def attach_unoptimized_bridge_from_interp(self, greenkey, newloop):
- pass
-
- # pick the optimizer this way
- optimize_loop = staticmethod(simple_optimize.optimize_loop)
- optimize_bridge = staticmethod(simple_optimize.optimize_bridge)
-
- trace_limit = sys.maxint
- debug_level = 2
-
- metainterp, rtyper = _get_bare_metainterp(f, args, self.CPUClass,
- self.type_system,
- **kwds)
- metainterp.staticdata.state = FakeWarmRunnerState()
- metainterp.staticdata.state.cpu = metainterp.staticdata.cpu
- if hasattr(self, 'finish_metainterp_for_interp_operations'):
- self.finish_metainterp_for_interp_operations(metainterp)
- portal_graph = rtyper.annotator.translator.graphs[0]
- cw = codewriter.CodeWriter(rtyper)
-
- graphs = cw.find_all_graphs(portal_graph, JitPolicy(),
- self.CPUClass.supports_floats)
- cw._start(metainterp.staticdata, None)
- portal_graph.func._jit_unroll_safe_ = True
- maingraph = cw.make_one_bytecode((portal_graph, None), False)
- cw.finish_making_bytecodes()
- metainterp.staticdata.portal_code = maingraph
- metainterp.staticdata._class_sizes = cw.class_sizes
- metainterp.staticdata.DoneWithThisFrameInt = DoneWithThisFrame
- metainterp.staticdata.DoneWithThisFrameRef = DoneWithThisFrameRef
- metainterp.staticdata.DoneWithThisFrameFloat = DoneWithThisFrame
- self.metainterp = metainterp
- try:
- metainterp.compile_and_run_once(*args)
- except DoneWithThisFrame, e:
- #if conftest.option.view:
- # metainterp.stats.view()
- return e.args[0]
- else:
- raise Exception("FAILED")
+ # get the JitCodes for the function f
+ _get_jitcodes(self, self.CPUClass, f, args, self.type_system)
+ # try to run it with blackhole.py
+ result1 = _run_with_blackhole(self, args)
+ # try to run it with pyjitpl.py
+ result2 = _run_with_pyjitpl(self, args)
+ assert result1 == result2
+ return result1
def check_history(self, expected=None, **isns):
# this can be used after calling meta_interp
@@ -151,7 +176,7 @@
class OOJitMixin(JitMixin):
type_system = 'ootype'
- CPUClass = runner.OOtypeCPU
+ #CPUClass = runner.OOtypeCPU
def setup_class(cls):
py.test.skip("ootype tests skipped for now")
@@ -204,9 +229,11 @@
from pypy.rlib.rarithmetic import r_uint
def f(a, b):
+ a = r_uint(a)
+ b = r_uint(b)
return a/b
- res = self.interp_operations(f, [r_uint(4), r_uint(3)])
+ res = self.interp_operations(f, [4, 3])
assert res == 1
def test_direct_call(self):
@@ -339,6 +366,38 @@
assert res == 42
self.check_operations_history(int_add=0, int_mul=0, call=0)
+ def test_constfold_call_pure(self):
+ myjitdriver = JitDriver(greens = ['m'], reds = ['n'])
+ def externfn(x):
+ return x - 3
+ externfn._pure_function_ = True
+ def f(n, m):
+ while n > 0:
+ myjitdriver.can_enter_jit(n=n, m=m)
+ myjitdriver.jit_merge_point(n=n, m=m)
+ n -= externfn(m)
+ return n
+ res = self.meta_interp(f, [21, 5])
+ assert res == -1
+
+ def test_constfold_call_pure_2(self):
+ myjitdriver = JitDriver(greens = ['m'], reds = ['n'])
+ def externfn(x):
+ return x - 3
+ externfn._pure_function_ = True
+ class V:
+ def __init__(self, value):
+ self.value = value
+ def f(n, m):
+ while n > 0:
+ myjitdriver.can_enter_jit(n=n, m=m)
+ myjitdriver.jit_merge_point(n=n, m=m)
+ v = V(m)
+ n -= externfn(v.value)
+ return n
+ res = self.meta_interp(f, [21, 5])
+ assert res == -1
+
def test_constant_across_mp(self):
myjitdriver = JitDriver(greens = [], reds = ['n'])
class X(object):
@@ -513,6 +572,39 @@
res = self.interp_operations(f, [15])
assert res == -1
+ def test_int_add_ovf(self):
+ def f(x, y):
+ try:
+ return ovfcheck(x + y)
+ except OverflowError:
+ return -42
+ res = self.interp_operations(f, [-100, 2])
+ assert res == -98
+ res = self.interp_operations(f, [1, sys.maxint])
+ assert res == -42
+
+ def test_int_sub_ovf(self):
+ def f(x, y):
+ try:
+ return ovfcheck(x - y)
+ except OverflowError:
+ return -42
+ res = self.interp_operations(f, [-100, 2])
+ assert res == -102
+ res = self.interp_operations(f, [1, -sys.maxint])
+ assert res == -42
+
+ def test_int_mul_ovf(self):
+ def f(x, y):
+ try:
+ return ovfcheck(x * y)
+ except OverflowError:
+ return -42
+ res = self.interp_operations(f, [-100, 2])
+ assert res == -200
+ res = self.interp_operations(f, [-3, sys.maxint//2])
+ assert res == -42
+
def test_mod_ovf(self):
myjitdriver = JitDriver(greens = [], reds = ['n', 'x', 'y'])
def f(n, x, y):
@@ -523,6 +615,7 @@
return n
res = self.meta_interp(f, [20, 1, 2])
assert res == 0
+ self.check_loops(call=0)
def test_abs(self):
myjitdriver = JitDriver(greens = [], reds = ['i', 't'])
@@ -581,10 +674,9 @@
self.check_tree_loop_count(2) # the loop and the entry path
# we get:
# ENTER - compile the new loop
- # ENTER (BlackHole) - leave
# ENTER - compile the entry bridge
# ENTER - compile the leaving path
- self.check_enter_count(4)
+ self.check_enter_count(3)
def test_bridge_from_interpreter_2(self):
# one case for backend - computing of framesize on guard failure
@@ -731,21 +823,26 @@
def test_zerodivisionerror(self):
# test the case of exception-raising operation that is not delegated
# to the backend at all: ZeroDivisionError
- from pypy.rpython.lltypesystem.lloperation import llop
#
def f(n):
+ assert n >= 0
try:
- return llop.int_mod_ovf_zer(lltype.Signed, 5, n)
+ return ovfcheck(5 % n)
except ZeroDivisionError:
return -666
+ except OverflowError:
+ return -777
res = self.interp_operations(f, [0])
assert res == -666
#
def f(n):
+ assert n >= 0
try:
- return llop.int_floordiv_ovf_zer(lltype.Signed, 6, n)
+ return ovfcheck(6 // n)
except ZeroDivisionError:
return -667
+ except OverflowError:
+ return -778
res = self.interp_operations(f, [0])
assert res == -667
@@ -795,7 +892,7 @@
assert not res
def test_isinstance_2(self):
- driver = JitDriver(greens = [], reds = ['x', 'n', 'sum'])
+ driver = JitDriver(greens = [], reds = ['n', 'sum', 'x'])
class A:
pass
class B(A):
@@ -836,7 +933,9 @@
return obj.a
res = self.interp_operations(fn, [1])
assert res == 1
- self.check_operations_history(guard_class=0, instanceof=0)
+ self.check_operations_history(guard_class=0)
+ if self.type_system == 'ootype':
+ self.check_operations_history(instanceof=0)
def test_r_dict(self):
from pypy.rlib.objectmodel import r_dict
@@ -1017,10 +1116,10 @@
def test_residual_external_call(self):
import math
- myjitdriver = JitDriver(greens = [], reds = ['x', 'y', 'res'])
+ myjitdriver = JitDriver(greens = [], reds = ['y', 'x', 'res'])
def f(x, y):
x = float(x)
- res = 0
+ res = 0.0
while y > 0:
myjitdriver.can_enter_jit(x=x, y=y, res=res)
myjitdriver.jit_merge_point(x=x, y=y, res=res)
@@ -1259,7 +1358,7 @@
self.check_loops(call=1)
def test_bug_optimizeopt_mutates_ops(self):
- myjitdriver = JitDriver(greens = [], reds = ['x', 'res', 'a', 'const'])
+ myjitdriver = JitDriver(greens = [], reds = ['x', 'res', 'const', 'a'])
class A(object):
pass
class B(A):
@@ -1326,6 +1425,16 @@
# this checks that the logic triggered by make_a_counter_per_value()
# works and prevents generating tons of bridges
+ def test_swap_values(self):
+ def f(x, y):
+ if x > 5:
+ x, y = y, x
+ return x - y
+ res = self.interp_operations(f, [10, 2])
+ assert res == -8
+ res = self.interp_operations(f, [3, 2])
+ assert res == 1
+
class TestOOtype(BasicTests, OOJitMixin):
@@ -1426,33 +1535,47 @@
from pypy.rpython.lltypesystem import lltype
TP = lltype.Struct('x')
- def f(p1, p2):
+ def f(i1, i2):
+ p1 = prebuilt[i1]
+ p2 = prebuilt[i2]
a = p1 is p2
b = p1 is not p2
c = bool(p1)
d = not bool(p2)
return 1000*a + 100*b + 10*c + d
- x = lltype.malloc(TP, flavor='raw')
- expected = f(x, x)
- assert self.interp_operations(f, [x, x]) == expected
- lltype.free(x, flavor='raw')
+ prebuilt = [lltype.malloc(TP, flavor='raw')] * 2
+ expected = f(0, 1)
+ assert self.interp_operations(f, [0, 1]) == expected
def test_casts(self):
+ py.test.skip("xxx fix or kill")
if not self.basic:
py.test.skip("test written in a style that "
"means it's frontend only")
- from pypy.rpython.lltypesystem import lltype, llmemory
-
- TP = lltype.GcStruct('x')
+ from pypy.rpython.lltypesystem import lltype, llmemory, rffi
+
+ TP = lltype.GcStruct('S1')
def f(p):
n = lltype.cast_ptr_to_int(p)
return n
-
x = lltype.malloc(TP)
- res = self.interp_operations(f, [x])
- expected = self.metainterp.cpu.do_cast_ptr_to_int(
- history.BoxPtr(lltype.cast_opaque_ptr(llmemory.GCREF, x))).value
- assert res == expected
+ xref = lltype.cast_opaque_ptr(llmemory.GCREF, x)
+ res = self.interp_operations(f, [xref])
+ y = llmemory.cast_ptr_to_adr(x)
+ y = llmemory.cast_adr_to_int(y)
+ assert rffi.get_real_int(res) == rffi.get_real_int(y)
+ #
+ TP = lltype.Struct('S2')
+ prebuilt = [lltype.malloc(TP, immortal=True),
+ lltype.malloc(TP, immortal=True)]
+ def f(x):
+ p = prebuilt[x]
+ n = lltype.cast_ptr_to_int(p)
+ return n
+ res = self.interp_operations(f, [1])
+ y = llmemory.cast_ptr_to_adr(prebuilt[1])
+ y = llmemory.cast_adr_to_int(y)
+ assert rffi.get_real_int(res) == rffi.get_real_int(y)
def test_collapsing_ptr_eq(self):
S = lltype.GcStruct('S')
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_blackhole.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_blackhole.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_blackhole.py Tue Jun 8 19:48:40 2010
@@ -1,87 +1,211 @@
+import py
from pypy.rlib.jit import JitDriver
from pypy.jit.metainterp.test.test_basic import LLJitMixin, OOJitMixin
-from pypy.jit.metainterp import pyjitpl
+from pypy.jit.metainterp.blackhole import BlackholeInterpBuilder
+from pypy.jit.metainterp.blackhole import BlackholeInterpreter
+from pypy.jit.metainterp.blackhole import convert_and_run_from_pyjitpl
+from pypy.jit.metainterp import history, pyjitpl
+from pypy.jit.codewriter.assembler import JitCode
+from pypy.rpython.lltypesystem import lltype, llmemory
+from pypy.rpython.llinterp import LLException
-class BlackholeTests(object):
-
- def meta_interp(self, *args):
- def counting_init(frame, metainterp, jitcode, greenkey=None):
- previnit(frame, metainterp, jitcode, greenkey)
- self.seen_frames.append(jitcode.name)
+class FakeCodeWriter:
+ pass
+class FakeAssembler:
+ pass
+class FakeCPU:
+ def bh_call_i(self, func, calldescr, args_i, args_r, args_f):
+ assert func == 321
+ assert calldescr == "<calldescr>"
+ if args_i[0] < 0:
+ raise LLException("etype", "evalue")
+ return args_i[0] * 2
+
+def getblackholeinterp(insns, descrs=[]):
+ cw = FakeCodeWriter()
+ cw.cpu = FakeCPU()
+ cw.assembler = FakeAssembler()
+ cw.assembler.insns = insns
+ cw.assembler.descrs = descrs
+ builder = BlackholeInterpBuilder(cw)
+ return builder.acquire_interp()
+
+def test_simple():
+ jitcode = JitCode("test")
+ jitcode.setup("\x00\x00\x01\x02"
+ "\x01\x02",
+ [])
+ blackholeinterp = getblackholeinterp({'int_add/ii>i': 0,
+ 'int_return/i': 1})
+ blackholeinterp.setposition(jitcode, 0)
+ blackholeinterp.setarg_i(0, 40)
+ blackholeinterp.setarg_i(1, 2)
+ blackholeinterp.run()
+ assert blackholeinterp.final_result_i() == 42
+
+def test_simple_const():
+ jitcode = JitCode("test")
+ jitcode.setup("\x00\x30\x01\x02"
+ "\x01\x02",
+ [])
+ blackholeinterp = getblackholeinterp({'int_sub/ci>i': 0,
+ 'int_return/i': 1})
+ blackholeinterp.setposition(jitcode, 0)
+ blackholeinterp.setarg_i(1, 6)
+ blackholeinterp.run()
+ assert blackholeinterp.final_result_i() == 42
+
+def test_simple_bigconst():
+ jitcode = JitCode("test")
+ jitcode.setup("\x00\xFD\x01\x02"
+ "\x01\x02",
+ [666, 666, 10042, 666])
+ blackholeinterp = getblackholeinterp({'int_sub/ii>i': 0,
+ 'int_return/i': 1})
+ blackholeinterp.setposition(jitcode, 0)
+ blackholeinterp.setarg_i(1, 10000)
+ blackholeinterp.run()
+ assert blackholeinterp.final_result_i() == 42
+
+def test_simple_loop():
+ jitcode = JitCode("test")
+ jitcode.setup("\x00\x16\x02\x10\x00" # L1: goto_if_not_int_gt %i0, 2, L2
+ "\x01\x17\x16\x17" # int_add %i1, %i0, %i1
+ "\x02\x16\x01\x16" # int_sub %i0, $1, %i0
+ "\x03\x00\x00" # goto L1
+ "\x04\x17", # L2: int_return %i1
+ [])
+ blackholeinterp = getblackholeinterp({'goto_if_not_int_gt/icL': 0,
+ 'int_add/ii>i': 1,
+ 'int_sub/ic>i': 2,
+ 'goto/L': 3,
+ 'int_return/i': 4})
+ blackholeinterp.setposition(jitcode, 0)
+ blackholeinterp.setarg_i(0x16, 6) # %i0
+ blackholeinterp.setarg_i(0x17, 100) # %i1
+ blackholeinterp.run()
+ assert blackholeinterp.final_result_i() == 100+6+5+4+3
+
+def test_simple_exception():
+ jitcode = JitCode("test")
+ jitcode.setup( # residual_call_ir_i $<* fn g>, <Descr>, I[%i9], R[], %i8
+ "\x01\xFF\x00\x00\x01\x09\x00\x08"
+ "\x00\x0D\x00" # catch_exception L1
+ "\x02\x08" # int_return %i8
+ "\x03\x2A", # L1: int_return $42
+ [321]) # <-- address of the function g
+ blackholeinterp = getblackholeinterp({'catch_exception/L': 0,
+ 'residual_call_ir_i/idIR>i': 1,
+ 'int_return/i': 2,
+ 'int_return/c': 3},
+ ["<calldescr>"])
+ #
+ blackholeinterp.setposition(jitcode, 0)
+ blackholeinterp.setarg_i(0x9, 100)
+ blackholeinterp.run()
+ assert blackholeinterp.final_result_i() == 200
+ #
+ blackholeinterp.setposition(jitcode, 0)
+ blackholeinterp.setarg_i(0x9, -100)
+ blackholeinterp.run()
+ assert blackholeinterp.final_result_i() == 42
+
+def test_convert_and_run_from_pyjitpl():
+ class MyMIFrame:
+ jitcode = JitCode("test")
+ jitcode.setup("\xFF" # illegal instruction
+ "\x00\x00\x01\x02" # int_add/ii>i
+ "\x01\x02", # int_return/i
+ [],
+ num_regs_i=3, num_regs_r=0, num_regs_f=0)
+ pc = 1
+ registers_i = [history.BoxInt(40), history.ConstInt(2), None]
+ class MyMetaInterp:
+ class staticdata:
+ result_type = 'int'
+ class profiler:
+ @staticmethod
+ def start_blackhole(): pass
+ @staticmethod
+ def end_blackhole(): pass
+ class DoneWithThisFrameInt(Exception):
+ pass
+ last_exc_value_box = None
+ framestack = [MyMIFrame()]
+ MyMetaInterp.staticdata.blackholeinterpbuilder = getblackholeinterp(
+ {'int_add/ii>i': 0, 'int_return/i': 1}).builder
+ MyMetaInterp.staticdata.blackholeinterpbuilder.metainterp_sd = \
+ MyMetaInterp.staticdata
+ #
+ d = py.test.raises(MyMetaInterp.staticdata.DoneWithThisFrameInt,
+ convert_and_run_from_pyjitpl, MyMetaInterp())
+ assert d.value.args == (42,)
+
+
+class TestBlackhole(LLJitMixin):
+
+ def test_blackholeinterp_cache(self):
+ myjitdriver = JitDriver(greens = [], reds = ['x', 'y'])
+ def choices(x):
+ if x == 2: return 10
+ if x == 3: return 199
+ if x == 4: return 124
+ if x == 5: return -521
+ if x == 6: return 8917
+ if x == 7: return -387
+ return 34871
+ def f(x):
+ y = 0
+ while x > 0:
+ myjitdriver.can_enter_jit(x=x, y=y)
+ myjitdriver.jit_merge_point(x=x, y=y)
+ y += choices(x)
+ x -= 1
+ return y
#
- previnit = pyjitpl.MIFrame.__init__.im_func
+ seen = []
+ def my_copy_constants(self, *args):
+ seen.append(1)
+ return org_copy_constants(self, *args)
+ org_copy_constants = BlackholeInterpreter.copy_constants
+ BlackholeInterpreter.copy_constants = my_copy_constants
try:
- self.seen_frames = []
- pyjitpl.MIFrame.__init__ = counting_init
- return super(BlackholeTests, self).meta_interp(*args)
+ res = self.meta_interp(f, [7], repeat=7)
finally:
- pyjitpl.MIFrame.__init__ = previnit
-
- def test_calls_not_followed(self):
- myjitdriver = JitDriver(greens = [], reds = ['n'])
- def h():
- return 42
- def g():
- return h()
- def f(n):
- while n > 0:
- myjitdriver.can_enter_jit(n=n)
- myjitdriver.jit_merge_point(n=n)
- n -= 1
- return g()
- res = self.meta_interp(f, [7])
- assert res == 42
- assert self.seen_frames == ['f', 'f']
-
- def test_indirect_calls_not_followed(self):
- myjitdriver = JitDriver(greens = [], reds = ['n'])
- def h():
- return 42
- def g():
- return h()
- def f(n):
- while n > 0:
- myjitdriver.can_enter_jit(n=n)
- myjitdriver.jit_merge_point(n=n)
- n -= 1
- if n < 0:
- call = h
- else:
- call = g
- return call()
- res = self.meta_interp(f, [7])
- assert res == 42
- assert self.seen_frames == ['f', 'f']
-
- def test_oosends_not_followed(self):
- myjitdriver = JitDriver(greens = [], reds = ['n'])
- class A:
- def meth(self):
- return 42
- class B(A):
- def meth(self):
- return 45
- class C(A):
- def meth(self):
- return 64
- def f(n):
- while n > 0:
- myjitdriver.can_enter_jit(n=n)
- myjitdriver.jit_merge_point(n=n)
- n -= 1
- if n < 0:
- x = B()
- else:
- x = C()
- return x.meth()
- res = self.meta_interp(f, [7])
- assert res == 64
- assert self.seen_frames == ['f', 'f']
-
-
-class TestLLtype(BlackholeTests, LLJitMixin):
- pass
-
-class TestOOtype(BlackholeTests, OOJitMixin):
- pass
+ BlackholeInterpreter.copy_constants = org_copy_constants
+ #
+ assert res == sum([choices(x) for x in range(1, 8)])
+ builder = pyjitpl._warmrunnerdesc.metainterp_sd.blackholeinterpbuilder
+ assert builder.num_interpreters == 2
+ assert len(seen) == 2 * 3
+
+ def test_blackholeinterp_cache_exc(self):
+ myjitdriver = JitDriver(greens = [], reds = ['x', 'y'])
+ class FooError(Exception):
+ def __init__(self, num):
+ self.num = num
+ def choices(x):
+ if x == 2: raise FooError(10)
+ if x == 3: raise FooError(199)
+ if x == 4: raise FooError(124)
+ if x == 5: raise FooError(-521)
+ if x == 6: raise FooError(8917)
+ if x == 7: raise FooError(-387)
+ raise FooError(34871)
+ def f(x):
+ y = 0
+ while x > 0:
+ myjitdriver.can_enter_jit(x=x, y=y)
+ myjitdriver.jit_merge_point(x=x, y=y)
+ try:
+ choices(x)
+ except FooError, e:
+ y += e.num
+ x -= 1
+ return y
+ res = self.meta_interp(f, [7], repeat=7)
+ assert res == sum([py.test.raises(FooError, choices, x).value.num
+ for x in range(1, 8)])
+ builder = pyjitpl._warmrunnerdesc.metainterp_sd.blackholeinterpbuilder
+ assert builder.num_interpreters == 2
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_compile.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_compile.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_compile.py Tue Jun 8 19:48:40 2010
@@ -2,7 +2,8 @@
from pypy.jit.metainterp.history import BoxInt
from pypy.jit.metainterp.specnode import NotSpecNode, ConstantSpecNode
from pypy.jit.metainterp.compile import insert_loop_token, compile_new_loop
-from pypy.jit.metainterp.compile import ResumeGuardDescr, ResumeGuardCounters
+from pypy.jit.metainterp.compile import ResumeGuardDescr
+from pypy.jit.metainterp.compile import ResumeGuardCountersInt
from pypy.jit.metainterp import optimize, jitprof, typesystem
from pypy.jit.metainterp.test.oparser import parse
from pypy.jit.metainterp.test.test_optimizefindnode import LLtypeMixin
@@ -107,49 +108,49 @@
def test_resume_guard_counters():
- rgc = ResumeGuardCounters()
+ rgc = ResumeGuardCountersInt()
# fill in the table
for i in range(5):
- count = rgc.see(BoxInt(100+i))
+ count = rgc.see_int(100+i)
assert count == 1
- count = rgc.see(BoxInt(100+i))
+ count = rgc.see_int(100+i)
assert count == 2
assert rgc.counters == [0] * (4-i) + [2] * (1+i)
for i in range(5):
- count = rgc.see(BoxInt(100+i))
+ count = rgc.see_int(100+i)
assert count == 3
# make a distribution: [5, 4, 7, 6, 3]
assert rgc.counters == [3, 3, 3, 3, 3]
- count = rgc.see(BoxInt(101))
+ count = rgc.see_int(101)
assert count == 4
- count = rgc.see(BoxInt(101))
+ count = rgc.see_int(101)
assert count == 5
- count = rgc.see(BoxInt(101))
+ count = rgc.see_int(101)
assert count == 6
- count = rgc.see(BoxInt(102))
+ count = rgc.see_int(102)
assert count == 4
- count = rgc.see(BoxInt(102))
+ count = rgc.see_int(102)
assert count == 5
- count = rgc.see(BoxInt(102))
+ count = rgc.see_int(102)
assert count == 6
- count = rgc.see(BoxInt(102))
+ count = rgc.see_int(102)
assert count == 7
- count = rgc.see(BoxInt(103))
+ count = rgc.see_int(103)
assert count == 4
- count = rgc.see(BoxInt(104))
+ count = rgc.see_int(104)
assert count == 4
- count = rgc.see(BoxInt(104))
+ count = rgc.see_int(104)
assert count == 5
assert rgc.counters == [5, 4, 7, 6, 3]
# the next new item should throw away 104, as 5 is the middle counter
- count = rgc.see(BoxInt(190))
+ count = rgc.see_int(190)
assert count == 1
assert rgc.counters == [1, 4, 7, 6, 3]
# the next new item should throw away 103, as 4 is the middle counter
- count = rgc.see(BoxInt(191))
+ count = rgc.see_int(191)
assert count == 1
assert rgc.counters == [1, 1, 7, 6, 3]
# the next new item should throw away 100, as 3 is the middle counter
- count = rgc.see(BoxInt(192))
+ count = rgc.see_int(192)
assert count == 1
assert rgc.counters == [1, 1, 7, 6, 1]
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_exception.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_exception.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_exception.py Tue Jun 8 19:48:40 2010
@@ -2,7 +2,7 @@
from pypy.jit.metainterp.test.test_basic import LLJitMixin, OOJitMixin
from pypy.rlib.jit import JitDriver, OPTIMIZER_SIMPLE
from pypy.rlib.rarithmetic import ovfcheck, LONG_BIT, intmask
-from pypy.jit.metainterp.policy import StopAtXPolicy
+from pypy.jit.codewriter.policy import StopAtXPolicy
class ExceptionTests:
@@ -516,11 +516,10 @@
assert res == -1
self.check_tree_loop_count(2) # the loop and the entry path
# we get:
- # ENTER - compile the new loop
- # ENTER (BlackHole) - leave
- # ENTER - compile the entry bridge
- # ENTER - compile the leaving path (raising MyError)
- self.check_enter_count(4)
+ # ENTER - compile the new loop
+ # ENTER - compile the entry bridge
+ # ENTER - compile the leaving path (raising MyError)
+ self.check_enter_count(3)
def test_bridge_from_interpreter_exc_2(self):
@@ -556,7 +555,6 @@
optimizer=OPTIMIZER_SIMPLE)
assert res == 8
-
def test_overflowerror_escapes(self):
def g(x):
return ovfcheck(x + 1)
@@ -570,6 +568,26 @@
res = self.interp_operations(f, [sys.maxint])
assert res == -42
+ def test_bug_1(self):
+ def h(i):
+ if i > 10:
+ raise ValueError
+ if i > 5:
+ raise KeyError
+ return 5
+ def g(i):
+ try:
+ return h(i)
+ except ValueError:
+ return 21
+ def f(i):
+ try:
+ return g(i)
+ except KeyError:
+ return 42
+ res = self.interp_operations(f, [99])
+ assert res == 21
+
class MyError(Exception):
def __init__(self, n):
self.n = n
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_executor.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_executor.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_executor.py Tue Jun 8 19:48:40 2010
@@ -1,60 +1,87 @@
import py
import sys, random
from pypy.rlib.rarithmetic import r_uint, intmask
-from pypy.jit.metainterp.executor import make_execute_list, execute
+from pypy.rpython.lltypesystem import lltype, llmemory
+from pypy.jit.metainterp.executor import execute
from pypy.jit.metainterp.executor import execute_varargs, execute_nonspec
from pypy.jit.metainterp.resoperation import rop
from pypy.jit.metainterp.history import BoxInt, ConstInt
+from pypy.jit.metainterp.history import BoxPtr, ConstPtr
from pypy.jit.metainterp.history import BoxFloat, ConstFloat
from pypy.jit.metainterp.history import AbstractDescr, Box
+from pypy.jit.metainterp import history
from pypy.jit.backend.model import AbstractCPU
class FakeDescr(AbstractDescr):
pass
-class FakeBox(Box):
+class FakeCallDescr(FakeDescr):
+ def get_return_type(self):
+ return history.FLOAT
+
+class FakeFieldDescr(FakeDescr):
+ def is_pointer_field(self):
+ return False
+ def is_float_field(self):
+ return True
+
+class FakeArrayDescr(FakeDescr):
+ def is_array_of_pointers(self):
+ return False
+ def is_array_of_floats(self):
+ return True
+
+class FakeResultR:
+ _TYPE = llmemory.GCREF
def __init__(self, *args):
- self.args = args
+ self.fakeargs = args
+
+class FakeMetaInterp:
+ pass
class FakeCPU(AbstractCPU):
supports_floats = True
- def do_new(self, descr):
- return FakeBox('new', descr)
-
- def do_arraylen_gc(self, box1, descr):
- return FakeBox('arraylen_gc', box1, descr)
-
- def do_setfield_gc(self, box1, box2, descr):
- return FakeBox('setfield_gc', box1, box2, descr)
+ def bh_new(self, descr):
+ return FakeResultR('new', descr)
- def do_setarrayitem_gc(self, box1, box2, box3, descr):
- return FakeBox('setarrayitem_gc', box1, box2, box3, descr)
+ def bh_arraylen_gc(self, descr, array):
+ assert not array
+ assert isinstance(descr, FakeDescr)
+ return 55
+
+ def bh_setfield_gc_f(self, struct, fielddescr, newvalue):
+ self.fakesetfield = (struct, newvalue, fielddescr)
+
+ def bh_setarrayitem_gc_f(self, arraydescr, array, index, newvalue):
+ self.fakesetarrayitem = (array, index, newvalue, arraydescr)
+
+ def bh_call_f(self, func, calldescr, args_i, args_r, args_f):
+ self.fakecalled = (func, calldescr, args_i, args_r, args_f)
+ return 42.5
- def do_call(self, args, descr):
- return FakeBox('call', args, descr)
-
- def do_strsetitem(self, box1, box2, box3):
- return FakeBox('strsetitem', box1, box2, box3)
-
-make_execute_list(FakeCPU)
+ def bh_strsetitem(self, string, index, newvalue):
+ self.fakestrsetitem = (string, index, newvalue)
def test_execute():
cpu = FakeCPU()
descr = FakeDescr()
- box = execute(cpu, rop.INT_ADD, None, BoxInt(40), ConstInt(2))
+ box = execute(cpu, None, rop.INT_ADD, None, BoxInt(40), ConstInt(2))
assert box.value == 42
- box = execute(cpu, rop.NEW, descr)
- assert box.args == ('new', descr)
+ box = execute(cpu, None, rop.NEW, descr)
+ assert box.value.fakeargs == ('new', descr)
def test_execute_varargs():
cpu = FakeCPU()
- descr = FakeDescr()
- argboxes = [BoxInt(321), ConstInt(123)]
- box = execute_varargs(cpu, rop.CALL, argboxes, descr)
- assert box.args == ('call', argboxes, descr)
+ descr = FakeCallDescr()
+ argboxes = [BoxInt(99999), BoxInt(321), ConstFloat(2.25), ConstInt(123),
+ BoxPtr(), BoxFloat(5.5)]
+ box = execute_varargs(cpu, FakeMetaInterp(), rop.CALL, argboxes, descr)
+ assert box.value == 42.5
+ assert cpu.fakecalled == (99999, descr, [321, 123],
+ [ConstPtr.value], [2.25, 5.5])
def test_execute_nonspec():
cpu = FakeCPU()
@@ -62,33 +89,38 @@
# cases with a descr
# arity == -1
argboxes = [BoxInt(321), ConstInt(123)]
- box = execute_nonspec(cpu, rop.CALL, argboxes, descr)
- assert box.args == ('call', argboxes, descr)
+ box = execute_nonspec(cpu, FakeMetaInterp(), rop.CALL,
+ argboxes, FakeCallDescr())
+ assert box.value == 42.5
# arity == 0
- box = execute_nonspec(cpu, rop.NEW, [], descr)
- assert box.args == ('new', descr)
+ box = execute_nonspec(cpu, None, rop.NEW, [], descr)
+ assert box.value.fakeargs == ('new', descr)
# arity == 1
- box1 = BoxInt(515)
- box = execute_nonspec(cpu, rop.ARRAYLEN_GC, [box1], descr)
- assert box.args == ('arraylen_gc', box1, descr)
+ box1 = BoxPtr()
+ box = execute_nonspec(cpu, None, rop.ARRAYLEN_GC, [box1], descr)
+ assert box.value == 55
# arity == 2
- box2 = BoxInt(222)
- box = execute_nonspec(cpu, rop.SETFIELD_GC, [box1, box2], descr)
- assert box.args == ('setfield_gc', box1, box2, descr)
+ box2 = BoxFloat(222.2)
+ fielddescr = FakeFieldDescr()
+ execute_nonspec(cpu, None, rop.SETFIELD_GC, [box1, box2], fielddescr)
+ assert cpu.fakesetfield == (box1.value, box2.value, fielddescr)
# arity == 3
- box3 = BoxInt(-33)
- box = execute_nonspec(cpu, rop.SETARRAYITEM_GC, [box1, box2, box3], descr)
- assert box.args == ('setarrayitem_gc', box1, box2, box3, descr)
+ box3 = BoxInt(33)
+ arraydescr = FakeArrayDescr()
+ execute_nonspec(cpu, None, rop.SETARRAYITEM_GC, [box1, box3, box2],
+ arraydescr)
+ assert cpu.fakesetarrayitem == (box1.value, box3.value, box2.value,
+ arraydescr)
# cases without descr
# arity == 1
- box = execute_nonspec(cpu, rop.INT_INVERT, [box1])
- assert box.value == ~515
+ box = execute_nonspec(cpu, None, rop.INT_INVERT, [box3])
+ assert box.value == ~33
# arity == 2
- box = execute_nonspec(cpu, rop.INT_LSHIFT, [box1, BoxInt(3)])
- assert box.value == 515 << 3
+ box = execute_nonspec(cpu, None, rop.INT_LSHIFT, [box3, BoxInt(3)])
+ assert box.value == 33 << 3
# arity == 3
- box = execute_nonspec(cpu, rop.STRSETITEM, [box1, box2, box3])
- assert box.args == ('strsetitem', box1, box2, box3)
+ execute_nonspec(cpu, None, rop.STRSETITEM, [box1, BoxInt(3), box3])
+ assert cpu.fakestrsetitem == (box1.value, 3, box3.value)
# ints
@@ -181,7 +213,7 @@
(rop.INT_IS_TRUE, [(0, 0), (1, 1), (2, 1), (-1, 1), (minint, 1)]),
(rop.INT_NEG, [(0, 0), (123, -123), (-23127, 23127)]),
(rop.INT_INVERT, [(0, ~0), (-1, ~(-1)), (123, ~123)]),
- (rop.BOOL_NOT, [(0, 1), (1, 0)]),
+ (rop.INT_IS_ZERO, [(0, 1), (1, 0), (2, 0), (-1, 0), (minint, 0)]),
]:
for x, y in testcases:
yield opnum, [x], y
@@ -204,7 +236,7 @@
def test_int_ops():
cpu = FakeCPU()
for opnum, boxargs, retvalue in get_int_tests():
- box = execute_nonspec(cpu, opnum, boxargs)
+ box = execute_nonspec(cpu, None, opnum, boxargs)
assert box.getint() == retvalue
# floats
@@ -242,9 +274,6 @@
yield (rop.FLOAT_NEG, [15.9], 'float', -15.9)
yield (rop.FLOAT_ABS, [-5.9], 'float', 5.9)
yield (rop.FLOAT_ABS, [15.9], 'float', 15.9)
- yield (rop.FLOAT_IS_TRUE, [-5.9], 'int', 1)
- yield (rop.FLOAT_IS_TRUE, [0.0], 'int', 0)
- yield (rop.FLOAT_IS_TRUE, [-0.0], 'int', 0)
yield (rop.CAST_FLOAT_TO_INT, [-5.9], 'int', -5)
yield (rop.CAST_FLOAT_TO_INT, [5.9], 'int', 5)
yield (rop.CAST_INT_TO_FLOAT, [123], 'float', 123.0)
@@ -276,7 +305,7 @@
def test_float_ops():
cpu = FakeCPU()
for opnum, boxargs, rettype, retvalue in get_float_tests(cpu):
- box = execute_nonspec(cpu, opnum, boxargs)
+ box = execute_nonspec(cpu, None, opnum, boxargs)
if rettype == 'float':
assert box.getfloat() == retvalue
elif rettype == 'int':
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_history.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_history.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_history.py Tue Jun 8 19:48:40 2010
@@ -9,10 +9,3 @@
s = lltype.cast_pointer(lltype.Ptr(S), t)
const = ConstPtr(lltype.cast_opaque_ptr(llmemory.GCREF, s))
assert const._getrepr_() == "*T"
-
-def test_slicing():
- h = History()
- h.operations = [1, 2, 3, 4, 5]
- rest = h.slice_history_at(2)
- assert rest == [4, 5]
- assert h.operations == [1, 2]
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_jitprof.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_jitprof.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_jitprof.py Tue Jun 8 19:48:40 2010
@@ -63,7 +63,7 @@
]
assert profiler.events == expected
assert profiler.times == [2, 1, 1, 1]
- assert profiler.counters == [1, 1, 1, 1, 4, 3, 1, 1, 7, 1, 0, 0, 0,
+ assert profiler.counters == [1, 1, 1, 1, 3, 3, 1, 7, 1, 0, 0, 0,
0, 0, 0, 0]
def test_simple_loop_with_call(self):
@@ -84,8 +84,8 @@
res = self.meta_interp(f, [6, 7])
assert res == 84
profiler = pyjitpl._warmrunnerdesc.metainterp_sd.profiler
- # calls = (executed, recorded, blackholed) x (inpure, pure)
- assert profiler.calls == [[1, 0], [1, 0], [0, 0]]
+ # calls = (executed, recorded) x (inpure, pure)
+ assert profiler.calls == [[1, 0], [1, 0]]
def test_blackhole_pure(self):
@purefunction
@@ -99,12 +99,11 @@
myjitdriver.can_enter_jit(x=x, y=y, res=res, z=z)
myjitdriver.jit_merge_point(x=x, y=y, res=res, z=z)
res += x
- if y == 1:
- res += g(z)
+ res += g(z)
y -= 1
return res * 2
res = self.meta_interp(f, [6, 7, 2])
- assert res == 90
+ assert res == f(6, 7, 2)
profiler = pyjitpl._warmrunnerdesc.metainterp_sd.profiler
- # calls = (executed, recorded, blackholed) x (inpure, pure)
- assert profiler.calls == [[0, 1], [0, 0], [0, 1]]
+ # calls = (executed, recorded) x (inpure, pure)
+ assert profiler.calls == [[0, 1], [0, 0]]
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_list.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_list.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_list.py Tue Jun 8 19:48:40 2010
@@ -1,7 +1,5 @@
import py
from pypy.rlib.jit import JitDriver
-from pypy.jit.metainterp.policy import StopAtXPolicy
-from pypy.rpython.ootypesystem import ootype
from pypy.jit.metainterp.test.test_basic import LLJitMixin, OOJitMixin
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_loop.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_loop.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_loop.py Tue Jun 8 19:48:40 2010
@@ -4,7 +4,7 @@
from pypy.jit.metainterp.warmspot import ll_meta_interp, get_stats
from pypy.rpython.lltypesystem import lltype
from pypy.jit.metainterp.test.test_basic import LLJitMixin, OOJitMixin
-from pypy.jit.metainterp.policy import StopAtXPolicy
+from pypy.jit.codewriter.policy import StopAtXPolicy
from pypy.jit.metainterp.resoperation import rop
from pypy.jit.metainterp import history
@@ -342,7 +342,7 @@
assert res == expected
def test_loop_unicode(self):
- myjitdriver = JitDriver(greens = [], reds = ['x', 'n'])
+ myjitdriver = JitDriver(greens = [], reds = ['n', 'x'])
def f(n):
x = u''
while n > 13:
@@ -356,7 +356,7 @@
assert res == expected
def test_loop_string(self):
- myjitdriver = JitDriver(greens = [], reds = ['x', 'n'])
+ myjitdriver = JitDriver(greens = [], reds = ['n', 'x'])
def f(n):
x = ''
while n > 13:
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_optimizefindnode.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_optimizefindnode.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_optimizefindnode.py Tue Jun 8 19:48:40 2010
@@ -6,7 +6,7 @@
from pypy.jit.backend.llgraph import runner
from pypy.jit.metainterp.history import (BoxInt, BoxPtr, ConstInt, ConstPtr,
- Const, ConstAddr, TreeLoop, BoxObj,
+ Const, TreeLoop, BoxObj,
ConstObj, AbstractDescr)
from pypy.jit.metainterp.optimizefindnode import PerfectSpecializationFinder
from pypy.jit.metainterp.optimizefindnode import BridgeSpecializationFinder
@@ -16,7 +16,8 @@
from pypy.jit.metainterp.specnode import VirtualArraySpecNode
from pypy.jit.metainterp.specnode import VirtualStructSpecNode
from pypy.jit.metainterp.specnode import ConstantSpecNode
-from pypy.jit.metainterp.effectinfo import EffectInfo
+from pypy.jit.codewriter.effectinfo import EffectInfo
+from pypy.jit.codewriter.heaptracker import register_known_gctype, adr2int
from pypy.jit.metainterp.test.oparser import parse
def test_sort_descrs():
@@ -113,7 +114,7 @@
EffectInfo([adescr], [], []))
mayforcevirtdescr = cpu.calldescrof(FUNC, FUNC.ARGS, FUNC.RESULT,
EffectInfo([nextdescr], [], [],
- forces_virtual_or_virtualizable=True))
+ EffectInfo.EF_FORCES_VIRTUAL_OR_VIRTUALIZABLE))
class LoopToken(AbstractDescr):
pass
asmdescr = LoopToken() # it can be whatever, it's not a descr though
@@ -129,83 +130,81 @@
jit_virtual_ref_vtable = vrefinfo.jit_virtual_ref_vtable
jvr_vtable_adr = llmemory.cast_ptr_to_adr(jit_virtual_ref_vtable)
- cpu.class_sizes = {
- cpu.cast_adr_to_int(node_vtable_adr): cpu.sizeof(NODE),
- cpu.cast_adr_to_int(node_vtable_adr2): cpu.sizeof(NODE2),
- cpu.cast_adr_to_int(u_vtable_adr): cpu.sizeof(U),
- cpu.cast_adr_to_int(jvr_vtable_adr): cpu.sizeof(
- vrefinfo.JIT_VIRTUAL_REF),
- }
+ register_known_gctype(cpu, node_vtable, NODE)
+ register_known_gctype(cpu, node_vtable2, NODE2)
+ register_known_gctype(cpu, u_vtable, U)
+ register_known_gctype(cpu, jit_virtual_ref_vtable,vrefinfo.JIT_VIRTUAL_REF)
+
namespace = locals()
-class OOtypeMixin(object):
+class OOtypeMixin_xxx_disabled(object):
type_system = 'ootype'
- def get_class_of_box(self, box):
- root = box.getref(ootype.ROOT)
- return ootype.classof(root)
+## def get_class_of_box(self, box):
+## root = box.getref(ootype.ROOT)
+## return ootype.classof(root)
- cpu = runner.OOtypeCPU(None)
- NODE = ootype.Instance('NODE', ootype.ROOT, {})
- NODE._add_fields({'value': ootype.Signed,
- 'floatval' : ootype.Float,
- 'next': NODE})
- NODE2 = ootype.Instance('NODE2', NODE, {'other': NODE})
-
- node_vtable = ootype.runtimeClass(NODE)
- node_vtable_adr = ootype.cast_to_object(node_vtable)
- node_vtable2 = ootype.runtimeClass(NODE2)
- node_vtable_adr2 = ootype.cast_to_object(node_vtable2)
-
- node = ootype.new(NODE)
- nodebox = BoxObj(ootype.cast_to_object(node))
- myptr = nodebox.value
- myptr2 = ootype.cast_to_object(ootype.new(NODE))
- nodebox2 = BoxObj(ootype.cast_to_object(node))
- valuedescr = cpu.fielddescrof(NODE, 'value')
- floatdescr = cpu.fielddescrof(NODE, 'floatval')
- nextdescr = cpu.fielddescrof(NODE, 'next')
- otherdescr = cpu.fielddescrof(NODE2, 'other')
- nodesize = cpu.typedescrof(NODE)
- nodesize2 = cpu.typedescrof(NODE2)
-
- arraydescr = cpu.arraydescrof(ootype.Array(ootype.Signed))
- floatarraydescr = cpu.arraydescrof(ootype.Array(ootype.Float))
-
- # a plain Record
- S = ootype.Record({'a': ootype.Signed, 'b': NODE})
- ssize = cpu.typedescrof(S)
- adescr = cpu.fielddescrof(S, 'a')
- bdescr = cpu.fielddescrof(S, 'b')
- sbox = BoxObj(ootype.cast_to_object(ootype.new(S)))
- arraydescr2 = cpu.arraydescrof(ootype.Array(S))
-
- T = ootype.Record({'c': ootype.Signed,
- 'd': ootype.Array(NODE)})
- tsize = cpu.typedescrof(T)
- cdescr = cpu.fielddescrof(T, 'c')
- ddescr = cpu.fielddescrof(T, 'd')
- arraydescr3 = cpu.arraydescrof(ootype.Array(NODE))
-
- U = ootype.Instance('U', ootype.ROOT, {'one': ootype.Array(NODE)})
- usize = cpu.typedescrof(U)
- onedescr = cpu.fielddescrof(U, 'one')
- u_vtable = ootype.runtimeClass(U)
- u_vtable_adr = ootype.cast_to_object(u_vtable)
-
- # force a consistent order
- valuedescr.sort_key()
- nextdescr.sort_key()
- adescr.sort_key()
- bdescr.sort_key()
-
- FUNC = lltype.FuncType([lltype.Signed], lltype.Signed)
- nonwritedescr = cpu.calldescrof(FUNC, FUNC.ARGS, FUNC.RESULT) # XXX fix ootype
-
- cpu.class_sizes = {node_vtable_adr: cpu.typedescrof(NODE),
- node_vtable_adr2: cpu.typedescrof(NODE2),
- u_vtable_adr: cpu.typedescrof(U)}
- namespace = locals()
+## cpu = runner.OOtypeCPU(None)
+## NODE = ootype.Instance('NODE', ootype.ROOT, {})
+## NODE._add_fields({'value': ootype.Signed,
+## 'floatval' : ootype.Float,
+## 'next': NODE})
+## NODE2 = ootype.Instance('NODE2', NODE, {'other': NODE})
+
+## node_vtable = ootype.runtimeClass(NODE)
+## node_vtable_adr = ootype.cast_to_object(node_vtable)
+## node_vtable2 = ootype.runtimeClass(NODE2)
+## node_vtable_adr2 = ootype.cast_to_object(node_vtable2)
+
+## node = ootype.new(NODE)
+## nodebox = BoxObj(ootype.cast_to_object(node))
+## myptr = nodebox.value
+## myptr2 = ootype.cast_to_object(ootype.new(NODE))
+## nodebox2 = BoxObj(ootype.cast_to_object(node))
+## valuedescr = cpu.fielddescrof(NODE, 'value')
+## floatdescr = cpu.fielddescrof(NODE, 'floatval')
+## nextdescr = cpu.fielddescrof(NODE, 'next')
+## otherdescr = cpu.fielddescrof(NODE2, 'other')
+## nodesize = cpu.typedescrof(NODE)
+## nodesize2 = cpu.typedescrof(NODE2)
+
+## arraydescr = cpu.arraydescrof(ootype.Array(ootype.Signed))
+## floatarraydescr = cpu.arraydescrof(ootype.Array(ootype.Float))
+
+## # a plain Record
+## S = ootype.Record({'a': ootype.Signed, 'b': NODE})
+## ssize = cpu.typedescrof(S)
+## adescr = cpu.fielddescrof(S, 'a')
+## bdescr = cpu.fielddescrof(S, 'b')
+## sbox = BoxObj(ootype.cast_to_object(ootype.new(S)))
+## arraydescr2 = cpu.arraydescrof(ootype.Array(S))
+
+## T = ootype.Record({'c': ootype.Signed,
+## 'd': ootype.Array(NODE)})
+## tsize = cpu.typedescrof(T)
+## cdescr = cpu.fielddescrof(T, 'c')
+## ddescr = cpu.fielddescrof(T, 'd')
+## arraydescr3 = cpu.arraydescrof(ootype.Array(NODE))
+
+## U = ootype.Instance('U', ootype.ROOT, {'one': ootype.Array(NODE)})
+## usize = cpu.typedescrof(U)
+## onedescr = cpu.fielddescrof(U, 'one')
+## u_vtable = ootype.runtimeClass(U)
+## u_vtable_adr = ootype.cast_to_object(u_vtable)
+
+## # force a consistent order
+## valuedescr.sort_key()
+## nextdescr.sort_key()
+## adescr.sort_key()
+## bdescr.sort_key()
+
+## FUNC = lltype.FuncType([lltype.Signed], lltype.Signed)
+## nonwritedescr = cpu.calldescrof(FUNC, FUNC.ARGS, FUNC.RESULT) # XXX fix ootype
+
+## cpu.class_sizes = {node_vtable_adr: cpu.typedescrof(NODE),
+## node_vtable_adr2: cpu.typedescrof(NODE2),
+## u_vtable_adr: cpu.typedescrof(U)}
+## namespace = locals()
class BaseTest(object):
invent_fail_descr = None
@@ -220,8 +219,7 @@
#
def constclass(cls_vtable):
if self.type_system == 'lltype':
- return ConstAddr(llmemory.cast_ptr_to_adr(cls_vtable),
- self.cpu)
+ return ConstInt(adr2int(llmemory.cast_ptr_to_adr(cls_vtable)))
else:
return ConstObj(ootype.cast_to_object(cls_vtable))
def constant(value):
@@ -357,7 +355,7 @@
assert not boxp2.fromstart
assert boxp1.knownclsbox is None
- assert boxp2.knownclsbox.value == self.node_vtable_adr
+ assert boxp2.knownclsbox.getaddr() == self.node_vtable_adr
def test_find_nodes_new_2(self):
ops = """
@@ -413,8 +411,8 @@
assert not boxp2.fromstart
assert not boxp3.fromstart
- assert boxp2.knownclsbox.value == self.node_vtable_adr
- assert boxp3.knownclsbox.value == self.node_vtable_adr2
+ assert boxp2.knownclsbox.getaddr() == self.node_vtable_adr
+ assert boxp3.knownclsbox.getaddr() == self.node_vtable_adr2
def test_find_nodes_new_aliasing_0(self):
ops = """
@@ -503,31 +501,31 @@
nextdescr=Virtual(node_vtable,
nextdescr=Virtual(node_vtable)))''')
- def test_find_nodes_oois(self):
+ def test_find_nodes_ptr_eq(self):
ops = """
[p3, p4, p2]
p0 = new_with_vtable(ConstClass(node_vtable))
p1 = new_with_vtable(ConstClass(node_vtable))
guard_nonnull(p0) []
- i3 = ooisnot(p0, NULL)
+ i3 = ptr_ne(p0, NULL)
guard_true(i3) []
- i4 = oois(p0, NULL)
+ i4 = ptr_eq(p0, NULL)
guard_false(i4) []
- i5 = ooisnot(NULL, p0)
+ i5 = ptr_ne(NULL, p0)
guard_true(i5) []
- i6 = oois(NULL, p0)
+ i6 = ptr_eq(NULL, p0)
guard_false(i6) []
- i7 = ooisnot(p0, p1)
+ i7 = ptr_ne(p0, p1)
guard_true(i7) []
- i8 = oois(p0, p1)
+ i8 = ptr_eq(p0, p1)
guard_false(i8) []
- i9 = ooisnot(p0, p2)
+ i9 = ptr_ne(p0, p2)
guard_true(i9) []
- i10 = oois(p0, p2)
+ i10 = ptr_eq(p0, p2)
guard_false(i10) []
- i11 = ooisnot(p2, p1)
+ i11 = ptr_ne(p2, p1)
guard_true(i11) []
- i12 = oois(p2, p1)
+ i12 = ptr_eq(p2, p1)
guard_false(i12) []
jump(p0, p1, p2)
"""
@@ -1160,14 +1158,13 @@
class TestLLtype(BaseTestOptimizeFindNode, LLtypeMixin):
pass
-class TestOOtype(BaseTestOptimizeFindNode, OOtypeMixin):
-
- def test_find_nodes_instanceof(self):
- ops = """
- [i0]
- p0 = new_with_vtable(ConstClass(node_vtable))
- i1 = instanceof(p0, descr=nodesize)
- jump(i1)
- """
- boxes, getnode = self.find_nodes(ops, 'Not')
- assert not getnode(boxes.p0).escaped
+##class TestOOtype(BaseTestOptimizeFindNode, OOtypeMixin):
+## def test_find_nodes_instanceof(self):
+## ops = """
+## [i0]
+## p0 = new_with_vtable(ConstClass(node_vtable))
+## i1 = instanceof(p0, descr=nodesize)
+## jump(i1)
+## """
+## boxes, getnode = self.find_nodes(ops, 'Not')
+## assert not getnode(boxes.p0).escaped
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_optimizeopt.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_optimizeopt.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_optimizeopt.py Tue Jun 8 19:48:40 2010
@@ -1,8 +1,7 @@
import py
from pypy.rlib.objectmodel import instantiate
-from pypy.jit.metainterp.test.test_resume import MyMetaInterp
from pypy.jit.metainterp.test.test_optimizefindnode import (LLtypeMixin,
- OOtypeMixin,
+ #OOtypeMixin,
BaseTest)
from pypy.jit.metainterp.optimizefindnode import PerfectSpecializationFinder
from pypy.jit.metainterp import optimizeopt
@@ -10,18 +9,17 @@
from pypy.jit.metainterp.optimizeutil import InvalidLoop
from pypy.jit.metainterp.history import AbstractDescr, ConstInt, BoxInt
from pypy.jit.metainterp.jitprof import EmptyProfiler
-from pypy.jit.metainterp import executor, compile, resume
+from pypy.jit.metainterp import executor, compile, resume, history
from pypy.jit.metainterp.resoperation import rop, opname, ResOperation
from pypy.jit.metainterp.test.oparser import pure_parse
-class FakeFrame(object):
- parent_resumedata_snapshot = None
- parent_resumedata_frame_info_list = None
-
- def __init__(self, code="", pc=0, exc_target=-1):
- self.jitcode = code
- self.pc = pc
- self.exception_target = exc_target
+##class FakeFrame(object):
+## parent_resumedata_snapshot = None
+## parent_resumedata_frame_info_list = None
+
+## def __init__(self, code="", pc=0):
+## self.jitcode = code
+## self.pc = pc
class Fake(object):
failargs_limit = 1000
@@ -45,9 +43,8 @@
fdescr = ResumeGuardDescr(None, None)
op = ResOperation(rop.GUARD_TRUE, [], None, descr=fdescr)
# setup rd data
- fi0 = resume.FrameInfo(None, FakeFrame("code0", 1, 2))
- fdescr.rd_frame_info_list = resume.FrameInfo(fi0,
- FakeFrame("code1", 3, -1))
+ fi0 = resume.FrameInfo(None, "code0", 11)
+ fdescr.rd_frame_info_list = resume.FrameInfo(fi0, "code1", 33)
snapshot0 = resume.Snapshot(None, [b0])
fdescr.rd_snapshot = resume.Snapshot(snapshot0, [b1])
#
@@ -215,14 +212,18 @@
def __eq__(self, other):
return type(self) is type(other) # xxx obscure
+def _sortboxes(boxes):
+ _kind2count = {history.INT: 1, history.REF: 2, history.FLOAT: 3}
+ return sorted(boxes, key=lambda box: _kind2count[box.type])
+
class BaseTestOptimizeOpt(BaseTest):
def invent_fail_descr(self, fail_args):
if fail_args is None:
return None
descr = Storage()
- descr.rd_frame_info_list = resume.FrameInfo(None, FakeFrame())
- descr.rd_snapshot = resume.Snapshot(None, fail_args)
+ descr.rd_frame_info_list = resume.FrameInfo(None, "code", 11)
+ descr.rd_snapshot = resume.Snapshot(None, _sortboxes(fail_args))
return descr
def assert_equal(self, optimized, expected):
@@ -273,7 +274,7 @@
i0 = int_add(2, 3)
i1 = int_is_true(i0)
guard_true(i1) []
- i2 = bool_not(i1)
+ i2 = int_is_zero(i1)
guard_false(i2) []
guard_value(i0, 5) []
jump()
@@ -289,7 +290,7 @@
from pypy.jit.metainterp.executor import execute_nonspec
from pypy.jit.metainterp.history import BoxInt
import random
- for opnum in range(rop.INT_ADD, rop.BOOL_NOT+1):
+ for opnum in range(rop.INT_ADD, rop.SAME_AS+1):
try:
op = opname[opnum]
except KeyError:
@@ -309,7 +310,7 @@
jump()
""" % (op.lower(), ', '.join(map(str, args)))
argboxes = [BoxInt(a) for a in args]
- expected_value = execute_nonspec(self.cpu, opnum,
+ expected_value = execute_nonspec(self.cpu, None, opnum,
argboxes).getint()
expected = """
[]
@@ -410,7 +411,7 @@
self.optimize_loop(ops, 'Not', expected)
def test_int_is_true_1(self):
- py.test.skip("too bad")
+ py.test.skip("XXX implement me")
ops = """
[i0]
i1 = int_is_true(i0)
@@ -427,6 +428,24 @@
"""
self.optimize_loop(ops, 'Not', expected)
+ def test_int_is_true_is_zero(self):
+ py.test.skip("XXX implement me")
+ ops = """
+ [i0]
+ i1 = int_is_true(i0)
+ guard_true(i1) []
+ i2 = int_is_zero(i0)
+ guard_false(i2) []
+ jump(i0)
+ """
+ expected = """
+ [i0]
+ i1 = int_is_true(i0)
+ guard_true(i1) []
+ jump(i0)
+ """
+ self.optimize_loop(ops, 'Not', expected)
+
def test_ooisnull_oononnull_2(self):
ops = """
[p0]
@@ -478,13 +497,13 @@
ops = """
[p0]
guard_class(p0, ConstClass(node_vtable)) []
- i0 = ooisnot(p0, NULL)
+ i0 = ptr_ne(p0, NULL)
guard_true(i0) []
- i1 = oois(p0, NULL)
+ i1 = ptr_eq(p0, NULL)
guard_false(i1) []
- i2 = ooisnot(NULL, p0)
+ i2 = ptr_ne(NULL, p0)
guard_true(i0) []
- i3 = oois(NULL, p0)
+ i3 = ptr_eq(NULL, p0)
guard_false(i1) []
jump(p0)
"""
@@ -499,13 +518,13 @@
ops = """
[p0]
setfield_gc(p0, 5, descr=valuedescr) # forces p0 != NULL
- i0 = ooisnot(p0, NULL)
+ i0 = ptr_ne(p0, NULL)
guard_true(i0) []
- i1 = oois(p0, NULL)
+ i1 = ptr_eq(p0, NULL)
guard_false(i1) []
- i2 = ooisnot(NULL, p0)
+ i2 = ptr_ne(NULL, p0)
guard_true(i0) []
- i3 = oois(NULL, p0)
+ i3 = ptr_eq(NULL, p0)
guard_false(i1) []
guard_nonnull(p0) []
jump(p0)
@@ -728,25 +747,25 @@
ops = """
[p0, p1, p2]
guard_nonnull(p0) []
- i3 = ooisnot(p0, NULL)
+ i3 = ptr_ne(p0, NULL)
guard_true(i3) []
- i4 = oois(p0, NULL)
+ i4 = ptr_eq(p0, NULL)
guard_false(i4) []
- i5 = ooisnot(NULL, p0)
+ i5 = ptr_ne(NULL, p0)
guard_true(i5) []
- i6 = oois(NULL, p0)
+ i6 = ptr_eq(NULL, p0)
guard_false(i6) []
- i7 = ooisnot(p0, p1)
+ i7 = ptr_ne(p0, p1)
guard_true(i7) []
- i8 = oois(p0, p1)
+ i8 = ptr_eq(p0, p1)
guard_false(i8) []
- i9 = ooisnot(p0, p2)
+ i9 = ptr_ne(p0, p2)
guard_true(i9) []
- i10 = oois(p0, p2)
+ i10 = ptr_eq(p0, p2)
guard_false(i10) []
- i11 = ooisnot(p2, p1)
+ i11 = ptr_ne(p2, p1)
guard_true(i11) []
- i12 = oois(p2, p1)
+ i12 = ptr_eq(p2, p1)
guard_false(i12) []
jump(p0, p1, p2)
"""
@@ -766,17 +785,17 @@
expected2 = """
[p0, p1, p2]
guard_nonnull(p0) []
- i7 = ooisnot(p0, p1)
+ i7 = ptr_ne(p0, p1)
guard_true(i7) []
- i8 = oois(p0, p1)
+ i8 = ptr_eq(p0, p1)
guard_false(i8) []
- i9 = ooisnot(p0, p2)
+ i9 = ptr_ne(p0, p2)
guard_true(i9) []
- i10 = oois(p0, p2)
+ i10 = ptr_eq(p0, p2)
guard_false(i10) []
- i11 = ooisnot(p2, p1)
+ i11 = ptr_ne(p2, p1)
guard_true(i11) []
- i12 = oois(p2, p1)
+ i12 = ptr_eq(p2, p1)
guard_false(i12) []
jump(p0, p1, p2)
"""
@@ -870,7 +889,7 @@
p0 = new_with_vtable(ConstClass(node_vtable))
setfield_gc(p0, NULL, descr=nextdescr)
p2 = getfield_gc(p0, descr=nextdescr)
- i1 = oois(p2, NULL)
+ i1 = ptr_eq(p2, NULL)
jump(i1)
"""
expected = """
@@ -886,7 +905,7 @@
p0 = new_with_vtable(ConstClass(node_vtable))
setfield_gc(p0, ConstPtr(myptr), descr=nextdescr)
p2 = getfield_gc(p0, descr=nextdescr)
- i1 = oois(p2, NULL)
+ i1 = ptr_eq(p2, NULL)
jump(i1)
"""
expected = """
@@ -1514,7 +1533,7 @@
"""
expected = """
[p1, i2, i3]
- guard_true(i3) [p1, i2]
+ guard_true(i3) [i2, p1]
i4 = int_neg(i2)
setfield_gc(p1, NULL, descr=nextdescr)
jump(p1, i2, i4)
@@ -1920,7 +1939,7 @@
ops = """
[p1]
guard_class(p1, ConstClass(node_vtable2)) []
- i = ooisnot(ConstPtr(myptr), p1)
+ i = ptr_ne(ConstPtr(myptr), p1)
guard_true(i) []
jump(p1)
"""
@@ -1936,9 +1955,9 @@
[p0]
p1 = getfield_gc(p0, descr=nextdescr)
p2 = getfield_gc(p0, descr=nextdescr)
- i1 = oois(p1, p2)
+ i1 = ptr_eq(p1, p2)
guard_true(i1) []
- i2 = ooisnot(p1, p2)
+ i2 = ptr_ne(p1, p2)
guard_false(i2) []
jump(p0)
"""
@@ -1952,8 +1971,8 @@
def test_remove_duplicate_pure_op(self):
ops = """
[p1, p2]
- i1 = oois(p1, p2)
- i2 = oois(p1, p2)
+ i1 = ptr_eq(p1, p2)
+ i2 = ptr_eq(p1, p2)
i3 = int_add(i1, 1)
i3b = int_is_true(i3)
guard_true(i3b) []
@@ -1968,7 +1987,7 @@
"""
expected = """
[p1, p2]
- i1 = oois(p1, p2)
+ i1 = ptr_eq(p1, p2)
i3 = int_add(i1, 1)
i3b = int_is_true(i3)
guard_true(i3b) []
@@ -2024,7 +2043,7 @@
# typically called twice, before and after optimization
if self.oparse is None:
fdescr.rd_frame_info_list = resume.FrameInfo(None,
- FakeFrame())
+ "code", 11)
fdescr.rd_snapshot = resume.Snapshot(None, fail_args)
self.oparse = oparse
#
@@ -2096,7 +2115,7 @@
for pvar, pfieldname, pfieldvar in pendingfields:
box = oparse.getvar(pvar)
fielddescr = self.namespace[pfieldname.strip()]
- fieldbox = executor.execute(self.cpu,
+ fieldbox = executor.execute(self.cpu, None,
rop.GETFIELD_GC,
fielddescr,
box)
@@ -2114,13 +2133,13 @@
if tag[0] in ('virtual', 'vstruct'):
fieldname, fieldvalue = fieldtext.split('=')
fielddescr = self.namespace[fieldname.strip()]
- fieldbox = executor.execute(self.cpu,
+ fieldbox = executor.execute(self.cpu, None,
rop.GETFIELD_GC,
fielddescr,
resolved)
elif tag[0] == 'varray':
fieldvalue = fieldtext
- fieldbox = executor.execute(self.cpu,
+ fieldbox = executor.execute(self.cpu, None,
rop.GETARRAYITEM_GC,
tag[1],
resolved, ConstInt(index))
@@ -2130,12 +2149,14 @@
index += 1
def check_expanded_fail_descr(self, expectedtext, guard_opnum):
+ from pypy.jit.metainterp.test.test_resume import ResumeDataFakeReader
+ from pypy.jit.metainterp.test.test_resume import MyMetaInterp
guard_op, = [op for op in self.loop.operations if op.is_guard()]
fail_args = guard_op.fail_args
fdescr = guard_op.descr
assert fdescr.guard_opnum == guard_opnum
- reader = resume.ResumeDataReader(fdescr, fail_args,
- MyMetaInterp(self.cpu))
+ reader = ResumeDataFakeReader(fdescr, fail_args,
+ MyMetaInterp(self.cpu))
boxes = reader.consume_boxes()
self._verify_fail_args(boxes, fdescr.oparse, expectedtext)
@@ -2190,7 +2211,7 @@
setfield_gc(p1, p2, descr=nextdescr)
setfield_gc(p2, i2, descr=valuedescr)
setfield_gc(p2, p3, descr=nextdescr)
- guard_true(i1, descr=fdescr) [p1, i3]
+ guard_true(i1, descr=fdescr) [i3, p1]
jump(i2, i1, i3, p3)
"""
expected = """
@@ -2199,15 +2220,14 @@
jump(i2, 1, i3, p3)
"""
self.optimize_loop(ops, 'Not, Not, Not, Not', expected)
- self.check_expanded_fail_descr('''p1, i3
+ self.check_expanded_fail_descr('''i3, p1
where p1 is a node_vtable, valuedescr=1, nextdescr=p2
where p2 is a node_vtable, valuedescr=i2, nextdescr=p3
''', rop.GUARD_TRUE)
def test_expand_fail_4(self):
- for arg in ['p1', 'p1,i2', 'i2,p1', 'p1,p2', 'p2,p1',
- 'p1,p2,i2', 'p1,i2,p2', 'p2,p1,i2',
- 'p2,i2,p1', 'i2,p1,p2', 'i2,p2,p1']:
+ for arg in ['p1', 'i2,p1', 'p1,p2', 'p2,p1',
+ 'i2,p1,p2', 'i2,p2,p1']:
self.make_fail_descr()
ops = """
[i1, i2, i3]
@@ -2218,7 +2238,7 @@
setfield_gc(p1, i2, descr=valuedescr)
setfield_gc(p1, p2, descr=nextdescr)
setfield_gc(p2, i2, descr=valuedescr)
- guard_true(i1, descr=fdescr) [i4, %s, i3]
+ guard_true(i1, descr=fdescr) [i4, i3, %s]
jump(i1, i2, i3)
"""
expected = """
@@ -2227,7 +2247,7 @@
jump(1, i2, i3)
"""
self.optimize_loop(ops % arg, 'Not, Not, Not', expected)
- self.check_expanded_fail_descr('''i3, %s, i3
+ self.check_expanded_fail_descr('''i3, i3, %s
where p1 is a node_vtable, valuedescr=i2, nextdescr=p2
where p2 is a node_vtable, valuedescr=i2''' % arg,
rop.GUARD_TRUE)
@@ -2242,7 +2262,7 @@
setfield_gc(p1, p2, descr=nextdescr)
setfield_gc(p2, i2, descr=valuedescr)
setfield_gc(p2, p1, descr=nextdescr) # a cycle
- guard_true(i1, descr=fdescr) [p1, i3, p2, i4]
+ guard_true(i1, descr=fdescr) [i3, i4, p1, p2]
jump(i2, i1, i3, i4)
"""
expected = """
@@ -2251,7 +2271,7 @@
jump(i2, 1, i3, i4)
"""
self.optimize_loop(ops, 'Not, Not, Not, Not', expected)
- self.check_expanded_fail_descr('''p1, i3, p2, i4
+ self.check_expanded_fail_descr('''i3, i4, p1, p2
where p1 is a node_vtable, valuedescr=i4, nextdescr=p2
where p2 is a node_vtable, valuedescr=i2, nextdescr=p1
''', rop.GUARD_TRUE)
@@ -2626,7 +2646,7 @@
setfield_gc(p2, 5, descr=virtualrefindexdescr)
escape(p2)
setfield_gc(p2, p1, descr=virtualforceddescr)
- setfield_gc(p2, -2, descr=virtualtokendescr)
+ setfield_gc(p2, -3, descr=virtualtokendescr)
jump(p1)
"""
# XXX we should optimize a bit more the case of a nonvirtual.
@@ -2668,7 +2688,7 @@
setfield_gc(p1b, 252, descr=valuedescr)
setfield_gc(p1, p1b, descr=nextdescr)
setfield_gc(p2, p1, descr=virtualforceddescr)
- setfield_gc(p2, -2, descr=virtualtokendescr)
+ setfield_gc(p2, -3, descr=virtualtokendescr)
jump(p0, i1)
"""
self.optimize_loop(ops, 'Not, Not', expected)
@@ -2709,7 +2729,7 @@
setfield_gc(p1b, i1, descr=valuedescr)
setfield_gc(p1, p1b, descr=nextdescr)
setfield_gc(p2, p1, descr=virtualforceddescr)
- setfield_gc(p2, -2, descr=virtualtokendescr)
+ setfield_gc(p2, -3, descr=virtualtokendescr)
jump(p0, i1)
"""
# the point of this test is that 'i1' should show up in the fail_args
@@ -2780,7 +2800,7 @@
escape(p2)
p1 = new_with_vtable(ConstClass(node_vtable))
setfield_gc(p2, p1, descr=virtualforceddescr)
- setfield_gc(p2, -2, descr=virtualtokendescr)
+ setfield_gc(p2, -3, descr=virtualtokendescr)
call_may_force(i1, descr=mayforcevirtdescr)
guard_not_forced() []
jump(i1)
@@ -2806,7 +2826,7 @@
setfield_gc(p2, 23, descr=virtualrefindexdescr)
escape(p2)
setfield_gc(p2, p1, descr=virtualforceddescr)
- setfield_gc(p2, -2, descr=virtualtokendescr)
+ setfield_gc(p2, -3, descr=virtualtokendescr)
call_may_force(i1, descr=mayforcevirtdescr)
guard_not_forced() [i1]
jump(i1, p1)
@@ -2880,31 +2900,31 @@
'''
self.optimize_loop(ops, 'Not', expected)
-class TestOOtype(BaseTestOptimizeOpt, OOtypeMixin):
+##class TestOOtype(BaseTestOptimizeOpt, OOtypeMixin):
- def test_instanceof(self):
- ops = """
- [i0]
- p0 = new_with_vtable(ConstClass(node_vtable))
- i1 = instanceof(p0, descr=nodesize)
- jump(i1)
- """
- expected = """
- [i0]
- jump(1)
- """
- self.optimize_loop(ops, 'Not', expected)
+## def test_instanceof(self):
+## ops = """
+## [i0]
+## p0 = new_with_vtable(ConstClass(node_vtable))
+## i1 = instanceof(p0, descr=nodesize)
+## jump(i1)
+## """
+## expected = """
+## [i0]
+## jump(1)
+## """
+## self.optimize_loop(ops, 'Not', expected)
- def test_instanceof_guard_class(self):
- ops = """
- [i0, p0]
- guard_class(p0, ConstClass(node_vtable)) []
- i1 = instanceof(p0, descr=nodesize)
- jump(i1, p0)
- """
- expected = """
- [i0, p0]
- guard_class(p0, ConstClass(node_vtable)) []
- jump(1, p0)
- """
- self.optimize_loop(ops, 'Not, Not', expected)
+## def test_instanceof_guard_class(self):
+## ops = """
+## [i0, p0]
+## guard_class(p0, ConstClass(node_vtable)) []
+## i1 = instanceof(p0, descr=nodesize)
+## jump(i1, p0)
+## """
+## expected = """
+## [i0, p0]
+## guard_class(p0, ConstClass(node_vtable)) []
+## jump(1, p0)
+## """
+## self.optimize_loop(ops, 'Not, Not', expected)
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_pyjitpl.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_pyjitpl.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_pyjitpl.py Tue Jun 8 19:48:40 2010
@@ -1,49 +1,20 @@
# some unit tests for the bytecode decoding
-from pypy.jit.metainterp import pyjitpl, codewriter, resoperation, history
+from pypy.jit.metainterp import pyjitpl
from pypy.jit.metainterp import jitprof
-from pypy.jit.metainterp.history import AbstractFailDescr, BoxInt, ConstInt
+from pypy.jit.metainterp.history import BoxInt, ConstInt
from pypy.jit.metainterp.history import History
from pypy.jit.metainterp.resoperation import ResOperation, rop
from pypy.jit.metainterp.test.test_optimizeopt import equaloplists
+from pypy.jit.codewriter.jitcode import JitCode
-def make_frame(code):
- bytecode = codewriter.JitCode("hello")
- bytecode.code = code
- bytecode.constants = None
- frame = pyjitpl.MIFrame(None, bytecode)
- frame.pc = 0
- return frame
-
-
-def test_decode_big_int():
- for code, value in [("\x80\x01", 128), ("\x81\x81\x01", 1 + (1 << 7) + (1 << 14))]:
- frame = make_frame(code)
- val = frame.load_int()
- assert val == value
-
-def test_decode_bool():
- frame = make_frame("\x00")
- assert not frame.load_bool()
-
- frame = make_frame("\x01")
- assert frame.load_bool()
-
-def test_simple_opimpl_exist():
- rop = resoperation.rop
- for opnum, opname in resoperation.opname.items():
- if opnum in (rop.SAME_AS, rop.CALL_PURE, rop.OOSEND_PURE,
- rop.FORCE_TOKEN):
- continue
- if rop._NOSIDEEFFECT_FIRST <= opnum <= rop._NOSIDEEFFECT_LAST:
- assert hasattr(pyjitpl.MIFrame, 'opimpl_' + opname.lower()), opname
def test_portal_trace_positions():
- jitcode = codewriter.JitCode("f")
- jitcode.code = jitcode.constants = None
- portal = codewriter.JitCode("portal")
- portal.code = portal.constants = None
+ jitcode = JitCode("f")
+ jitcode.setup(None)
+ portal = JitCode("portal")
+ portal.setup(None)
class FakeStaticData:
cpu = None
portal_code = portal
@@ -95,7 +66,7 @@
c3 = ConstInt(3)
boxes = [b1, b2, b1, c3]
dup = {}
- metainterp.remove_consts_and_duplicates(boxes, 0, 4, dup)
+ metainterp.remove_consts_and_duplicates(boxes, 4, dup)
assert boxes[0] is b1
assert boxes[1] is b2
assert is_another_box_like(boxes[2], b1)
@@ -108,12 +79,12 @@
#
del metainterp.history.operations[:]
b4 = BoxInt(4)
- boxes = ["something random", b2, b4, "something else"]
- metainterp.remove_consts_and_duplicates(boxes, 1, 3, dup)
- assert is_another_box_like(boxes[1], b2)
- assert boxes[2] is b4
+ boxes = [b2, b4, "something random"]
+ metainterp.remove_consts_and_duplicates(boxes, 2, dup)
+ assert is_another_box_like(boxes[0], b2)
+ assert boxes[1] is b4
assert equaloplists(metainterp.history.operations, [
- ResOperation(rop.SAME_AS, [b2], boxes[1]),
+ ResOperation(rop.SAME_AS, [b2], boxes[0]),
])
def test_get_name_from_address():
@@ -121,42 +92,7 @@
def __init__(self):
pass
metainterp_sd = FakeMetaInterpSd()
- metainterp_sd.info_from_codewriter(None, None,
- [(123, "a"), (456, "b")],
- None)
+ metainterp_sd.setup_list_of_addr2name([(123, 'a'), (456, 'b')])
assert metainterp_sd.get_name_from_address(123) == 'a'
assert metainterp_sd.get_name_from_address(456) == 'b'
assert metainterp_sd.get_name_from_address(789) == ''
-
-def test_initialize_state_from_guard_failure():
- from pypy.jit.metainterp.typesystem import llhelper
- calls = []
-
- class FakeCPU:
- ts = llhelper
-
- def make_boxes_from_latest_values(self, faildescr):
- return [BoxInt(0), None, BoxInt(2), None, BoxInt(4)]
-
- class FakeStaticData:
- cpu = FakeCPU()
- profiler = jitprof.EmptyProfiler()
-
- metainterp = pyjitpl.MetaInterp(FakeStaticData())
-
- def rebuild_state_after_failure(descr, newboxes):
- calls.append(newboxes)
- metainterp.rebuild_state_after_failure = rebuild_state_after_failure
-
- class FakeResumeDescr:
- def must_compile(self, *args):
- return True
- resumedescr = FakeResumeDescr()
- metainterp.initialize_state_from_guard_failure(resumedescr)
-
- inp = metainterp.history.inputargs
- assert len(inp) == 3
- assert [box.value for box in inp] == [0, 2, 4]
- b0, b2, b4 = inp
- assert len(calls) == 1
- assert calls[0] == [b0, None, b2, None, b4]
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_recursive.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_recursive.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_recursive.py Tue Jun 8 19:48:40 2010
@@ -1,7 +1,8 @@
import py
from pypy.rlib.jit import JitDriver, we_are_jitted, OPTIMIZER_SIMPLE, hint
+from pypy.rlib.jit import unroll_safe
from pypy.jit.metainterp.test.test_basic import LLJitMixin, OOJitMixin
-from pypy.jit.metainterp.policy import StopAtXPolicy
+from pypy.jit.codewriter.policy import StopAtXPolicy
from pypy.rpython.annlowlevel import hlstr
from pypy.jit.metainterp.warmspot import CannotInlineCanEnterJit, get_stats
@@ -24,6 +25,7 @@
return 1
res = self.meta_interp(main, [20], optimizer=OPTIMIZER_SIMPLE)
assert res == main(20)
+ self.check_history(call=0)
def test_simple_recursion_with_exc(self):
myjitdriver = JitDriver(greens=[], reds=['n', 'm'])
@@ -105,11 +107,11 @@
def can_inline(*args):
return True
else:
- def can_inline(code, i):
+ def can_inline(i, code):
code = hlstr(code)
return not JUMP_BACK in code
- jitdriver = JitDriver(greens = ['code', 'i'], reds = ['n'],
+ jitdriver = JitDriver(greens = ['i', 'code'], reds = ['n'],
can_inline = can_inline)
def interpret(codenum, n, i):
@@ -178,12 +180,12 @@
def test_guard_failure_in_inlined_function(self):
from pypy.rpython.annlowlevel import hlstr
- def p(code, pc):
+ def p(pc, code):
code = hlstr(code)
return "%s %d %s" % (code, pc, code[pc])
- def c(code, pc):
+ def c(pc, code):
return "l" not in hlstr(code)
- myjitdriver = JitDriver(greens=['code', 'pc'], reds=['n'],
+ myjitdriver = JitDriver(greens=['pc', 'code'], reds=['n'],
get_printable_location=p, can_inline=c)
def f(code, n):
pc = 0
@@ -215,12 +217,12 @@
def test_guard_failure_and_then_exception_in_inlined_function(self):
from pypy.rpython.annlowlevel import hlstr
- def p(code, pc):
+ def p(pc, code):
code = hlstr(code)
return "%s %d %s" % (code, pc, code[pc])
- def c(code, pc):
+ def c(pc, code):
return "l" not in hlstr(code)
- myjitdriver = JitDriver(greens=['code', 'pc'], reds=['n', 'flag'],
+ myjitdriver = JitDriver(greens=['pc', 'code'], reds=['n', 'flag'],
get_printable_location=p, can_inline=c)
def f(code, n):
pc = 0
@@ -259,12 +261,12 @@
def test_exception_in_inlined_function(self):
from pypy.rpython.annlowlevel import hlstr
- def p(code, pc):
+ def p(pc, code):
code = hlstr(code)
return "%s %d %s" % (code, pc, code[pc])
- def c(code, pc):
+ def c(pc, code):
return "l" not in hlstr(code)
- myjitdriver = JitDriver(greens=['code', 'pc'], reds=['n'],
+ myjitdriver = JitDriver(greens=['pc', 'code'], reds=['n'],
get_printable_location=p, can_inline=c)
class Exc(Exception):
@@ -305,12 +307,12 @@
# it fails, it is very delicate in terms of parameters,
# bridge/loop creation order
from pypy.rpython.annlowlevel import hlstr
- def p(code, pc):
+ def p(pc, code):
code = hlstr(code)
return "%s %d %s" % (code, pc, code[pc])
- def c(code, pc):
+ def c(pc, code):
return "l" not in hlstr(code)
- myjitdriver = JitDriver(greens=['code', 'pc'], reds=['n'],
+ myjitdriver = JitDriver(greens=['pc', 'code'], reds=['n'],
get_printable_location=p, can_inline=c)
def f(code, n):
@@ -394,9 +396,36 @@
self.check_aborted_count(8)
self.check_enter_count_at_most(30)
+ def test_trace_limit_with_exception_bug(self):
+ myjitdriver = JitDriver(greens=[], reds=['n'])
+ @unroll_safe
+ def do_stuff(n):
+ while n > 0:
+ n -= 1
+ raise ValueError
+ def loop(n):
+ pc = 0
+ while n > 80:
+ myjitdriver.can_enter_jit(n=n)
+ myjitdriver.jit_merge_point(n=n)
+ try:
+ do_stuff(n)
+ except ValueError:
+ # the trace limit is checked when we arrive here, and we
+ # have the exception still in last_exc_value_box at this
+ # point -- so when we abort because of a trace too long,
+ # the exception is passed to the blackhole interp and
+ # incorrectly re-raised from here
+ pass
+ n -= 1
+ return n
+ TRACE_LIMIT = 66
+ res = self.meta_interp(loop, [100], trace_limit=TRACE_LIMIT)
+ assert res == 80
+
def test_max_failure_args(self):
FAILARGS_LIMIT = 10
- jitdriver = JitDriver(greens = [], reds = ['o', 'i', 'n'])
+ jitdriver = JitDriver(greens = [], reds = ['i', 'n', 'o'])
class A(object):
def __init__(self, i0, i1, i2, i3, i4, i5, i6, i7, i8, i9):
@@ -429,7 +458,7 @@
def test_max_failure_args_exc(self):
FAILARGS_LIMIT = 10
- jitdriver = JitDriver(greens = [], reds = ['o', 'i', 'n'])
+ jitdriver = JitDriver(greens = [], reds = ['i', 'n', 'o'])
class A(object):
def __init__(self, i0, i1, i2, i3, i4, i5, i6, i7, i8, i9):
@@ -495,12 +524,12 @@
self.check_loops(call_may_force=0, call=0)
def test_trace_from_start(self):
- def p(code, pc):
+ def p(pc, code):
code = hlstr(code)
return "%s %d %s" % (code, pc, code[pc])
- def c(code, pc):
+ def c(pc, code):
return "l" not in hlstr(code)
- myjitdriver = JitDriver(greens=['code', 'pc'], reds=['n'],
+ myjitdriver = JitDriver(greens=['pc', 'code'], reds=['n'],
get_printable_location=p, can_inline=c)
def f(code, n):
@@ -535,12 +564,12 @@
self.check_history(int_add=1)
def test_dont_inline_huge_stuff(self):
- def p(code, pc):
+ def p(pc, code):
code = hlstr(code)
return "%s %d %s" % (code, pc, code[pc])
- def c(code, pc):
+ def c(pc, code):
return "l" not in hlstr(code)
- myjitdriver = JitDriver(greens=['code', 'pc'], reds=['n'],
+ myjitdriver = JitDriver(greens=['pc', 'code'], reds=['n'],
get_printable_location=p, can_inline=c)
def f(code, n):
@@ -693,7 +722,7 @@
class Frame(object):
_virtualizable2_ = ['thing']
- driver = JitDriver(greens = ['codeno'], reds = ['frame', 'i'],
+ driver = JitDriver(greens = ['codeno'], reds = ['i', 'frame'],
virtualizables = ['frame'],
get_printable_location = lambda codeno : str(codeno),
can_inline = lambda codeno : False)
@@ -729,7 +758,7 @@
class Frame(object):
_virtualizable2_ = ['thing']
- driver = JitDriver(greens = ['codeno'], reds = ['frame', 'i'],
+ driver = JitDriver(greens = ['codeno'], reds = ['i', 'frame'],
virtualizables = ['frame'],
get_printable_location = lambda codeno : str(codeno),
can_inline = lambda codeno : False)
@@ -770,7 +799,7 @@
assert res == main(0)
def test_directly_call_assembler_virtualizable_with_array(self):
- myjitdriver = JitDriver(greens = ['codeno'], reds = ['n', 'frame', 'x'],
+ myjitdriver = JitDriver(greens = ['codeno'], reds = ['n', 'x', 'frame'],
virtualizables = ['frame'],
can_inline = lambda codeno : False)
@@ -816,7 +845,7 @@
class Frame(object):
_virtualizable2_ = ['thing']
- driver = JitDriver(greens = ['codeno'], reds = ['frame', 'i'],
+ driver = JitDriver(greens = ['codeno'], reds = ['i', 'frame'],
virtualizables = ['frame'],
get_printable_location = lambda codeno : str(codeno),
can_inline = lambda codeno : False)
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_resume.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_resume.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_resume.py Tue Jun 8 19:48:40 2010
@@ -3,10 +3,11 @@
from pypy.jit.metainterp.optimizeopt import VirtualValue, OptValue, VArrayValue
from pypy.jit.metainterp.optimizeopt import VStructValue
from pypy.jit.metainterp.resume import *
-from pypy.jit.metainterp.history import BoxInt, BoxPtr, ConstInt, ConstAddr
+from pypy.jit.metainterp.history import BoxInt, BoxPtr, ConstInt
from pypy.jit.metainterp.history import ConstPtr, ConstFloat
from pypy.jit.metainterp.test.test_optimizefindnode import LLtypeMixin
from pypy.jit.metainterp import executor
+from pypy.jit.codewriter import heaptracker
class Storage:
rd_frame_info_list = None
@@ -60,12 +61,12 @@
self.resboxes = []
def newframe(self, jitcode):
- frame = FakeFrame(jitcode, -1, -1)
+ frame = FakeFrame(jitcode, -1)
self.framestack.append(frame)
return frame
def execute_and_record(self, opnum, descr, *argboxes):
- resbox = executor.execute(self.cpu, opnum, descr, *argboxes)
+ resbox = executor.execute(self.cpu, None, opnum, descr, *argboxes)
self.trace.append((opnum,
list(argboxes),
resbox,
@@ -74,10 +75,75 @@
self.resboxes.append(resbox)
return resbox
+S = lltype.GcStruct('S')
+gcref1 = lltype.cast_opaque_ptr(llmemory.GCREF, lltype.malloc(S))
+gcref2 = lltype.cast_opaque_ptr(llmemory.GCREF, lltype.malloc(S))
+gcrefnull = lltype.nullptr(llmemory.GCREF.TO)
+
+class MyCPU:
+ class ts:
+ NULLREF = gcrefnull
+ CONST_NULL = ConstPtr(gcrefnull)
+ def __init__(self, values):
+ self.values = values
+ def get_latest_value_count(self):
+ return len(self.values)
+ def get_latest_value_int(self, index):
+ return self.values[index]
+ def get_latest_value_ref(self, index):
+ return self.values[index]
+ def get_latest_value_float(self, index):
+ return self.values[index]
+
+class MyBlackholeInterp:
+ def __init__(self, ARGS):
+ self.written_i = []
+ self.written_r = []
+ self.written_f = []
+ self.ARGS = ARGS
+
+ def get_current_position_info(self):
+ class MyInfo:
+ @staticmethod
+ def enumerate_vars(callback_i, callback_r, callback_f, _):
+ count_i = count_r = count_f = 0
+ for index, ARG in enumerate(self.ARGS):
+ if ARG == lltype.Signed:
+ callback_i(index, count_i); count_i += 1
+ elif ARG == llmemory.GCREF:
+ callback_r(index, count_r); count_r += 1
+ elif ARG == lltype.Float:
+ callback_f(index, count_f); count_f += 1
+ else:
+ assert 0
+ return MyInfo()
+
+ def setarg_i(self, index, value):
+ assert index == len(self.written_i)
+ self.written_i.append(value)
+
+ def setarg_r(self, index, value):
+ assert index == len(self.written_r)
+ self.written_r.append(value)
+
+ def setarg_f(self, index, value):
+ assert index == len(self.written_f)
+ self.written_f.append(value)
+
+def _next_section(reader, *expected):
+ bh = MyBlackholeInterp(map(lltype.typeOf, expected))
+ reader.consume_one_section(bh)
+ expected_i = [x for x in expected if lltype.typeOf(x) == lltype.Signed]
+ expected_r = [x for x in expected if lltype.typeOf(x) == llmemory.GCREF]
+ expected_f = [x for x in expected if lltype.typeOf(x) == lltype.Float]
+ assert bh.written_i == expected_i
+ assert bh.written_r == expected_r
+ assert bh.written_f == expected_f
+
def test_simple_read():
- b1, b2, b3 = [BoxInt(), BoxPtr(), BoxInt()]
- c1, c2, c3 = [ConstInt(1), ConstInt(2), ConstInt(3)]
+ #b1, b2, b3 = [BoxInt(), BoxPtr(), BoxInt()]
+ c1, c2, c3 = [ConstInt(111), ConstInt(222), ConstInt(333)]
storage = Storage()
storage.rd_consts = [c1, c2, c3]
numb = Numbering(None, [tag(0, TAGBOX), tag(1, TAGBOX), tag(2, TAGBOX)])
@@ -88,44 +154,54 @@
tag(0, TAGBOX),
tag(1, TAGBOX)])
storage.rd_numb = numb
-
- b1s, b2s, b3s = [BoxInt(), BoxPtr(), BoxInt()]
- assert b1s != b3s
- reader = ResumeDataReader(storage, [b1s, b2s, b3s], MyMetaInterp())
- lst = reader.consume_boxes()
- assert lst == [b1s, ConstInt(1), LLtypeMixin.cpu.ts.CONST_NULL, b1s, b2s]
- lst = reader.consume_boxes()
- assert lst == [ConstInt(2), ConstInt(3)]
- lst = reader.consume_boxes()
- assert lst == [b1s, b2s, b3s]
+ #
+ cpu = MyCPU([42, gcref1, -66])
+ reader = ResumeDataDirectReader(cpu, storage)
+ _next_section(reader, 42, 111, gcrefnull, 42, gcref1)
+ _next_section(reader, 222, 333)
+ _next_section(reader, 42, gcref1, -66)
+ #
+ metainterp = MyMetaInterp(cpu)
+ reader = ResumeDataBoxReader(storage, metainterp)
+ bi, br, bf = [None]*3, [None]*2, [None]*0
+ info = MyBlackholeInterp([lltype.Signed, lltype.Signed,
+ llmemory.GCREF, lltype.Signed,
+ llmemory.GCREF]).get_current_position_info()
+ reader.consume_boxes(info, bi, br, bf)
+ b1s = reader.liveboxes[0]
+ b2s = reader.liveboxes[1]
+ assert bi == [b1s, ConstInt(111), b1s]
+ assert br == [ConstPtr(gcrefnull), b2s]
+ bi, br, bf = [None]*2, [None]*0, [None]*0
+ info = MyBlackholeInterp([lltype.Signed,
+ lltype.Signed]).get_current_position_info()
+ reader.consume_boxes(info, bi, br, bf)
+ assert bi == [ConstInt(222), ConstInt(333)]
+ bi, br, bf = [None]*2, [None]*1, [None]*0
+ info = MyBlackholeInterp([lltype.Signed, llmemory.GCREF,
+ lltype.Signed]).get_current_position_info()
+ reader.consume_boxes(info, bi, br, bf)
+ b3s = reader.liveboxes[2]
+ assert bi == [b1s, b3s]
+ assert br == [b2s]
+ #
def test_simple_read_tagged_ints():
- b1, b2, b3 = [BoxInt(), BoxPtr(), BoxInt()]
storage = Storage()
storage.rd_consts = []
- numb = Numbering(None, [tag(0, TAGBOX), tag(1, TAGBOX), tag(2, TAGBOX)])
- numb = Numbering(numb, [tag(2, TAGINT), tag(3, TAGINT)])
- numb = Numbering(numb, [tag(0, TAGBOX),
- tag(1, TAGINT),
- tag(0, TAGBOX),
- tag(1, TAGBOX)])
+ numb = Numbering(None, [tag(100, TAGINT)])
storage.rd_numb = numb
- b1s, b2s, b3s = [BoxInt(), BoxPtr(), BoxInt()]
- assert b1s != b3s
- reader = ResumeDataReader(storage, [b1s, b2s, b3s], MyMetaInterp())
- lst = reader.consume_boxes()
- assert lst == [b1s, ConstInt(1), b1s, b2s]
- lst = reader.consume_boxes()
- assert lst == [ConstInt(2), ConstInt(3)]
- lst = reader.consume_boxes()
- assert lst == [b1s, b2s, b3s]
+ #
+ cpu = MyCPU([])
+ reader = ResumeDataDirectReader(cpu, storage)
+ _next_section(reader, 100)
def test_prepare_virtuals():
class FakeVinfo(object):
- def allocate(self, metainterp):
+ def allocate(self, decoder):
return "allocated"
- def setfields(self, metainterp, virtual, func):
+ def setfields(self, decoder, virtual):
assert virtual == "allocated"
class FakeStorage(object):
rd_virtuals = [FakeVinfo(), None]
@@ -135,8 +211,8 @@
class FakeMetainterp(object):
_already_allocated_resume_virtuals = None
cpu = None
- reader = ResumeDataReader(FakeStorage(), [], FakeMetainterp())
- assert reader.virtuals == ["allocated", None]
+ reader = ResumeDataDirectReader(None, FakeStorage())
+ assert reader.virtuals == ["allocated", reader.virtual_default]
# ____________________________________________________________
@@ -146,11 +222,13 @@
parent_resumedata_snapshot = None
parent_resumedata_frame_info_list = None
- def __init__(self, code, pc, exc_target, *boxes):
+ def __init__(self, code, pc, *boxes):
self.jitcode = code
self.pc = pc
- self.exception_target = exc_target
- self.env = list(boxes)
+ self._env = list(boxes)
+
+ def get_list_of_active_boxes(self, flag):
+ return self._env
def setup_resume_at_op(self, pc, exception_target, env):
self.__init__(self.jitcode, pc, exception_target, *env)
@@ -160,8 +238,7 @@
def __ne__(self, other):
return self.__dict__ != other.__dict__
def __repr__(self):
- return "<FF %s %s %s %s>" % (self.jitcode, self.pc,
- self.exception_target, self.env)
+ return "<FF %s %s %s>" % (self.jitcode, self.pc, self._env)
def test_Snapshot_create():
l = ['b0', 'b1']
@@ -176,20 +253,16 @@
def test_FrameInfo_create():
jitcode = "JITCODE"
- frame = FakeFrame(jitcode, 1, 2)
- fi = FrameInfo(None, frame)
+ fi = FrameInfo(None, jitcode, 1)
assert fi.prev is None
assert fi.jitcode is jitcode
assert fi.pc == 1
- assert fi.exception_target == 2
jitcode1 = "JITCODE1"
- frame1 = FakeFrame(jitcode, 3, 4)
- fi1 = FrameInfo(fi, frame1)
+ fi1 = FrameInfo(fi, jitcode1, 3)
assert fi1.prev is fi
- assert fi1.jitcode is jitcode
+ assert fi1.jitcode is jitcode1
assert fi1.pc == 3
- assert fi1.exception_target == 4
def test_Numbering_create():
l = [1, 2]
@@ -205,7 +278,7 @@
def test_capture_resumedata():
b1, b2, b3 = [BoxInt(), BoxPtr(), BoxInt()]
c1, c2, c3 = [ConstInt(1), ConstInt(2), ConstInt(3)]
- fs = [FakeFrame("code0", 0, -1, b1, c1, b2)]
+ fs = [FakeFrame("code0", 0, b1, c1, b2)]
storage = Storage()
capture_resumedata(fs, None, [], storage)
@@ -218,13 +291,12 @@
assert storage.rd_snapshot.boxes == [] # for virtualrefs
snapshot = storage.rd_snapshot.prev
assert snapshot.prev is None
- assert snapshot.boxes == fs[0].env
- assert snapshot.boxes is not fs[0].env
+ assert snapshot.boxes == fs[0]._env
storage = Storage()
- fs = [FakeFrame("code0", 0, -1, b1, c1, b2),
- FakeFrame("code1", 3, 7, b3, c2, b1),
- FakeFrame("code2", 9, -1, c3, b2)]
+ fs = [FakeFrame("code0", 0, b1, c1, b2),
+ FakeFrame("code1", 3, b3, c2, b1),
+ FakeFrame("code2", 9, c3, b2)]
capture_resumedata(fs, None, [], storage)
frame_info_list = storage.rd_frame_info_list
@@ -235,26 +307,23 @@
assert storage.rd_snapshot.boxes == [] # for virtualrefs
snapshot = storage.rd_snapshot.prev
assert snapshot.prev is fs[2].parent_resumedata_snapshot
- assert snapshot.boxes == fs[2].env
- assert snapshot.boxes is not fs[2].env
+ assert snapshot.boxes == fs[2]._env
frame_info_list = frame_info_list.prev
assert frame_info_list.prev is fs[1].parent_resumedata_frame_info_list
assert frame_info_list.jitcode == 'code1'
snapshot = snapshot.prev
assert snapshot.prev is fs[1].parent_resumedata_snapshot
- assert snapshot.boxes == fs[1].env
- assert snapshot.boxes is not fs[1].env
+ assert snapshot.boxes == fs[1]._env
frame_info_list = frame_info_list.prev
assert frame_info_list.prev is None
assert frame_info_list.jitcode == 'code0'
snapshot = snapshot.prev
assert snapshot.prev is None
- assert snapshot.boxes == fs[0].env
- assert snapshot.boxes is not fs[0].env
+ assert snapshot.boxes == fs[0]._env
- fs[2].env = [b2, b3]
+ fs[2]._env = [b3, b2]
fs[2].pc = 15
vbs = [b1, b2]
vrs = [b3]
@@ -266,16 +335,11 @@
assert frame_info_list.pc == 15
snapshot = storage.rd_snapshot
- assert snapshot.boxes == vbs
- assert snapshot.boxes is not vbs
-
- snapshot = snapshot.prev
- assert snapshot.boxes == vrs
- assert snapshot.boxes is not vrs
+ assert snapshot.boxes == vrs + vbs # in the same list
snapshot = snapshot.prev
assert snapshot.prev is fs[2].parent_resumedata_snapshot
- assert snapshot.boxes == fs[2].env
+ assert snapshot.boxes == fs[2]._env
class FakeMetaInterpStaticData:
@@ -285,12 +349,13 @@
failargs_limit = 100
def test_rebuild_from_resumedata():
+ py.test.skip("XXX rewrite")
b1, b2, b3 = [BoxInt(), BoxPtr(), BoxInt()]
c1, c2, c3 = [ConstInt(1), ConstInt(2), ConstInt(3)]
storage = Storage()
- fs = [FakeFrame("code0", 0, -1, b1, c1, b2),
- FakeFrame("code1", 3, 7, b3, c2, b1),
- FakeFrame("code2", 9, -1, c3, b2)]
+ fs = [FakeFrame("code0", 0, b1, c1, b2),
+ FakeFrame("code1", 3, b3, c2, b1),
+ FakeFrame("code2", 9, c3, b2)]
capture_resumedata(fs, None, [], storage)
memo = ResumeDataLoopMemo(FakeMetaInterpStaticData())
modifier = ResumeDataVirtualAdder(storage, memo)
@@ -300,21 +365,21 @@
b1t, b2t, b3t = [BoxInt(), BoxPtr(), BoxInt()]
newboxes = _resume_remap(liveboxes, [b1, b2, b3], b1t, b2t, b3t)
- result = rebuild_from_resumedata(metainterp, newboxes, storage,
- False)
+ result = rebuild_from_resumedata(metainterp, storage, False)
assert result == (None, [])
- fs2 = [FakeFrame("code0", 0, -1, b1t, c1, b2t),
- FakeFrame("code1", 3, 7, b3t, c2, b1t),
- FakeFrame("code2", 9, -1, c3, b2t)]
+ fs2 = [FakeFrame("code0", 0, b1t, c1, b2t),
+ FakeFrame("code1", 3, b3t, c2, b1t),
+ FakeFrame("code2", 9, c3, b2t)]
assert metainterp.framestack == fs2
def test_rebuild_from_resumedata_with_virtualizable():
+ py.test.skip("XXX rewrite")
b1, b2, b3, b4 = [BoxInt(), BoxPtr(), BoxInt(), BoxPtr()]
c1, c2, c3 = [ConstInt(1), ConstInt(2), ConstInt(3)]
storage = Storage()
- fs = [FakeFrame("code0", 0, -1, b1, c1, b2),
- FakeFrame("code1", 3, 7, b3, c2, b1),
- FakeFrame("code2", 9, -1, c3, b2)]
+ fs = [FakeFrame("code0", 0, b1, c1, b2),
+ FakeFrame("code1", 3, b3, c2, b1),
+ FakeFrame("code2", 9, c3, b2)]
capture_resumedata(fs, [b4], [], storage)
memo = ResumeDataLoopMemo(FakeMetaInterpStaticData())
modifier = ResumeDataVirtualAdder(storage, memo)
@@ -327,21 +392,22 @@
result = rebuild_from_resumedata(metainterp, newboxes, storage,
True)
assert result == ([b4t], [])
- fs2 = [FakeFrame("code0", 0, -1, b1t, c1, b2t),
- FakeFrame("code1", 3, 7, b3t, c2, b1t),
- FakeFrame("code2", 9, -1, c3, b2t)]
+ fs2 = [FakeFrame("code0", 0, b1t, c1, b2t),
+ FakeFrame("code1", 3, b3t, c2, b1t),
+ FakeFrame("code2", 9, c3, b2t)]
assert metainterp.framestack == fs2
def test_rebuild_from_resumedata_two_guards():
+ py.test.skip("XXX rewrite")
b1, b2, b3, b4 = [BoxInt(), BoxPtr(), BoxInt(), BoxInt()]
c1, c2, c3 = [ConstInt(1), ConstInt(2), ConstInt(3)]
storage = Storage()
- fs = [FakeFrame("code0", 0, -1, b1, c1, b2),
- FakeFrame("code1", 3, 7, b3, c2, b1),
- FakeFrame("code2", 9, -1, c3, b2)]
+ fs = [FakeFrame("code0", 0, b1, c1, b2),
+ FakeFrame("code1", 3, b3, c2, b1),
+ FakeFrame("code2", 9, c3, b2)]
capture_resumedata(fs, None, [], storage)
storage2 = Storage()
- fs = fs[:-1] + [FakeFrame("code2", 10, -1, c3, b2, b4)]
+ fs = fs[:-1] + [FakeFrame("code2", 10, c3, b2, b4)]
capture_resumedata(fs, None, [], storage2)
memo = ResumeDataLoopMemo(FakeMetaInterpStaticData())
@@ -359,9 +425,9 @@
result = rebuild_from_resumedata(metainterp, newboxes, storage,
False)
assert result == (None, [])
- fs2 = [FakeFrame("code0", 0, -1, b1t, c1, b2t),
- FakeFrame("code1", 3, 7, b3t, c2, b1t),
- FakeFrame("code2", 9, -1, c3, b2t)]
+ fs2 = [FakeFrame("code0", 0, b1t, c1, b2t),
+ FakeFrame("code1", 3, b3t, c2, b1t),
+ FakeFrame("code2", 9, c3, b2t)]
assert metainterp.framestack == fs2
newboxes = _resume_remap(liveboxes2, [b1, b2, b3, b4], b1t, b2t, b3t, b4t)
@@ -370,7 +436,7 @@
result = rebuild_from_resumedata(metainterp, newboxes, storage2,
False)
assert result == (None, [])
- fs2 = fs2[:-1] + [FakeFrame("code2", 10, -1, c3, b2t, b4t)]
+ fs2 = fs2[:-1] + [FakeFrame("code2", 10, c3, b2t, b4t)]
assert metainterp.framestack == fs2
@@ -379,6 +445,9 @@
pass
fakeoptimizer = FakeOptimizer_VirtualValue()
+def ConstAddr(addr, cpu): # compatibility
+ return ConstInt(heaptracker.adr2int(addr))
+
def virtual_value(keybox, value, next):
vv = VirtualValue(fakeoptimizer, ConstAddr(LLtypeMixin.node_vtable_adr,
LLtypeMixin.cpu), keybox)
@@ -389,17 +458,18 @@
return vv
def test_rebuild_from_resumedata_two_guards_w_virtuals():
+ py.test.skip("XXX rewrite")
b1, b2, b3, b4, b5 = [BoxInt(), BoxPtr(), BoxInt(), BoxInt(), BoxInt()]
c1, c2, c3, c4 = [ConstInt(1), ConstInt(2), ConstInt(3),
LLtypeMixin.nodebox.constbox()]
storage = Storage()
- fs = [FakeFrame("code0", 0, -1, b1, c1, b2),
- FakeFrame("code1", 3, 7, b3, c2, b1),
- FakeFrame("code2", 9, -1, c3, b2)]
+ fs = [FakeFrame("code0", 0, b1, c1, b2),
+ FakeFrame("code1", 3, b3, c2, b1),
+ FakeFrame("code2", 9, c3, b2)]
capture_resumedata(fs, None, [], storage)
storage2 = Storage()
- fs = fs[:-1] + [FakeFrame("code2", 10, -1, c3, b2, b4)]
+ fs = fs[:-1] + [FakeFrame("code2", 10, c3, b2, b4)]
capture_resumedata(fs, None, [], storage2)
memo = ResumeDataLoopMemo(FakeMetaInterpStaticData())
@@ -433,9 +503,9 @@
False)
b2t = metainterp.resboxes[0]
- fs2 = [FakeFrame("code0", 0, -1, b1t, c1, b2t),
- FakeFrame("code1", 3, 7, b3t, c2, b1t),
- FakeFrame("code2", 9, -1, c3, b2t)]
+ fs2 = [FakeFrame("code0", 0, b1t, c1, b2t),
+ FakeFrame("code1", 3, b3t, c2, b1t),
+ FakeFrame("code2", 9, c3, b2t)]
assert metainterp.framestack == fs2
newboxes = _resume_remap(liveboxes2, [b1, b3, b4], b1t, b3t, b4t)
@@ -445,17 +515,18 @@
False)
b2t = metainterp.resboxes[0]
assert len(metainterp.resboxes) == 2
- fs2 = [FakeFrame("code0", 0, -1, b1t, c1, b2t),
- FakeFrame("code1", 3, 7, b3t, c2, b1t),
- FakeFrame("code2", 10, -1, c3, b2t, b4t)]
+ fs2 = [FakeFrame("code0", 0, b1t, c1, b2t),
+ FakeFrame("code1", 3, b3t, c2, b1t),
+ FakeFrame("code2", 10, c3, b2t, b4t)]
assert metainterp.framestack == fs2
def test_rebuild_from_resumedata_two_guards_w_shared_virtuals():
+ py.test.skip("XXX rewrite")
b1, b2, b3, b4, b5, b6 = [BoxPtr(), BoxPtr(), BoxInt(), BoxPtr(), BoxInt(), BoxInt()]
c1, c2, c3, c4 = [ConstInt(1), ConstInt(2), ConstInt(3),
LLtypeMixin.nodebox.constbox()]
storage = Storage()
- fs = [FakeFrame("code0", 0, -1, c1, b2, b3)]
+ fs = [FakeFrame("code0", 0, c1, b2, b3)]
capture_resumedata(fs, None, [], storage)
memo = ResumeDataLoopMemo(FakeMetaInterpStaticData())
@@ -467,7 +538,7 @@
tag(0, TAGCONST)]
storage2 = Storage()
- fs = [FakeFrame("code0", 0, -1, b1, b4, b2)]
+ fs = [FakeFrame("code0", 0, b1, b4, b2)]
capture_resumedata(fs, None, [], storage2)
values[b4] = virtual_value(b4, b6, c4)
modifier = ResumeDataVirtualAdder(storage2, memo)
@@ -478,9 +549,10 @@
def test_resumedata_top_recursive_virtuals():
+ py.test.skip("XXX rewrite")
b1, b2, b3 = [BoxPtr(), BoxPtr(), BoxInt()]
storage = Storage()
- fs = [FakeFrame("code0", 0, -1, b1, b2)]
+ fs = [FakeFrame("code0", 0, b1, b2)]
capture_resumedata(fs, None, [], storage)
memo = ResumeDataLoopMemo(FakeMetaInterpStaticData())
@@ -727,16 +799,11 @@
modifier = ResumeDataVirtualAdder(storage, memo)
liveboxes = modifier.finish({})
assert storage.rd_snapshot is None
- metainterp = MyMetaInterp()
- reader = ResumeDataReader(storage, [], metainterp)
- lst = reader.consume_boxes()
- assert lst == [b1s, b2s, b3s]
- lst = reader.consume_boxes()
- assert lst == [ConstInt(2), ConstInt(3)]
- lst = reader.consume_boxes()
- assert lst == [ConstInt(sys.maxint), ConstInt(1), ConstInt(sys.maxint),
- ConstInt(2**16)]
- assert metainterp.trace == []
+ cpu = MyCPU([])
+ reader = ResumeDataDirectReader(cpu, storage)
+ _next_section(reader, sys.maxint, 2**16, -65)
+ _next_section(reader, 2, 3)
+ _next_section(reader, sys.maxint, 1, sys.maxint, 2**16)
def test_virtual_adder_memo_const_sharing():
@@ -756,6 +823,46 @@
assert storage2.rd_consts is memo.consts
+class ResumeDataFakeReader(ResumeDataBoxReader):
+ """Another subclass of AbstractResumeDataReader meant for tests."""
+ def __init__(self, storage, newboxes, metainterp):
+ self._init(metainterp.cpu, storage)
+ self.liveboxes = newboxes
+ self.metainterp = metainterp
+ self._prepare(storage)
+
+ def consume_boxes(self):
+ self.lst = []
+ class Whatever:
+ def __eq__(self, other):
+ return True
+ class MyInfo:
+ @staticmethod
+ def enumerate_vars(callback_i, callback_r, callback_f, _):
+ for index, tagged in enumerate(self.cur_numb.nums):
+ box = self.decode_box(tagged, Whatever())
+ if box.type == INT:
+ callback_i(index, index)
+ elif box.type == REF:
+ callback_r(index, index)
+ elif box.type == FLOAT:
+ callback_f(index, index)
+ else:
+ assert 0
+ self._prepare_next_section(MyInfo())
+ return self.lst
+
+ def write_an_int(self, count_i, box):
+ assert box.type == INT
+ self.lst.append(box)
+ def write_a_ref(self, count_r, box):
+ assert box.type == REF
+ self.lst.append(box)
+ def write_a_float(self, count_f, box):
+ assert box.type == FLOAT
+ self.lst.append(box)
+
+
def test_virtual_adder_no_op_renaming():
b1s, b2s, b3s = [BoxInt(1), BoxInt(2), BoxInt(3)]
storage = make_storage(b1s, b2s, b3s)
@@ -777,7 +884,7 @@
b1t, b3t = [BoxInt(11), BoxInt(33)]
newboxes = _resume_remap(liveboxes, [b1_2, b3s], b1t, b3t)
metainterp = MyMetaInterp()
- reader = ResumeDataReader(storage, newboxes, metainterp)
+ reader = ResumeDataFakeReader(storage, newboxes, metainterp)
lst = reader.consume_boxes()
assert lst == [b1t, b1t, b3t]
lst = reader.consume_boxes()
@@ -797,7 +904,7 @@
b2t, b3t = [BoxPtr(demo55o), BoxInt(33)]
newboxes = _resume_remap(liveboxes, [b2s, b3s], b2t, b3t)
metainterp = MyMetaInterp()
- reader = ResumeDataReader(storage, newboxes, metainterp)
+ reader = ResumeDataFakeReader(storage, newboxes, metainterp)
lst = reader.consume_boxes()
c1t = ConstInt(111)
assert lst == [c1t, b2t, b3t]
@@ -849,10 +956,10 @@
b5s], b3t, b5t)
metainterp = MyMetaInterp()
- reader = ResumeDataReader(storage, newboxes, metainterp)
+ reader = ResumeDataFakeReader(storage, newboxes, metainterp)
assert len(reader.virtuals) == 2
- b2t = reader._decode_box(modifier._gettagged(b2s))
- b4t = reader._decode_box(modifier._gettagged(b4s))
+ b2t = reader.decode_ref(modifier._gettagged(b2s))
+ b4t = reader.decode_ref(modifier._gettagged(b4s))
trace = metainterp.trace
b2new = (rop.NEW_WITH_VTABLE, [ConstAddr(LLtypeMixin.node_vtable_adr,
LLtypeMixin.cpu)],
@@ -912,9 +1019,9 @@
b4t)
# resume
metainterp = MyMetaInterp()
- reader = ResumeDataReader(storage, newboxes, metainterp)
+ reader = ResumeDataFakeReader(storage, newboxes, metainterp)
assert len(reader.virtuals) == 1
- b2t = reader._decode_box(tag(0, TAGVIRTUAL))
+ b2t = reader.decode_ref(tag(0, TAGVIRTUAL))
trace = metainterp.trace
expected = [
(rop.NEW_ARRAY, [ConstInt(2)], b2t, LLtypeMixin.arraydescr),
@@ -957,9 +1064,9 @@
#
NULL = ConstPtr.value
metainterp = MyMetaInterp()
- reader = ResumeDataReader(storage, newboxes, metainterp)
+ reader = ResumeDataFakeReader(storage, newboxes, metainterp)
assert len(reader.virtuals) == 1
- b2t = reader._decode_box(tag(0, TAGVIRTUAL))
+ b2t = reader.decode_ref(tag(0, TAGVIRTUAL))
trace = metainterp.trace
expected = [
@@ -1004,7 +1111,7 @@
newboxes = _resume_remap(liveboxes, [b2s, b4s], b2t, b4t)
metainterp = MyMetaInterp()
- reader = ResumeDataReader(storage, newboxes, metainterp)
+ reader = ResumeDataFakeReader(storage, newboxes, metainterp)
assert reader.virtuals is None
trace = metainterp.trace
b2set = (rop.SETFIELD_GC, [b2t, b4t], None, LLtypeMixin.nextdescr)
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_send.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_send.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_send.py Tue Jun 8 19:48:40 2010
@@ -1,7 +1,6 @@
import py
from pypy.rlib.jit import JitDriver, hint, purefunction
-from pypy.jit.metainterp.policy import StopAtXPolicy
-from pypy.rpython.ootypesystem import ootype
+from pypy.jit.codewriter.policy import StopAtXPolicy
from pypy.jit.metainterp.test.test_basic import LLJitMixin, OOJitMixin
@@ -375,7 +374,7 @@
self.check_loop_count(2)
def test_behavior_change_after_a_while(self):
- myjitdriver = JitDriver(greens = [], reds = ['x', 'y'])
+ myjitdriver = JitDriver(greens = [], reds = ['y', 'x'])
class Base:
def __init__(self, value):
self.value = value
@@ -455,7 +454,7 @@
self.check_tree_loop_count(2)
def test_bug1(self):
- myjitdriver = JitDriver(greens = [], reds = ['node', 'n'])
+ myjitdriver = JitDriver(greens = [], reds = ['n', 'node'])
class Base:
pass
class A(Base):
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_slist.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_slist.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_slist.py Tue Jun 8 19:48:40 2010
@@ -1,5 +1,4 @@
import py
-from pypy.jit.metainterp.policy import StopAtXPolicy
from pypy.jit.metainterp.test.test_basic import LLJitMixin, OOJitMixin
from pypy.rlib.jit import JitDriver, OPTIMIZER_SIMPLE
@@ -65,7 +64,7 @@
assert res == 0
def test_getitem(self):
- myjitdriver = JitDriver(greens = [], reds = ['n', 'lst', 'i'])
+ myjitdriver = JitDriver(greens = [], reds = ['n', 'i', 'lst'])
def f(n):
lst = []
for i in range(n):
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_string.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_string.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_string.py Tue Jun 8 19:48:40 2010
@@ -1,13 +1,13 @@
import py
from pypy.rlib.jit import JitDriver
-from pypy.jit.metainterp.policy import StopAtXPolicy
+from pypy.jit.codewriter.policy import StopAtXPolicy
from pypy.rpython.ootypesystem import ootype
from pypy.jit.metainterp.test.test_basic import LLJitMixin, OOJitMixin
class StringTests:
def test_eq_residual(self):
- jitdriver = JitDriver(greens = [], reds = ['s', 'n', 'i'])
+ jitdriver = JitDriver(greens = [], reds = ['n', 'i', 's'])
global_s = "hello"
def f(n, b, s):
if b:
@@ -44,6 +44,34 @@
assert res == 5
self.check_loops(**{self.CALL_PURE: 0})
+ def test_newstr(self):
+ jitdriver = JitDriver(greens = [], reds = ['n', 'm'])
+ def f(n, m):
+ while True:
+ jitdriver.can_enter_jit(m=m, n=n)
+ jitdriver.jit_merge_point(m=m, n=n)
+ bytecode = 'adlfkj' + chr(n)
+ res = bytecode[n]
+ m -= 1
+ if m < 0:
+ return ord(res)
+ res = self.meta_interp(f, [6, 10])
+ assert res == 6
+
+ def test_newunicode(self):
+ jitdriver = JitDriver(greens = [], reds = ['n', 'm'])
+ def f(n, m):
+ while True:
+ jitdriver.can_enter_jit(m=m, n=n)
+ jitdriver.jit_merge_point(m=m, n=n)
+ bytecode = u'adlfkj' + unichr(n)
+ res = bytecode[n]
+ m -= 1
+ if m < 0:
+ return ord(res)
+ res = self.meta_interp(f, [6, 10])
+ assert res == 6
+
class TestOOtype(StringTests, OOJitMixin):
CALL_PURE = "oosend_pure"
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_tl.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_tl.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_tl.py Tue Jun 8 19:48:40 2010
@@ -1,6 +1,6 @@
import py
-from pypy.rlib.jit import JitDriver, OPTIMIZER_SIMPLE
-from pypy.jit.metainterp.policy import StopAtXPolicy
+from pypy.rlib.jit import OPTIMIZER_SIMPLE
+from pypy.jit.codewriter.policy import StopAtXPolicy
from pypy.jit.metainterp.test.test_basic import OOJitMixin, LLJitMixin
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_tlc.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_tlc.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_tlc.py Tue Jun 8 19:48:40 2010
@@ -21,7 +21,7 @@
pool = tlc.ConstantPool()
bytecode = tlc.compile(src, pool)
interp = self._get_interp(bytecode, pool)
- return self.meta_interp(interp, [0, inputarg], view=False)
+ return self.meta_interp(interp, [0, inputarg])
def test_method(self):
code = """
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_virtual.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_virtual.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_virtual.py Tue Jun 8 19:48:40 2010
@@ -1,12 +1,12 @@
import py
from pypy.rlib.jit import JitDriver, hint
from pypy.rlib.objectmodel import compute_unique_id
-from pypy.jit.metainterp.policy import StopAtXPolicy
+from pypy.jit.codewriter.policy import StopAtXPolicy
from pypy.jit.metainterp.test.test_basic import LLJitMixin, OOJitMixin
from pypy.rpython.lltypesystem import lltype, rclass
from pypy.rpython.lltypesystem.lloperation import llop
from pypy.rpython.ootypesystem import ootype
-from pypy.jit.metainterp import heaptracker
+from pypy.jit.codewriter import heaptracker
class VirtualTests:
def _freeze_(self):
@@ -299,10 +299,9 @@
self.check_tree_loop_count(2) # the loop and the entry path
# we get:
# ENTER - compile the new loop
- # ENTER (BlackHole) - leave
# ENTER - compile the entry bridge
# ENTER - compile the leaving path
- self.check_enter_count(4)
+ self.check_enter_count(3)
class VirtualMiscTests:
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_virtualizable.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_virtualizable.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_virtualizable.py Tue Jun 8 19:48:40 2010
@@ -2,14 +2,15 @@
from pypy.rpython.extregistry import ExtRegistryEntry
from pypy.rpython.lltypesystem import lltype, lloperation, rclass, llmemory
from pypy.rpython.annlowlevel import llhelper
-from pypy.jit.metainterp.policy import StopAtXPolicy
+from pypy.jit.codewriter.policy import StopAtXPolicy
+from pypy.jit.codewriter import heaptracker
from pypy.rlib.jit import JitDriver, hint, dont_look_inside
from pypy.rlib.jit import OPTIMIZER_SIMPLE, OPTIMIZER_FULL
from pypy.rlib.rarithmetic import intmask
from pypy.jit.metainterp.test.test_basic import LLJitMixin, OOJitMixin
from pypy.rpython.rclass import FieldListAccessor
from pypy.jit.metainterp.warmspot import get_stats, get_translator
-from pypy.jit.metainterp import history, heaptracker
+from pypy.jit.metainterp import history
from pypy.jit.metainterp.test.test_optimizefindnode import LLtypeMixin
def promote_virtualizable(*args):
@@ -461,7 +462,7 @@
def test_virtualizable_with_array(self):
- myjitdriver = JitDriver(greens = [], reds = ['n', 'frame', 'x'],
+ myjitdriver = JitDriver(greens = [], reds = ['n', 'x', 'frame'],
virtualizables = ['frame'])
class Frame(object):
@@ -521,7 +522,7 @@
def test_external_pass(self):
- jitdriver = JitDriver(greens = [], reds = ['frame', 'n', 'z'],
+ jitdriver = JitDriver(greens = [], reds = ['n', 'z', 'frame'],
virtualizables = ['frame'])
class BaseFrame(object):
@@ -583,6 +584,45 @@
self.check_aborted_count(2)
self.check_tree_loop_count(0)
+ def test_external_read_with_exception(self):
+ jitdriver = JitDriver(greens = [], reds = ['frame'],
+ virtualizables = ['frame'])
+
+ class Frame(object):
+ _virtualizable2_ = ['x', 'y']
+ class SomewhereElse:
+ pass
+ somewhere_else = SomewhereElse()
+
+ class FooError(Exception):
+ def __init__(self, value):
+ self.value = value
+
+ def g():
+ result = somewhere_else.top_frame.y # external read
+ debug_print(lltype.Void, '-+-+-+-+- external read:', result)
+ raise FooError(result)
+
+ def f(n):
+ frame = Frame()
+ frame.x = n
+ frame.y = 10
+ somewhere_else.top_frame = frame
+ while frame.x > 0:
+ jitdriver.can_enter_jit(frame=frame)
+ jitdriver.jit_merge_point(frame=frame)
+ try:
+ g()
+ except FooError, e:
+ frame.x -= e.value
+ frame.y += 1
+ return frame.x
+
+ res = self.meta_interp(f, [123], policy=StopAtXPolicy(g))
+ assert res == f(123)
+ self.check_aborted_count(2)
+ self.check_tree_loop_count(0)
+
def test_external_write(self):
jitdriver = JitDriver(greens = [], reds = ['frame'],
virtualizables = ['frame'])
@@ -821,7 +861,7 @@
assert res == f(123)
def test_external_read_sometimes_recursive(self):
- jitdriver = JitDriver(greens = [], reds = ['frame', 'rec'],
+ jitdriver = JitDriver(greens = [], reds = ['rec', 'frame'],
virtualizables = ['frame'])
class Frame(object):
@@ -941,7 +981,7 @@
assert res == f(123)
def test_promote_index_in_virtualizable_list(self):
- jitdriver = JitDriver(greens = [], reds = ['frame', 'n'],
+ jitdriver = JitDriver(greens = [], reds = ['n', 'frame'],
virtualizables = ['frame'])
class Frame(object):
_virtualizable2_ = ['stackpos', 'stack[*]']
@@ -1084,7 +1124,7 @@
res = self.meta_interp(f, [10])
assert res == 55
- self.check_loops(new_with_vtable=0, oois=1)
+ self.check_loops(new_with_vtable=0, ptr_eq=1)
def test_virtual_child_frame_with_arrays(self):
myjitdriver = JitDriver(greens = [], reds = ['frame'],
@@ -1196,7 +1236,7 @@
if not self.basic:
py.test.skip("purely frontend test")
- myjitdriver = JitDriver(greens = [], reds = ['frame', 'fail'],
+ myjitdriver = JitDriver(greens = [], reds = ['fail', 'frame'],
virtualizables = ['frame'])
class Frame(object):
@@ -1251,7 +1291,7 @@
self.x = x
self.next = None
- driver = JitDriver(greens=[], reds=['frame', 'result'],
+ driver = JitDriver(greens=[], reds=['result', 'frame'],
virtualizables=['frame'])
def interp(caller):
@@ -1284,15 +1324,15 @@
self.n = n
self.next = None
- driver = JitDriver(greens=[], reds=['frame', 'result'],
+ driver = JitDriver(greens=[], reds=['result', 'frame'],
virtualizables=['frame'])
- def p(code, pc):
+ def p(pc, code):
code = hlstr(code)
return "%s %d %s" % (code, pc, code[pc])
- def c(code, pc):
+ def c(pc, code):
return "l" not in hlstr(code)
- myjitdriver = JitDriver(greens=['code', 'pc'], reds=['frame'],
+ myjitdriver = JitDriver(greens=['pc', 'code'], reds=['frame'],
virtualizables=["frame"],
get_printable_location=p, can_inline=c)
def f(code, frame):
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_virtualref.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_virtualref.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_virtualref.py Tue Jun 8 19:48:40 2010
@@ -12,9 +12,9 @@
class VRefTests:
- def finish_metainterp_for_interp_operations(self, metainterp):
- self.vrefinfo = VirtualRefInfo(metainterp.staticdata.state)
- metainterp.staticdata.virtualref_info = self.vrefinfo
+ def finish_setup_for_interp_operations(self):
+ self.vrefinfo = VirtualRefInfo(self.warmrunnerstate)
+ self.cw.setup_vrefinfo(self.vrefinfo)
def test_make_vref_simple(self):
class X:
@@ -81,8 +81,26 @@
JIT_VIRTUAL_REF = self.vrefinfo.JIT_VIRTUAL_REF
bxs2[0].getref(lltype.Ptr(JIT_VIRTUAL_REF)).virtual_token = 1234567
#
- self.metainterp.rebuild_state_after_failure(guard_op.descr,
- guard_op.fail_args[:])
+ # try reloading from blackhole.py's point of view
+ from pypy.jit.metainterp.resume import ResumeDataDirectReader
+ cpu = self.metainterp.cpu
+ cpu.get_latest_value_count = lambda : len(guard_op.fail_args)
+ cpu.get_latest_value_int = lambda i:guard_op.fail_args[i].getint()
+ cpu.get_latest_value_ref = lambda i:guard_op.fail_args[i].getref_base()
+ cpu.clear_latest_values = lambda count: None
+ resumereader = ResumeDataDirectReader(cpu, guard_op.descr)
+ vrefinfo = self.metainterp.staticdata.virtualref_info
+ lst = []
+ vrefinfo.continue_tracing = lambda vref, virtual: \
+ lst.append((vref, virtual))
+ resumereader.consume_vref_and_vable(vrefinfo, None)
+ del vrefinfo.continue_tracing
+ assert len(lst) == 1
+ lltype.cast_opaque_ptr(lltype.Ptr(JIT_VIRTUAL_REF),
+ lst[0][0]) # assert correct type
+ #
+ # try reloading from pyjitpl's point of view
+ self.metainterp.rebuild_state_after_failure(guard_op.descr)
assert len(self.metainterp.framestack) == 1
assert len(self.metainterp.virtualref_boxes) == 2
assert self.metainterp.virtualref_boxes[0].value == bxs1[0].value
@@ -424,7 +442,7 @@
self.check_aborted_count(0)
def test_recursive_call_1(self):
- myjitdriver = JitDriver(greens = [], reds = ['n', 'frame', 'rec'])
+ myjitdriver = JitDriver(greens = [], reds = ['n', 'rec', 'frame'])
#
class XY:
pass
@@ -454,7 +472,7 @@
self.check_aborted_count(0)
def test_recursive_call_2(self):
- myjitdriver = JitDriver(greens = [], reds = ['n', 'frame', 'rec'])
+ myjitdriver = JitDriver(greens = [], reds = ['n', 'rec', 'frame'])
#
class XY:
n = 0
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_warmspot.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_warmspot.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_warmspot.py Tue Jun 8 19:48:40 2010
@@ -277,13 +277,13 @@
type_system = 'lltype'
class TestOOWarmspot(WarmspotTests, OOJitMixin):
- CPUClass = runner.OOtypeCPU
+ ##CPUClass = runner.OOtypeCPU
type_system = 'ootype'
class TestWarmspotDirect(object):
def setup_class(cls):
from pypy.jit.metainterp.typesystem import llhelper
- from pypy.jit.metainterp.support import annotate
+ from pypy.jit.codewriter.support import annotate
from pypy.jit.metainterp.warmspot import WarmRunnerDesc
from pypy.rpython.lltypesystem.rclass import OBJECT, OBJECT_VTABLE
from pypy.rpython.lltypesystem import lltype, llmemory
@@ -299,7 +299,7 @@
raise metainterp_sd.warmrunnerdesc.DoneWithThisFrameInt(3)
if self.no == 1:
raise metainterp_sd.warmrunnerdesc.ContinueRunningNormally(
- [BoxInt(0), BoxInt(1)])
+ [0], [], [], [1], [], [])
if self.no == 3:
exc = lltype.malloc(OBJECT)
exc.typeptr = exc_vtable
@@ -308,10 +308,15 @@
lltype.cast_opaque_ptr(llmemory.GCREF, exc))
return self.no
+ class FakeDescr:
+ def as_vtable_size_descr(self):
+ return self
+
class FakeCPU(object):
supports_floats = False
ts = llhelper
translate_support_code = False
+ stats = "stats"
def get_fail_descr_number(self, d):
return -1
@@ -320,7 +325,7 @@
pass
def nodescr(self, *args, **kwds):
- pass
+ return FakeDescr()
fielddescrof = nodescr
calldescrof = nodescr
sizeof = nodescr
@@ -343,6 +348,7 @@
return red
rtyper = annotate(f, [0])
+ FakeCPU.rtyper = rtyper
translator = rtyper.annotator.translator
translator.config.translation.gc = 'hybrid'
cls.desc = WarmRunnerDesc(translator, CPUClass=FakeCPU)
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_warmstate.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_warmstate.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_warmstate.py Tue Jun 8 19:48:40 2010
@@ -128,8 +128,7 @@
class FakeWarmRunnerDesc:
cpu = FakeCPU()
red_args_types = ["int", "float"]
- class metainterp_sd:
- virtualizable_info = None
+ virtualizable_info = None
#
state = WarmEnterState(FakeWarmRunnerDesc())
set_future_values = state.make_set_future_values()
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_ztranslation.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_ztranslation.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/test/test_ztranslation.py Tue Jun 8 19:48:40 2010
@@ -5,7 +5,6 @@
from pypy.rlib.jit import PARAMETERS, dont_look_inside
from pypy.jit.metainterp.jitprof import Profiler
from pypy.rpython.lltypesystem import lltype, llmemory
-from pypy.rpython.ootypesystem import ootype
class TranslationTest:
@@ -40,7 +39,7 @@
def can_inline():
return False
- jitdriver = JitDriver(greens = [], reds = ['frame', 'total'],
+ jitdriver = JitDriver(greens = [], reds = ['total', 'frame'],
virtualizables = ['frame'],
get_jitcell_at=get_jitcell_at,
set_jitcell_at=set_jitcell_at,
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/typesystem.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/typesystem.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/typesystem.py Tue Jun 8 19:48:40 2010
@@ -4,6 +4,7 @@
from pypy.rpython.annlowlevel import cast_instance_to_base_ptr
from pypy.rpython.annlowlevel import cast_instance_to_base_obj
from pypy.jit.metainterp import history
+from pypy.jit.codewriter import heaptracker
from pypy.rlib.objectmodel import r_dict
def deref(T):
@@ -44,9 +45,9 @@
BASETYPE = llmemory.GCREF
BoxRef = history.BoxPtr
ConstRef = history.ConstPtr
- ConstAddr = history.ConstAddr
loops_done_with_this_frame_ref = None # patched by compile.py
- CONST_NULL = history.ConstPtr(history.ConstPtr.value)
+ NULLREF = history.ConstPtr.value
+ CONST_NULL = history.ConstPtr(NULLREF)
CVAL_NULLREF = None # patched by optimizeopt.py
def new_ConstRef(self, x):
@@ -71,17 +72,16 @@
def cast_fnptr_to_root(self, fnptr):
return llmemory.cast_ptr_to_adr(fnptr)
- def cls_of_box(self, cpu, box):
+ def cls_of_box(self, box):
obj = box.getref(lltype.Ptr(rclass.OBJECT))
cls = llmemory.cast_ptr_to_adr(obj.typeptr)
- return history.ConstInt(cpu.cast_adr_to_int(cls))
+ return history.ConstInt(heaptracker.adr2int(cls))
- def subclassOf(self, cpu, clsbox1, clsbox2):
- adr = clsbox2.getaddr(cpu)
+ def instanceOf(self, instbox, clsbox):
+ adr = clsbox.getaddr()
bounding_class = llmemory.cast_adr_to_ptr(adr, rclass.CLASSTYPE)
- adr = clsbox1.getaddr(cpu)
- real_class = llmemory.cast_adr_to_ptr(adr, rclass.CLASSTYPE)
- return rclass.ll_issubclass(real_class, bounding_class)
+ real_instance = instbox.getref(rclass.OBJECTPTR)
+ return rclass.ll_isinstance(real_instance, bounding_class)
def get_exception_box(self, etype):
return history.ConstInt(etype)
@@ -120,7 +120,7 @@
def cast_vtable_to_hashable(self, cpu, ptr):
adr = llmemory.cast_ptr_to_adr(ptr)
- return cpu.cast_adr_to_int(adr)
+ return heaptracker.adr2int(adr)
def cast_from_ref(self, TYPE, value):
return lltype.cast_opaque_ptr(TYPE, value)
@@ -130,8 +130,8 @@
return lltype.cast_opaque_ptr(llmemory.GCREF, value)
cast_to_ref._annspecialcase_ = 'specialize:ll'
- def getaddr_for_box(self, cpu, box):
- return box.getaddr(cpu)
+ def getaddr_for_box(self, box):
+ return box.getaddr()
def rd_eq(ref1, ref2):
return ref1 == ref2
@@ -151,9 +151,9 @@
BASETYPE = ootype.Object
BoxRef = history.BoxObj
ConstRef = history.ConstObj
- ConstAddr = history.ConstObj
loops_done_with_this_frame_ref = None # patched by compile.py
- CONST_NULL = history.ConstObj(history.ConstObj.value)
+ NULLREF = history.ConstObj.value
+ CONST_NULL = history.ConstObj(NULLREF)
CVAL_NULLREF = None # patched by optimizeopt.py
def new_ConstRef(self, x):
@@ -233,7 +233,7 @@
return ootype.cast_to_object(value)
cast_to_ref._annspecialcase_ = 'specialize:ll'
- def getaddr_for_box(self, cpu, box):
+ def getaddr_for_box(self, box):
return box.getref_base()
llhelper = LLTypeHelper()
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/virtualizable.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/virtualizable.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/virtualizable.py Tue Jun 8 19:48:40 2010
@@ -72,6 +72,10 @@
for name in static_fields]
self.array_field_descrs = [cpu.fielddescrof(VTYPE, name)
for name in array_fields]
+ self.static_field_by_descrs = dict(
+ [(descr, i) for (i, descr) in enumerate(self.static_field_descrs)])
+ self.array_field_by_descrs = dict(
+ [(descr, i) for (i, descr) in enumerate(self.array_field_descrs)])
#
getlength = cpu.ts.getlength
getarrayitem = cpu.ts.getarrayitem
@@ -102,6 +106,52 @@
i = i + 1
assert len(boxes) == i + 1
#
+ def write_from_resume_data_partial(virtualizable, reader, nums):
+ # Load values from the reader (see resume.py) described by
+ # the list of numbers 'nums', and write them in their proper
+ # place in the 'virtualizable'. This works from the end of
+ # the list and returns the index in 'nums' of the start of
+ # the virtualizable data found, allowing the caller to do
+ # further processing with the start of the list.
+ i = len(nums) - 1
+ assert i >= 0
+ for ARRAYITEMTYPE, fieldname in unroll_array_fields_rev:
+ lst = getattr(virtualizable, fieldname)
+ for j in range(getlength(lst)-1, -1, -1):
+ i -= 1
+ assert i >= 0
+ x = reader.load_value_of_type(ARRAYITEMTYPE, nums[i])
+ setarrayitem(lst, j, x)
+ for FIELDTYPE, fieldname in unroll_static_fields_rev:
+ i -= 1
+ assert i >= 0
+ x = reader.load_value_of_type(FIELDTYPE, nums[i])
+ setattr(virtualizable, fieldname, x)
+ return i
+ #
+ def load_list_of_boxes(virtualizable, reader, nums):
+ # Uses 'virtualizable' only to know the length of the arrays;
+ # does not write anything into it. The returned list is in
+ # the format expected of virtualizable_boxes, so it ends in
+ # the virtualizable itself.
+ i = len(nums) - 1
+ assert i >= 0
+ boxes = [reader.decode_box_of_type(self.VTYPEPTR, nums[i])]
+ for ARRAYITEMTYPE, fieldname in unroll_array_fields_rev:
+ lst = getattr(virtualizable, fieldname)
+ for j in range(getlength(lst)-1, -1, -1):
+ i -= 1
+ assert i >= 0
+ box = reader.decode_box_of_type(ARRAYITEMTYPE, nums[i])
+ boxes.append(box)
+ for FIELDTYPE, fieldname in unroll_static_fields_rev:
+ i -= 1
+ assert i >= 0
+ box = reader.decode_box_of_type(FIELDTYPE, nums[i])
+ boxes.append(box)
+ boxes.reverse()
+ return boxes
+ #
def check_boxes(virtualizable, boxes):
# for debugging
i = 0
@@ -141,8 +191,14 @@
static_fields))
unroll_array_fields = unrolling_iterable(zip(ARRAYITEMTYPES,
array_fields))
+ unroll_static_fields_rev = unrolling_iterable(
+ reversed(list(unroll_static_fields)))
+ unroll_array_fields_rev = unrolling_iterable(
+ reversed(list(unroll_array_fields)))
self.read_boxes = read_boxes
self.write_boxes = write_boxes
+ self.write_from_resume_data_partial = write_from_resume_data_partial
+ self.load_list_of_boxes = load_list_of_boxes
self.check_boxes = check_boxes
self.get_index_in_array = get_index_in_array
self.get_array_length = get_array_length
@@ -172,6 +228,9 @@
return self.cpu.ts.cast_to_instance_maybe(self.VTYPEPTR, virtualizable)
cast_to_vtype._annspecialcase_ = 'specialize:ll'
+ def cast_gcref_to_vtype(self, virtualizable):
+ return lltype.cast_opaque_ptr(self.VTYPEPTR, virtualizable)
+
def is_vtypeptr(self, TYPE):
return rvirtualizable2.match_virtualizable_type(TYPE, self.VTYPEPTR)
@@ -212,12 +271,6 @@
assert virtualizable.vable_token == self.TOKEN_NONE
force_now._dont_inline_ = True
- def forced_vable(self, virtualizable_boxes):
- virtualizable_box = virtualizable_boxes[-1]
- virtualizable = self.unwrap_virtualizable_box(virtualizable_box)
- self.write_boxes(virtualizable, virtualizable_boxes)
- virtualizable.vable_token = self.TOKEN_NONE
-
# ____________________________________________________________
#
# The 'vable_token' field of a virtualizable is either 0, -1, or points
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/virtualref.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/virtualref.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/virtualref.py Tue Jun 8 19:48:40 2010
@@ -1,6 +1,7 @@
from pypy.rpython.rmodel import inputconst, log
from pypy.rpython.lltypesystem import lltype, llmemory, rffi, rclass
from pypy.jit.metainterp import history
+from pypy.jit.codewriter import heaptracker
class VirtualRefInfo:
@@ -20,7 +21,8 @@
'jit_virtual_ref')
# build some constants
adr = llmemory.cast_ptr_to_adr(self.jit_virtual_ref_vtable)
- self.jit_virtual_ref_const_class = history.ConstAddr(adr, self.cpu)
+ adr = heaptracker.adr2int(adr)
+ self.jit_virtual_ref_const_class = history.ConstInt(adr)
fielddescrof = self.cpu.fielddescrof
self.descr_virtual_token = fielddescrof(self.JIT_VIRTUAL_REF,
'virtual_token')
@@ -60,11 +62,11 @@
# The 'virtual_token' field has the same meaning as the 'vable_token' field
# of a virtualizable. It is equal to:
- # * -2 (TOKEN_NONE) when tracing, except as described below;
+ # * -3 (TOKEN_NONE) when tracing, except as described below;
# * -1 (TOKEN_TRACING_RESCALL) during tracing when we do a residual call;
# * addr in the CPU stack (set by FORCE_TOKEN) when running the assembler;
- # * -2 (TOKEN_NONE) after the virtual is forced, if it is forced at all.
- TOKEN_NONE = -2
+ # * -3 (TOKEN_NONE) after the virtual is forced, if it is forced at all.
+ TOKEN_NONE = -3
TOKEN_TRACING_RESCALL = -1
def virtual_ref_during_tracing(self, real_object):
@@ -104,16 +106,6 @@
# marker "modified during residual call" set.
return True
- def forced_single_vref(self, gcref, real_object):
- if not self.is_virtual_ref(gcref):
- return
- assert real_object
- vref = lltype.cast_opaque_ptr(lltype.Ptr(self.JIT_VIRTUAL_REF), gcref)
- assert (vref.virtual_token != self.TOKEN_NONE and
- vref.virtual_token != self.TOKEN_TRACING_RESCALL)
- vref.virtual_token = self.TOKEN_NONE
- vref.forced = lltype.cast_opaque_ptr(rclass.OBJECTPTR, real_object)
-
def continue_tracing(self, gcref, real_object):
if not self.is_virtual_ref(gcref):
return
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/warmspot.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/warmspot.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/warmspot.py Tue Jun 8 19:48:40 2010
@@ -16,12 +16,13 @@
from pypy.translator.simplify import get_funcobj, get_functype
from pypy.translator.unsimplify import call_final_function
-from pypy.jit.metainterp import codewriter
-from pypy.jit.metainterp import support, history, pyjitpl, gc
+from pypy.jit.metainterp import history, pyjitpl, gc
from pypy.jit.metainterp.pyjitpl import MetaInterpStaticData, MetaInterp
-from pypy.jit.metainterp.policy import JitPolicy
from pypy.jit.metainterp.typesystem import LLTypeHelper, OOTypeHelper
from pypy.jit.metainterp.jitprof import Profiler, EmptyProfiler
+from pypy.jit.metainterp.jitexc import JitException
+from pypy.jit.codewriter import support, codewriter
+from pypy.jit.codewriter.policy import JitPolicy
from pypy.rlib.jit import DEBUG_STEPS, DEBUG_DETAILED, DEBUG_OFF, DEBUG_PROFILE
# ____________________________________________________________
@@ -130,9 +131,6 @@
stats.maybe_view()
stats.check_consistency()
-class JitException(Exception):
- _go_through_llinterp_uncaught_ = True # ugh
-
class ContinueRunningNormallyBase(JitException):
pass
@@ -144,47 +142,49 @@
class WarmRunnerDesc(object):
def __init__(self, translator, policy=None, backendopt=True, CPUClass=None,
- optimizer=None, **kwds):
+ optimizer=None, ProfilerClass=EmptyProfiler, **kwds):
pyjitpl._warmrunnerdesc = self # this is a global for debugging only!
- if policy is None:
- policy = JitPolicy()
self.set_translator(translator)
+ self.build_cpu(CPUClass, **kwds)
self.find_portal()
- self.codewriter = codewriter.CodeWriter(self.rtyper)
- graphs = self.codewriter.find_all_graphs(self.portal_graph,
- policy,
- CPUClass.supports_floats)
+ self.codewriter = codewriter.CodeWriter(self.cpu, self.portal_graph)
+ if policy is None:
+ policy = JitPolicy()
+ policy.set_supports_floats(self.cpu.supports_floats)
+ graphs = self.codewriter.find_all_graphs(policy)
policy.dump_unsafe_loops()
self.check_access_directly_sanity(graphs)
if backendopt:
self.prejit_optimizations(policy, graphs)
- self.build_meta_interp(CPUClass, **kwds)
+ self.build_meta_interp(ProfilerClass)
self.make_args_specification()
#
from pypy.jit.metainterp.virtualref import VirtualRefInfo
- self.metainterp_sd.virtualref_info = VirtualRefInfo(self)
+ vrefinfo = VirtualRefInfo(self)
+ self.codewriter.setup_vrefinfo(vrefinfo)
if self.jitdriver.virtualizables:
from pypy.jit.metainterp.virtualizable import VirtualizableInfo
- self.metainterp_sd.virtualizable_info = VirtualizableInfo(self)
+ self.virtualizable_info = VirtualizableInfo(self)
+ self.codewriter.setup_virtualizable_info(self.virtualizable_info)
+ else:
+ self.virtualizable_info = None
#
self.make_exception_classes()
self.make_driverhook_graphs()
self.make_enter_function()
self.rewrite_jit_merge_point(policy)
-
- self.codewriter.generate_bytecode(self.metainterp_sd,
- self.portal_graph,
- self.portal_runner_ptr
- )
+
+ verbose = not self.cpu.translate_support_code
+ self.codewriter.make_jitcodes(verbose=verbose)
self.rewrite_can_enter_jit()
self.rewrite_set_param()
- self.rewrite_force_virtual()
+ self.rewrite_force_virtual(vrefinfo)
self.add_finish()
- self.metainterp_sd.finish_setup(optimizer=optimizer)
+ self.metainterp_sd.finish_setup(self.codewriter, optimizer=optimizer)
def finish(self):
- vinfo = self.metainterp_sd.virtualizable_info
+ vinfo = self.virtualizable_info
if vinfo is not None:
vinfo.finish()
if self.cpu.translate_support_code:
@@ -244,11 +244,10 @@
remove_asserts=True,
really_remove_asserts=True)
- def build_meta_interp(self, CPUClass, translate_support_code=False,
- view="auto", no_stats=False,
- ProfilerClass=EmptyProfiler, **kwds):
+ def build_cpu(self, CPUClass, translate_support_code=False,
+ no_stats=False, **kwds):
assert CPUClass is not None
- opt = history.Options(**kwds)
+ self.opt = history.Options(**kwds)
if no_stats:
stats = history.NoStats()
else:
@@ -259,18 +258,18 @@
annhelper = self.annhelper
else:
annhelper = None
- cpu = CPUClass(self.translator.rtyper, self.stats, opt,
+ cpu = CPUClass(self.translator.rtyper, self.stats, self.opt,
translate_support_code, gcdescr=self.gcdescr)
self.cpu = cpu
- self.metainterp_sd = MetaInterpStaticData(self.portal_graph, # xxx
- cpu,
- self.stats, opt,
+
+ def build_meta_interp(self, ProfilerClass):
+ self.metainterp_sd = MetaInterpStaticData(self.cpu,
+ self.opt,
ProfilerClass=ProfilerClass,
warmrunnerdesc=self)
def make_exception_classes(self):
- portalfunc_ARGS = unrolling_iterable(
- [(i, 'arg%d' % i, ARG) for i, ARG in enumerate(self.PORTAL_FUNCTYPE.ARGS)])
+
class DoneWithThisFrameVoid(JitException):
def __str__(self):
return 'DoneWithThisFrameVoid()'
@@ -304,18 +303,19 @@
return 'ExitFrameWithExceptionRef(%s)' % (self.value,)
class ContinueRunningNormally(ContinueRunningNormallyBase):
- def __init__(self, argboxes):
- # accepts boxes as argument, but unpacks them immediately
- # before we raise the exception -- the boxes' values will
- # be modified in a 'finally' by restore_patched_boxes().
- from pypy.jit.metainterp.warmstate import unwrap
- for i, name, ARG in portalfunc_ARGS:
- v = unwrap(ARG, argboxes[i])
- setattr(self, name, v)
-
+ def __init__(self, gi, gr, gf, ri, rr, rf):
+ # the six arguments are: lists of green ints, greens refs,
+ # green floats, red ints, red refs, and red floats.
+ self.green_int = gi
+ self.green_ref = gr
+ self.green_float = gf
+ self.red_int = ri
+ self.red_ref = rr
+ self.red_float = rf
def __str__(self):
- return 'ContinueRunningNormally(%s)' % (
- ', '.join(map(str, self.args)),)
+ return 'ContinueRunningNormally(%s, %s, %s, %s, %s, %s)' % (
+ self.green_int, self.green_ref, self.green_float,
+ self.red_int, self.red_ref, self.red_float)
self.DoneWithThisFrameVoid = DoneWithThisFrameVoid
self.DoneWithThisFrameInt = DoneWithThisFrameInt
@@ -411,17 +411,10 @@
def make_args_specification(self):
graph, block, index = self.jit_merge_point_pos
op = block.operations[index]
- args = op.args[2:]
- ALLARGS = []
- self.green_args_spec = []
- self.red_args_types = []
- for i, v in enumerate(args):
- TYPE = v.concretetype
- ALLARGS.append(TYPE)
- if i < len(self.jitdriver.greens):
- self.green_args_spec.append(TYPE)
- else:
- self.red_args_types.append(history.getkind(TYPE))
+ greens_v, reds_v = support.decode_hp_hint_args(op)
+ ALLARGS = [v.concretetype for v in (greens_v + reds_v)]
+ self.green_args_spec = [v.concretetype for v in greens_v]
+ self.red_args_types = [history.getkind(v.concretetype) for v in reds_v]
self.num_green_args = len(self.green_args_spec)
RESTYPE = graph.getreturnvar().concretetype
(self.JIT_ENTER_FUNCTYPE,
@@ -443,7 +436,7 @@
continue
op = block.operations[index]
- greens_v, reds_v = decode_hp_hint_args(op)
+ greens_v, reds_v = support.decode_hp_hint_args(op)
args_v = greens_v + reds_v
vlist = [Constant(jit_enter_fnptr, FUNCPTR)] + args_v
@@ -500,13 +493,24 @@
# ____________________________________________________________
# Prepare the portal_runner() helper
#
+ from pypy.jit.metainterp.warmstate import specialize_value
portal_ptr = self.cpu.ts.functionptr(PORTALFUNC, 'portal',
graph = portalgraph)
self.portal_ptr = portal_ptr
- portalfunc_ARGS = unrolling_iterable(
- [(i, 'arg%d' % i, ARG) for i, ARG in enumerate(PORTALFUNC.ARGS)])
-
-
+ #
+ portalfunc_ARGS = []
+ nums = {}
+ for i, ARG in enumerate(PORTALFUNC.ARGS):
+ if i < len(self.jitdriver.greens):
+ color = 'green'
+ else:
+ color = 'red'
+ attrname = '%s_%s' % (color, history.getkind(ARG))
+ count = nums.get(attrname, 0)
+ nums[attrname] = count + 1
+ portalfunc_ARGS.append((ARG, attrname, count))
+ portalfunc_ARGS = unrolling_iterable(portalfunc_ARGS)
+ #
rtyper = self.translator.rtyper
RESULT = PORTALFUNC.RESULT
result_kind = history.getkind(RESULT)
@@ -520,21 +524,22 @@
portal_ptr)(*args)
except self.ContinueRunningNormally, e:
args = ()
- for _, name, _ in portalfunc_ARGS:
- v = getattr(e, name)
- args = args + (v,)
+ for ARGTYPE, attrname, count in portalfunc_ARGS:
+ x = getattr(e, attrname)[count]
+ x = specialize_value(ARGTYPE, x)
+ args = args + (x,)
except self.DoneWithThisFrameVoid:
assert result_kind == 'void'
return
except self.DoneWithThisFrameInt, e:
assert result_kind == 'int'
- return lltype.cast_primitive(RESULT, e.result)
+ return specialize_value(RESULT, e.result)
except self.DoneWithThisFrameRef, e:
assert result_kind == 'ref'
- return ts.cast_from_ref(RESULT, e.result)
+ return specialize_value(RESULT, e.result)
except self.DoneWithThisFrameFloat, e:
assert result_kind == 'float'
- return e.result
+ return specialize_value(RESULT, e.result)
except self.ExitFrameWithExceptionRef, e:
value = ts.cast_to_baseclass(e.value)
if not we_are_translated():
@@ -550,8 +555,9 @@
self.PTR_PORTAL_FUNCTYPE.TO,
self.PTR_PORTAL_FUNCTYPE.TO.ARGS,
self.PTR_PORTAL_FUNCTYPE.TO.RESULT)
+ self.codewriter.setup_portal_runner_ptr(self.portal_runner_ptr)
- vinfo = self.metainterp_sd.virtualizable_info
+ vinfo = self.virtualizable_info
def assembler_call_helper(failindex, virtualizableref):
fail_descr = self.cpu.get_fail_descr_from_number(failindex)
@@ -565,22 +571,23 @@
fail_descr = self.cpu.execute_token(loop_token)
except self.ContinueRunningNormally, e:
args = ()
- for _, name, _ in portalfunc_ARGS:
- v = getattr(e, name)
- args = args + (v,)
+ for ARGTYPE, attrname, count in portalfunc_ARGS:
+ x = getattr(e, attrname)[count]
+ x = specialize_value(ARGTYPE, x)
+ args = args + (x,)
return ll_portal_runner(*args)
except self.DoneWithThisFrameVoid:
assert result_kind == 'void'
return
except self.DoneWithThisFrameInt, e:
assert result_kind == 'int'
- return lltype.cast_primitive(RESULT, e.result)
+ return specialize_value(RESULT, e.result)
except self.DoneWithThisFrameRef, e:
assert result_kind == 'ref'
- return ts.cast_from_ref(RESULT, e.result)
+ return specialize_value(RESULT, e.result)
except self.DoneWithThisFrameFloat, e:
assert result_kind == 'float'
- return e.result
+ return specialize_value(RESULT, e.result)
except self.ExitFrameWithExceptionRef, e:
value = ts.cast_to_baseclass(e.value)
if not we_are_translated():
@@ -607,7 +614,7 @@
op = origblock.operations[origindex]
assert op.opname == 'jit_marker'
assert op.args[0].value == 'jit_merge_point'
- greens_v, reds_v = decode_hp_hint_args(op)
+ greens_v, reds_v = support.decode_hp_hint_args(op)
vlist = [Constant(self.portal_runner_ptr, self.PTR_PORTAL_FUNCTYPE)]
vlist += greens_v
vlist += reds_v
@@ -651,22 +658,8 @@
op.opname = 'direct_call'
op.args[:3] = [closures[funcname]]
- def rewrite_force_virtual(self):
+ def rewrite_force_virtual(self, vrefinfo):
if self.cpu.ts.name != 'lltype':
py.test.skip("rewrite_force_virtual: port it to ootype")
all_graphs = self.translator.graphs
- vrefinfo = self.metainterp_sd.virtualref_info
vrefinfo.replace_force_virtual_with_call(all_graphs)
-
-
-def decode_hp_hint_args(op):
- # Returns (list-of-green-vars, list-of-red-vars) without Voids.
- assert op.opname == 'jit_marker'
- jitdriver = op.args[1].value
- numgreens = len(jitdriver.greens)
- numreds = len(jitdriver.reds)
- greens_v = op.args[2:2+numgreens]
- reds_v = op.args[2+numgreens:]
- assert len(reds_v) == numreds
- return ([v for v in greens_v if v.concretetype is not lltype.Void],
- [v for v in reds_v if v.concretetype is not lltype.Void])
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/warmstate.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/warmstate.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/metainterp/warmstate.py Tue Jun 8 19:48:40 2010
@@ -11,11 +11,26 @@
from pypy.rlib.jit import DEBUG_PROFILE
from pypy.rlib.jit import BaseJitCell
from pypy.rlib.debug import debug_start, debug_stop, debug_print
-from pypy.jit.metainterp import support, history
+from pypy.jit.metainterp import history
+from pypy.jit.codewriter import support, heaptracker
# ____________________________________________________________
@specialize.arg(0)
+def specialize_value(TYPE, x):
+ """'x' must be a Signed, a GCREF or a Float.
+ This function casts it to a more specialized type, like Char or Ptr(..).
+ """
+ INPUT = lltype.typeOf(x)
+ if INPUT is lltype.Signed:
+ return lltype.cast_primitive(TYPE, x) # XXX missing: Ptr(non-gc)
+ elif INPUT is lltype.Float:
+ assert TYPE is lltype.Float
+ return x
+ else:
+ return lltype.cast_opaque_ptr(TYPE, x)
+
+ at specialize.arg(0)
def unwrap(TYPE, box):
if TYPE is lltype.Void:
return None
@@ -39,7 +54,7 @@
return history.BoxPtr(value)
else:
adr = llmemory.cast_ptr_to_adr(value)
- value = cpu.cast_adr_to_int(adr)
+ value = heaptracker.adr2int(adr)
# fall through to the end of the function
elif isinstance(lltype.typeOf(value), ootype.OOType):
value = ootype.cast_to_object(value)
@@ -180,7 +195,7 @@
return self.maybe_compile_and_run
metainterp_sd = self.warmrunnerdesc.metainterp_sd
- vinfo = metainterp_sd.virtualizable_info
+ vinfo = self.warmrunnerdesc.virtualizable_info
num_green_args = self.warmrunnerdesc.num_green_args
get_jitcell = self.make_jitcell_getter()
set_future_values = self.make_set_future_values()
@@ -401,7 +416,7 @@
warmrunnerdesc = self.warmrunnerdesc
cpu = warmrunnerdesc.cpu
- vinfo = warmrunnerdesc.metainterp_sd.virtualizable_info
+ vinfo = warmrunnerdesc.virtualizable_info
red_args_types = unrolling_iterable(warmrunnerdesc.red_args_types)
#
def set_future_values(*redargs):
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/tl/spli/interpreter.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/tl/spli/interpreter.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/tl/spli/interpreter.py Tue Jun 8 19:48:40 2010
@@ -24,7 +24,7 @@
unrolling_compare_dispatch_table = unrolling_iterable(
enumerate(compare_ops))
-jitdriver = JitDriver(greens = ['code', 'instr_index'],
+jitdriver = JitDriver(greens = ['instr_index', 'code'],
reds = ['frame'],
virtualizables = ['frame'])
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tl.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tl.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tl.py Tue Jun 8 19:48:40 2010
@@ -56,7 +56,7 @@
def make_interp(supports_call):
myjitdriver = JitDriver(greens = ['pc', 'code'],
- reds = ['stack', 'inputarg'],
+ reds = ['inputarg', 'stack'],
virtualizables = ['stack'])
def interp(code='', pc=0, inputarg=0):
if not isinstance(code,str):
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tla/tla.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tla/tla.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tla/tla.py Tue Jun 8 19:48:40 2010
@@ -71,10 +71,10 @@
# ____________________________________________________________
-def get_printable_location(bytecode, pc):
+def get_printable_location(pc, bytecode):
return str(pc)
-jitdriver = JitDriver(greens=['bytecode', 'pc'],
+jitdriver = JitDriver(greens=['pc', 'bytecode'],
reds=['self'],
virtualizables=['self'],
get_printable_location=get_printable_location)
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tlc.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tlc.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tlc.py Tue Jun 8 19:48:40 2010
@@ -226,7 +226,7 @@
def make_interp(supports_call, jitted=True):
- myjitdriver = JitDriver(greens = ['code', 'pc'],
+ myjitdriver = JitDriver(greens = ['pc', 'code'],
reds = ['frame', 'pool'])
def interp(code='', pc=0, inputarg=0, pool=None):
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tlr.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tlr.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/tl/tlr.py Tue Jun 8 19:48:40 2010
@@ -12,7 +12,7 @@
NEG_A = 8
class TLRJitDriver(JitDriver):
- greens = ['bytecode', 'pc']
+ greens = ['pc', 'bytecode']
reds = ['a', 'regs']
tlrjitdriver = TLRJitDriver()
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/tool/jitoutput.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/tool/jitoutput.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/tool/jitoutput.py Tue Jun 8 19:48:40 2010
@@ -21,8 +21,6 @@
(('recorded_ops.calls',), '^\s+calls:\s+(\d+)$'),
(('recorded_ops.pure_calls',), '^\s+pure calls:\s+(\d+)$'),
(('guards',), '^guards:\s+(\d+)$'),
- (('blackholed_ops.total',), '^blackholed ops:\s+(\d+)$'),
- (('blackholed_ops.pure_calls',), '^\s+pure calls:\s+(\d+)$'),
(('opt_ops',), '^opt ops:\s+(\d+)$'),
(('opt_guards',), '^opt guards:\s+(\d+)$'),
(('forcings',), '^forcings:\s+(\d+)$'),
@@ -62,7 +60,6 @@
def __init__(self):
self.ops = Ops()
self.recorded_ops = Ops()
- self.blackholed_ops = Ops()
self.abort = Aborts()
def parse_prof(output):
Modified: pypy/branch/blackhole-improvement-merge/pypy/jit/tool/test/test_jitoutput.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/jit/tool/test/test_jitoutput.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/jit/tool/test/test_jitoutput.py Tue Jun 8 19:48:40 2010
@@ -41,8 +41,6 @@
assert info.recorded_ops.calls == 0
assert info.recorded_ops.pure_calls == 0
assert info.guards == 1
- assert info.blackholed_ops.total == 0
- assert info.blackholed_ops.pure_calls == 0
assert info.opt_ops == 6
assert info.opt_guards == 1
assert info.forcings == 0
@@ -59,8 +57,6 @@
calls: 3
pure calls: 2
guards: 1
-blackholed ops: 5
- pure calls: 3
opt ops: 6
opt guards: 1
forcings: 1
@@ -87,8 +83,6 @@
assert info.recorded_ops.calls == 3
assert info.recorded_ops.pure_calls == 2
assert info.guards == 1
- assert info.blackholed_ops.total == 5
- assert info.blackholed_ops.pure_calls == 3
assert info.opt_ops == 6
assert info.opt_guards == 1
assert info.forcings == 1
Modified: pypy/branch/blackhole-improvement-merge/pypy/module/pypyjit/policy.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/module/pypyjit/policy.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/module/pypyjit/policy.py Tue Jun 8 19:48:40 2010
@@ -1,4 +1,4 @@
-from pypy.jit.metainterp.policy import JitPolicy
+from pypy.jit.codewriter.policy import JitPolicy
class PyPyJitPolicy(JitPolicy):
Modified: pypy/branch/blackhole-improvement-merge/pypy/module/pypyjit/test/test_pypy_c.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/module/pypyjit/test/test_pypy_c.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/module/pypyjit/test/test_pypy_c.py Tue Jun 8 19:48:40 2010
@@ -222,7 +222,7 @@
while i < n+OFFSET:
i = f(f(i))
return i
- ''', 96,
+ ''', 98,
([20], 20),
([31], 32))
ops = self.get_by_bytecode("LOAD_GLOBAL")
@@ -263,7 +263,7 @@
x = a.f(i)
i = a.f(x)
return i
- ''', 92,
+ ''', 93,
([20], 20),
([31], 32))
ops = self.get_by_bytecode("LOOKUP_METHOD")
@@ -308,7 +308,7 @@
x = a.f(i)
i = a.g(x)
return i
- ''', 105,
+ ''', 106,
([20], 20),
([31], 31))
ops = self.get_by_bytecode("LOOKUP_METHOD")
Modified: pypy/branch/blackhole-improvement-merge/pypy/objspace/flow/model.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/objspace/flow/model.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/objspace/flow/model.py Tue Jun 8 19:48:40 2010
@@ -416,13 +416,14 @@
lst.append(link)
return result
-def copygraph(graph, shallow=False, varmap={}):
+def copygraph(graph, shallow=False, varmap={}, shallowvars=False):
"Make a copy of a flow graph."
blockmap = {}
varmap = varmap.copy()
+ shallowvars = shallowvars or shallow
def copyvar(v):
- if shallow:
+ if shallowvars:
return v
try:
return varmap[v]
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/llinterp.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/llinterp.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/llinterp.py Tue Jun 8 19:48:40 2010
@@ -111,16 +111,14 @@
self.traceback_frames = []
lines = []
for frame in frames:
- logline = frame.graph.name
+ logline = frame.graph.name + "()"
if frame.curr_block is None:
logline += " <not running yet>"
lines.append(logline)
continue
try:
- logline += " " + self.typer.annotator.annotated[frame.curr_block].__module__
- except (KeyError, AttributeError):
- # if the graph is from the GC it was not produced by the same
- # translator :-(
+ logline += " " + self.typer.annotator.annotated[frame.curr_block].func.__module__
+ except (KeyError, AttributeError, TypeError):
logline += " <unknown module>"
lines.append(logline)
for i, operation in enumerate(frame.curr_block.operations):
@@ -808,9 +806,9 @@
checkptr(ptr)
return llmemory.cast_ptr_to_adr(ptr)
- def op_cast_adr_to_int(self, adr):
+ def op_cast_adr_to_int(self, adr, mode):
checkadr(adr)
- return llmemory.cast_adr_to_int(adr)
+ return llmemory.cast_adr_to_int(adr, mode)
def op_weakref_create(self, v_obj):
def objgetter(): # special support for gcwrapper.py
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/ll2ctypes.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/ll2ctypes.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/ll2ctypes.py Tue Jun 8 19:48:40 2010
@@ -505,7 +505,7 @@
# additionally, this adds mess to __del__ "semantics"
_all_callbacks = {}
_all_callbacks_results = []
-_callback2obj = {}
+_int2obj = {}
_callback_exc_info = None
def get_rtyper():
@@ -522,6 +522,13 @@
"""
if isinstance(llobj, lltype._uninitialized):
return uninitialized2ctypes(llobj.TYPE)
+ if isinstance(llobj, llmemory.AddressAsInt):
+ cobj = ctypes.cast(lltype2ctypes(llobj.adr), ctypes.c_void_p)
+ res = intmask(cobj.value)
+ _int2obj[res] = llobj.adr.ptr._obj
+ return res
+ if isinstance(llobj, llmemory.fakeaddress):
+ llobj = llobj.ptr or 0
T = lltype.typeOf(llobj)
@@ -614,8 +621,9 @@
else:
ctypes_func_type = get_ctypes_type(T)
res = ctypes_func_type(callback)
- _callback2obj[ctypes.cast(res, ctypes.c_void_p).value] = container
_all_callbacks[key] = res
+ key2 = intmask(ctypes.cast(res, ctypes.c_void_p).value)
+ _int2obj[key2] = container
return res
index = 0
@@ -724,9 +732,9 @@
container = _array_of_known_length(T.TO)
container._storage = cobj.contents
elif isinstance(T.TO, lltype.FuncType):
- cobjkey = ctypes.cast(cobj, ctypes.c_void_p).value
- if cobjkey in _callback2obj:
- container = _callback2obj[cobjkey]
+ cobjkey = intmask(ctypes.cast(cobj, ctypes.c_void_p).value)
+ if cobjkey in _int2obj:
+ container = _int2obj[cobjkey]
else:
_callable = get_ctypes_trampoline(T.TO, cobj)
return lltype.functionptr(T.TO, getattr(cobj, '__name__', '?'),
@@ -993,6 +1001,8 @@
"""Cast a value to a result type, trying to use the same rules as C."""
if not isinstance(RESTYPE, lltype.LowLevelType):
raise TypeError("rffi.cast() first arg should be a TYPE")
+ if isinstance(value, llmemory.AddressAsInt):
+ value = value.adr
if isinstance(value, llmemory.fakeaddress):
value = value.ptr or 0
TYPE1 = lltype.typeOf(value)
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/llarena.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/llarena.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/llarena.py Tue Jun 8 19:48:40 2010
@@ -223,7 +223,8 @@
else:
return self.arena._getid() < arena._getid()
- def _cast_to_int(self):
+ def _cast_to_int(self, symbolic=False):
+ assert not symbolic
return self.arena._getid() + self.offset
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/llmemory.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/llmemory.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/llmemory.py Tue Jun 8 19:48:40 2010
@@ -7,6 +7,7 @@
import weakref
from pypy.rlib.objectmodel import Symbolic
from pypy.rpython.lltypesystem import lltype
+from pypy.tool.uid import uid
class AddressOffset(Symbolic):
@@ -478,11 +479,14 @@
else:
return lltype.nullptr(EXPECTED_TYPE.TO)
- def _cast_to_int(self):
- # This is a bit annoying. We want this method to still work when the
- # pointed-to object is dead
+ def _cast_to_int(self, symbolic=False):
if self:
- return self.ptr._cast_to_int(False)
+ if symbolic:
+ return AddressAsInt(self)
+ else:
+ # This is a bit annoying. We want this method to still work
+ # when the pointed-to object is dead
+ return self.ptr._cast_to_int(False)
else:
return 0
@@ -496,6 +500,29 @@
# ____________________________________________________________
+class AddressAsInt(Symbolic):
+ # a symbolic, rendered as an address cast to an integer.
+ def __init__(self, adr):
+ self.adr = adr
+ def annotation(self):
+ from pypy.annotation import model
+ return model.SomeInteger()
+ def lltype(self):
+ return lltype.Signed
+ def __eq__(self, other):
+ return self.adr == cast_int_to_adr(other)
+ def __ne__(self, other):
+ return self.adr != cast_int_to_adr(other)
+ def __nonzero__(self):
+ return bool(self.adr)
+ def __repr__(self):
+ try:
+ return '<AddressAsInt %s>' % (self.adr.ptr,)
+ except AttributeError:
+ return '<AddressAsInt at 0x%x>' % (uid(self),)
+
+# ____________________________________________________________
+
class NullAddressError(Exception):
pass
@@ -603,12 +630,31 @@
def cast_adr_to_ptr(adr, EXPECTED_TYPE):
return adr._cast_to_ptr(EXPECTED_TYPE)
-def cast_adr_to_int(adr):
- return adr._cast_to_int()
+def cast_adr_to_int(adr, mode="emulated"):
+ # The following modes are supported before translation (after
+ # translation, it's all just a cast):
+ # * mode="emulated": goes via lltype.cast_ptr_to_int(), which returns some
+ # number based on id(). The difference is that it works even if the
+ # address is that of a dead object.
+ # * mode="symbolic": returns an AddressAsInt instance, which can only be
+ # cast back to an address later.
+ # * mode="forced": uses rffi.cast() to return a real number.
+ assert mode in ("emulated", "symbolic", "forced")
+ res = adr._cast_to_int(symbolic = (mode != "emulated"))
+ if mode == "forced":
+ from pypy.rpython.lltypesystem.rffi import cast
+ res = cast(lltype.Signed, res)
+ return res
_NONGCREF = lltype.Ptr(lltype.OpaqueType('NONGCREF'))
def cast_int_to_adr(int):
- ptr = lltype.cast_int_to_ptr(_NONGCREF, int)
+ if isinstance(int, AddressAsInt):
+ return int.adr
+ try:
+ ptr = lltype.cast_int_to_ptr(_NONGCREF, int)
+ except ValueError:
+ from pypy.rpython.lltypesystem import ll2ctypes
+ ptr = ll2ctypes._int2obj[int]._as_ptr()
return cast_ptr_to_adr(ptr)
# ____________________________________________________________
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/lloperation.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/lloperation.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/lloperation.py Tue Jun 8 19:48:40 2010
@@ -263,7 +263,7 @@
'uint_rshift': LLOp(canfold=True),
'uint_xor': LLOp(canfold=True),
- 'float_is_true': LLOp(canfold=True),
+ 'float_is_true': LLOp(canfold=True), # it really means "x != 0.0"
'float_neg': LLOp(canfold=True),
'float_abs': LLOp(canfold=True),
@@ -410,7 +410,7 @@
'cast_ptr_to_adr': LLOp(sideeffects=False),
'cast_adr_to_ptr': LLOp(canfold=True),
'cast_adr_to_int': LLOp(sideeffects=False),
- 'cast_int_to_adr': LLOp(canfold=True), # not implemented in llinterp
+ 'cast_int_to_adr': LLOp(canfold=True),
'get_group_member': LLOp(canfold=True),
'get_next_group_member':LLOp(canfold=True),
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/lltype.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/lltype.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/lltype.py Tue Jun 8 19:48:40 2010
@@ -301,9 +301,17 @@
class RttiStruct(Struct):
_runtime_type_info = None
+ def _install_extras(self, rtti=False, **kwds):
+ if rtti:
+ self._runtime_type_info = opaqueptr(RuntimeTypeInfo,
+ name=self._name,
+ about=self)._obj
+ Struct._install_extras(self, **kwds)
+
def _attach_runtime_type_info_funcptr(self, funcptr, destrptr):
if self._runtime_type_info is None:
- self._runtime_type_info = opaqueptr(RuntimeTypeInfo, name=self._name, about=self)._obj
+ raise TypeError("attachRuntimeTypeInfo: %r must have been built "
+ "with the rtti=True argument" % (self,))
if funcptr is not None:
T = typeOf(funcptr)
if (not isinstance(T, Ptr) or
@@ -1877,7 +1885,8 @@
def cast_int_to_ptr(PTRTYPE, oddint):
if oddint == 0:
return nullptr(PTRTYPE.TO)
- assert oddint & 1, "only odd integers can be cast back to ptr"
+ if not (oddint & 1):
+ raise ValueError("only odd integers can be cast back to ptr")
return _ptr(PTRTYPE, oddint, solid=True)
def attachRuntimeTypeInfo(GCSTRUCT, funcptr=None, destrptr=None):
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/rclass.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/rclass.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/rclass.py Tue Jun 8 19:48:40 2010
@@ -13,7 +13,7 @@
Ptr, Struct, GcStruct, malloc, \
cast_pointer, cast_ptr_to_int, castable, nullptr, \
RuntimeTypeInfo, getRuntimeTypeInfo, typeOf, \
- Array, Char, Void, attachRuntimeTypeInfo, \
+ Array, Char, Void, \
FuncType, Bool, Signed, functionptr, FuncType, PyObject
from pypy.rpython.lltypesystem import lltype
from pypy.rpython.robject import PyObjRepr, pyobj_repr
@@ -60,7 +60,8 @@
CLASSTYPE = Ptr(OBJECT_VTABLE)
OBJECT = GcStruct('object', ('typeptr', CLASSTYPE),
hints = {'immutable': True, 'shouldntbenull': True,
- 'typeptr': True})
+ 'typeptr': True},
+ rtti = True)
OBJECTPTR = Ptr(OBJECT)
OBJECT_VTABLE.become(Struct('object_vtable',
#('parenttypeptr', CLASSTYPE),
@@ -72,7 +73,7 @@
hints = {'immutable': True}))
# non-gc case
NONGCOBJECT = Struct('nongcobject', ('typeptr', CLASSTYPE))
-NONGCOBJECTPTR = Ptr(OBJECT)
+NONGCOBJECTPTR = Ptr(NONGCOBJECT)
OBJECT_BY_FLAVOR = {'gc': OBJECT,
'raw': NONGCOBJECT}
@@ -348,18 +349,20 @@
if hints is None:
hints = {}
hints = self._check_for_immutable_hints(hints)
+ kwds = {}
+ if self.gcflavor == 'gc':
+ kwds['rtti'] = True
object_type = MkStruct(self.classdef.name,
('super', self.rbase.object_type),
hints=hints,
adtmeths=adtmeths,
- *llfields)
+ *llfields,
+ **kwds)
self.object_type.become(object_type)
allinstancefields.update(self.rbase.allinstancefields)
allinstancefields.update(fields)
self.fields = fields
self.allinstancefields = allinstancefields
- if self.gcflavor == 'gc':
- attachRuntimeTypeInfo(self.object_type)
def _setup_repr_final(self):
AbstractInstanceRepr._setup_repr_final(self)
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/test/test_ll2ctypes.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/test/test_ll2ctypes.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/test/test_ll2ctypes.py Tue Jun 8 19:48:40 2010
@@ -1242,6 +1242,15 @@
res = interpret(f, [])
assert res == 6
+ def test_force_to_int(self):
+ S = lltype.Struct('S')
+ p = lltype.malloc(S, flavor='raw')
+ a = llmemory.cast_ptr_to_adr(p)
+ i = llmemory.cast_adr_to_int(a, "forced")
+ assert type(i) is int
+ assert i == llmemory.cast_adr_to_int(a, "forced")
+ lltype.free(p, flavor='raw')
+
class TestPlatform(object):
def test_lib_on_libpaths(self):
from pypy.translator.platform import platform
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/test/test_llmemory.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/test/test_llmemory.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/test/test_llmemory.py Tue Jun 8 19:48:40 2010
@@ -624,3 +624,24 @@
# the following line crashes if the array is dead
ptr1 = cast_adr_to_ptr(adr, lltype.Ptr(lltype.FixedSizeArray(Address, 1)))
ptr1[0] = NULL
+
+def test_cast_adr_to_int():
+ A = lltype.Array(Address)
+ ptr = lltype.malloc(A, 10, immortal=True)
+ adr = cast_ptr_to_adr(ptr)
+ i = cast_adr_to_int(adr, mode="symbolic")
+ assert isinstance(i, AddressAsInt)
+ assert cast_int_to_adr(i) == adr
+ assert cast_adr_to_int(NULL, mode="symbolic") == 0
+ assert cast_int_to_adr(0) == NULL
+ #
+ i = cast_adr_to_int(adr, mode="emulated")
+ assert type(i) is int
+ i = cast_adr_to_int(NULL, mode="emulated")
+ assert type(i) is int and i == 0
+ #
+ i = cast_adr_to_int(adr, mode="forced")
+ assert type(i) is int
+ #assert cast_int_to_adr(i) == adr -- depends on ll2ctypes details
+ i = cast_adr_to_int(NULL, mode="forced")
+ assert type(i) is int and i == 0
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/test/test_lltype.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/test/test_lltype.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/lltypesystem/test/test_lltype.py Tue Jun 8 19:48:40 2010
@@ -363,22 +363,25 @@
def test_getRuntimeTypeInfo():
S = GcStruct('s', ('x', Signed))
py.test.raises(ValueError, "getRuntimeTypeInfo(S)")
- pinf0 = attachRuntimeTypeInfo(S)
+ S = GcStruct('s', ('x', Signed), rtti=True)
+ pinfx = getRuntimeTypeInfo(S)
+ pinf0 = attachRuntimeTypeInfo(S) # no-op, really
assert pinf0._obj.about == S
+ assert pinf0 == pinfx
pinf = getRuntimeTypeInfo(S)
assert pinf == pinf0
pinf1 = getRuntimeTypeInfo(S)
assert pinf == pinf1
- Z = GcStruct('z', ('x', Unsigned))
- attachRuntimeTypeInfo(Z)
+ Z = GcStruct('z', ('x', Unsigned), rtti=True)
assert getRuntimeTypeInfo(Z) != pinf0
- Sbis = GcStruct('s', ('x', Signed))
- attachRuntimeTypeInfo(Sbis)
+ Sbis = GcStruct('s', ('x', Signed), rtti=True)
assert getRuntimeTypeInfo(Sbis) != pinf0
assert Sbis != S # the attached runtime type info distinguishes them
+ Ster = GcStruct('s', ('x', Signed), rtti=True)
+ assert Sbis != Ster # the attached runtime type info distinguishes them
def test_getRuntimeTypeInfo_destrpointer():
- S = GcStruct('s', ('x', Signed))
+ S = GcStruct('s', ('x', Signed), rtti=True)
def f(s):
s.x = 1
def type_info_S(p):
@@ -399,12 +402,12 @@
assert pinf._obj.query_funcptr == qp
def test_runtime_type_info():
- S = GcStruct('s', ('x', Signed))
+ S = GcStruct('s', ('x', Signed), rtti=True)
attachRuntimeTypeInfo(S)
s = malloc(S)
s.x = 0
assert runtime_type_info(s) == getRuntimeTypeInfo(S)
- S1 = GcStruct('s1', ('sub', S), ('x', Signed))
+ S1 = GcStruct('s1', ('sub', S), ('x', Signed), rtti=True)
attachRuntimeTypeInfo(S1)
s1 = malloc(S1)
s1.sub.x = 0
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/memory/gctransform/test/test_boehm.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/memory/gctransform/test/test_boehm.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/memory/gctransform/test/test_boehm.py Tue Jun 8 19:48:40 2010
@@ -40,7 +40,7 @@
assert f is not None
def test_boehm_finalizer___del__():
- S = lltype.GcStruct("S", ('x', lltype.Signed))
+ S = lltype.GcStruct("S", ('x', lltype.Signed), rtti=True)
def f(s):
s.x = 1
def type_info_S(p):
@@ -58,7 +58,8 @@
assert f is not None
def test_boehm_finalizer_nomix___del___and_pyobj():
- S = lltype.GcStruct("S", ('x', lltype.Signed), ('y', lltype.Ptr(lltype.PyObject)))
+ S = lltype.GcStruct("S", ('x', lltype.Signed),
+ ('y', lltype.Ptr(lltype.PyObject)), rtti=True)
def f(s):
s.x = 1
def type_info_S(p):
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/memory/gctransform/test/test_refcounting.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/memory/gctransform/test/test_refcounting.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/memory/gctransform/test/test_refcounting.py Tue Jun 8 19:48:40 2010
@@ -175,7 +175,7 @@
assert len(ops['gc_free']) == 1
def test_deallocator_with_destructor():
- S = lltype.GcStruct("S", ('x', lltype.Signed))
+ S = lltype.GcStruct("S", ('x', lltype.Signed), rtti=True)
def f(s):
s.x = 1
def type_info_S(p):
@@ -192,9 +192,9 @@
graph, t = make_deallocator(S)
def test_caching_dynamic_deallocator():
- S = lltype.GcStruct("S", ('x', lltype.Signed))
- S1 = lltype.GcStruct("S1", ('s', S), ('y', lltype.Signed))
- T = lltype.GcStruct("T", ('x', lltype.Signed))
+ S = lltype.GcStruct("S", ('x', lltype.Signed), rtti=True)
+ S1 = lltype.GcStruct("S1", ('s', S), ('y', lltype.Signed), rtti=True)
+ T = lltype.GcStruct("T", ('x', lltype.Signed), rtti=True)
def f_S(s):
s.x = 1
def f_S1(s1):
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/memory/test/test_lldict.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/memory/test/test_lldict.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/memory/test/test_lldict.py Tue Jun 8 19:48:40 2010
@@ -100,7 +100,7 @@
_TYPE = llmemory.Address
def __init__(self, intval):
self.intval = intval
- def _cast_to_int(self):
+ def _cast_to_int(self, symbolic="?"):
return self.intval
def __repr__(self):
return '<intaddr 0x%x>' % (self.intval & (sys.maxint*2+1),)
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/raddress.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/raddress.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/raddress.py Tue Jun 8 19:48:40 2010
@@ -7,6 +7,8 @@
from pypy.rpython.rptr import PtrRepr
from pypy.rpython.lltypesystem import lltype
from pypy.rlib.rarithmetic import r_uint
+from pypy.rlib.objectmodel import we_are_translated
+
class __extend__(annmodel.SomeAddress):
def rtyper_makerepr(self, rtyper):
@@ -33,7 +35,7 @@
def ll_str(self, a):
from pypy.rpython.lltypesystem.rstr import ll_str
- id = cast_adr_to_int(a)
+ id = ll_addrhash(a)
return ll_str.ll_int2hex(r_uint(id), True)
def rtype_getattr(self, hop):
@@ -55,7 +57,7 @@
get_ll_fasthash_function = get_ll_hash_function
def ll_addrhash(addr1):
- return cast_adr_to_int(addr1)
+ return cast_adr_to_int(addr1, "forced")
address_repr = AddressRepr()
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/rbuiltin.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/rbuiltin.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/rbuiltin.py Tue Jun 8 19:48:40 2010
@@ -637,9 +637,14 @@
def rtype_cast_adr_to_int(hop):
assert isinstance(hop.args_r[0], raddress.AddressRepr)
- adr, = hop.inputargs(hop.args_r[0])
+ adr = hop.inputarg(hop.args_r[0], arg=0)
+ if len(hop.args_s) == 1:
+ mode = "emulated"
+ else:
+ mode = hop.args_s[1].const
hop.exception_cannot_occur()
- return hop.genop('cast_adr_to_int', [adr],
+ return hop.genop('cast_adr_to_int',
+ [adr, hop.inputconst(lltype.Void, mode)],
resulttype = lltype.Signed)
def rtype_cast_int_to_adr(hop):
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_exception.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_exception.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_exception.py Tue Jun 8 19:48:40 2010
@@ -3,6 +3,7 @@
from pypy.rpython.lltypesystem.lltype import *
from pypy.rpython.test.tool import BaseRtypingTest, LLRtypeMixin, OORtypeMixin
from pypy.rpython.llinterp import LLException
+from pypy.rpython.error import MissingRTypeOperation
class MyException(Exception):
pass
@@ -125,7 +126,18 @@
class TestLLtype(BaseTestException, LLRtypeMixin):
- pass
+ def test_cannot_raise_ll_exception(self):
+ from pypy.rpython.annlowlevel import cast_instance_to_base_ptr
+ def g():
+ e = OverflowError()
+ lle = cast_instance_to_base_ptr(e)
+ raise lle # instead, must cast back from a base ptr to an instance
+ def f():
+ try:
+ g()
+ except OverflowError:
+ return 42
+ py.test.raises(MissingRTypeOperation, self.interpret, f, [])
class TestOOtype(BaseTestException, OORtypeMixin):
pass
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_llann.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_llann.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_llann.py Tue Jun 8 19:48:40 2010
@@ -343,8 +343,7 @@
assert s.items[1].const == 3
def test_getRuntimeTypeInfo(self):
- S = GcStruct('s', ('x', Signed))
- attachRuntimeTypeInfo(S)
+ S = GcStruct('s', ('x', Signed), rtti=True)
def llf():
return getRuntimeTypeInfo(S)
s = self.annotate(llf, [])
@@ -353,8 +352,7 @@
assert s.const == getRuntimeTypeInfo(S)
def test_runtime_type_info(self):
- S = GcStruct('s', ('x', Signed))
- attachRuntimeTypeInfo(S)
+ S = GcStruct('s', ('x', Signed), rtti=True)
def llf(p):
return runtime_type_info(p)
s = self.annotate(llf, [annmodel.SomePtr(Ptr(S))])
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_rdict.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_rdict.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_rdict.py Tue Jun 8 19:48:40 2010
@@ -781,6 +781,24 @@
assert lltype.typeOf(res.item1) == lltype.typeOf(res.item2)
assert lltype.typeOf(res.item1) == lltype.typeOf(res.item3)
+ def test_dict_of_addresses(self):
+ from pypy.rpython.lltypesystem import llmemory
+ TP = lltype.Struct('x')
+ a = lltype.malloc(TP, flavor='raw', immortal=True)
+ b = lltype.malloc(TP, flavor='raw', immortal=True)
+
+ def func(i):
+ d = {}
+ d[llmemory.cast_ptr_to_adr(a)] = 123
+ d[llmemory.cast_ptr_to_adr(b)] = 456
+ if i > 5:
+ key = llmemory.cast_ptr_to_adr(a)
+ else:
+ key = llmemory.cast_ptr_to_adr(b)
+ return d[key]
+
+ assert self.interpret(func, [3]) == 456
+
def test_prebuilt_list_of_addresses(self):
from pypy.rpython.lltypesystem import llmemory
Modified: pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_rptr.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_rptr.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/rpython/test/test_rptr.py Tue Jun 8 19:48:40 2010
@@ -36,8 +36,7 @@
assert s.ll_ptrtype == PS2
def test_runtime_type_info():
- S = GcStruct('s', ('x', Signed))
- attachRuntimeTypeInfo(S)
+ S = GcStruct('s', ('x', Signed), rtti=True)
def ll_example(p):
return (runtime_type_info(p),
runtime_type_info(p) == getRuntimeTypeInfo(S))
@@ -176,6 +175,31 @@
res = interpret(fn, [5])
assert res is True
+def test_cast_adr_to_int():
+ S = Struct('S')
+ p = malloc(S, immortal=True)
+ def fn(n):
+ a = llmemory.cast_ptr_to_adr(p)
+ if n == 2:
+ return llmemory.cast_adr_to_int(a, "emulated")
+ elif n == 4:
+ return llmemory.cast_adr_to_int(a, "symbolic")
+ else:
+ return llmemory.cast_adr_to_int(a, "forced")
+
+ res = interpret(fn, [2])
+ assert type(res) is int
+ assert res == cast_ptr_to_int(p)
+ #
+ res = interpret(fn, [4])
+ assert isinstance(res, llmemory.AddressAsInt)
+ assert llmemory.cast_int_to_adr(res) == llmemory.cast_ptr_to_adr(p)
+ #
+ res = interpret(fn, [6])
+ assert type(res) is int
+ from pypy.rpython.lltypesystem import rffi
+ assert res == rffi.cast(Signed, p)
+
def test_flavored_malloc():
T = GcStruct('T', ('y', Signed))
def fn(n):
Modified: pypy/branch/blackhole-improvement-merge/pypy/translator/c/primitive.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/translator/c/primitive.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/translator/c/primitive.py Tue Jun 8 19:48:40 2010
@@ -7,7 +7,7 @@
from pypy.rpython.lltypesystem.llmemory import Address, \
AddressOffset, ItemOffset, ArrayItemsOffset, FieldOffset, \
CompositeOffset, ArrayLengthOffset, \
- GCHeaderOffset, GCREF
+ GCHeaderOffset, GCREF, AddressAsInt
from pypy.rpython.lltypesystem.llarena import RoundedUpForAllocation
from pypy.translator.c.support import cdecl, barebonearray
@@ -61,6 +61,8 @@
name = name_small_integer(value.lowpart, db)
assert (value.rest & value.MASK) == 0
return '(%s+%dL)' % (name, value.rest)
+ elif isinstance(value, AddressAsInt):
+ return '((long)%s)' % name_address(value.adr, db)
else:
raise Exception("unimplemented symbolic %r"%value)
if value is None:
Modified: pypy/branch/blackhole-improvement-merge/pypy/translator/c/src/address.h
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/translator/c/src/address.h (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/translator/c/src/address.h Tue Jun 8 19:48:40 2010
@@ -16,5 +16,5 @@
#define OP_ADR_LT(x,y,r) r = ((x) < (y))
#define OP_ADR_GE(x,y,r) r = ((x) >= (y))
-#define OP_CAST_ADR_TO_INT(x, r) r = ((long)x)
-#define OP_CAST_INT_TO_ADR(x, r) r = ((void *)(x))
+#define OP_CAST_ADR_TO_INT(x, mode, r) r = ((long)x)
+#define OP_CAST_INT_TO_ADR(x, r) r = ((void *)(x))
Modified: pypy/branch/blackhole-improvement-merge/pypy/translator/c/test/test_genc.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/translator/c/test/test_genc.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/translator/c/test/test_genc.py Tue Jun 8 19:48:40 2010
@@ -144,10 +144,8 @@
assert f1() == '\x00'
def test_runtime_type_info():
- S = GcStruct('s', ('is_actually_s1', Bool))
- S1 = GcStruct('s1', ('sub', S))
- attachRuntimeTypeInfo(S)
- attachRuntimeTypeInfo(S1)
+ S = GcStruct('s', ('is_actually_s1', Bool), rtti=True)
+ S1 = GcStruct('s1', ('sub', S), rtti=True)
def rtti_S(p):
if p.is_actually_s1:
return getRuntimeTypeInfo(S1)
Modified: pypy/branch/blackhole-improvement-merge/pypy/translator/c/test/test_lladdresses.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/translator/c/test/test_lladdresses.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/translator/c/test/test_lladdresses.py Tue Jun 8 19:48:40 2010
@@ -193,3 +193,42 @@
fc = compile(f, [int])
res = fc(42)
assert res == 0
+
+def test_cast_int_to_adr():
+ S = lltype.Struct("S", ("x", lltype.Signed))
+ s = lltype.malloc(S, immortal=True)
+ s.x = 42
+ integer = cast_adr_to_int(cast_ptr_to_adr(s), mode="symbolic")
+ def f(n):
+ if n > 1:
+ i = integer
+ else:
+ i = 123 # nonsense, but never used
+ print "hello world" # prevent constant-folding
+ adr = cast_int_to_adr(i)
+ s = cast_adr_to_ptr(adr, lltype.Ptr(S))
+ return s.x
+ fc = compile(f, [int])
+ res = fc(5)
+ assert res == 42
+
+def test_dict_of_addresses():
+ TP = lltype.Struct('x')
+ a = lltype.malloc(TP, flavor='raw', immortal=True)
+ b = lltype.malloc(TP, flavor='raw', immortal=True)
+
+ def f(i):
+ d = {}
+ d[cast_ptr_to_adr(a)] = 123
+ d[cast_ptr_to_adr(b)] = 456
+ if i > 5:
+ key = cast_ptr_to_adr(a)
+ else:
+ key = cast_ptr_to_adr(b)
+ return d[key]
+
+ fc = compile(f, [int])
+ res = fc(-77)
+ assert res == 456
+ res = fc(77)
+ assert res == 123
Modified: pypy/branch/blackhole-improvement-merge/pypy/translator/c/test/test_refcount.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/translator/c/test/test_refcount.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/translator/c/test/test_refcount.py Tue Jun 8 19:48:40 2010
@@ -130,9 +130,8 @@
def test_del_basic():
for gcpolicy in ["ref"]: #, "framework"]:
- S = lltype.GcStruct('S', ('x', lltype.Signed))
+ S = lltype.GcStruct('S', ('x', lltype.Signed), rtti=True)
TRASH = lltype.GcStruct('TRASH', ('x', lltype.Signed))
- lltype.attachRuntimeTypeInfo(S)
GLOBAL = lltype.Struct('GLOBAL', ('x', lltype.Signed))
glob = lltype.malloc(GLOBAL, immortal=True)
def destructor(s):
Modified: pypy/branch/blackhole-improvement-merge/pypy/translator/tool/make_dot.py
==============================================================================
--- pypy/branch/blackhole-improvement-merge/pypy/translator/tool/make_dot.py (original)
+++ pypy/branch/blackhole-improvement-merge/pypy/translator/tool/make_dot.py Tue Jun 8 19:48:40 2010
@@ -152,7 +152,7 @@
shape = "octagon"
if block.exitswitch is not None:
- lines.append("exitswitch: %s" % block.exitswitch)
+ lines.append("exitswitch: %s" % (block.exitswitch,))
iargs = " ".join(map(repr, block.inputargs))
if self.VERBOSE:
More information about the Pypy-commit
mailing list