[pypy-svn] r76720 - pypy/branch/better-map-instances/pypy/objspace/std

[arigo at codespeak.net]

Author: arigo
Date: Wed Aug 25 11:33:02 2010
New Revision: 76720

Modified:
   pypy/branch/better-map-instances/pypy/objspace/std/mapdict.py
Log:
Mostly add XXXes.


Modified: pypy/branch/better-map-instances/pypy/objspace/std/mapdict.py
==============================================================================
--- pypy/branch/better-map-instances/pypy/objspace/std/mapdict.py	(original)
+++ pypy/branch/better-map-instances/pypy/objspace/std/mapdict.py	Wed Aug 25 11:33:02 2010
@@ -45,6 +45,7 @@
         oldattr = obj._get_mapdict_map()
         oldattr._size_estimate += attr.size_estimate() - oldattr.size_estimate()
         if attr.length() > len(obj._get_mapdict_storage()):
+            # note that attr.size_estimate() is always at least attr.length()
             new_storage = [None] * attr.size_estimate()
             for i in range(len(obj._get_mapdict_storage())):
                 new_storage[i] = obj._get_mapdict_storage()[i]
@@ -200,7 +201,7 @@
 # ____________________________________________________________
 # object implementation
 
-DICT = 6
+DICT = 6     # XXX meant '0'?
 SLOT = 1
 SPECIAL = 2
 
@@ -354,13 +355,13 @@
         return MapDictIteratorImplementation(self.space, self)
 
     def impl_clear(self):
-        raise NotImplementedError("abstract base class")
+        XXX     # implement me!
 
     def _clear_fields(self):
         self.w_obj = None
 
     def _as_rdict(self):
-        r_dict_content = self.initialize_as_rdict()
+        self.initialize_as_rdict()
         space = self.space
         w_obj = self.w_obj
         materialize_r_dict(space, w_obj, self)