[pypy-svn] r69552 - pypy/branch/stringbuilder/pypy/objspace/std

[fijal at codespeak.net]

Author: fijal
Date: Mon Nov 23 14:14:27 2009
New Revision: 69552

Modified:
   pypy/branch/stringbuilder/pypy/objspace/std/stringobject.py
Log:
Revert reusin list, breaks tests. We're safe since unicodejoin is aware
of people changing lists. Semantics of this is messy, but at least consistent
with CPython.


Modified: pypy/branch/stringbuilder/pypy/objspace/std/stringobject.py
==============================================================================
--- pypy/branch/stringbuilder/pypy/objspace/std/stringobject.py	(original)
+++ pypy/branch/stringbuilder/pypy/objspace/std/stringobject.py	Mon Nov 23 14:14:27 2009
@@ -362,7 +362,7 @@
             if not space.is_true(space.isinstance(w_s, space.w_str)):
                 if space.is_true(space.isinstance(w_s, space.w_unicode)):
                     w_u = space.call_function(space.w_unicode, w_self)
-                    return space.call_method(w_u, "join", w_list)
+                    return space.call_method(w_u, "join", space.newlist(list_w))
                 raise OperationError(
                     space.w_TypeError,
                     space.wrap("sequence item %d: expected string, %s "