[pypy-svn] r60900 - in pypy/branch/oo-jit/pypy/translator/c: . src
arigo at codespeak.net
arigo at codespeak.net
Mon Jan 12 11:38:08 CET 2009
Author: arigo
Date: Mon Jan 12 11:38:08 2009
New Revision: 60900
Modified:
pypy/branch/oo-jit/pypy/translator/c/funcgen.py
pypy/branch/oo-jit/pypy/translator/c/src/rtyper.h
pypy/branch/oo-jit/pypy/translator/c/src/support.h
Log:
Fix debug_print of strings, broken now that the RPython strings
are no longer zero-terminated. Requires copying the RPython
strings into a non-movable, zero-terminated buffer.
Modified: pypy/branch/oo-jit/pypy/translator/c/funcgen.py
==============================================================================
--- pypy/branch/oo-jit/pypy/translator/c/funcgen.py (original)
+++ pypy/branch/oo-jit/pypy/translator/c/funcgen.py Mon Jan 12 11:38:08 2009
@@ -714,7 +714,7 @@
format.append(''.join(arg.value.chars).replace('%', '%%'))
else:
format.append('%s')
- argv.append('RPyString_AsString(%s)' % self.expr(arg))
+ argv.append('RPyString_AsCharP(%s)' % self.expr(arg))
continue
elif T == Signed:
format.append('%ld')
@@ -747,7 +747,7 @@
format.append(msg.replace('%', '%%'))
continue
argv.append(self.expr(arg))
- return "fprintf(stderr, %s%s);" % (
+ return "fprintf(stderr, %s%s); RPyString_FreeCache();" % (
c_string_constant(' '.join(format) + '\n\000'),
''.join([', ' + s for s in argv]))
Modified: pypy/branch/oo-jit/pypy/translator/c/src/rtyper.h
==============================================================================
--- pypy/branch/oo-jit/pypy/translator/c/src/rtyper.h (original)
+++ pypy/branch/oo-jit/pypy/translator/c/src/rtyper.h Mon Jan 12 11:38:08 2009
@@ -5,11 +5,12 @@
#define RPyString_Size(rps) ((rps)->rs_chars.length)
-#define RPyString_AsString(rps) ((rps)->rs_chars.items)
/* prototypes */
+char *RPyString_AsCharP(RPyString *rps);
+void RPyString_FreeCache(void);
RPyString *RPyString_FromString(char *buf);
@@ -17,11 +18,39 @@
#ifndef PYPY_NOT_MAIN_FILE
+struct _RPyString_dump_t {
+ struct _RPyString_dump_t *next;
+ char data[1];
+} *_RPyString_dump = NULL;
+
+char *RPyString_AsCharP(RPyString *rps)
+{
+ long len = RPyString_Size(rps);
+ struct _RPyString_dump_t *dump = \
+ malloc(sizeof(struct _RPyString_dump_t) + len);
+ if (!dump)
+ return "(out of memory!)";
+ dump->next = _RPyString_dump;
+ _RPyString_dump = dump;
+ memcpy(dump->data, rps->rs_chars.items, len);
+ dump->data[len] = 0;
+ return dump->data;
+}
+
+void RPyString_FreeCache(void)
+{
+ while (_RPyString_dump) {
+ struct _RPyString_dump_t *dump = _RPyString_dump;
+ _RPyString_dump = dump->next;
+ free(dump);
+ }
+}
+
RPyString *RPyString_FromString(char *buf)
{
int length = strlen(buf);
RPyString *rps = RPyString_New(length);
- memcpy(RPyString_AsString(rps), buf, length);
+ memcpy(rps->rs_chars.items, buf, length);
return rps;
}
Modified: pypy/branch/oo-jit/pypy/translator/c/src/support.h
==============================================================================
--- pypy/branch/oo-jit/pypy/translator/c/src/support.h (original)
+++ pypy/branch/oo-jit/pypy/translator/c/src/support.h Mon Jan 12 11:38:08 2009
@@ -20,12 +20,12 @@
#define FAIL_ZER(msg) FAIL_EXCEPTION(PyExc_ZeroDivisionError, msg)
#define CFAIL() RPyConvertExceptionFromCPython()
-#define PyString_FromRPyString(rpystr) \
- PyString_FromStringAndSize(RPyString_AsString(rpystr), RPyString_Size(rpystr))
+/* #define PyString_FromRPyString(rpystr) \ */
+/* PyString_FromStringAndSize(RPyString_AsString(rpystr), RPyString_Size(rpystr)) */
-#define PyString_ToRPyString(s, rpystr) \
- memcpy(RPyString_AsString(rpystr), PyString_AS_STRING(s), \
- RPyString_Size(rpystr))
+/* #define PyString_ToRPyString(s, rpystr) \ */
+/* memcpy(RPyString_AsString(rpystr), PyString_AS_STRING(s), \ */
+/* RPyString_Size(rpystr)) */
/* Extra checks can be enabled with the RPY_ASSERT or RPY_LL_ASSERT
* macros. They differ in the level at which the tests are made.
More information about the Pypy-commit
mailing list