[pypy-svn] r63557 - pypy/branch/pyjitpl5-simplify/pypy/jit/metainterp

[arigo at codespeak.net]

Author: arigo
Date: Fri Apr  3 11:13:25 2009
New Revision: 63557

Modified:
   pypy/branch/pyjitpl5-simplify/pypy/jit/metainterp/optimize.py
Log:
Add a warning style of comment.


Modified: pypy/branch/pyjitpl5-simplify/pypy/jit/metainterp/optimize.py
==============================================================================
--- pypy/branch/pyjitpl5-simplify/pypy/jit/metainterp/optimize.py	(original)
+++ pypy/branch/pyjitpl5-simplify/pypy/jit/metainterp/optimize.py	Fri Apr  3 11:13:25 2009
@@ -554,6 +554,11 @@
 
         newboxes = [self.nodes[arg].source for arg in op_fail.args]
         op_fail.args = newboxes
+        # NB. we mutate op_fail in-place above.  That's bad.  Hopefully
+        # it does not really matter because no-one is going to look again
+        # at its unoptimized version.  We cannot really clone it because
+        # of how the rest works (e.g. it is returned by
+        # cpu.execute_operations()).
         rebuild_ops.append(op_fail)
         op1 = op.clone()
         op1.suboperations = rebuild_ops