[pypy-svn] rev 1582 - pypy/trunk/src/pypy/translator

[arigo at codespeak.net]

Author: arigo
Date: Sat Oct  4 18:26:55 2003
New Revision: 1582

Modified:
   pypy/trunk/src/pypy/translator/genpyrex.py
Log:
Don't use the 'x.y' syntax in Pyrex if 'y' is not a valid Python identifier


Modified: pypy/trunk/src/pypy/translator/genpyrex.py
==============================================================================
--- pypy/trunk/src/pypy/translator/genpyrex.py	(original)
+++ pypy/trunk/src/pypy/translator/genpyrex.py	Sat Oct  4 18:26:55 2003
@@ -34,6 +34,15 @@
             method = getattr(self, "op_%s" % operator, self.generic_op)
             return method() 
 
+    def ispythonident(self, s):
+        if s[0] not in "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ_":
+            return False
+        for c in s[1:]:
+            if (c not in "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ_"
+                         "0123456789"):
+                return False
+        return True
+
 
     def generic_op(self): 
         """Generic handler for all operators, which I don't handle explicitly"""
@@ -83,7 +92,7 @@
     def op_getattr(self):
         args = self.argnames
         attr = self.op.args[1]
-        if isinstance(attr, Constant):  ###don't we have only the strings here?
+        if isinstance(attr, Constant) and self.ispythonident(attr.value):
             return "%s = %s.%s" % (self.resultname, args[0], attr.value)
         else: 
             return "%s = getattr(%s)" % (self.resultname, ", ".join(args))