[pypy-svn] rev 685 - pypy/trunk/src/pypy/module

lac at codespeak.net lac at codespeak.net
Thu May 29 16:44:55 CEST 2003


Author: lac
Date: Thu May 29 16:44:55 2003
New Revision: 685

Modified:
   pypy/trunk/src/pypy/module/builtin_app.py
Log:
make filter use list comprehensions


Modified: pypy/trunk/src/pypy/module/builtin_app.py
==============================================================================
--- pypy/trunk/src/pypy/module/builtin_app.py	(original)
+++ pypy/trunk/src/pypy/module/builtin_app.py	Thu May 29 16:44:55 2003
@@ -53,15 +53,11 @@
        is True.  If function is None, then return the items in the sequence
        which are True."""
      
-    res = []
     if function is None:
-       for elem in collection:
-           if elem:
-              res.append(elem)
-    else:
-       for elem in collection:
-           if function(elem):
-              res.append(elem)
+        res = [item for item in collection if item]
+    else:
+        res = [item for item in collection if function(item)]
+              
     if type(collection) is tuple:
        return tuple(res)
     elif type(collection) is str:


More information about the Pypy-commit mailing list