[Patches] [ python-Patches-1677694 ] test_timeout refactoring

[SourceForge.net]

Patches item #1677694, was opened at 2007-03-09 19:49
Message generated for change (Settings changed) made by collinwinter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1677694&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Björn Lindqvist (sonderblade)
Assigned to: Nobody/Anonymous (nobody)
Summary: test_timeout refactoring

Initial Comment:
Please see #728815. https://sourceforge.net/tracker/index.php?func=detail&aid=728815&group_id=5470&atid=305470

----------------------------------------------------------------------

Comment By: Björn Lindqvist (sonderblade)
Date: 2007-03-10 09:39

Message:
Logged In: YES 
user_id=51702
Originator: YES

But the bugfix is so simple. :) The original author Dmitry Vasiliev
claimed that connecting to www.google.com with port 80 did not always work
for him because of a transparent proxy. I believe what he meant was that
connection was not guaranteed to timeout. So he changed the port to 21
which www.google.com does not respond to.

----------------------------------------------------------------------

Comment By: Collin Winter (collinwinter)
Date: 2007-03-09 22:39

Message:
Logged In: YES 
user_id=1344176
Originator: NO

In a comment on patch #728815, you (Bjorn) said, "[p]lus, (I think) it
fixes a bug which (I think) only happens when you access the internet from
behind a web proxy." Could you split any bug fixes into a patch separate
from the code cleanup and refactoring? That will make reviewing it/them
easier.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1677694&group_id=5470