[Patches] [ python-Patches-1676994 ] Refactor test_popen2.py to use unittest.

[SourceForge.net]

Patches item #1676994, was opened at 2007-03-09 01:38
Message generated for change (Comment added) made by collinwinter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1676994&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Tests
Group: Python 2.6
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Jerry Seutter (jseutter)
Assigned to: Collin Winter (collinwinter)
Summary: Refactor test_popen2.py to use unittest.

Initial Comment:
This patch turns test_popen2.py into a unittest file.  There should be no changes in what the file tests.

Modifying test_popen2.py to use unittest also required making a small change to popen2.py, which also contains some testing code.

Lib/test/output/test_popen2 should be removed when this patch is applied.

----------------------------------------------------------------------

>Comment By: Collin Winter (collinwinter)
Date: 2007-03-16 17:16

Message:
Logged In: YES 
user_id=1344176
Originator: NO

Checked in as r54417. Thanks for the patch!

----------------------------------------------------------------------

Comment By: Jerry Seutter (jseutter)
Date: 2007-03-16 00:53

Message:
Logged In: YES 
user_id=1727609
Originator: YES

patch v2 changes:

verbose = False was a bug.  Removed.

Folded popen2._test() moved into test_popen2 (good idea, btw).  Refactored
some more.


----------------------------------------------------------------------

Comment By: Jerry Seutter (jseutter)
Date: 2007-03-16 00:51

Message:
Logged In: YES 
user_id=1727609
Originator: YES

File Added: refactor_test_popen2.py.patch

----------------------------------------------------------------------

Comment By: Collin Winter (collinwinter)
Date: 2007-03-15 22:46

Message:
Logged In: YES 
user_id=1344176
Originator: NO

Why not fold popen2._test() into test_popen2? Is there a reason for the
"verbose = False" assignment at the top?


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1676994&group_id=5470