[Patches] [ python-Patches-1680959 ] Add tests for pipes module (test_pipes)

[SourceForge.net]

Patches item #1680959, was opened at 2007-03-14 15:48
Message generated for change (Comment added) made by collinwinter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1680959&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: Tests
Group: Python 2.6
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Alan McIntyre (alanmcintyre)
Assigned to: Collin Winter (collinwinter)
Summary: Add tests for pipes module (test_pipes)

Initial Comment:
The attached file contains a patch to:
 - remove the "just import it" test for pipes from test_sundry.py
 - add test_pipes to expected skips on win32 in regrtest.py
 - remove the "small test program and example" from pipes.py (it seems to me this is best put in either tests or docs instead of the module itself)

It also includes a new test_pipes.py module.  At the moment this covers about 86% of the pipes.py code; I'll try to get that higher, but I wanted to throw this out there for initial feedback.

----------------------------------------------------------------------

>Comment By: Collin Winter (collinwinter)
Date: 2007-03-15 22:40

Message:
Logged In: YES 
user_id=1344176
Originator: NO

Thanks for your patch!

Initial comments:

* test_pipes does not conform to PEP 8 (whitespace issues, line length,
etc).
* SVN reports that test_pipes has inconsistent line endings.
* Calling os.path.exists() as a check before os.unlink() creates a race
condition; just catch the exception.
* In the future, please include new files in the patch itself. "svn add"
the file, then "svn diff" will include it when creating the diff.

Please address these issues.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1680959&group_id=5470