[Patches] [ python-Patches-1668482 ] don't use '-' and '_' in mkstemp
SourceForge.net
noreply at sourceforge.net
Thu Mar 8 23:17:48 CET 2007
Patches item #1668482, was opened at 2007-02-25 12:47
Message generated for change (Comment added) made by collinwinter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1668482&group_id=5470
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 2.5
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Arvin Schnell (arvins)
Assigned to: Collin Winter (collinwinter)
Summary: don't use '-' and '_' in mkstemp
Initial Comment:
I suggest to not use '-' and '_' in the filename
generated by mkstemp. Without a prefix you end
up with filename that start with '-' witch are
clumsy to delete in the shell.
glibc's mkstemp also uses only alphanumerical
characters.
----------------------------------------------------------------------
>Comment By: Collin Winter (collinwinter)
Date: 2007-03-08 17:17
Message:
Logged In: YES
user_id=1344176
Originator: NO
Applied as r54232; not backporting.
Thanks for your patch, Arvin!
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2007-03-08 16:48
Message:
Logged In: YES
user_id=21627
Originator: NO
Looks fine, go ahead.
----------------------------------------------------------------------
Comment By: Collin Winter (collinwinter)
Date: 2007-03-08 16:03
Message:
Logged In: YES
user_id=1344176
Originator: NO
Martin, any objections to committing this if only "-" is removed? I'll
take care of the check-in.
----------------------------------------------------------------------
Comment By: Arvin Schnell (arvins)
Date: 2007-02-25 17:44
Message:
Logged In: YES
user_id=698939
Originator: YES
Nothing is wrong with '_'. I just wanted to make it consistent with
glibc.
Both 62**6 and 63**6 are huge numbers so it doesn't really matter.
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2007-02-25 17:03
Message:
Logged In: YES
user_id=21627
Originator: NO
I can see what's wrong with -, but what is the problem with _?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1668482&group_id=5470
More information about the Patches
mailing list