[Patches] [ python-Patches-1674228 ] sq_ass_slice ignored if sq_slice not defined

[SourceForge.net]

Patches item #1674228, was opened at 2007-03-05 17:20
Message generated for change (Comment added) made by gbrandl
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1674228&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core (C code)
Group: Python 2.5
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Žiga Seilnacht (zseil)
Assigned to: Nobody/Anonymous (nobody)
Summary: sq_ass_slice ignored if  sq_slice not defined

Initial Comment:
Function assign_slice in ceval.c is checking for the
presence of type->tp_as_sequence->tp_slice method
instead of type->tp_as_sequence->tp_ass_slice method.

This means that simple slice assignment fails for
classes that have a __setslice__ method, but are
missing a __getslice__ method (see the test in the
patch).

The change shouldn't break any code that worked
before, so I think that it can be safely backported.





----------------------------------------------------------------------

>Comment By: Georg Brandl (gbrandl)
Date: 2007-03-05 22:28

Message:
Logged In: YES 
user_id=849994
Originator: NO

Committed as rev. 54139, 54140 (2.5).


----------------------------------------------------------------------

Comment By: Žiga Seilnacht (zseil)
Date: 2007-03-05 17:22

Message:
Logged In: YES 
user_id=1326842
Originator: YES

File Added: assign_slice_25.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1674228&group_id=5470