[Patches] [ python-Patches-1761803 ] Some fix abount _WIN32_WINNT

SourceForge.net noreply at sourceforge.net
Sat Jul 28 13:43:11 CEST 2007


Patches item #1761803, was opened at 2007-07-27 08:57
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1761803&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core (C code)
Group: Python 2.6
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Hirokazu Yamamoto (ocean-city)
>Assigned to: Mark Hammond (mhammond)
Summary: Some fix abount _WIN32_WINNT

Initial Comment:
http://mail.python.org/pipermail/python-checkins/2007-July/061251.html
Due to r56561 change, VC6 fails to compile Module/posixmodule.c, becaue Crypt API needs _WIN32_WINNT  definition. I'll atach the fix patch.

1. Fix a typo in PC/pyconfig.h.
2. Still compile fails, because Py_BUILD_CORE seems not to be defined on VC6 build system. I greped, and found that it's only defined on VC8(PCBuild8/pythoncore/pythoncore.vcproj). Maybe it's right fix to define Py_BUILD_CORE on all platforms, but I don't know the meaning of this macro, so I simply reverted r55103 change which removed local _WIN32_WINNT definition in Module/posixmodule.c.



----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2007-07-28 13:43

Message:
Logged In: YES 
user_id=21627
Originator: NO

Mark, since this was your checkin: Can you take a look?

If not, please unassign.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1761803&group_id=5470


More information about the Patches mailing list