[Patches] [ python-Patches-1751801 ] Patch for Windows build

[SourceForge.net]

Patches item #1751801, was opened at 2007-07-11 12:51
Message generated for change (Comment added) made by theller
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1751801&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: Python 3000
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Thomas Heller (theller)
Assigned to: Nobody/Anonymous (nobody)
Summary: Patch for Windows build

Initial Comment:
In Modules/_fileio.c, HAVE_FTRUNCATE is undefined for Windows.

----------------------------------------------------------------------

>Comment By: Thomas Heller (theller)
Date: 2007-07-11 14:47

Message:
Logged In: YES 
user_id=11105
Originator: YES

Committed as SVN rev. 56264, after fixing the indentation of the added
lines in config.c.
Note that config.c is indented partly with tabs, partly with spaces
anyway.

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2007-07-11 14:33

Message:
Logged In: YES 
user_id=6380
Originator: NO

Looks fine. Can you check this in yourself?

Nit: I note that the line added for _fileio to PC/config.c is improperly
indented (space/tab issue?).

Note that this will make various tests using f.truncate() fail.  At some
point we need to implement it using the same APIs as were used in the old
file object.

Also, my hope is that eventually we'll have a Windows specific version of
_fileio.c instead of this code, using all-native Windows API calls.  (Any
volunteers?)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1751801&group_id=5470