[Patches] [ python-Patches-1457736 ] patch for building trunk with VC6

Tue Oct 17 17:24:04 CEST 2006

Patches item #1457736, was opened at 2006-03-24 14:40
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1457736&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Windows
Group: Python 2.5
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Hirokazu Yamamoto (ocean-city)
Assigned to: Nobody/Anonymous (nobody)
Summary: patch for building trunk with VC6

Initial Comment:
Hello. I tried to build trunk with VC6, but failed.
The reasons are

 - _W64 is not defined on VC6. (PC/pyconfig.h)

 - intptr_t and uintptr_t are not decleared on VC6.
(should use Py_intptr_t and Py_uintptr_t respectively)

I'll submit the patch for these two issues as
"build_trunk_for_vc6.patch".

And more two issues.

 - zlib was make built into pythoncore, but
PC/VC6/pythoncore.dsp is not updated for it yet.

I'll submit the file itself.

 - long long cannot be used on VC6, so 0xFFFFULL is
failed to compile with "invalid suffix" error.

I workarounded this replaced ULL with UI64 (_int64's
suffix) but I don't know how to make the patch. maybe
can this tequnique be used?

  #define Py_ULL(x) x##ULL /* non VC6 */

  #define Py_ULL(x) x##UI64 /* VC6 */

  Py_ULL(0xFFFFFFFFFFFFFFFF) instead of 0xFFF...FULL

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2006-10-17 17:24

Message:
Logged In: YES 
user_id=21627

Thanks for the patch. Committed as r52356 and r52357.

If you have further modifications to make, please submit
them as a new patch.

----------------------------------------------------------------------

Comment By: Hirokazu Yamamoto (ocean-city)
Date: 2006-10-16 13:44

Message:
Logged In: YES 
user_id=1200846

I updated patch. Addition to previous my comment....

* I believe no need to add header files into dsp files
because VC6 detects header modification and compiles
corresponding cpp files correctly.

* Still I don't know well, changed some compiler/linker
options to follow pythoncore.dsp way. (/o "NUL", /MTd=>/MDd
/ZI=>/Zi, SUBTRACT LINK32 /pdb:none,
ported /base value from PCBuild)

----------------------------------------------------------------------

Comment By: Hirokazu Yamamoto (ocean-city)
Date: 2006-10-15 16:32

Message:
Logged In: YES 
user_id=1200846

I've done rough merge. But I don't understand every
difference between base and working copy, I'll check detail
tomorrow. (Some differences comes from the fact I copied
compiler options from other dsp files. But I don't know this
differences cause something)

This is current summary...

* zlib.dsp: no longer needed so removed.
* _sqlite3.dsp: added.
* _ssl.mak: /DWIN32 and user32.lib advapi32.lib are needed.
* _bsddb.dsp and others: use newer version of external files
like PCBuild.
* bz2.dsp: avoid "Special Build Tool". I experienced error
when built this module from VisualC++6 IDE. Need to build
bzip2-1.0.3 separately.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2006-10-15 14:06

Message:
Logged In: YES 
user_id=21627

Many of these issues have been fixed. Can you please update
the patch again to fix the remaining ones?

----------------------------------------------------------------------

Comment By: Hirokazu Yamamoto (ocean-city)
Date: 2006-07-24 15:02

Message:
Logged In: YES 
user_id=1200846

This supports other packages other than _msi. (I skipped
this package because I don't know how to test it)

test case passed successfully.

----------------------------------------------------------------------

Comment By: Hirokazu Yamamoto (ocean-city)
Date: 2006-05-25 06:33

Message:
Logged In: YES 
user_id=1200846

Thanks to Luke Dunstan, my patch becomes much smaller.

  - Replace *.dsp in PC/VC6 with attached files.

  - Remove PC/VC6/zlib.dsp

  - _sqlite3 and other new packages are not supported

I read core member are not interested in VC6 anymore, so
this is for VC6 guy. I don't want to install VC++2005Express
because it installs .net framework which I don't need. I'm
Java guy. :-)

----------------------------------------------------------------------

Comment By: Hirokazu Yamamoto (ocean-city)
Date: 2006-05-07 07:40

Message:
Logged In: YES 
user_id=1200846

Oops, I forgot to upload the file.

  - Apply x.patch.

  - Replace pythoncore.dsp and pcbuild.dsw in PC/VC6 with
    attached files.

 - Remove PC/VC6/zlib.dsp

----------------------------------------------------------------------

Comment By: Hirokazu Yamamoto (ocean-city)
Date: 2006-05-07 07:37

Message:
Logged In: YES 
user_id=1200846

Hello. I updated the patch. (Probably this is better)

  - defined ULL() macro locally in Modules/sha512module.c
      maybe it's better to declare Py_ULL or something
      globally, but I don't know how to do it.

 - more patch for zlib builtin (ie: PC/VC6/Readme.txt)

I cannot try this patch on VC7 or later, but
I confirmed lib/test/testall.py passed on VC6.

----------------------------------------------------------------------

Comment By: Luke Dunstan (infidel)
Date: 2006-05-06 20:16

Message:
Logged In: YES 
user_id=30442

Is there anything preventing this patch from being 
applied? It would help me with building the trunk using 
both VC6 and Microsoft eMbedded Visual C++ 4.0 (for 
Windows CE).

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2006-03-26 19:02

Message:
Logged In: YES 
user_id=33168

Raymond, maybe this will help get VC6 building?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1457736&group_id=5470