[Patches] [ python-Patches-1351020 ] PythonD DJGPP-specific patch set for porting to DOS.

[SourceForge.net]

Patches item #1351020, was opened at 2005-11-08 09:08
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1351020&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: Python 2.4
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ben Decker (bdeck)
Assigned to: Nobody/Anonymous (nobody)
Summary: PythonD DJGPP-specific patch set for porting to DOS.

Initial Comment:
This is our initial recommendation for PythonD specific 
patch set running in DOS. Build requires at least 
DJGPP 2.04 32-bit DOS compiler (see 
http://www.delorie.com/djgpp/) and Watt-32 tcp/ip stack 
for DJGPP (see http://www.bgnett.no/~giva/). Operates 
under MSDOS, FreeDOS, Win32 and NT. Requires 
DOS mode long filename driver/TSR. See 
http://www.caddit.net/pythond.htm for details 
concerning the PythonD project.

Diffed against 2.4.2 Final distribution.

Diff script used:
#! /usr/bin/bash
for file in `find . -name *.orig -print`
do
  export filename=`echo -n $file | sed -e 's/\.orig$//'`
  diff -c $file $filename >> pythond.diff
done

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2006-11-08 07:32

Message:
Logged In: YES 
user_id=21627

Can you please update the patch to the current subversion trunk?
Please integrate 1351036 also, providing only a single patch.

There are a number of problems with that patch:
- what is the purpose of the site.py changes?
  Some parts (like a plain print statement) certainly have no
  place, other parts (like readline history support)
traditionally
  belong to the user's PYTHONSTARTUP. Integrating them into
Python
  might be an option, but that is independent of the patch.
- please make the C block structure "work" even in presence of
  ifdefs. I.e. when you change the condition of a while loop,
  duplicate the entire while loop (which is just --i in one
case),
  or introduce a macro to compute the condition.
  In several cases of posixmodule.c, introducing IS_SEP might be
  useful.
- remove debugging code, even if commented out
- why do you put the thread module into config.c.in? It's
normally
  included through Setup.config
- Don't use C++ comments

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1351020&group_id=5470