[Patches] [ python-Patches-1445739 ] New with semantics

SourceForge.net noreply at sourceforge.net
Wed Mar 15 08:59:28 CET 2006


Patches item #1445739, was opened at 2006-03-08 07:50
Message generated for change (Comment added) made by nnorwitz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1445739&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core (C code)
Group: Python 2.5
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Guido van Rossum (gvanrossum)
Assigned to: Guido van Rossum (gvanrossum)
Summary: New with semantics

Initial Comment:
Here's a patch that implements the new with statement
semantics: if __exit__ got passed an exception, it is
only swallowed when __exit__ returns *true*.  So it is
no longer necessary for __exit__ handlers to re-raise
the exception.

This is a bit rough still -- existing unit tests have
been adjusted, but there should be additional unit
tests for the new functionality.  Also the re-raise
code in various __exit__ handlers coded in the previous
patch could be removed (note that re-raising doesn't do
any harm -- it's just not necessary).

----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2006-03-14 23:59

Message:
Logged In: YES 
user_id=33168

Guido checked this in a few days ago AFAIK, so closing.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1445739&group_id=5470


More information about the Patches mailing list