[Patches] [ python-Patches-1396093 ] Further .vcproj cleanups

[SourceForge.net]

Patches item #1396093, was opened at 2006-01-03 16:58
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1396093&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: Python 2.5
Status: Open
Resolution: None
Priority: 7
Submitted By: Adal Chiriliuc (adalx)
Assigned to: Martin v. Löwis (loewis)
Summary: Further .vcproj cleanups

Initial Comment:
The #1307806 patch failed to apply completely in
r41897, probably because it was generated for Python
2.4.2 which didn't include the AST files.

I've attached a patch which will complete the cleanup
of pythoncore.vcproj and which also cleans up
_elementtree.vcproj.

Note that there is a bug in the current
pythoncore.vcproj: The BUILD macro is defined as 60, it
should be at least 67 as it was in Python 2.4.2.

I didn't fix this since I don't know what's the correct
BUILD number for Python 2.5 (68?).


----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2006-01-14 19:40

Message:
Logged In: YES 
user_id=21627

This patch is wrong: for expat, it removes HAVE_EXPAT_H,
XML_NS, etc, which are all necessary for expat to be build
correctly.

Also, can you please create the patches through "svn diff"?
Then it is clearer what revision you are diffing against.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2006-01-14 19:19

Message:
Logged In: YES 
user_id=21627

The build number is gone in Python 2.5, so we should just
remove all traces of it; I will do that.

For reference, see PCbuild/BUILDno.txt.

----------------------------------------------------------------------

Comment By: Thomas Heller (theller)
Date: 2006-01-03 17:02

Message:
Logged In: YES 
user_id=11105

The build number is usually set to the correct value shortly
before a binary release.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1396093&group_id=5470