[Patches] [ python-Patches-774221 ] 2.3c1: zipfile.py confused by garbage at the very end of zip

[SourceForge.net]

Patches item #774221, was opened at 2003-07-19 11:00
Message generated for change (Comment added) made by akuchling
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=774221&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nikolai Saoukh (nms)
>Assigned to: A.M. Kuchling (akuchling)
Summary: 2.3c1: zipfile.py confused by garbage at the very end of zip

Initial Comment:
Some zip files can contain garbage past the End of Central Directory. _EndRecData() treat it as comment, thus failing
sanity check for comment length.

----------------------------------------------------------------------

>Comment By: A.M. Kuchling (akuchling)
Date: 2006-12-22 13:25

Message:
Logged In: YES 
user_id=11375
Originator: NO

Under what circumstances do zip files have garbage appended to them?  Are
there buggy zipfile-generating programs out there, or does the garbage come
from, say, an extra newline added when a zipfile is attached to an e-mail?

The patch looks OK, but I'm nervous about adding code to silently ignore
an incorrect zipfile.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=774221&group_id=5470