[Patches] [ python-Patches-1300515 ] xdrlib.py: pack_fstring() did not use null bytes for padding

[SourceForge.net]

Patches item #1300515, was opened at 2005-09-23 11:37
Message generated for change (Comment added) made by birkenfeld
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1300515&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 2.5
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Don Quijote (dq_searchlores)
Assigned to: Nobody/Anonymous (nobody)
Summary: xdrlib.py: pack_fstring() did not use null bytes for padding

Initial Comment:
According to the documentation, null shall be used as
padding byte. But, as the test below shows, instead of
null, additional trailing characters of the original
string are used. This is also wrong according to the
related RFC 1014 (and RFC 1832).

This is tested on Python 2.4.1 (#65, Mar 30 2005,
09:13:57) [MSC v.1310 32 bit (Intel)] on win32

>>> import xdrlib
>>> p = xdrlib.Packer()
>>> p.pack_fstring(2,"abcdef")
>>> p.get_buffer()
'abcd'

I am expecting 'ab\0\0'

This change does not have any impact on unpack_fstring().

The patch is done against the current CVS tree.
The patch does not add nor change any functionality.

----------------------------------------------------------------------

>Comment By: Reinhold Birkenfeld (birkenfeld)
Date: 2005-09-29 22:49

Message:
Logged In: YES 
user_id=1188172

Thanks for the patch, committed in xdrlib.py r1.18, r1.16.4.1

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1300515&group_id=5470