[Patches] [ python-Patches-1110248 ] patch for gzip.GzipFile.flush()
SourceForge.net
noreply at sourceforge.net
Thu Mar 3 09:38:39 CET 2005
Patches item #1110248, was opened at 2005-01-26 22:57
Message generated for change (Comment added) made by loewis
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1110248&group_id=5470
Category: Library (Lib)
Group: Python 2.4
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: David Schnepper (dschnepper)
Assigned to: Nobody/Anonymous (nobody)
Summary: patch for gzip.GzipFile.flush()
Initial Comment:
Ensure the compress buffer is flushed prior to the
file buffer being flushed when gzip.GzipFile.flush()
is invoked.
Patch for bug 1110242
----------------------------------------------------------------------
>Comment By: Martin v. Löwis (loewis)
Date: 2005-03-03 09:38
Message:
Logged In: YES
user_id=21627
Thanks for the patch. I believe it does not fully fix the
bug reported: not all input data are flushed with
Z_SYNC_FLUSH, but only some (up to an output byte boundary
or some such). I also believe that a "complete" fix for the
bug is not possible, as flushing all input data would
require Z_FINISH, and then no more additional data could be
written into the stream.
As this is still an improvement over the current status, I
committed it as
gzip.py 1.43
NEWS 1.1251
----------------------------------------------------------------------
Comment By: Alan McIntyre (ESRG) (alanmcintyre)
Date: 2005-02-27 05:36
Message:
Logged In: YES
user_id=1115903
This patch appears to fix the bug as described, and running
the regression tests on Python 2.5a0 (CVS HEAD) turns up no
problems. Since the documentation says that a GzipFile
"simulates most of the methods of a file object," I would
expect GzipFile.flush() to act in the way that David
described in the first paragraph of the bug report, and his
patch seems to provide that as far as I can tell.
Note: I only ran tests on Python 2.5a0 built with MSVC .NET
on Windows XP.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1110248&group_id=5470
More information about the Patches
mailing list