[Patches] [ python-Patches-1144549 ] cgitb: make more usable for 'binary-only' sw (new patch)

[SourceForge.net]

Patches item #1144549, was opened at 2005-02-19 23:23
Message generated for change (Settings changed) made by birkenfeld
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1144549&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Reinhold Birkenfeld (birkenfeld)
>Assigned to: Reinhold Birkenfeld (birkenfeld)
Summary: cgitb: make more usable for 'binary-only' sw (new patch)

Initial Comment:
see patch #751943:

"""
I am abusing cgitb to show a traceback window for a GUI
application in Qt. In such a case, the source code to
the program is not always available. The stack trace is
anyway useful to be submitted to the developers of the
code. I attach a patch that should add some info to the
HTML traceback made by cgitb in case the source file is
not available.
"""

This new patch, however, does not generate a link to
"file://?" if the filename is not known.

At the same time, it stops shadowing file() by renaming
local vars.

----------------------------------------------------------------------

>Comment By: Reinhold Birkenfeld (birkenfeld)
Date: 2005-06-27 00:00

Message:
Logged In: YES 
user_id=1188172

Fixed the link to file://?/. Did not do the renaming of
variables. (Don't touch working code.)

----------------------------------------------------------------------

Comment By: Reinhold Birkenfeld (birkenfeld)
Date: 2005-04-02 19:13

Message:
Logged In: YES 
user_id=1188172

Deleted first, useless patch.

----------------------------------------------------------------------

Comment By: Reinhold Birkenfeld (birkenfeld)
Date: 2005-02-20 08:17

Message:
Logged In: YES 
user_id=1188172

You're right, the 'or ?' must vanish; see attached second patch.

But I did diff against CVS HEAD, didn't I?

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2005-02-20 03:14

Message:
Logged In: NO 

!             filename = os.path.abspath(filename) or '?'

Why is the 'or ?' still there?

Also, patches are preferred to be against CVS HEAD, rather
than against a previous patched version.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1144549&group_id=5470