[Patches] [ python-Patches-1095362 ] fixes urllib2 digest to allow arbitrary methods

SourceForge.net noreply at sourceforge.net
Sun Jan 9 06:54:21 CET 2005


Patches item #1095362, was opened at 2005-01-04 00:46
Message generated for change (Comment added) made by jlgijsbers
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1095362&group_id=5470

Category: Library (Lib)
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: John Reese (rrttjj)
>Assigned to: Johannes Gijsbers (jlgijsbers)
Summary: fixes urllib2 digest to allow arbitrary methods

Initial Comment:
urllib2.AbstractDigestAuthHandler.get_authorization
always forced the method to be either 'GET' or 'HEAD'
when computing the digest.  This meant that digest auth
for any other method would fail automatically; for
example, DELETE or PUT, for any HTTP servers that
support them, or DAV verbs like PROPFIND.  This single
line change just calls Request.get_method instead of
hardcoding the defaulting logic.

Request.get_method still forces the method to be either
GET or HEAD, but a determined caller can override
Request if they need to use a different method.

----------------------------------------------------------------------

>Comment By: Johannes Gijsbers (jlgijsbers)
Date: 2005-01-09 06:54

Message:
Logged In: YES 
user_id=469548

A very determined caller indeed. I've checked in the patch
on maint24 and HEAD. Less duplication and more flexibility
never hurt anyone, right?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1095362&group_id=5470


More information about the Patches mailing list