[Patches] [ python-Patches-1117398 ] cookielib LWPCookieJar and
MozillaCookieJar exceptions
SourceForge.net
noreply at sourceforge.net
Thu Feb 10 23:25:24 CET 2005
Patches item #1117398, was opened at 2005-02-06 17:39
Message generated for change (Comment added) made by jjlee
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1117398&group_id=5470
Category: Library (Lib)
Group: Python 2.4
Status: Open
Resolution: None
Priority: 5
Submitted By: John J Lee (jjlee)
Assigned to: Nobody/Anonymous (nobody)
Summary: cookielib LWPCookieJar and MozillaCookieJar exceptions
Initial Comment:
cookielib.LWPCookieJar and .MozillaCookieJar are
documented to raise cookielib.LoadError on attempt to
load an invalid cookies file, but do not.
I think this should be backported to the 2.4
maintenance branch.
Reason: I suspect more people will be bitten by the bug
than will be bitten by the patch, since cookies files
will rarely be invalid, so people are likely to have
written except statements based on the docs in this
case, rather than based on the actual exception that
currently occurs.
----------------------------------------------------------------------
>Comment By: John J Lee (jjlee)
Date: 2005-02-10 22:25
Message:
Logged In: YES
user_id=261020
Jim, I don't understand the first sentence in your comment.
Re a 2.4 backport that makes LoadError derive from IOError:
it makes me wince, but I can't think of an argument against it.
No, LoadError should not be a subclass of IOError in the
trunk, because the cases where LoadError is documented to be
raised do not involve failures of I/O, but rather invalid
data. See the docs for IOError. (FWIW, EnvironmentError
(IOError's base class) wouldn't be a suitable subclass
either: eg. what would we want with an .errno attribute?)
----------------------------------------------------------------------
Comment By: Jim Jewett (jimjjewett)
Date: 2005-02-08 16:58
Message:
Logged In: YES
user_id=764593
I often look at the code in a second idle window rather
than starting a web browser.
Would it work to make LoadError a subclass of IOError, at
least for the backport? People who followed the docs will
get a bugfix, but people who followed the code would get
no breakage.
Should LoadError be a subclass of IOError even in the
main trunk?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1117398&group_id=5470
More information about the Patches
mailing list