[Patches] [ python-Patches-1048728 ] Bug fixes and cleanup for decimal.py

[SourceForge.net]

Patches item #1048728, was opened at 2004-10-17 11:33
Message generated for change (Comment added) made by rhettinger
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1048728&group_id=5470

Category: Library (Lib)
Group: Python 2.4
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Neal Norwitz (nnorwitz)
Assigned to: Raymond Hettinger (rhettinger)
Summary: Bug fixes and cleanup for decimal.py

Initial Comment:
Bug fixes:  == was used in 2 places where it looked
like assignment was intended.

-        context._rounding_decision == ALWAYS_ROUND
+        context._rounding_decision = ALWAYS_ROUND

Cleanups: remove unused import and unused local variables.

----------------------------------------------------------------------

>Comment By: Raymond Hettinger (rhettinger)
Date: 2004-10-20 02:00

Message:
Logged In: YES 
user_id=80475

Accepted and applied (with small modifications):
   Lib/decimal.py 1.28

Facundo, rounding is required by the spec when it says that 
the selected value should have the effect of a unary plus.

----------------------------------------------------------------------

Comment By: Facundo Batista (facundobatista)
Date: 2004-10-19 19:57

Message:
Logged In: YES 
user_id=752496

Raymond:

The cleanups are OK.

Regarding changing == for =, didn't find nothing in the Spec
that says that after max() and min() you should *always*
round. So, I'll go for droping the line. But the tests are
OK with and without the assingment (IOW, with == and with
=), which makes me doubt.

I'm assigning this to you because I'm not sure about
commiting after beta.

Thanks!

.    Facundo

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1048728&group_id=5470