[Patches] [ python-Patches-468347 ] mask signals for non-main pthreads

[SourceForge.net]

Patches item #468347, was opened at 2001-10-05 11:58
Message generated for change (Comment added) made by jasonlowe
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=468347&group_id=5470

Category: Modules
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Jason Lowe (jasonlowe)
Assigned to: Guido van Rossum (gvanrossum)
Summary: mask signals for non-main pthreads

Initial Comment:
This patch updates Python/thread_pthread.h to mask all
signals for any thread created.  This will keep all
signals masked for any thread that isn't the initial
thread.  For Solaris and Linux, the two platforms I was
able to test it on, it solves bug #465673 (pthreads
need signal protection) and probably will solve bug
#219772 (Interactive InterPreter+ Thread -> core dump
at exit).

I'd be great if this could get some testing on other
platforms, especially HP-UX pre 11.00 and post 11.00,
as I had to make some guesses for the DCE thread case.
AIX is also a concern as I saw some mention of using
sigthreadmask() as a pthread_sigmask() equivalent, but
this patch doesn't use sigthreadmask().  I don't have
access to AIX.

Note that thread_pthread.h.orig in this patch is the
unmodified version from the Python2.1 release.



----------------------------------------------------------------------

>Comment By: Jason Lowe (jasonlowe)
Date: 2004-05-11 14:59

Message:
Logged In: YES 
user_id=56897

I agree, the patch is very problematic, especially for
synchronous signals like SIGSEGV.  I've added more details
to the discussion in bug 756924.

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2004-05-11 09:01

Message:
Logged In: YES 
user_id=6380

This patch has caused more problems than it solves, IMO! 
Have a look at bug 756924:

http://sourceforge.net/tracker/index.php?func=detail&aid=756924&group_id=5470&atid=105470

Jason, if you're still around, would you mind looking into
an alternative fix for 465673 as suggested there?

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2001-10-12 16:49

Message:
Logged In: YES 
user_id=6380

As you said, the patch was out of date. Normally that would
be enough to ask you to resubmit it relative to the current
CVS, but it was too easy.

I've checked this in as thread_pthread.h rev 2.33 now, so
that it gets maximal exposure when the 2.2b1 release goes
out next week.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=468347&group_id=5470