[Patches] [ python-Patches-966493 ] Cleanup generator/eval_frame exposure

SourceForge.net noreply at sourceforge.net
Sun Jun 27 11:43:39 EDT 2004


Patches item #966493, was opened at 2004-06-04 14:58
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=966493&group_id=5470

Category: Core (C code)
Group: Python 2.4
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: James William Pye (jwpye)
Assigned to: Martin v. Löwis (loewis)
Summary: Cleanup generator/eval_frame exposure

Initial Comment:
Hopefully get this cleanup in before 2.4..

. Include genobject.h in Python.h to save embedders an
AC check to identify its existance(allowing a simple
#ifndef Py_GENOBJECT_H)
. Follow up my own recommendation to just reference
eval_frame directly by exposing it(change references in
ceval.c and genobject.c accordingly).
. Update headers accordingly; reference frameobject in
genobject.h and ceval.h as struct _frame * like others
do to avoid including frameobject.h

Rename PyEval_EvaluateFrame to PyEval_EvalFrame to be
consistent with PyEval_EvalCode[Ex] in eval.h.

Hopefully it isnt too late to change this before 2.4,
sorry for not having it in the first patch.. :-(

Changes files:

genobject.c
genobject.h
ceval.c
ceval.h
Python.h

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2004-06-27 17:43

Message:
Logged In: YES 
user_id=21627

Thanks for the patch. Committed as

Python.h 2.64
ceval.h 2.52
genobject.h 2.2
genobject.c 1.3
ceval.c 2.407


----------------------------------------------------------------------

Comment By: Raymond Hettinger (rhettinger)
Date: 2004-06-15 13:33

Message:
Logged In: YES 
user_id=80475

Martin, I believe this patches your checkin.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=966493&group_id=5470



More information about the Patches mailing list