[Patches] [ python-Patches-963318 ] New module cookielib
SourceForge.net
noreply at sourceforge.net
Tue Jun 1 00:38:13 EDT 2004
Patches item #963318, was opened at 2004-05-31 01:39
Message generated for change (Comment added) made by loewis
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=963318&group_id=5470
Category: Library (Lib)
Group: Python 2.4
>Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: John J Lee (jjlee)
Assigned to: Nobody/Anonymous (nobody)
Summary: New module cookielib
Initial Comment:
cookielib itself is here:
http://codespeak.net/svn/user/jjlee/wwwsearch/ClientCookie/branch/python-2.4_candidate/
All I'm uploading here are patches to the various other
files in Python that are affected.
Remaining issues:
-The .unverifiable and .origin_req_host attributes I've
added to urllib2.Request are a bit ugly (yet another
bit of HTTP-specific state). But I guess it's too late
to start having subclasses for specific protocol schemes.
-Implementation wart: ._now attributes.
-test_urllib2.py depends on test_cookielib.py. What's
the right way to fix this?
-Thread synchronization needs checking by someone with
more of a clue about this: I have great confidence that
it IS currently broken, since I've never tested it.
-Update magic string in LWPCookieJar, if Gisle agrees
(I'm waiting for a reply).
----------------------------------------------------------------------
>Comment By: Martin v. Löwis (loewis)
Date: 2004-06-01 06:38
Message:
Logged In: YES
user_id=21627
Thanks, committed as 1.2. Please create new patches in the
future if you wish to make further changes. If you find they
get no attention, give them priority 6 and assign them to me.
----------------------------------------------------------------------
Comment By: John J Lee (jjlee)
Date: 2004-06-01 01:21
Message:
Logged In: YES
user_id=261020
Here's a fix for the noisy unit tests.
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2004-05-31 20:23
Message:
Logged In: YES
user_id=21627
Thanks for the patch. Applied as
lib.tex 1.226
libcookie.tex 1.12
libcookielib.tex 1.1
liburllib2.tex 1.18
whatsnew24.tex 1.49
_LWPCookieJar.py 1.1
_MozillaCookieJar.py 1.1
cookielib.py 1.1
urllib2.py 1.67
test_cookielib.py 1.1
test_urllib2.py 1.13
NEWS 1.978
----------------------------------------------------------------------
Comment By: John J Lee (jjlee)
Date: 2004-05-31 19:09
Message:
Logged In: YES
user_id=261020
OK, done.
----------------------------------------------------------------------
Comment By: John J Lee (jjlee)
Date: 2004-05-31 16:20
Message:
Logged In: YES
user_id=261020
Martin, in case you are just about to apply this: I've
finally stopped dithering about the first 'remaining issue'
above (unverifiable and origin_req_host), and am just about
to update liburllib2.tex.patch, urllib2.py.patch and
test_urllib2.py.patch (and cookielib itself).
----------------------------------------------------------------------
Comment By: John J Lee (jjlee)
Date: 2004-05-31 13:07
Message:
Logged In: YES
user_id=261020
The files that should be copied from the subversion
repository are:
_LWPCookieJar.py
_MozillaCookieJar.py
cookielib.py
test/test_cookielib.py
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=963318&group_id=5470
More information about the Patches
mailing list