[Patches] [ python-Patches-822994 ] StringIO.py clean-up.

[SourceForge.net]

Patches item #822994, was opened at 2003-10-13 21:47
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822994&group_id=5470

Category: Library (Lib)
Group: Python 2.3
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Wojtek Walczak (gminick)
Assigned to: Nobody/Anonymous (nobody)
Summary: StringIO.py clean-up.

Initial Comment:
Well, a one frequently used piece of code closed into function, self.closed returns 
True/False instead of 1/0, self.softspace removed because it wasn't used. Sorry for 
wasting your time if you don't treat it as a clean-up ;)

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2003-10-18 12:21

Message:
Logged In: YES 
user_id=21627

I found that isclosed is a bad function name: it is no
predicate (i.e. doesn't return bool), so I have renamed the
function, and committed the patch as StringIO.py 1.30.

----------------------------------------------------------------------

Comment By: Wojtek Walczak (gminick)
Date: 2003-10-14 21:53

Message:
Logged In: YES 
user_id=679226

Sorry, self.softspace is back again in the code. New patch attached.
Thank you for a comment, Michael.

----------------------------------------------------------------------

Comment By: Michael Hudson (mwh)
Date: 2003-10-14 13:43

Message:
Logged In: YES 
user_id=6656

softspace can be used, just not in this file.  don't take it
out.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822994&group_id=5470