[Patches] [ python-Patches-660485 ] Cygwin _tkinter Tcl/Tk 8.3 patch
SourceForge.net
noreply@sourceforge.net
Tue, 04 Feb 2003 19:00:56 -0800
Patches item #660485, was opened at 2002-12-31 14:40
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=660485&group_id=5470
Category: Modules
Group: None
Status: Open
>Resolution: Accepted
Priority: 5
Submitted By: Jason Tishler (jlt63)
>Assigned to: Jason Tishler (jlt63)
Summary: Cygwin _tkinter Tcl/Tk 8.3 patch
Initial Comment:
The attached patch enables Cygwin Python to
build cleanly against the latest Cygwin Tcl/Tk
which is based on Tcl/Tk 8.3. It also prevents
building against the real X headers, if installed.
Note that the first _tkinter.c hunk is only to
suppress the following compiler warning:
/home/jt/src/PythonCvs/Modules/_tkinter.c:66:1:
warning: "CONST" redefined
In file included
from /home/jt/src/PythonCvs/Modules/_tkinter.c:56:
/usr/include/tcl.h:280:1: warning: this is the location of
the previous definition
I can eliminate this hunk if you wish.
OK to apply?
----------------------------------------------------------------------
>Comment By: Neal Norwitz (nnorwitz)
Date: 2003-02-04 22:00
Message:
Logged In: YES
user_id=33168
Looks fine, please apply.
----------------------------------------------------------------------
Comment By: Jason Tishler (jlt63)
Date: 2003-02-04 08:47
Message:
Logged In: YES
user_id=86216
The attached patch reverts the following:
It also prevents building against the real X
headers, if installed.
After discussions with the Cygwin project
lead, I believe that building against the real
X headers is OK. Especially, since the psuedo-X
headers are *not* installed by the Cygwin Tcl/Tk
binary package.
----------------------------------------------------------------------
Comment By: Jason Tishler (jlt63)
Date: 2002-12-31 15:32
Message:
Logged In: YES
user_id=86216
> I think the line #undef CONST should be added
> unconditionally before the #define CONST.
Agreed.
Checked in as:
Modules/_tkinter.c 1.141
setup.py 1.131
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2002-12-31 14:58
Message:
Logged In: YES
user_id=21627
I think the line #undef CONST should be added
unconditionally before the #define CONST. Apart from that,
the patch is fine.
----------------------------------------------------------------------
Comment By: Jason Tishler (jlt63)
Date: 2002-12-31 14:43
Message:
Logged In: YES
user_id=86216
Hmm...The patch file vanished! I also did not get a
confirmation that my patch was successfully submitted.
Nevertheless, I am trying again...
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2002-12-31 14:41
Message:
Logged In: YES
user_id=21627
There's no uploaded file! You have to check the
checkbox labeled "Check to Upload & Attach File"
when you upload a file.
Please try again.
(This is a SourceForge annoyance that we can do
nothing about. :-( )
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=660485&group_id=5470