[Patches] [ python-Patches-850789 ] call com_set_lineno more often

[SourceForge.net]

Patches item #850789, was opened at 2003-11-28 15:55
Message generated for change (Settings changed) made by mwh
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=850789&group_id=5470

Category: Parser/Compiler
Group: Python 2.4
>Status: Closed
>Resolution: Later
Priority: 5
Submitted By: Michael Hudson (mwh)
Assigned to: Nobody/Anonymous (nobody)
Summary: call com_set_lineno more often

Initial Comment:
This patch makes Python/compile.c:com_node call
com_set_lineno unconditionally, and removes all the
other calls to the function, exploiting the fact that
com_set_lineno is now a noop when unnecessary.

I can't help feeling this is too easy.  What have I missed?

Resulting python passes make test, but that's not
really news.

----------------------------------------------------------------------

>Comment By: Michael Hudson (mwh)
Date: 2003-12-15 12:38

Message:
Logged In: YES 
user_id=6656

I withdraw this patch.  It breaks tracing & frame_set_lineno in 
complicated ways that will take real thought to fix.

The more I think about it, the more I think the hypothetical 2.4 
compiler should use a richer data structure than c_lnotab.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=850789&group_id=5470