[Patches] [ python-Patches-722839 ] HAVE_GAI_STRERROR typo fix

[SourceForge.net]

Patches item #722839, was opened at 2003-04-16 23:59
Message generated for change (Comment added) made by bkc
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=722839&group_id=5470

Category: Modules
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Brad Clements (bkc)
Assigned to: Martin v. Löwis (loewis)
Summary: HAVE_GAI_STRERROR typo fix

Initial Comment:
This patch fixes a typo in getaddrinfo.c. The #ifdef 
doesn't match the define in pyconfig.h


----------------------------------------------------------------------

>Comment By: Brad Clements (bkc)
Date: 2003-04-18 21:29

Message:
Logged In: YES 
user_id=4631

ow, it seems I have wasted your time. Sorry, long nights of 
shoehorning python 2.3a into an 8meg 68K embedded 
system has taken it's toll.

I'm using uClibc and apparently ./configure had, I guess, at 
one point set HAVE_GAI_STRERROR but not 
HAVE_GETADDRINFO.

I must have gone for the easy fix a few days ago, and then in 
the course I must have mis-typed GAI as GIA, fixed it later 
then felt "gee, I should file a patch".

Sorry, I should have realized obvious problems like this 
wouldn't likely.

(btw, I have statically linked Python 2.3 to uClibc, libxml2 and 
libxslt producing a 2.5 meg exe that runs medusa .. a bit 
slow on a 48 mhz M5272 chip)

I wish to retract this patch.


----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-04-18 21:14

Message:
Logged In: YES 
user_id=21627

Can you please report what problem this is needed on?
getaddrinfo.c is only used if you don't have getaddrinfo.
However, if you don't have getaddrinfo, you shouldn't have
gai_strerror, either.

More specifically: What is the precise error that you get
that triggered that change?

----------------------------------------------------------------------

Comment By: Brad Clements (bkc)
Date: 2003-04-18 21:03

Message:
Logged In: YES 
user_id=4631

Oops, sorry.

The description of this patch is not correct, but it's still 
needed.  pyconfig.h defines "HAVE_GAI_STRERROR" but 
Modules/getaddrinfo.c doesn't use the #define to control the 
declaration of gai_strerror()

Note that socketmodule.c does use this #define. I'm 
suggesting that getaddrinfo.c should also use it to NOT define 
gai_strerror.



----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-04-18 20:15

Message:
Logged In: YES 
user_id=21627

What specifically is the typo you are referring to? I cannot
see any ifdef at all, and your patch does not correct any ifdef.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=722839&group_id=5470