[Patches] [ python-Patches-594001 ] PEP 277: Unicode file name support
noreply@sourceforge.net
noreply@sourceforge.net
Sun, 29 Sep 2002 18:03:52 -0700
Patches item #594001, was opened at 2002-08-12 21:33
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=594001&group_id=5470
Category: Windows
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Martin v. Löwis (loewis)
Assigned to: Mark Hammond (mhammond)
Summary: PEP 277: Unicode file name support
Initial Comment:
This patch is in an updated version of the patch [1]
mentioned in the PEP. In addition to merging it with
the CVS, it fixes a few formatting problems.
----------------------------------------------------------------------
>Comment By: Mark Hammond (mhammond)
Date: 2002-09-30 11:03
Message:
Logged In: YES
user_id=14198
Will review this instant - sorry for the delay.
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2002-09-26 16:24
Message:
Logged In: YES
user_id=21627
Mark, can you please indicate whether you will review this
patch?
----------------------------------------------------------------------
Comment By: Tim Peters (tim_one)
Date: 2002-09-26 05:43
Message:
Logged In: YES
user_id=31435
Sorry, Martin, bouncing back to Mark -- I really don't know
anything about the Windows filename APIs.
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2002-09-23 01:31
Message:
Logged In: YES
user_id=21627
Tim, can you review this?
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2002-09-04 22:06
Message:
Logged In: YES
user_id=21627
This is a new version:
- wrapped all Windows wide API code with #ifdef
Py_WIN_WIDE_FILENAMES
- added test case
Mark, can you please take a look at this?
----------------------------------------------------------------------
Comment By: Guido van Rossum (gvanrossum)
Date: 2002-08-12 23:38
Message:
Logged In: YES
user_id=6380
I'd make unicode_filenames() a macro that expands to 0 on
platforms without this wart. I'd also test for wfunc!=NULL
before calling unicode_filenames().
There's a lot of hairy code here. Are you sure that there
are test cases in the test suite that exercise all of it?
Aren't there some #ifdefs missing? posix_[12]str have code
that's only relevant for Windows but isn't #ifdef'ed out
like it is elsewhere.
There should probably be a separate #define in pyport.h to
test for this that's equivalent to defined(MS_WINDOWS) &&
!defined(Py_UNICODE_WIDE), so this can be uniformly tested
to see whether this code is necessary.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=594001&group_id=5470