[Patches] [ python-Patches-593069 ] socketmodule.[ch] downgrade

noreply@sourceforge.net noreply@sourceforge.net
Tue, 03 Sep 2002 12:06:29 -0700


Patches item #593069, was opened at 2002-08-09 10:20
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=593069&group_id=5470

Category: Modules
Group: Python 2.3
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: Stepan Koltsov (yozh)
Assigned to: Nobody/Anonymous (nobody)
Summary: socketmodule.[ch] downgrade

Initial Comment:
1. Was removed fields 'sock_type' and 'sock_proto' from
structure  PySocketSockObject since they are not used
anywhere.

2. Changed semantics of 'socket.fromfd'. Now it ignore
3rd and 4th arguments, 2nd arg is optional, if it was
not specified, it got with getsockname call.

3. Added constant AF_LOCAL.


----------------------------------------------------------------------

>Comment By: Guido van Rossum (gvanrossum)
Date: 2002-09-03 15:06

Message:
Logged In: YES 
user_id=6380

Rejected. sock_type and sock_proto are used in the socket()
call, and I find it useful to be able to report these in
repr(). I may use your trick to get the default family for
fromfd() though.

What is AF_LOCAL? Your patch for it is wrong -- it doesn't
add a proper #ifdef around it, and it defines the value to
be the same as AF_INET.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=593069&group_id=5470