[Patches] [ python-Patches-626548 ] Support Hangul Syllable names
noreply@sourceforge.net
noreply@sourceforge.net
Sat, 23 Nov 2002 04:23:21 -0800
Patches item #626548, was opened at 2002-10-21 23:11
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=626548&group_id=5470
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Martin v. Löwis (loewis)
>Assigned to: Martin v. Löwis (loewis)
Summary: Support Hangul Syllable names
Initial Comment:
This patch implements section 25.2 of ISO 10646
(Character names and annotations for Hangul syllables).
----------------------------------------------------------------------
>Comment By: Martin v. Löwis (loewis)
Date: 2002-11-23 13:23
Message:
Logged In: YES
user_id=21627
Since there were no further comments, committed as
NEWS 1.537
unicodedata.c 2.21
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2002-11-11 15:45
Message:
Logged In: YES
user_id=21627
I have now updated the patch to use 4-space indents, and
added a NEWS entry. Any further changes needed?
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2002-10-23 13:41
Message:
Logged In: YES
user_id=21627
As for docs: I'd add a NEWS entry only.
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2002-10-23 13:31
Message:
Logged In: YES
user_id=21627
Can you please elaborate this position? Is it not important
to follow the established and agreed style guide?
----------------------------------------------------------------------
Comment By: M.-A. Lemburg (lemburg)
Date: 2002-10-23 13:02
Message:
Logged In: YES
user_id=38388
Apart from that the patch looks ok. Do you have some docs
to go with it ?
----------------------------------------------------------------------
Comment By: M.-A. Lemburg (lemburg)
Date: 2002-10-23 13:00
Message:
Logged In: YES
user_id=38388
No, I'd rather leave things as they are w/r to indentation.
Thanks.
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2002-10-23 12:42
Message:
Logged In: YES
user_id=21627
Perhaps the entire file should be formatted to conform with
PEP 7 (single-tab indents, where a tab is worth 8 spaces).
Should I submit a separate patch for this reformatting?
----------------------------------------------------------------------
Comment By: M.-A. Lemburg (lemburg)
Date: 2002-10-23 12:32
Message:
Logged In: YES
user_id=38388
One more minor nit: the indentation in the C file is 4
chars, please
reindent your code accordingly.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=626548&group_id=5470