[Patches] [ python-Patches-588809 ] LDFLAGS support for build_ext.py

[noreply@sourceforge.net]

Patches item #588809, was opened at 2002-07-30 17:36
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=588809&group_id=5470

Category: Distutils and setup.py
Group: Python 2.2.x
>Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Robert Weber (chipsforbrains)
Assigned to: A.M. Kuchling (akuchling)
Summary: LDFLAGS support for build_ext.py

Initial Comment:
a hack at best

----------------------------------------------------------------------

>Comment By: A.M. Kuchling (akuchling)
Date: 2002-11-04 14:53

Message:
Logged In: YES 
user_id=11375

Checked in as revision 1.87 of build_ext.py and revision 1.51
of sysconfig.py.  Thanks!



----------------------------------------------------------------------

Comment By: A.M. Kuchling (akuchling)
Date: 2002-11-04 14:43

Message:
Logged In: YES 
user_id=11375

Really?  I suppose there might be platforms where this matters, like SGI with its -n32/-o32 switches for different binary formats.  

So, I have no objections to the patch; I'll check it in.



----------------------------------------------------------------------

Comment By: Robert Weber (chipsforbrains)
Date: 2002-11-04 13:33

Message:
Logged In: YES 
user_id=245624

I followed autoconf, where the linker includes CFLAGS, CPPFLAGS, and LDFLAGS.  I assume they had a good reason to do this.


----------------------------------------------------------------------

Comment By: A.M. Kuchling (akuchling)
Date: 2002-11-04 13:15

Message:
Logged In: YES 
user_id=11375

It mostly looks fine to me, too.  One question: the branch for CFLAGS
adds the value of CFLAGS to the shared linker invocation, which seems incorrect.  Why?  (And does autoconf also do this?  If autoconf does this,
it's probably for some reason and we should therefore also do it.)



----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-08-07 04:27

Message:
Logged In: YES 
user_id=21627

The patch looks fine to me, but I'd like to hear the opinion
of a distutils guru.

----------------------------------------------------------------------

Comment By: Robert Weber (chipsforbrains)
Date: 2002-08-06 15:35

Message:
Logged In: YES 
user_id=245624

> As a hack, I think it is unacceptable for Python. 
> 
>I'd encourage you to integrate this (and CFLAGS) into 
>sysconfig.customize_compiler. 
> 
>It would be ok if only the Unix compiler honors those 
>settings for now. 
> Martin v. Löwis (loewis) 
 
I have written a better patch to sysconfig.py that doe all others so that everything works like autoconf. 
 
I will post the patch in a sec.s CFLAGS and

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-08-04 05:05

Message:
Logged In: YES 
user_id=21627

As a hack, I think it is unacceptable for Python.

I'd encourage you to integrate this (and CFLAGS) into
sysconfig.customize_compiler.

It would be ok if only the Unix compiler honors those
settings for now.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=588809&group_id=5470