[Patches] [ python-Patches-569753 ] Remove support for Win16

[noreply@sourceforge.net]

Patches item #569753, was opened at 2002-06-16 22:32
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=569753&group_id=5470

Category: Windows
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Martin v. Löwis (loewis)
Assigned to: Martin v. Löwis (loewis)
Summary: Remove support for Win16

Initial Comment:
This patch removes support for WIN16 from Python, to 
allow simplification of some obfuscated code (in 
particular in posixmodule). According to PC/readme.txt, 
16-bit Windows is not supported anymore.

In addition to removing this code, it also streamlines the 
usage of the macros: MS_WINDOWS is now 
synonymous to MS_WIN32, and the patch replaces all 
occurrences of MS_WIN32 with MS_WINDOWS. The 
definition of MS_WIN32 is left alone, for backwards 
compatibility.

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2002-06-30 17:30

Message:
Logged In: YES 
user_id=21627

Committed as

 _codecsmodule.c 2.12
_hotshot.c 1.19
_localemodule.c 2.33
mmapmodule.c 2.39
posixmodule.c 2.241
signalmodule.c 2.70
timemodule.c 2.128
fileobject.c 2.164
unicodeobject.c 2.155
PC/getpathp.c 1.27
PC/pyconfig.h 1.11
bltinmodule.c 2.261
dynload_win.c 2.11
errors.c 2.70
frozenmain.c 2.28
import.c 2.208
pythonrun.c 2.161
sysmodule.c 2.107


----------------------------------------------------------------------

Comment By: Mark Hammond (mhammond)
Date: 2002-06-27 10:03

Message:
Logged In: YES 
user_id=14198

Looks good to me!  Back to Martin to check in.

----------------------------------------------------------------------

Comment By: Tim Peters (tim_one)
Date: 2002-06-27 05:01

Message:
Logged In: YES 
user_id=31435

Mark, is this OK by you?  It's OK by me.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2002-06-27 04:29

Message:
Logged In: YES 
user_id=33168

I looked through the patch.  I didn't see any negative
effects on non-windows builds.
The change was almost always MS_WIN32 -> MS_WINDOWS.

I can't test the code though, since I don't have MS windows. :-)
Maybe we could remove all that useless windows code? :-)
Seriously, the patch seems fine and is probably a good idea,
but I can't really give any guidance, but the patch worked
fine on Linux.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=569753&group_id=5470