[Patches] [ python-Patches-562987 ] Remove UserDict from cookie.py
noreply@sourceforge.net
noreply@sourceforge.net
Wed, 26 Jun 2002 08:20:03 -0700
Patches item #562987, was opened at 2002-05-31 12:00
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=562987&group_id=5470
Category: Library (Lib)
Group: Python 2.3
>Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Raymond Hettinger (rhettinger)
Assigned to: Raymond Hettinger (rhettinger)
Summary: Remove UserDict from cookie.py
Initial Comment:
Inherit from dict rather than UserDict.
Replace for k in d.keys() with for k in d.
Regression tests okay.
Slightly shorter, faster, cleaner code.
Doesn't conflict with docs.
----------------------------------------------------------------------
>Comment By: Raymond Hettinger (rhettinger)
Date: 2002-06-26 10:20
Message:
Logged In: YES
user_id=80475
Thanks for the code review.
Committed Cookie 1.13.
----------------------------------------------------------------------
Comment By: A.M. Kuchling (akuchling)
Date: 2002-06-26 08:41
Message:
Logged In: YES
user_id=11375
OK; I've finally taken a look at this, and the patch looks fine. Go
ahead and check it in.
----------------------------------------------------------------------
Comment By: Raymond Hettinger (rhettinger)
Date: 2002-05-31 13:01
Message:
Logged In: YES
user_id=80475
Can you please give this a review?
----------------------------------------------------------------------
Comment By: Guido van Rossum (gvanrossum)
Date: 2002-05-31 12:04
Message:
Logged In: YES
user_id=6380
I'm not the right person to review this; I've never used the
Cookie module and don't know what the consequences of this
change might be.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=562987&group_id=5470