[Patches] [ python-Patches-591305 ] Documentation err in bytecode defs.

[noreply@sourceforge.net]

Patches item #591305, was opened at 2002-08-05 17:17
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=591305&group_id=5470

Category: Documentation
Group: Python 2.3
Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Michael Chermside (mcherm)
Assigned to: Neal Norwitz (nnorwitz)
Summary: Documentation err in bytecode defs.

Initial Comment:
The error in the definition of the opcode is obvious
and easy to understand -- the definition used TOS1
where TOS was intended.

However, this is my first use of the patch submission
process, and my use of patch manager may be way off. If
I've done something silly like submit my diff backward
(from new code back to old) or in the wrong format,
please drop me an email explaining how to generate a
correct patch or where to read about how to do it.

----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2002-08-06 09:32

Message:
Logged In: YES 
user_id=33168

I never thought about it like that.  It makes sense.  Thanks!

----------------------------------------------------------------------

Comment By: Michael Hudson (mwh)
Date: 2002-08-06 04:32

Message:
Logged In: YES 
user_id=6656

Not really relavent, but: unified diffs are good when you want 
to see the changes, context diffs are good when you want to 
see what you're getting.

During the 221 release process I found I was glad for the
insistence on context diffs (to my surprise).


----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2002-08-05 19:35

Message:
Logged In: YES 
user_id=33168

The patch is not reversed and is a context diff.  This is
good (although I prefer unified diff).  With unified diffs,
you can see + and - for the lines which make more sense to
me (good to check that you have the order correct).  It's
easier for me if you do the diff from the src directory, but
I'm not sure what others prefer and it's not a big deal.  I
got a warning from patch:  (Stripping trailing CRs from patch.)

Checked in as:  libdis.tex 1.38 and 1.33.10.3.

Thanks!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=591305&group_id=5470