[Patches] [ python-Patches-403977 ] Rename config.h to pyac_config.h, per SF bug #131774

nobody nobody@sourceforge.net
Tue, 27 Feb 2001 12:48:48 -0800


Patches #403977, was updated on 2001-02-23 13:28
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=403977&group_id=5470

Category: Build
Group: None
Status: Open
Priority: 5
Submitted By: Thomas Wouters
Assigned to: Jeremy Hylton
Summary: Rename config.h to pyac_config.h, per SF bug #131774

Initial Comment:
This patch fixes the UNIX and Windows builds to use 'pyac_config.h' instead of 'config.h', to avoid the problems summarized in SF bug #131774. It doesn't address the placing issue, however, because I believe it's intended to be like this.

Most changes were done using a fairly intelligent shell+sed oneliner, but they should be correct. The Windows build *seems* correct, though I can't be sure. Someone will have to check ;) It is probably a good idea to remove 'config.h' before testing, to be sure I got all references.

The UNIX build requires that autoconf is installed, and requires a 'autoheader ; autoconf' is done before running 'configure'. Removing config.h(.in) is also a good idea.

I excluded the OS2 build files, and will be uploading those as a seperate patch to avoid making this one unreadable Though only two files are involved, they both list all dependencies for *all* files in its entirety, so the patch is quite large. If those files are auto-generated, someone please tell me so :-)

I also didn't fix distutils, though it looks like it does need fixing. And I didn't do anything wrt. backwards compatibility. We should probably provide a config.h that just does

#warning Warning: Use of Python-specific config.h is deprecated. Use pyac_config.h instead.
#include <pyac_config.h>

The name is just my suggestion, changing it into something less acronymic would be no problem at all. I think 'pythonconfig.h' gives the wrong message though: the file isn't used to configure Python itself, after all ;)


----------------------------------------------------------------------

Comment By: Tim Peters
Date: 2001-02-27 12:48

Message:
Logged In: YES 
user_id=31435

Pushed onto Jeremy.  Jeremy, we want to do this much 
fiddling so late in the cycle?

Thomas, don't worry about Windows.  I only need a warning 
about that, and I've aware of this now (thanks!).  Check in 
the new MS project files or don't, it's easy for me to 
fix 'em up regardless (indeed, it's not worth extra time to 
check it in advance).

Note that "#warning" is not std C.  I'm afraid you'll have 
to make it an #error.  OTOH, if you leave a file 
*named* "config.h" in the distribution, it doesn't really 
address the bug report, right?

BTW, I have no idea what "pyac" is supposed to bring to 
mind.  Is that some Unixism?


----------------------------------------------------------------------

Comment By: Thomas Wouters
Date: 2001-02-23 13:32

Message:
Apologies for the large blurb in the 'details' section. I keep forgetting SF strips *all* whitespace from that block :(

Assigning to Tim "The Windows Bot" Peters to test (and fix) the Windows build changes. Let me know if your patch still doesn't work and you want me to send you patched files instead, Tim.



----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=403977&group_id=5470