[Patches] [ python-Patches-410161 ] Create parsermodule.h
noreply@sourceforge.net
noreply@sourceforge.net
Tue, 11 Dec 2001 21:22:02 -0800
Patches item #410161, was opened at 2001-03-20 13:38
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=410161&group_id=5470
Category: Modules
Group: None
Status: Open
Resolution: Out of Date
Priority: 4
Submitted By: Paul Prescod (prescod)
Assigned to: Fred L. Drake, Jr. (fdrake)
Summary: Create parsermodule.h
Initial Comment:
(supercedes #409307)
When Fred created parsermodule.c back in the mid-90's
he put in a comment that some of the code should
really be moved into a header file for more general
use. Now I need that feature to implement compiler
hooks.
The basic idea is that parsermodule declared all of
its types and functions in the .c file instead of
a .h. That meant that they were unavailable to other
code.
----------------------------------------------------------------------
>Comment By: Guido van Rossum (gvanrossum)
Date: 2001-12-11 21:22
Message:
Logged In: YES
user_id=6380
Fred, can you ping Paul to ask if he still wants this? If
not, we should close the patch. (Paul doesn't respond to
email sent to his SF account, at least he ignores SF change
messages, so you'll have to write him directly at
ActiveState.)
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2001-08-13 14:58
Message:
Logged In: YES
user_id=21627
The current patch fails to apply, which is complicated by
the fact that it is an oldstyle diff, rather than a
context (-c) or unified (-u) one. So I mark it outdated. I
think that the idea, in general, was a good one. So if it
gets updated, I'd encourage a more speedy processing of it
before it outdates again.
OTOH, if it is not updated, I propose to close it as
rejected in October 2001.
----------------------------------------------------------------------
Comment By: Paul Prescod (prescod)
Date: 2001-03-23 18:26
Message:
Logged In: YES
user_id=31788
Well here's some incentive to check it in when you get a
chance. I've got another patch that allows for pluggable
compilers. parsermodule is used to build node objects to
pass to Python code that replaces the compiler. Of course
we may soon want pluggable parsers too...
----------------------------------------------------------------------
Comment By: Paul Prescod (prescod)
Date: 2001-03-23 18:26
Message:
Logged In: YES
user_id=31788
Well here's some incentive to check it in when you get a
chance. I've got another patch that allows for pluggable
compilers. parsermodule is used to build node objects to
pass to Python code that replaces the compiler. Of course
we may soon want pluggable parsers too...
----------------------------------------------------------------------
Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2001-03-20 22:17
Message:
Logged In: YES
user_id=3066
I'll try to check in something similar tomorrow, when I've
had a little time to sit on this now that I've actually read
the comments. ;-) I don't think the included header is
exactly right, but that's in part that I don't think the
names are good (yes, I know they're mine!).
----------------------------------------------------------------------
Comment By: Paul Prescod (prescod)
Date: 2001-03-20 13:41
Message:
Logged In: YES
user_id=31788
(argh...the patch didn't show up)
----------------------------------------------------------------------
Comment By: Paul Prescod (prescod)
Date: 2001-03-20 13:39
Message:
Logged In: YES
user_id=31788
I'm adding the changes to parsermodule.c that need to be
made so as not to duplicate the information in the new
parsermodule.h.
----------------------------------------------------------------------
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=410161&group_id=5470