[Patches] [ python-Patches-485959 ] Final set of patches to Demo/tix

noreply@sourceforge.net noreply@sourceforge.net
Sun, 09 Dec 2001 16:01:06 -0800


Patches item #485959, was opened at 2001-11-27 03:16
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=485959&group_id=5470

Category: Tkinter
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Internet Discovery (idiscovery)
Assigned to: Martin v. Löwis (loewis)
Summary: Final set of patches to Demo/tix

Initial Comment:
Final set of patches to Demo/tix - this should be it for a while.

Tix.py: Fixed tix_configure and fixed some of the doc strings.

tixwidgets.py: fixed loop, added some more docstrings,
and made some progress on the global image1 problem.
Look for the code around 'if 0:' - it may point towards a
bug in Tkinter. Image class. Also if I can understand this
proble, maybe I can solve the long outstanding bug described
in Demo/tix/BUG.txt.

samples/ Fixed SHList1 and 2 not quiting when run from samples/
and fixed a bug in all of the demos that was leaving zombie pythonw
processes under Windows in 2.1.0



----------------------------------------------------------------------

>Comment By: Internet Discovery (idiscovery)
Date: 2001-12-09 16:01

Message:
Logged In: YES 
user_id=33229

Does the attached Tix.py patch run cleanly (it does for me).

The bugs in Tix.py and tixwidgets.py should be be fixed
before 2.2 goes final - the others are not so important.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2001-12-09 09:48

Message:
Logged In: YES 
user_id=21627

I don't think I can find the time to look at this once more
before 2.2 - it was already quite time-consuming the last
time. I would apply a patch in the last minute with little
inspection if it applies cleanly.

As for the nature of the problems: I believe for atleast one
of the files, the modified file was CRLF converted, so I
can't use the file you provided, either.

I recommend that you obtain a copy of cvs.exe for Windows,
so that you don't have to use a web browser to download the
files, and produce a diff.

----------------------------------------------------------------------

Comment By: Internet Discovery (idiscovery)
Date: 2001-12-08 22:52

Message:
Logged In: YES 
user_id=33229

Are the reject significant or just spurious linefeeds at the end of the file?

Please apply the patches of the files that run cleanly as the patches are
all independent and are all against the current files. The Tix.py and
tixiwdgets.py contain important bug fixes.

Let me know if the rejects are signiifcant; I don't always have access
to unix cvs, and the SF CVS download option under Windows adds
spurious linefeeds at the end. That's why I add the .dst files to
the tar so you can see if any rejects are trivial.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2001-12-02 04:35

Message:
Logged In: YES 
user_id=21627

These patches don't apply cleanly; I get patch rejects in 

Control.py.rej  SHList1.py.rej  SHList2.py.rej

Please obtain the current version through CVS, and produce a
'cvs diff -u', instead of individual diff files. We only
need the diffs; the original files aren't needed (so you
don't need to produce a tar file, either).

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=485959&group_id=5470