[Patches] [ python-Patches-455137 ] Makes popen work with COMMAND.COM on WNT
noreply@sourceforge.net
noreply@sourceforge.net
Sun, 26 Aug 2001 23:39:13 -0700
Patches item #455137, was opened at 2001-08-24 16:11
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=455137&group_id=5470
Category: core (C code)
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Brian Quinlan (bquinlan)
Assigned to: Tim Peters (tim_one)
Summary: Makes popen work with COMMAND.COM on WNT
Initial Comment:
This patches causes the Window's implementation of
popen to always use the w9xpopen hack if the shell
specified in ComSpec is COMMAND.COM.
This fixes a bug where popen would not work if the
user installed W2K over W9X (the install-over
procedure does not change ComSpec).
I also changed the CreateProcess exception to include
the commandline used. I found it useful in my
debugging so others might like it too.
I also tried to make this patch work by checking if
the shell's file OS is VOS_DOS or VOS_WINDOWS16.
Unfortunately that doesn't work because COMMAND.COM
doesn't have a version resource and we can't assume
that it is 16-bit if it doesn't have one (bash doesn't
either). So I think checking for names is the best
that we can do for now.
----------------------------------------------------------------------
>Comment By: Tim Peters (tim_one)
Date: 2001-08-26 23:39
Message:
Logged In: YES
user_id=31435
Thanks! The indentation was screwy in spots, as if you
used an editor set to move tab chars to multiple-of-4
columns. Repaired that, and checked in as
Misc/ACKS; new revision: 1.108
Misc/NEWS; new revision: 1.214
Modules/posixmodule.c; new revision: 2.197
----------------------------------------------------------------------
Comment By: Tim Peters (tim_one)
Date: 2001-08-26 22:47
Message:
Logged In: YES
user_id=31435
Assigned to me.
----------------------------------------------------------------------
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=455137&group_id=5470