[Patches] [ python-Patches-448261 ] OSX patches - review wanted
noreply@sourceforge.net
noreply@sourceforge.net
Tue, 07 Aug 2001 21:34:02 -0700
Patches item #448261, was opened at 2001-08-05 15:17
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=448261&group_id=5470
Category: Build
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Jack Jansen (jackjansen)
Assigned to: Nobody/Anonymous (nobody)
Summary: OSX patches - review wanted
Initial Comment:
I'm posting these here because I'm not a configure-guru
and I'd like someone to check that I'm doing reasonable
things.
The patch does three things:
- Warn if you haven't specified --with-suffix and a
directory "python" with lowercase p exists (you're
probably on a non-case-sensitive filesystem and
building python will fail)
- Force --with-dyld on OSX (there is no alternative as
on NextStep).
- If you're building in a subdir also create the
directories Mac and Mac/Python.
----------------------------------------------------------------------
>Comment By: Martin v. Löwis (loewis)
Date: 2001-08-07 21:34
Message:
Logged In: YES
user_id=21627
On --with-dyld: If --with-dyld is the only choice on the
Mac, then it should not be set implicitly. Instead,
support for not having it should be removed. I.e. in all
places that check for with_dyld, the Darwin case should be
split out, and the resulting features should be
automatically activated. E.g.
Darwin/*|next/*)
if test "$ns_dyld"
then LDSHARED='$(CC) $(LDFLAGS) -bundle
-undefined suppress'
else LDSHARED='$(CC) $(CFLAGS) -nostdlib
-r';
fi
if test "$with_next_framework" ; then
LDSHARED="$LDSHARED \"
fi ;;
should change to
Darwin/*)LDSHARED='$(CC) $(LDFLAGS) -bundle
-undefined suppress'
LDSHARED='$(CC) $(LDFLAGS) -bundle -undefined suppress'
next/*)
if test "$ns_dyld"
then LDSHARED='$(CC) $(LDFLAGS) -bundle
-undefined suppress'
else LDSHARED='$(CC) $(CFLAGS) -nostdlib
-r';
fi
if test "$with_next_framework" ; then
LDSHARED="$LDSHARED \"
fi ;;
As a result, --with-dyld becomes a next-only thing. It may
be that --with-next-framework is also meaningless on
Darwin, in which case the support for specifying it on
Darwin should be removed. So I disapprove the part of the
patch that just sets with_dyld.
On Mac/Python, I think the hierarchy is backwards, it
should be Python/Mac instead. It also appears that only
macglue.c is actually used on Darwin (I don't know whether
the others are ever used). If that is the case, macglue.c
should be moved to Python/, in which case the SRCDIRS
change is not needed anymore, either.
In any case, I think Mac should not be in SRCDIRS, since
it does not contain any sources. It appears you listed it
only to get Mac created before Mac/Python is created.
Instead, mkdir -p should be used to create SRCDIRS.
While you are at it, you should carefully review the other
Next stuff whether it really applies to Darwin. E.g. why
is it that we check for
-f /System/Library/CoreServices/software_version
Is this for Darwin only, or was there a NeXT release that
had this but not /usr/lib/NextStep/software_version? If
this is for Darwin only, I think the test should be
removed, with the Darwin code in it. I suppose that
--with-next-arch is not supported on Darwin, is it?
----------------------------------------------------------------------
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=448261&group_id=5470