[Patches] [Patch #101653] unidb-based unicodetype.c replacement (part 2)

noreply@sourceforge.net noreply@sourceforge.net
Mon, 25 Sep 2000 16:41:35 -0700


Patch #101653 has been updated. 

Project: 
Category: core (C code)
Status: Closed
Summary: unidb-based unicodetype.c replacement (part 2)

Follow-Ups:

Date: 2000-Sep-25 14:13
By: lemburg

Comment:
Some compilers out there have problems with static arrays
which don't specify the number of records in their constructors.

Wouldn't it be possible to generate the array bounds in the
generation script ?

-------------------------------------------------------

Date: 2000-Sep-25 14:34
By: twouters

Comment:
A quick grep shows about 850 static arrays with unspecified length in the current Python source tree. I'm not against adding the length explicitly (can't hurt, after all) but it's probably not worth the trouble if it can't be done easily.

-------------------------------------------------------

Date: 2000-Sep-25 15:03
By: tim_one

Comment:
It's easy for the script to add this.  I'd like to see it too, but only mildly -- it's a nice little check on whether all the elements actually got written out.
-------------------------------------------------------

Date: 2000-Sep-25 15:19
By: lemburg

Comment:
Something else I noticed when I updated my CVS tree:

There's a typo in the filename for the unicodectype
table: it should be unicodectype_db.h, not unicodetype_db.h
(note the missing "c").

-------------------------------------------------------

Date: 2000-Sep-25 15:33
By: none

Comment:
the tables are taken from the unidb project, and have the same names: "unicodename_db", "unicodetype_db",
and "unicodedata_db".

the patch summary contains a real typo, though...

</F>
-------------------------------------------------------

Date: 2000-Sep-25 15:40
By: lemburg

Comment:
Hmm, I still like unicodectype* better -- after all the ctype.h
inspired the name. Since the two files belong together I'd
prefer to have them use the same prefix name 'unicodectype'.
-------------------------------------------------------

Date: 2000-Sep-25 15:57
By: tim_one

Comment:
C:\Code\python\dist\src\PCbuild>python
Python 2.0b1 (#6, Sep 25 2000, 18:23:25) [MSC 32 bit (Intel)] on win32
Type "copyright", "credits" or "license" for more information.
>>> u"ABC".isupper()
0
>>>

Doesn't look right to me.
-------------------------------------------------------

Date: 2000-Sep-25 16:41
By: tim_one

Comment:
This has been checked in and passes the tests.  More fiddling has to wait until after 2.0b2 ships.
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/patch/?func=detailpatch&patch_id=101653&group_id=5470