[Patches] Re: [Patch #101857] ifdef for USE_STACKCHECK consistant

Dan Wolfe dkwolfe@pacbell.net
Tue, 10 Oct 2000 23:13:55 -0700


>Patch #101857 has been updated. 
>
actually no,   I didn't do a check for all "#if defined"'s as I was 
looking only for the USE_STACKCHECK variable to figure out how to fix 
another bug....

Ok... I'll hold off doing a grep and a patch against the entire source 
until after 2.0 ships... : -)

Thanks for pointing out that I overlooked all the other #if defined's


- Dan


>Project: 
>Category: core (C code)
>Status: Rejected
>Summary: ifdef for USE_STACKCHECK consistant
>
>Follow-Ups:
>
>Date: 2000-Oct-10 21:26
>By: fdrake
>
>Comment:
>Did you do an extensive check for other instances of this syntax?  There 
>are a *lot* of instances of this:
>
>$ grep '^#if defined([a-zA-Z0-9_]*)$' */*.[ch] | wc -l
>     70
>
>This patch only changes the result by two.
>I'm rejecting this on the basis that it isn't important and doesn't impose 
>any measure of consistency.
>-------------------------------------------------------
>
>-------------------------------------------------------
>For more info, visit:
>
>http://sourceforge.net/patch/?func=detailpatch&patch_id=101857&group_id=5470